Address /W4 compiler warnings for Windows (#4910)

This commit is contained in:
Zach H
2023-10-15 20:31:13 -04:00
committed by GitHub
parent cb90a8356b
commit 186f4289e9
50 changed files with 279 additions and 272 deletions

View File

@@ -144,11 +144,11 @@ void Server_Game::storeGameInformation()
replayMatchInfo->set_game_name(gameInfo.description());
const QStringList &allGameTypes = room->getGameTypes();
QStringList gameTypes;
QStringList _gameTypes;
for (int i = gameInfo.game_types_size() - 1; i >= 0; --i)
gameTypes.append(allGameTypes[gameInfo.game_types(i)]);
_gameTypes.append(allGameTypes[gameInfo.game_types(i)]);
for (auto playerName : allPlayersEver) {
for (const auto &playerName : allPlayersEver) {
replayMatchInfo->add_player_names(playerName.toStdString());
}
@@ -171,7 +171,7 @@ void Server_Game::storeGameInformation()
delete sessionEvent;
if (server->getStoreReplaysEnabled()) {
server->getDatabaseInterface()->storeGameInformation(room->getName(), gameTypes, gameInfo, allPlayersEver,
server->getDatabaseInterface()->storeGameInformation(room->getName(), _gameTypes, gameInfo, allPlayersEver,
allSpectatorsEver, replayList);
}
}
@@ -710,8 +710,8 @@ void Server_Game::createGameJoinedEvent(Server_Player *player, ResponseContainer
event2.set_active_player_id(activePlayer);
event2.set_active_phase(activePhase);
for (Server_Player *player : players.values()) {
player->getInfo(event2.add_player_list(), player, player->getSpectator() && spectatorsSeeEverything, true);
for (auto *_player : players.values()) {
_player->getInfo(event2.add_player_list(), _player, _player->getSpectator() && spectatorsSeeEverything, true);
}
rc.enqueuePostResponseItem(ServerMessage::GAME_EVENT_CONTAINER, prepareGameEvent(event2, -1));