[Fix-Warnings] Remove more redundant empty declarations. (extra semicolons) (#6374)

cockatrice/src/client/network/update/card_spoiler/spoiler_background_updater.h

@@ -22,7 +22,7 @@ public:
     inline QString getCardUpdaterBinaryName()
     {
         return "oracle";
-    };
+    }
     QByteArray getHash(const QString fileName);
     QByteArray getHash(QByteArray data);
     static bool deleteSpoilerFile();

cockatrice/src/client/settings/shortcuts_settings.h

@@ -99,15 +99,15 @@ public:
     void setSequence(const QList &_sequence)
     {
         QList::operator=(_sequence);
-    };
+    }
     [[nodiscard]] QString getName() const
     {
         return QApplication::translate("shortcutsTab", name.toUtf8().data());
-    };
+    }
     [[nodiscard]] QString getGroupName() const
     {
         return ShortcutGroup::getGroupName(group);
-    };
+    }
 
 private:
     QString name;
@@ -129,7 +129,7 @@ public:
     [[nodiscard]] QList<QString> getAllShortcutKeys() const
     {
         return shortCuts.keys();
-    };
+    }
 
     void setShortcuts(const QString &name, const QList<QKeySequence> &Sequence);
     void setShortcuts(const QString &name, const QKeySequence &Sequence);

cockatrice/src/database/interface/settings_card_preference_provider.h

@@ -15,7 +15,7 @@ public:
     [[nodiscard]] bool getIncludeRebalancedCards() const override
     {
         return SettingsCache::instance().getIncludeRebalancedCards();
-    };
+    }
 };
 
 #endif // COCKATRICE_SETTINGS_CARD_PREFERENCE_PROVIDER_H

cockatrice/src/game/player/player.h

@@ -113,7 +113,7 @@ public:
     [[nodiscard]] PlayerActions *getPlayerActions() const
     {
         return playerActions;
-    };
+    }
 
     [[nodiscard]] PlayerEventHandler *getPlayerEventHandler() const
     {
@@ -123,7 +123,7 @@ public:
     [[nodiscard]] PlayerInfo *getPlayerInfo() const
     {
         return playerInfo;
-    };
+    }
 
     [[nodiscard]] PlayerMenu *getPlayerMenu() const
     {

cockatrice/src/game/zones/logic/card_zone_logic.h

@@ -52,7 +52,7 @@ public:
     void rawInsertCard(CardItem *card, int index)
     {
         cards.insert(index, card);
-    };
+    }
 
     [[nodiscard]] const CardList &getCards() const
     {

cockatrice/src/interface/widgets/cards/additional_info/mana_symbol_widget.h

@@ -23,15 +23,15 @@ public:
     [[nodiscard]] bool isColorActive() const
     {
         return isActive;
-    };
+    }
     [[nodiscard]] QString getSymbol() const
     {
         return symbol;
-    };
+    }
     [[nodiscard]] QChar getSymbolChar() const
     {
         return symbol[0];
-    };
+    }
 
     void loadManaIcon();
 

cockatrice/src/interface/widgets/deck_editor/deck_editor_database_display_widget.h

@@ -32,7 +32,7 @@ public:
     QTreeView *getDatabaseView()
     {
         return databaseView;
-    };
+    }
 
 public slots:
     ExactCard currentCard() const;

cockatrice/src/interface/widgets/printing_selector/printing_selector.h

@@ -39,7 +39,7 @@ public:
     [[nodiscard]] DeckListModel *getDeckModel() const
     {
         return deckModel;
-    };
+    }
 
 public slots:
     void retranslateUi();

cockatrice/src/interface/widgets/server/user/user_list_manager.cpp

@@ -167,4 +167,4 @@ const ServerInfo_User *UserListManager::getOnlineUser(const QString &userName) c
     }
 
     return nullptr;
-};
+}

cockatrice/src/interface/widgets/tabs/api/edhrec/display/cards/edhrec_api_response_card_list_display_widget.h

@@ -24,7 +24,7 @@ public:
     [[nodiscard]] QString getBannerText() const
     {
         return header->getText();
-    };
+    }
 
 private:
     QVBoxLayout *layout;

cockatrice/src/interface/widgets/visual_deck_storage/deck_preview/deck_preview_tag_display_widget.h

@@ -44,7 +44,7 @@ public:
     {
         state = newState;
         update();
-    };
+    }
 
 signals:
     /**

cockatrice/src/interface/widgets/visual_deck_storage/visual_deck_storage_folder_display_widget.h

@@ -31,7 +31,7 @@ public:
     [[nodiscard]] FlowWidget *getFlowWidget() const
     {
         return flowWidget;
-    };
+    }
 
 public slots:
     void updateVisibility(bool recursive = true);

cockatrice/src/interface/window_main.h

@@ -135,7 +135,7 @@ private:
     inline QString getCardUpdaterBinaryName()
     {
         return "oracle";
-    };
+    }
     void createCardUpdateProcess(bool background = false);
     void exitCardDatabaseUpdate();
 

libcockatrice_card/libcockatrice/card/card_info.h

@@ -190,7 +190,7 @@ public:
     const QSet<QString> &getAltNames()
     {
         return altNames;
-    };
+    }
     [[nodiscard]] const QString &getText() const
     {
         return text;

libcockatrice_card/libcockatrice/card/game_specific_terms.h

@@ -53,6 +53,6 @@ inline static const QString getNicePropertyName(QString key)
         return QCoreApplication::translate("Mtg", "Color Identity");
     return key;
 }
-}; // namespace Mtg
+} // namespace Mtg
 
 #endif

libcockatrice_deck_list/libcockatrice/deck_list/deck_list.h

@@ -158,7 +158,7 @@ protected:
     virtual QString getCardZoneFromName(const QString /*cardName*/, QString currentZoneName)
     {
         return currentZoneName;
-    };
+    }
 
     /**
      * @brief Produce the complete display name of a card.
@@ -169,7 +169,7 @@ protected:
     virtual QString getCompleteCardName(const QString &cardName) const
     {
         return cardName;
-    };
+    }
 
 signals:
     /// Emitted when the deck hash changes.

libcockatrice_models/libcockatrice/models/deck_list/deck_list_model.h

@@ -203,7 +203,7 @@ public:
     [[nodiscard]] QModelIndex getRoot() const
     {
         return nodeToIndex(root);
-    };
+    }
 
     /**
      * @brief Returns the value of the grouping category for a card based on the current criteria.

libcockatrice_network/libcockatrice/network/server/local/local_server_interface.h

@@ -25,7 +25,7 @@ public:
     QString getConnectionType() const override
     {
         return "local";
-    };
+    }
     void transmitProtocolItem(const ServerMessage &item) override;
 signals:
     void itemToClient(const ServerMessage &item);

libcockatrice_network/libcockatrice/network/server/remote/game/server_abstract_participant.h

@@ -76,7 +76,7 @@ public:
     virtual void prepareDestroy()
     {
         removeFromGame();
-    };
+    }
     void removeFromGame();
     Server_AbstractUserInterface *getUserInterface() const
     {

libcockatrice_network/libcockatrice/network/server/remote/server_database_interface.h

@@ -83,7 +83,7 @@ public:
     virtual bool usernameIsValid(const QString & /*userName */, QString & /* error */)
     {
         return true;
-    };
+    }
 public slots:
     virtual void endSession(qint64 /* sessionId */)
     {
@@ -154,16 +154,16 @@ public:
                                    int & /* banSecondsRemaining */)
     {
         return false;
-    };
+    }
     virtual int checkNumberOfUserAccounts(const QString & /* email */)
     {
         return 0;
-    };
+    }
     virtual bool
     changeUserPassword(const QString & /* user */, const QString & /* password */, bool /* passwordNeedsHash */)
     {
         return false;
-    };
+    }
     virtual bool changeUserPassword(const QString & /* user */,
                                     const QString & /* oldPassword */,
                                     bool /* oldPasswordNeedsHash */,
@@ -171,7 +171,7 @@ public:
                                     bool /* newPasswordNeedsHash */)
     {
         return false;
-    };
+    }
 };
 
 #endif

servatrice/src/serversocketinterface.h

@@ -177,7 +177,7 @@ public:
     QString getConnectionType() const
     {
         return "tcp";
-    };
+    }
 
 private:
     QTcpSocket *socket;
@@ -190,11 +190,11 @@ protected:
     void writeToSocket(QByteArray &data)
     {
         socket->write(data);
-    };
+    }
     void flushSocket()
     {
         socket->flush();
-    };
+    }
     void initSessionDeprecated();
     bool initTcpSession();
 protected slots:
@@ -224,7 +224,7 @@ public:
     QString getConnectionType() const
     {
         return "websocket";
-    };
+    }
 
 private:
     QWebSocket *socket;
@@ -234,11 +234,11 @@ protected:
     void writeToSocket(QByteArray &data)
     {
         socket->sendBinaryMessage(data);
-    };
+    }
     void flushSocket()
     {
         socket->flush();
-    };
+    }
     bool initWebsocketSession();
 protected slots:
     void binaryMessageReceived(const QByteArray &message);