From d5d9f9bedc7a2e9865eb588395b2fed53304b60d Mon Sep 17 00:00:00 2001
From: RickyRister <42636155+RickyRister@users.noreply.github.com>
Date: Fri, 22 Aug 2025 20:26:16 -0700
Subject: [PATCH] Refactor: Remove unused fields in InnerDecklistNode (#6086)

---
 common/decklist.cpp |  3 +--
 common/decklist.h   | 22 +++-------------------
 2 files changed, 4 insertions(+), 21 deletions(-)

diff --git a/common/decklist.cpp b/common/decklist.cpp
index 8efdeb572..d040914c5 100644
--- a/common/decklist.cpp
+++ b/common/decklist.cpp
@@ -93,8 +93,7 @@ int AbstractDecklistNode::depth() const
 }
 
 InnerDecklistNode::InnerDecklistNode(InnerDecklistNode *other, InnerDecklistNode *_parent)
-    : AbstractDecklistNode(_parent), name(other->getName()), cardSetShortName(other->getCardSetShortName()),
-      cardCollectorNumber(other->getCardCollectorNumber()), cardProviderId(other->getCardProviderId())
+    : AbstractDecklistNode(_parent), name(other->getName())
 {
     for (int i = 0; i < other->size(); ++i) {
         auto *inner = dynamic_cast<InnerDecklistNode *>(other->at(i));
diff --git a/common/decklist.h b/common/decklist.h
index 5e90ab180..e5f2753cd 100644
--- a/common/decklist.h
+++ b/common/decklist.h
@@ -84,10 +84,6 @@ public:
 class InnerDecklistNode : public AbstractDecklistNode, public QList<AbstractDecklistNode *>
 {
     QString name;
-    QString cardSetShortName;
-    QString cardCollectorNumber;
-    QString cardProviderId;
-    class compareFunctor;
 
 public:
     explicit InnerDecklistNode(QString _name = QString(), InnerDecklistNode *_parent = nullptr, int position = -1)
@@ -109,27 +105,15 @@ public:
     [[nodiscard]] virtual QString getVisibleName() const;
     [[nodiscard]] QString getCardProviderId() const override
     {
-        return cardProviderId;
-    }
-    void setCardProviderId(const QString &_cardProviderId)
-    {
-        cardProviderId = _cardProviderId;
+        return "";
     }
     [[nodiscard]] QString getCardSetShortName() const override
     {
-        return cardSetShortName;
-    }
-    void setCardSetShortName(const QString &_cardSetShortName)
-    {
-        cardSetShortName = _cardSetShortName;
+        return "";
     }
     [[nodiscard]] QString getCardCollectorNumber() const override
     {
-        return cardCollectorNumber;
-    }
-    void setCardCollectorNumber(const QString &_cardCollectorNumber)
-    {
-        cardCollectorNumber = _cardCollectorNumber;
+        return "";
     }
     [[nodiscard]] bool isDeckHeader() const override
     {