Merge branch 'master' into 2474-server-status

Ref #2474

.appveyor.yml

@@ -0,0 +1,107 @@
+version: build {build}
+
+# Skipping commits affecting specific files (GitHub only).
+# More details here: https://www.appveyor.com/docs/appveyor-yml and https://www.appveyor.com/docs/how-to/filtering-commits
+skip_commits:
+  files:
+    - .ci/travis-*
+    - .github/
+    - .tx/
+    - webclient/
+    - .clang-format
+    - .*ignore
+    - .codacy.yml
+    - .gitlab-ci.yml
+    - .travis.yml
+    - '**/*.md'
+    - Dockerfile
+    - LICENSE
+
+skip_branch_with_pr: true
+
+clone_depth: 50    #same as travis, see https://www.appveyor.com/blog/2014/06/04/shallow-clone-for-git-repositories/
+
+image: Visual Studio 2017
+
+cache:
+    - c:\Tools\vcpkg\installed
+
+environment:
+    matrix:
+        - target_arch: win64
+          qt_ver: 5.9\msvc2017_64
+          cmake_generator: Visual Studio 15 2017 Win64
+          cmake_toolset: v141,host=x64
+          vcpkg_arch: x64
+
+        - target_arch: win32
+          qt_ver: 5.9\msvc2015 # Qt doesn't provide a msvc2017_32
+          cmake_generator: Visual Studio 15 2017
+          cmake_toolset: v141
+          vcpkg_arch: x86
+
+install:
+    - vcpkg remove --outdated --recurse
+    - vcpkg install openssl protobuf liblzma zlib --triplet %vcpkg_arch%-windows
+
+services:
+    - mysql
+
+build_script:
+    - ps: |
+        New-Item -ItemType directory -Path $env:APPVEYOR_BUILD_FOLDER\build
+        Set-Location -Path $env:APPVEYOR_BUILD_FOLDER\build
+        $vcpkgbindir = "C:\Tools\vcpkg\installed\$env:vcpkg_arch-windows\bin"
+        $mysqldll = "c:\Program Files\MySQL\MySQL Server 5.7\lib\libmysql.dll"
+        cmake --version
+        cmake .. -G "$env:cmake_generator" -T "$env:cmake_toolset" "-DCMAKE_TOOLCHAIN_FILE=c:/tools/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_PREFIX_PATH=c:/Qt/$env:qt_ver;$vcpkgbindir" "-DWITH_SERVER=1" "-DMYSQLCLIENT_LIBRARIES=$mysqldll"
+    - msbuild PACKAGE.vcxproj /p:Configuration=Release
+    - ps: |
+        $exe = dir -name *.exe
+        $new_name = $exe.Replace(".exe", "-${env:target_arch}.exe")
+        Push-AppveyorArtifact $exe -FileName $new_name
+        $cmake_name = $exe.Replace(".exe", "-${env:target_arch}.cmake.txt")
+        Push-AppveyorArtifact CMakeCache.txt -FileName $cmake_name
+        $json = New-Object PSObject
+        (New-Object PSObject | Add-Member -PassThru NoteProperty bin $new_name | Add-Member -PassThru NoteProperty cmake $cmake_name | Add-Member -PassThru NoteProperty commit $env:APPVEYOR_REPO_COMMIT) | ConvertTo-JSON | Out-File -FilePath "latest-$env:target_arch" -Encoding ASCII
+        Push-AppveyorArtifact "latest-$env:target_arch"
+        $version = $matches['content']
+
+test: off
+
+
+# Builds for pull requests skip the deployment step altogether
+deploy:
+# Deploy configuration for "beta" releases
+  - provider: GitHub
+    auth_token:
+      secure: p+7wPVry2XEa6TBm9XH8IaQZbBmXQ/J2ldbGmcIxUZD3NkkPrSRRlmE7Of1CBBIO
+    tag: "$(APPVEYOR_REPO_TAG_NAME)"
+    release: "Cockatrice $(APPVEYOR_REPO_TAG_NAME)"
+    description: "Beta release of Cockatrice"
+    artifact: /.*\.exe/
+    force_update: true
+    draft: false
+    prerelease: true
+    on:
+      APPVEYOR_REPO_TAG: true
+      APPVEYOR_REPO_TAG_NAME: /([0-9]|[1-9][0-9])(\.([0-9]|[1-9][0-9])){2}-beta(\.([2-9]|[1-9][0-9]))?$/    # regex to match semver naming convention for beta pre-releases
+
+# Deploy configuration for "stable" releases
+  - provider: GitHub
+    auth_token:
+       secure: p+7wPVry2XEa6TBm9XH8IaQZbBmXQ/J2ldbGmcIxUZD3NkkPrSRRlmE7Of1CBBIO
+    tag: "$(APPVEYOR_REPO_TAG_NAME)"
+    release: "Cockatrice $(APPVEYOR_REPO_TAG_NAME)"
+    artifact: /.*\.exe/
+    force_update: true
+    draft: false
+    prerelease: false
+    on:
+      APPVEYOR_REPO_TAG: true
+      APPVEYOR_REPO_TAG_NAME: /([0-9]|[1-9][0-9])(\.([0-9]|[1-9][0-9])){2}$/    # regex to match semver naming convention for stable full releases
+
+
+# Announcements of build image updates: https://www.appveyor.com/updates/
+# Official validator for ".appveyor.yml" config file: https://ci.appveyor.com/tools/validate-yaml
+# AppVeyor config documentation: https://www.appveyor.com/docs/build-configuration/

.ci/ArchLinux/Dockerfile

@@ -1,17 +0,0 @@
-from archlinux:latest
-
-RUN pacman --sync --refresh --sysupgrade --needed --noconfirm \
-        base-devel \
-        ccache \
-        cmake \
-        git \
-        gtest \
-        mariadb-libs \
-        protobuf \
-        qt6-base \
-        qt6-multimedia \
-        qt6-svg \
-        qt6-tools \
-        qt6-translations \
-        qt6-websockets \
-    && pacman --sync --clean --clean --noconfirm

.ci/Debian10/Dockerfile

@@ -1,25 +0,0 @@
-FROM debian:10
-
-RUN apt-get update && apt-get install -y --no-install-recommends \
-        build-essential \
-        ccache \
-        clang-format \
-        cmake \
-        file \
-        g++ \
-        git \
-        liblzma-dev \
-        libmariadb-dev-compat \
-        libprotobuf-dev \
-        libqt5multimedia5-plugins \
-        libqt5sql5-mysql \
-        libqt5svg5-dev \
-        libqt5websockets5-dev \
-        protobuf-compiler \
-        qt5-default \
-        qtbase5-dev \
-        qtmultimedia5-dev \
-        qttools5-dev \
-        qttools5-dev-tools \
-    && apt-get clean \
-    && rm -rf /var/lib/apt/lists/*

.ci/Debian11/Dockerfile

@@ -1,24 +0,0 @@
-FROM debian:11
-
-RUN apt-get update && \
-    DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
-        build-essential \
-        ccache \
-        clang-format \
-        cmake \
-        file \
-        g++ \
-        git \
-        liblzma-dev \
-        libmariadb-dev-compat \
-        libprotobuf-dev \
-        libqt5multimedia5-plugins \
-        libqt5sql5-mysql \
-        libqt5svg5-dev \
-        libqt5websockets5-dev \
-        protobuf-compiler \
-        qtmultimedia5-dev \
-        qttools5-dev \
-        qttools5-dev-tools \
-    && apt-get clean \
-    && rm -rf /var/lib/apt/lists/*

.ci/Fedora29/Dockerfile

@@ -1,4 +1,4 @@
-FROM fedora:35
+FROM fedora:29
 
 RUN dnf install -y \
         @development-tools \
@@ -7,15 +7,13 @@ RUN dnf install -y \
         desktop-file-utils \
         file \
         gcc-c++ \
-        git \
         hicolor-icon-theme \
         libappstream-glib \
-        mariadb-devel \
         protobuf-devel \
-        qt5-{qttools,qtsvg,qtmultimedia,qtwebsockets}-devel \
+        qt5-{qttools,qtsvg,qtmultimedia,qtwebsockets}-devel-5.11.1-2.fc29 \
         rpm-build \
         sqlite-devel \
         wget \
-        xz-devel \
         zlib-devel \
+        xz-devel \
     && dnf clean all

.ci/Fedora36/Dockerfile

@@ -1,14 +0,0 @@
-FROM fedora:36
-
-RUN dnf install -y \
-        ccache \
-        cmake \
-        gcc-c++ \
-        git \
-        mariadb-devel \
-        protobuf-devel \
-        qt6-{qttools,qtsvg,qtmultimedia,qtwebsockets}-devel \
-        rpm-build \
-        xz-devel \
-        zlib-devel \
-    && dnf clean all

.ci/UbuntuBionic/Dockerfile

@@ -2,23 +2,21 @@ FROM ubuntu:bionic
 
 RUN apt-get update && apt-get install -y --no-install-recommends \
         build-essential \
-        ccache \
         clang-format \
-        cmake \
         file \
         g++ \
         git \
+        ccache \
+        cmake \
         liblzma-dev \
-        libmariadb-dev-compat \
         libprotobuf-dev \
         libqt5multimedia5-plugins \
-        libqt5sql5-mysql \
         libqt5svg5-dev \
+        libqt5sql5-mysql \
         libqt5websockets5-dev \
         protobuf-compiler \
         qt5-default \
-        qtmultimedia5-dev \
         qttools5-dev \
         qttools5-dev-tools \
-    && apt-get clean \
+        qtmultimedia5-dev \
     && rm -rf /var/lib/apt/lists/*

.ci/UbuntuFocal/Dockerfile

@@ -1,25 +0,0 @@
-FROM ubuntu:focal
-
-RUN apt-get update && \
-    DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
-        build-essential \
-        ccache \
-        clang-format \
-        cmake \
-        file \
-        g++ \
-        git \
-        liblzma-dev \
-        libmariadb-dev-compat \
-        libprotobuf-dev \
-        libqt5multimedia5-plugins \
-        libqt5sql5-mysql \
-        libqt5svg5-dev \
-        libqt5websockets5-dev \
-        protobuf-compiler \
-        qt5-default \
-        qtmultimedia5-dev \
-        qttools5-dev \
-        qttools5-dev-tools \
-    && apt-get clean \
-    && rm -rf /var/lib/apt/lists/*

.ci/UbuntuJammy/Dockerfile

@@ -1,26 +0,0 @@
-FROM ubuntu:jammy
-
-RUN apt-get update && \
-    DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
-        build-essential \
-        ccache \
-        clang-format \
-        cmake \
-        file \
-        g++ \
-        git \
-        libgl-dev \
-        liblzma-dev \
-        libmariadb-dev-compat \
-        libprotobuf-dev \
-        libqt6multimedia6 \
-        libqt6sql6-mysql \
-        libqt6svg6-dev \
-        libqt6websockets6-dev \
-        protobuf-compiler \
-        qt6-l10n-tools \
-        qt6-multimedia-dev \
-        qt6-tools-dev \
-        qt6-tools-dev-tools \
-    && apt-get clean \
-    && rm -rf /var/lib/apt/lists/*

.ci/compile.sh

@@ -1,195 +0,0 @@
-#!/bin/bash
-
-# This script is to be used by the ci environment from the project root directory, do not use it from somewhere else.
-
-# Compiles cockatrice inside of a ci environment
-# --install runs make install
-# --package [<package type>] runs make package, optionally force the type
-# --suffix <suffix> renames package with this suffix, requires arg
-# --server compiles servatrice
-# --test runs tests
-# --debug or --release sets the build type ie CMAKE_BUILD_TYPE
-# --ccache [<size>] uses ccache and shows stats, optionally provide size
-# --dir <dir> sets the name of the build dir, default is "build"
-# --parallel <core count> sets how many cores cmake should build with in parallel
-# uses env: BUILDTYPE MAKE_INSTALL MAKE_PACKAGE PACKAGE_TYPE PACKAGE_SUFFIX MAKE_SERVER MAKE_TEST USE_CCACHE CCACHE_SIZE BUILD_DIR PARALLEL_COUNT
-# (correspond to args: --debug/--release --install --package <package type> --suffix <suffix> --server --test --ccache <ccache_size> --dir <dir> --parallel <core_count>)
-# exitcode: 1 for failure, 3 for invalid arguments
-
-# Read arguments
-while [[ $# != 0 ]]; do
-  case "$1" in
-    '--')
-      shift
-      ;;
-    '--install')
-      MAKE_INSTALL=1
-      shift
-      ;;
-    '--package')
-      MAKE_PACKAGE=1
-      shift
-      if [[ $# != 0 && ${1:0:1} != - ]]; then
-        PACKAGE_TYPE="$1"
-        shift
-      fi
-      ;;
-    '--suffix')
-      shift
-      if [[ $# == 0 ]]; then
-        echo "::error file=$0::--suffix expects an argument"
-        exit 3
-      fi
-      PACKAGE_SUFFIX="$1"
-      shift
-      ;;
-    '--server')
-      MAKE_SERVER=1
-      shift
-      ;;
-    '--test')
-      MAKE_TEST=1
-      shift
-      ;;
-    '--debug')
-      BUILDTYPE="Debug"
-      shift
-      ;;
-    '--release')
-      BUILDTYPE="Release"
-      shift
-      ;;
-    '--ccache')
-      USE_CCACHE=1
-      shift
-      if [[ $# != 0 && ${1:0:1} != - ]]; then
-        CCACHE_SIZE="$1"
-        shift
-      fi
-      ;;
-    '--dir')
-      shift
-      if [[ $# == 0 ]]; then
-        echo "::error file=$0::--dir expects an argument"
-        exit 3
-      fi
-      BUILD_DIR="$1"
-      shift
-      ;;
-    '--parallel')
-      shift
-      if [[ $# == 0 ]]; then
-        echo "::error file=$0::--parallel expects an argument"
-        exit 3
-      fi
-      PARALLEL_COUNT="$1"
-      shift
-      ;;
-    *)
-      echo "::error file=$0::unrecognized option: $1"
-      exit 3
-      ;;
-  esac
-done
-
-set -e
-
-# Setup
-./servatrice/check_schema_version.sh
-if [[ ! $BUILDTYPE ]]; then
-  BUILDTYPE=Release
-fi
-if [[ ! $BUILD_DIR ]]; then
-  BUILD_DIR="build"
-fi
-mkdir -p "$BUILD_DIR"
-cd "$BUILD_DIR"
-
-# Add cmake flags
-flags=("-DCMAKE_BUILD_TYPE=$BUILDTYPE")
-if [[ $MAKE_SERVER ]]; then
-  flags+=("-DWITH_SERVER=1")
-fi
-if [[ $MAKE_TEST ]]; then
-  flags+=("-DTEST=1")
-fi
-if [[ $USE_CCACHE ]]; then
-  flags+=("-DUSE_CCACHE=1")
-  if [[ $CCACHE_SIZE ]]; then
-    # note, this setting persists after running the script
-    ccache --max-size "$CCACHE_SIZE"
-  fi
-fi
-if [[ $PACKAGE_TYPE ]]; then
-  flags+=("-DCPACK_GENERATOR=$PACKAGE_TYPE")
-fi
-
-# Add cmake --build flags
-buildflags=(--config "$BUILDTYPE")
-if [[ $PARALLEL_COUNT ]]; then
-  if [[ $(cmake --build /not_a_dir --parallel |& head -1) =~ parallel ]]; then
-    # workaround for bionic having an old cmake
-    echo "this version of cmake does not support --parallel, using native build tool -j instead"
-    buildflags+=(-- -j "$PARALLEL_COUNT")
-    # note, no normal build flags should be added after this
-  else
-    buildflags+=(--parallel "$PARALLEL_COUNT")
-  fi
-fi
-
-function ccachestatsverbose() {
-  # note, verbose only works on newer ccache, discard the error
-  local got
-  if got="$(ccache --show-stats --verbose 2>/dev/null)"; then
-    echo "$got"
-  else
-    ccache --show-stats
-  fi
-}
-
-# Compile
-if [[ $USE_CCACHE ]]; then
-  echo "::group::Show ccache stats"
-  ccachestatsverbose
-  echo "::endgroup::"
-fi
-
-echo "::group::Configure cmake"
-cmake --version
-cmake .. "${flags[@]}"
-echo "::endgroup::"
-
-echo "::group::Build project"
-cmake --build . "${buildflags[@]}"
-echo "::endgroup::"
-
-if [[ $USE_CCACHE ]]; then
-  echo "::group::Show ccache stats again"
-  ccachestatsverbose
-  echo "::endgroup::"
-fi
-
-if [[ $MAKE_TEST ]]; then
-  echo "::group::Run tests"
-  ctest -C "$BUILDTYPE"
-  echo "::endgroup::"
-fi
-
-if [[ $MAKE_INSTALL ]]; then
-  echo "::group::Install"
-  cmake --build . --target install --config "$BUILDTYPE"
-  echo "::endgroup::"
-fi
-
-if [[ $MAKE_PACKAGE ]]; then
-  echo "::group::Create package"
-  cmake --build . --target package --config "$BUILDTYPE"
-  echo "::endgroup::"
-
-  if [[ $PACKAGE_SUFFIX ]]; then
-    echo "::group::Update package name"
-    cd ..
-    BUILD_DIR="$BUILD_DIR" .ci/name_build.sh "$PACKAGE_SUFFIX"
-    echo "::endgroup::"
-  fi
-fi

.ci/docker.sh

@@ -1,165 +0,0 @@
-#!/bin/bash
-
-# This script is to be used by the ci environment from the project root directory, do not use it from somewhere else.
-
-# Creates or loads docker images to use in compilation, creates RUN function to start compilation on the docker image.
-# <arg> sets the name of the docker image, these correspond to directories in .ci
-# --get loads the image from a previously saved image cache, will build if no image is found
-# --build builds the image from the Dockerfile in .ci/$NAME
-# --save stores the image, if an image was loaded it will not be stored
-# --interactive immediately starts the image interactively for debugging
-# --set-cache <location> sets the location to cache the image or for ccache
-# requires: docker
-# uses env: NAME CACHE BUILD GET SAVE INTERACTIVE
-# (correspond to args: <name> --set-cache <cache> --build --get --save --interactive)
-# sets env: RUN CCACHE_DIR IMAGE_NAME RUN_ARGS RUN_OPTS BUILD_SCRIPT
-# exitcode: 1 for failure, 2 for missing dockerfile, 3 for invalid arguments
-export BUILD_SCRIPT=".ci/compile.sh"
-
-project_name="cockatrice"
-save_extension=".tar.gz"
-image_cache="image"
-ccache_cache=".ccache"
-
-# Read arguments
-while [[ $# != 0 ]]; do
-  case "$1" in
-    '--build')
-      BUILD=1
-      shift
-      ;;
-    '--get')
-      GET=1
-      shift
-      ;;
-    '--interactive')
-      INTERACTIVE=1
-      shift
-      ;;
-    '--save')
-      SAVE=1
-      shift
-      ;;
-    '--set-cache')
-      CACHE=$2
-      if ! [[ -d $CACHE ]]; then
-        echo "could not find cache path: $CACHE" >&2
-        return 3
-      fi
-      shift 2
-      ;;
-    *)
-      if [[ ${1:0:1} == - ]]; then
-        echo "unrecognized option: $1"
-        return 3
-      fi
-      NAME="$1"
-      shift
-      ;;
-  esac
-done
-
-# Setup
-if ! [[ $NAME ]]; then
-  echo "no build name given" >&2
-  return 3
-fi
-
-export IMAGE_NAME="${project_name,,}_${NAME,,}" # lower case
-
-docker_dir=".ci/$NAME"
-if ! [[ -r $docker_dir/Dockerfile ]]; then
-  echo "could not find Dockerfile in $docker_dir" >&2
-  return 2 # even if the image is cached, we do not want to run if there is no way to build this image
-fi
-
-if ! [[ $CACHE ]]; then
-  echo "cache dir is not set!" >&2
-  CACHE="$(mktemp -d)"
-  echo "set cache dir to $CACHE" >&2
-fi
-if ! [[ -d $CACHE ]]; then
-  echo "could not find cache dir: $CACHE" >&2
-  mkdir -p "$CACHE"
-  unset GET # the dir is empty
-fi
-if [[ $GET || $SAVE ]]; then
-  img_dir="$CACHE/$image_cache"
-  img_save="$img_dir/$IMAGE_NAME$save_extension"
-  if ! [[ -d $img_dir ]]; then
-    echo "could not find image dir: $img_dir" >&2
-    mkdir -p "$img_dir"
-  fi
-fi
-export CCACHE_DIR="$CACHE/$ccache_cache"
-if ! [[ -d $CCACHE_DIR ]]; then
-  echo "could not find ccache dir: $CCACHE_DIR" >&2
-  mkdir -p "$CCACHE_DIR"
-fi
-
-# Get the docker image from previously stored save
-if [[ $GET ]]; then
-  if [[ $img_save ]] && docker load --input "$img_save"; then
-    echo "loaded image"
-    docker images
-    unset BUILD # do not overwrite the loaded image with build
-    unset SAVE # do not overwrite the stored image with the same image
-    if [[ $(find "$CCACHE_DIR" -type f -print -quit) ]]; then # check contents of ccache
-      echo "setting ccache to readonly"
-      export RUN_ARGS="$RUN_ARGS -e CCACHE_READONLY=1 -e CCACHE_NOSTATS=1" # do not overwrite ccache
-    else
-      echo "ccache is empty: $(find "$CCACHE_DIR")" >&2
-    fi
-  else
-    echo "could not load cached image, building instead" >&2
-    BUILD=1
-  fi
-fi
-
-# Build the docker image from dockerfile
-if [[ $BUILD ]]; then
-  if docker build --tag "$IMAGE_NAME" "$docker_dir"; then
-    echo "built image"
-    docker images
-  else
-    echo "could not build image $IMAGE_NAME" >&2
-    return 1
-  fi
-fi
-
-# Save docker image to cache (compressed)
-if [[ $SAVE ]]; then
-  if [[ $img_save ]] && docker save --output "$img_save" "$IMAGE_NAME"; then
-    echo "saved image to: $img_save"
-  else
-    echo "could not save image $IMAGE_NAME" >&2
-  fi
-fi
-
-# Set compile function, runs the compile script on the image, passes arguments to the script
-function RUN ()
-{
-  echo "running image:"
-  if [[ $(docker images) =~ "$IMAGE_NAME" ]]; then
-    local args=(--mount "type=bind,source=$PWD,target=/src")
-    args+=(--workdir "/src")
-    args+=(--user "$(id -u):$(id -g)")
-    if [[ $CCACHE_DIR ]]; then
-      args+=(--mount "type=bind,source=$CCACHE_DIR,target=/.ccache")
-      args+=(--env "CCACHE_DIR=/.ccache")
-    fi
-    docker run "${args[@]}" $RUN_ARGS "$IMAGE_NAME" bash "$BUILD_SCRIPT" $RUN_OPTS "$@"
-    return $?
-  else
-    echo "could not find docker image: $IMAGE_NAME" >&2
-    return 3
-  fi
-}
-
-# for debugging, start the docker image interactively instead of building
-# starts immediately, does not require sourcing or RUN
-if [[ $INTERACTIVE ]]; then
-  export BUILD_SCRIPT="-i"
-  export RUN_ARGS="$RUN_ARGS -it"
-  RUN
-fi

.ci/lint_cpp.sh

@@ -1,69 +0,0 @@
-#!/bin/bash
-
-# fetch master branch
-git fetch origin master
-
-# unshallow if needed
-echo "Finding merge base"
-if ! git merge-base origin/master HEAD; then
-  echo "Could not find merge base, unshallowing repo"
-  git fetch --unshallow
-fi
-
-# Check formatting using format.sh
-echo "Checking your code using clang-format/cmake-format..."
-
-diff="$(./format.sh --diff --cmake --cf-version --branch origin/master)"
-err=$?
-
-case $err in
-  1)
-    cat <<EOM
-
-***********************************************************
-***                                                     ***
-***   Your code does not comply with our style guide.   ***
-***                                                     ***
-***   Please correct it or run the "format.sh" script.  ***
-***  Then commit and push those changes to this branch. ***
-***   Check our CONTRIBUTING.md file for more details.  ***
-***                                                     ***
-***                    Thank you ❤️                      ***
-***                                                     ***
-***********************************************************
-
-Used version:
-${diff%%
-----------
-*}
-
-The following changes should be made:
-${diff#*
-----------
-}
-
-Exiting...
-EOM
-    exit 2
-    ;;
-
-  0)
-    cat <<EOM
-
-***********************************************************
-***                                                     ***
-***       Your code complies with our style guide!      ***
-***                                                     ***
-***                      Awesome 👍                     ***
-***                                                     ***
-***********************************************************
-
-Exiting...
-EOM
-    exit 0
-    ;;
-
-  *)
-    echo "Something went wrong in our formatting checks: format.sh returned $err" >&2
-    ;;
-esac

.ci/name_build.sh

@@ -1,55 +0,0 @@
-#!/bin/bash
-# used by the ci to rename build artifacts
-# renames the file to [original name][SUFFIX].[original extension]
-# where SUFFIX is either available in the environment or as the first arg
-# if MAKE_ZIP is set instead a zip is made
-# expected to be run in the build directory unless BUILD_DIR is set
-# adds output to GITHUB_OUTPUT
-builddir="${BUILD_DIR:=.}"
-findrx="Cockatrice-*.*"
-
-if [[ $1 ]]; then
-  SUFFIX="$1"
-fi
-
-# check env
-if [[ ! $SUFFIX ]]; then
-  echo "::error file=$0::SUFFIX is missing"
-  exit 2
-fi
-
-set -e
-
-# find file
-found="$(find "$builddir" -maxdepth 1 -type f -name "$findrx" -print -quit)"
-path="${found%/*}" # remove all after last /
-file="${found##*/}" # remove all before last /
-if [[ ! $file ]]; then
-  echo "::error file=$0::could not find package"
-  exit 1
-fi
-oldpwd="$PWD"
-if ! cd "$path"; then
-  echo "::error file=$0::could not get file path"
-  exit 1
-fi
-
-# set filename
-name="${file%.*}" # remove all after last .
-new_name="$name$SUFFIX."
-if [[ $MAKE_ZIP ]]; then
-  filename="${new_name}zip"
-  echo "creating zip '$filename' from '$file'"
-  zip "$filename" "$file"
-else
-  extension="${file##*.}" # remove all before last .
-  filename="$new_name$extension"
-  echo "renaming '$file' to '$filename'"
-  mv "$file" "$filename"
-fi
-
-cd "$oldpwd"
-relative_path="$path/$filename"
-ls -l "$relative_path"
-echo "path=$relative_path" >>"$GITHUB_OUTPUT"
-echo "name=$filename" >>"$GITHUB_OUTPUT"

.ci/prep_release.sh

@@ -1,113 +0,0 @@
-#!/bin/bash
-# sets the properties of ci releases
-# this doesn't have to be 100% foolproof
-# the releases are first made as drafts and will be vetted by a human
-# it just has to provide a template
-# this requires the repo to be unshallowed
-# adds output to GITHUB_OUTPUT
-template_path=".ci/release_template.md"
-body_path="/tmp/release.md"
-beta_regex='beta'
-name_regex='set\(GIT_TAG_RELEASENAME "([[:print:]]+)")'
-whitespace='^\s*$'
-
-if [[ $1 ]]; then
-  TAG="$1"
-fi
-
-# check env
-if [[ ! $TAG ]]; then
-  echo "::error file=$0::TAG is missing"
-  exit 2
-fi
-
-# create title
-if [[ $TAG =~ $beta_regex ]]; then
-  echo "is_beta=yes" >>"$GITHUB_OUTPUT"
-  title="$TAG"
-  echo "creating beta release '$title'"
-elif [[ ! $(cat CMakeLists.txt) =~ $name_regex ]]; then
-  echo "::error file=$0::could not find releasename in CMakeLists.txt"
-  exit 1
-else
-  echo "is_beta=no" >>"$GITHUB_OUTPUT"
-  name="${BASH_REMATCH[1]}"
-  version="${TAG##*-}"
-  title="Cockatrice $version: $name"
-  no_beta=1
-  echo "friendly_name=$name" >>"$GITHUB_OUTPUT"
-  echo "creating full release '$title'"
-fi
-echo "title=$title" >>"$GITHUB_OUTPUT"
-
-# add release notes template
-if [[ $no_beta ]]; then
-  body="$(cat "$template_path")"
-  if [[ ! $body ]]; then
-    echo "::warning file=$0::could not find release template"
-  fi
-  body="${body//--REPLACE-WITH-RELEASE-TITLE--/$title}"
-else
-  body="--REPLACE-WITH-COMMIT-COUNT-- commits have been included over the previous --REPLACE-WITH-PREVIOUS-RELEASE-TYPE--
-
-<details>
-<summary><b>show changes</b></summary>
-
---REPLACE-WITH-GENERATED-LIST--
-</details>"
-fi
-
-# add git log to release notes
-all_tags="
-$(git tag)" # tags are ordered alphabetically
-before="${all_tags%%
-"$TAG"*}" # strip line with current tag an all lines after it
-# note the extra newlines are needed to always have a last line
-if [[ $all_tags == "$before" ]]; then
-  echo "::warning file=$0::could not find current tag"
-else
-  while
-    previous="${before##*
-}" # get the last line
-    # skip this tag if this is a full release and it's a beta or if empty
-    [[ $no_beta && $previous =~ $beta_regex || ! $previous ]]
-  do
-    beta_list+=" $previous" # add to list of skipped betas
-    next_before="${before%
-*}" # strip the last line
-    if [[ $next_before == "$before" ]]; then
-      unset previous
-      break
-    fi
-    before="$next_before"
-  done
-  if [[ $previous ]]; then
-    if generated_list="$(git log "$previous..$TAG" --pretty="- %s")"; then
-      count="$(git rev-list --count "$previous..$TAG")"
-      [[ $previous =~ $beta_regex ]] && previousreleasetype="beta release" || previousreleasetype="full release"
-      echo "adding list of commits to release notes:"
-      echo "'$previous' to '$TAG' ($count commits)"
-      # --> is the markdown comment escape sequence, emojis are way better
-      generated_list="${generated_list//-->/→}"
-      body="${body//--REPLACE-WITH-GENERATED-LIST--/$generated_list}"
-      body="${body//--REPLACE-WITH-COMMIT-COUNT--/$count}"
-      body="${body//--REPLACE-WITH-PREVIOUS-RELEASE-TAG--/$previous}"
-      body="${body//--REPLACE-WITH-PREVIOUS-RELEASE-TYPE--/$previousreleasetype}"
-      if [[ $beta_list =~ $whitespace ]]; then
-        beta_list="-n there are no betas to delete!"
-      else
-        echo "the following betas should be deleted after publishing:"
-        echo "$beta_list"
-      fi
-      body="${body//--REPLACE-WITH-BETA-LIST--/$beta_list}"
-    else
-      echo "::warning file=$0::failed to produce git log"
-    fi
-  else
-    echo "::warning file=$0::could not find previous tag"
-  fi
-fi
-
-# write to file
-echo "body_path=$body_path" >>"$GITHUB_OUTPUT"
-echo "$body" >"$body_path"

.ci/release_template.md

@@ -1,94 +0,0 @@
-<!-- this template comes from .ci/release_template.md -->
-
-<!-- Don't forget to delete the previous betas after publishing this!
-git push -d origin --REPLACE-WITH-BETA-LIST--
- -->
-
-<!-- This list of binaries should be updated every time the ci is changed to
-include different targets -->
-<pre>
-<b>Pre-compiled binaries we serve:</b>
- - <kbd>Windows 7/8/10/11 (32-bit)</kbd>
- - <kbd>Windows 7/8 (64-bit)</kbd>
- - <kbd>Windows 10/11 (64-bit)</kbd>
- - <kbd>macOS 10.14</kbd> ("Mojave")
- - <kbd>macOS 10.15</kbd> ("Catalina")
- - <kbd>macOS 11.0+</kbd> ("Big Sur")
- - <kbd>Ubuntu 18.04</kbd> ("Bionic Beaver")
- - <kbd>Ubuntu 20.04</kbd> ("Focal Fossa")
- - <kbd>Ubuntu 22.04</kbd> ("Jammy Jellyfish")
- - <kbd>Debian 10</kbd> ("Buster")
- - <kbd>Debian 11</kbd> ("Bullseye")
- - <kbd>Fedora 35</kbd>
- - <kbd>Fedora 36</kbd>
-<kbd>We are also packaged in Arch Linux's official community repository, courtesy of @FFY00</kbd></i>
-<kbd>General linux support is available via a flatpak package (Flathub)</kbd></i>
-</pre>
-
-
-## General Notes
-
-We're pleased to announce the newest official release: <kbd>--REPLACE-WITH-RELEASE-TITLE--</kbd>
-
-We hope you enjoy the changes made and we have listed all changes, with their corresponding tickets, since the last version of Cockatrice was released for your convenience.
-
-If you ever encounter a bug, have a suggestion or idea, or feel a need for a developer to look into something, please feel free to [open a ticket](https://github.com/Cockatrice/Cockatrice/issues). ([How to create a GitHub Ticket for Cockatrice](https://github.com/Cockatrice/Cockatrice/wiki/How-to-Create-a-GitHub-Ticket-Regarding-Cockatrice))
-
-For any information relating to Cockatrice, please take a look at our official site: **https://cockatrice.github.io**
-
-If you'd like to help contribute to Cockatrice in any way, check out our [README](https://github.com/Cockatrice/Cockatrice#get-involved-). We're always available to answer questions you may have on how the program works and how you can provide a meaningful contribution.
-
-
-## Upgrading Cockatrice
-<!-- this optional section puts a warning banner for problems with updating
-> ⚠️ **With this release, we no longer provide a ready-to-install binary for:**
-> --DEPRECATED-OS-HERE--
- -->
-
-- Run the internal software updater: <kbd>Help → Check for Client Updates</kbd>
-
-Don't forget to update your card database right after! (<kbd>Help → Check for Card Updates...</kbd>)
-
-
-## Changelog
-<!--
-This list is generated and should be moved to their respective header and
-possibly edited a little.
-Append PR numbers of fixups to their main PR to keep the list coherent.
-Put the quantity of remaining PR's below the highlights section.
-Remove empty headers when done.
-
---REPLACE-WITH-GENERATED-LIST--
- -->
-
-<!-- Highlights of the release -->
-### ⚠️ Important:
-### ✨ New Features:
-### 🐛 Fixed Bugs / Resolved issues:
-
-<!-- Complete list of changes (foldable) -->
-<details>
-<summary>
-📘 <b>Show all changes</b> (--REPLACE-WITH-COMMIT-COUNT-- commits)
-</summary>
-
-### User Interface
-### Under the Hood
-### Oracle
-### Servatrice
-### Webatrice
-
-</details>
-
-
-## Translations
-- **Thanks for over 300 people contributing to 20+ different languages up to now!**
-- Without the help of the community we couldn't offer that great language support... keep up the good work!
-- It's actually very easy to join and help for yourself - find out more here:
-    - [Help us Translate Cockatrice into your native language!](https://github.com/Cockatrice/Cockatrice/wiki/Translation-FAQ)
-
-
-## Special Thanks
-<!-- Personalise this a bit! -->
-We continue to find it amazing that so many people contribute their time, knowledge, code, testing and more to the project. We'd like to thank the entire Cockatrice community for their efforts.
-<!-- We'd like to especially recognize @ZeldaZach, --ADD-CONTRIBUTORS-HERE-- for their help in preparing so many amazing new features for the user base. -->

.ci/travis-compile.sh

@@ -0,0 +1,149 @@
+#!/bin/bash
+
+# This script is to be used in .travis.yaml from the project root directory, do not use it from somewhere else.
+
+# Read arguments
+while [[ "$@" ]]; do
+  case "$1" in
+    '--format')
+      CHECK_FORMAT=1
+      shift
+      ;;
+    '--install')
+      MAKE_INSTALL=1
+      shift
+      ;;
+    '--package')
+      MAKE_PACKAGE=1
+      shift
+      if [[ $# != 0 && $1 != -* ]]; then
+        PACKAGE_NAME="$1"
+        shift
+        if [[ $# != 0 && $1 != -* ]]; then
+          PACKAGE_TYPE="$1"
+          shift
+        fi
+      fi
+      ;;
+    '--server')
+      MAKE_SERVER=1
+      shift
+      ;;
+    '--test')
+      MAKE_TEST=1
+      shift
+      ;;
+    '--debug')
+      BUILDTYPE="Debug"
+      shift
+      ;;
+    '--release')
+      BUILDTYPE="Release"
+      shift
+      ;;
+    *)
+      if [[ $1 == -* ]]; then
+        echo "unrecognized option: $1"
+        exit 3
+      fi
+      BUILDTYPE="$1"
+      shift
+      ;;
+  esac
+done
+
+# Check formatting using clang-format
+if [[ $CHECK_FORMAT ]]; then
+  echo "Checking your code using clang-format..."
+  diff="$(./clangify.sh --diff --cf-version)"
+  err=$?
+  case $err in
+    1)
+      cat <<EOM
+***********************************************************
+***                                                     ***
+***    Your code does not comply with our styleguide.   ***
+***                                                     ***
+***  Please correct it or run the "clangify.sh" script. ***
+***  Then commit and push those changes to this branch. ***
+***   Check our CONTRIBUTING.md file for more details.  ***
+***                                                     ***
+***                     Thank you ♥                     ***
+***                                                     ***
+***********************************************************
+
+Used clang-format version:
+${diff%%
+*}
+
+The following changes should be made:
+${diff#*
+}
+
+Exiting...
+EOM
+      exit 2
+      ;;
+    0)
+      echo "Thank you for complying with our code standards."
+      ;;
+    *)
+      echo "Something went wrong in our formatting checks: clangify returned $err" >&2
+      ;;
+  esac
+fi
+
+set -e
+
+# Setup
+./servatrice/check_schema_version.sh
+mkdir -p build
+cd build
+
+# Add cmake flags
+if [[ $MAKE_SERVER ]]; then
+  flags+=" -DWITH_SERVER=1"
+fi
+if [[ $MAKE_TEST ]]; then
+  flags+=" -DTEST=1"
+  BUILDTYPE="Debug" # test requires buildtype Debug
+fi
+if [[ $BUILDTYPE ]]; then
+  flags+=" -DCMAKE_BUILD_TYPE=$BUILDTYPE"
+fi
+if [[ $PACKAGE_TYPE ]]; then
+  flags+=" -DCPACK_GENERATOR=$PACKAGE_TYPE"
+fi
+
+# Add qt install location when using brew
+if [[ $(uname) == "Darwin" ]]; then
+  PATH="/usr/local/opt/ccache/bin:$PATH"
+  flags+=" -DCMAKE_PREFIX_PATH=/usr/local/opt/qt5/"
+fi
+
+# Compile
+cmake --version
+cmake .. $flags
+make -j2
+
+if [[ $MAKE_TEST ]]; then
+  make test
+fi
+
+if [[ $MAKE_INSTALL ]]; then
+  make install
+fi
+
+if [[ $MAKE_PACKAGE ]]; then
+  make package
+  if [[ $PACKAGE_NAME ]]; then
+    found=$(find . -maxdepth 1 -type f -name "Cockatrice-*.*" -print -quit)
+    path=${found%/*}
+    file=${found##*/}
+    if [[ ! $file ]]; then
+      echo "could not find package" >&2
+      exit 1
+    fi
+    mv "$path/$file" "$path/${file%.*}-$PACKAGE_NAME.${file##*.}"
+  fi
+fi

.clang-format

@@ -23,9 +23,3 @@ BinPackParameters: false
 AllowAllParametersOfDeclarationOnNextLine: false
 IndentCaseLabels: true
 PointerAlignment: Right
-SortIncludes: true
-IncludeBlocks: Regroup
----
-Language: Proto
-AllowShortFunctionsOnASingleLine: None
-SpacesInContainerLiterals: false

.cmake-format.json

@@ -1,109 +0,0 @@
-{
-  "format": {
-    "_help_line_width": [
-      "How wide to allow formatted cmake files"
-    ],
-    "line_width": 120,
-    "_help_tab_size": [
-      "How many spaces to tab for indent"
-    ],
-    "tab_size": 2,
-    "_help_max_subgroups_hwrap": [
-      "If an argument group contains more than this many sub-groups",
-      "(parg or kwarg groups) then force it to a vertical layout."
-    ],
-    "max_subgroups_hwrap": 2,
-    "_help_max_pargs_hwrap": [
-      "If a positional argument group contains more than this many",
-      "arguments, then force it to a vertical layout."
-    ],
-    "max_pargs_hwrap": 6,
-    "_help_max_rows_cmdline": [
-      "If a cmdline positional group consumes more than this many",
-      "lines without nesting, then invalidate the layout (and nest)"
-    ],
-    "max_rows_cmdline": 5,
-    "_help_separate_ctrl_name_with_space": [
-      "If true, separate flow control names from their parentheses",
-      "with a space"
-    ],
-    "separate_ctrl_name_with_space": false,
-    "_help_separate_fn_name_with_space": [
-      "If true, separate function names from parentheses with a",
-      "space"
-    ],
-    "separate_fn_name_with_space": false,
-    "_help_dangle_parens": [
-      "If a statement is wrapped to more than one line, than dangle",
-      "the closing parenthesis on its own line."
-    ],
-    "dangle_parens": true,
-    "_help_dangle_align": [
-      "If the trailing parenthesis must be 'dangled' on its on",
-      "line, then align it to this reference: `prefix`: the start",
-      "of the statement,  `prefix-indent`: the start of the",
-      "statement, plus one indentation  level, `child`: align to",
-      "the column of the arguments"
-    ],
-    "dangle_align": "prefix",
-    "_help_min_prefix_chars": [
-      "If the statement spelling length (including space and",
-      "parenthesis) is smaller than this amount, then force reject",
-      "nested layouts."
-    ],
-    "min_prefix_chars": 4,
-    "_help_max_prefix_chars": [
-      "If the statement spelling length (including space and",
-      "parenthesis) is larger than the tab width by more than this",
-      "amount, then force reject un-nested layouts."
-    ],
-    "max_prefix_chars": 10,
-    "_help_max_lines_hwrap": [
-      "If a candidate layout is wrapped horizontally but it exceeds",
-      "this many lines, then reject the layout."
-    ],
-    "max_lines_hwrap": 2,
-    "_help_line_ending": [
-      "What style line endings to use in the output."
-    ],
-    "line_ending": "auto",
-    "_help_command_case": [
-      "Format command names consistently as 'lower' or 'upper' case"
-    ],
-    "command_case": "lower",
-    "_help_keyword_case": [
-      "Format keywords consistently as 'lower' or 'upper' case"
-    ],
-    "keyword_case": "upper",
-    "_help_always_wrap": [
-      "A list of command names which should always be wrapped"
-    ],
-    "always_wrap": [],
-    "_help_enable_sort": [
-      "If true, the argument lists which are known to be sortable",
-      "will be sorted lexicographically"
-    ],
-    "enable_sort": true,
-    "_help_autosort": [
-      "If true, the parsers may infer whether or not an argument",
-      "list is sortable (without annotation)."
-    ],
-    "autosort": true,
-    "_help_require_valid_layout": [
-      "By default, if cmake-format cannot successfully fit",
-      "everything into the desired line-width it will apply the",
-      "last, most aggressive attempt that it made. If this flag is",
-      "True, however, cmake-format will print error, exit with non-",
-      "zero status code, and write-out nothing"
-    ],
-    "require_valid_layout": false,
-    "_help_layout_passes": [
-      "A dictionary mapping layout nodes to a list of wrap",
-      "decisions. See the documentation for more information."
-    ],
-    "layout_passes": {}
-  },
-  "markup": {
-    "enable_markup": false
-  }
-}

.dockerignore

@@ -1,6 +1,7 @@
 .git/
 build/
 .github/
+.travis/
 .tx/
 cockatrice/
 doc/

.github/CONTRIBUTING.md

@@ -1,6 +1,4 @@
-  [Introduction](#contributing-to-cockatrice) | [Code Style Guide](
-#code-style-guide) | [Translations](#translations) | [Release Management](
-#release-management)
+  [Introduction](#contributing-to-cockatrice) | [Code Style Guide](#code-style-guide) | [Translations](#translations) | [Release Management](#release-management)
 
 ----
 
@@ -9,89 +7,50 @@
 # Contributing to Cockatrice #
 First off, thanks for taking the time to contribute to our project! 🎉 ❤ ️✨
 
-The following is a set of guidelines for contributing to Cockatrice. These are
-mostly guidelines, not rules. Use your best judgment, and feel free to propose
-changes to this document in a pull request.
+The following is a set of guidelines for contributing to Cockatrice. These are mostly guidelines, not rules. Use your best judgment, and feel free to propose changes to this document in a pull request.
 
 
 # Recommended Setups #
 
-For those developers who like the Linux or MacOS environment, many of our
-developers like working with a nifty program called [CLion](
-https://www.jetbrains.com/clion/). The program's a great asset and one of the
-best tools you'll find on these systems, but you're welcomed to use any IDE
-you most enjoy.
+For those developers who like the Linux or MacOS environment, many of our developers like working with a nifty program called [CLion](https://www.jetbrains.com/clion/). The program's a great asset and one of the best tools you'll find on these systems, but you're welcomed to use any IDE you most enjoy.
 
-Developers who like Windows development tend to find [Visual Studio](
-https://www.visualstudio.com/) the best tool for the job.
+Developers who like Windows development tend to find [Visual Studio](https://www.visualstudio.com/) the best tool for the job.
 
-[![Discord](https://img.shields.io/discord/314987288398659595?label=Discord&logo=discord&logoColor=white&color=7289da)](https://discord.gg/ZASRzKu)
-[![Gitter Chat](https://img.shields.io/gitter/room/Cockatrice/Cockatrice.svg)](https://gitter.im/Cockatrice/Cockatrice)
-
-If you'd like to ask questions, get advice, or just want to say hi,
-the Cockatrice Development Team uses [Discord](https://discord.gg/ZASRzKu)
-for communications in the #dev channel. If you're not into Discord, we also
-have a [Gitter](https://gitter.im/Cockatrice/Cockatrice) channel available,
-albeit slightly less active.
+If you have any questions on IDEs, feel free to chat with us on [Gitter](https://gitter.im/Cockatrice/Cockatrice) and we would love to help answer your questions!  
 
 
 # Code Style Guide #
 
-### Formatting and continuous integration (CI) ###
+### Formatting and continuous integration (ci) ###
 
-We use a separate job on the CI to check your code for formatting issues. If
-your pull request failed the test, you can check the output on the checks tab.
-It's the first job called "linter", you can click the "Check code formatting"
-step to see the output of the test.
+We currently use Travis CI to check your code for formatting issues, if your pull request was rejected because of this it would show a message in the logs. Click on "Details" next to the failed Travis CI build and then click on the failed build (most likely the fastest one) to see the log.
 
-The message will look like this:
+The message will look somewhat similar to this:
 ```
-***********************************************************
-***                                                     ***
-***   Your code does not comply with our style guide.   ***
-***                                                     ***
-***   Please correct it or run the "format.sh" script.  ***
-***  Then commit and push those changes to this branch. ***
-***   Check our CONTRIBUTING.md file for more details.  ***
-***                                                     ***
-***                    Thank you ❤️                      ***
-***                                                     ***
-***********************************************************
+************************************************************
+*** Your code does not meet our formatting guidelines.   ***
+*** Please correct it then commit and push your changes. ***
+*** See our CONTRIBUTING.md file for more information.   ***
+************************************************************
 ```
-The CONTRIBUTING.md file mentioned in that message is the file you are
-currently reading. Please see [this section](#formatting) below for full
-information on our formatting guidelines.
+The CONTRIBUTING.md file mentioned is this file. Please read [this section](#Formatting) for full information on our formatting guidelines.
 
 ### Compatibility ###
 
-Cockatrice is currently compiled on all platforms using <kbd>C++11</kbd>.
-You'll notice <kbd>C++03</kbd> code throughout the codebase. Please feel free
-to help convert it over!
+Cockatrice is currently compiled on all platforms using <kbd>C++11</kbd>. You'll notice <kbd>C++03</kbd> code throughout the codebase. Please feel free to help convert it over!
 
-For consistency, we use Qt data structures where possible. For example,
-`QString` over `std::string` and `QList` over `std::vector`.
-
-Do not use old C style casts in new code, instead use a [`static_cast<>`](
-https://en.cppreference.com/w/cpp/language/static_cast)
-or other appropriate conversion.
+For consistency, we use Qt data structures where possible. For example, `QString` over
+`std::string` and `QList` over `std::vector`.
 
 ### Formatting ###
 
-The handy tool `clang-format` can format your code for you, it is available for
-almost any environment. A special `.clang-format` configuration file is
-included in the project and is used to format your code.
+The handy tool `clang-format` can format your code for you, it is available for almost any environment. A special `.clang-format` configuration file is included in the project and is used to format your code.
 
-We've also included a bash script, `format.sh`, that will use clang-format to
-format all files in your pr in one go. Use `./format.sh --help` to show a full
-help page.
+We've also included a bash script, `clangify.sh`, that will use clang-format to format all files in one go. Use `./clangify.sh --help` to show a full help page.
 
-To run clang-format on a single source file simply use the command
-`clang-format -i <filename>` to format it in place. (Some systems install
-clang-format with a specific version number appended,
-`find /usr/bin -name clang-format*` should find it for you)
+To run clang-format on a single source file simply use the command `clang-format -i <filename>` to format it in place. (some systems install clang-format with a specific version number appended, `find /usr/bin -name clang-format*` should find it for you)
 
-See [the clang-format documentation](
-https://clang.llvm.org/docs/ClangFormat.html) for more information about the tool.
+See [the clang-format documentation](https://clang.llvm.org/docs/ClangFormat.html) for more information about the tool.
 
 #### Header files ####
 
@@ -103,8 +62,7 @@ Use header guards in the form of `FILE_NAME_H`.
 Simple functions, such as getters, may be written inline in the header file,
 but other functions should be written in the source file.
 
-Group project includes first, followed by library includes. All in alphabetic order.
-Like this:
+Group library includes after project includes, and in alphabetic order. Like this:
 ```c++
 // Good
 #include "card.h"
@@ -130,15 +88,9 @@ Like this:
 Use `UpperCamelCase` for classes, structs, enums, etc. and `lowerCamelCase` for
 function and variable names.
 
-Don't use [Hungarian Notation](
-https://en.wikipedia.org/wiki/Hungarian_notation).
-
-Member variables aren't decorated in any way. Don't prefix or suffix them with
+Member variables aren't decorated in any way. Don't prefix or suffix with
 underscores, etc.
 
-Use a separate line for each declaration, don't use a single line like this
-`int one = 1, two = 2` and instead split them into two lines.
-
 For arguments to constructors which have the same names as member variables,
 prefix those arguments with underscores:
 ```c++
@@ -163,8 +115,7 @@ If you find any usage of the old keywords, we encourage you to fix it.
 
 #### Braces ####
 
-Braces should go on their own line except for control statements, the use of
-braces around single line statements is preferred.
+Braces should go on their own line except for control statements, the use of braces around single line statements is preferred.
 See the following example:
 ```c++
 int main()
@@ -185,25 +136,17 @@ int main()
 
 #### Indentation and Spacing ####
 
-Always indent using 4 spaces, do not use tabs. Opening and closing braces
-should be on the same indentation layer, member access specifiers in classes or
-structs should not be indented.
+Always indent using 4 spaces, do not use tabs. Opening and closing braces should be on the same indentation layer, member access specifiers in classes or structs should not be indented.
 
-All operators and braces should be separated by spaces, do not add a space next
-to the inside of a brace.
+All operators and braces should be separated by spaces, do not add a space next to the inside of a brace.
 
-If multiple lines of code that follow eachother have single line comments
-behind them, place all of them on the same indentation level. This indentation
-level should be equal to the longest line of code for each of these comments,
-without added spacing.
+If multiple lines of code that follow eachother have single line comments behind them, place all of them on the same indentation level. This indentation level should be equal to the longest line of code for each of these comments, without added spacing.
 
 #### Lines ####
 
-Do not leave trailing whitespace on any line. Most IDEs check for this
-nowadays and clean it up for you.
+Do not have trailing whitespace in your lines. Most IDEs check for this nowadays and clean it up for you.
 
-Lines should be 120 characters or less. Please break up lines that are too long
-into smaller parts, for example at spaces or after opening a brace.
+Lines should be 120 characters or less. Please break up lines that are too long into smaller parts, for example at spaces or after opening a brace.
 
 ### Memory Management ###
 
@@ -239,93 +182,44 @@ as `QScopedPointer`, or, less preferably, `QSharedPointer`.
 The servatrice database's schema can be found at `servatrice/servatrice.sql`.
 Everytime the schema gets modified, some other steps are due:
  1. Increment the value of `cockatrice_schema_version` in `servatrice.sql`;
- 2. Increment the value of `DATABASE_SCHEMA_VERSION` in
- `servatrice_database_interface.h` accordingly;
- 3. Create a new migration file inside the `servatrice/migrations` directory
- named after the new schema version.
- 4. Run the `servatrice/check_schema_version.sh` script to ensure everything is
- fine.
+ 2. Increment the value of `DATABASE_SCHEMA_VERSION` in `servatrice_database_interface.h` accordingly;
+ 3. Create a new migration file inside the `servatrice/migrations` directory named after the new schema version.
+ 4. Run the `servatrice/check_schema_version.sh` script to ensure everything is fine.
 
-The migration file should include the sql statements needed to migrate the
-database schema and data from the previous to the new version, and an
-additional statement that updates `cockatrice_schema_version` to the correct
-value.
+The migration file should include the sql statements needed to migrate the database schema and data from the previous to the new version, and an additional statement that updates `cockatrice_schema_version` to the correct value.
 
-Ensure that the migration produces the expected effects; e.g. if you add a
-new column, make sure the migration places it in the same order as
-servatrice.sql.
+Ensure that the migration produces the expected effects; e.g. if you add a new column, make sure the migration places it in the same order as servatrice.sql.
 
 ### Protocol buffer ###
 
-Cockatrice and Servatrice exchange data using binary messages. The syntax of
-these messages is defined in the `proto` files in the `common/pb` folder. These
-files define the way data contained in each message is serialized using
-Google's [protocol buffers](https://developers.google.com/protocol-buffers/).
-Any change to the `proto` files should be taken with caution and tested
-intensively before being merged, because a change to the protocol could make
-new clients incompatible to the old server and vice versa.
+Cockatrice and Servatrice exchange data using binary messages. The syntax of these messages is defined in the `proto` files in the `common/pb` folder. These files defines the way data contained in each message is serialized using Google's [protocol buffer](https://developers.google.com/protocol-buffers/).
+Any change to the `proto` file should be taken with caution and tested intensively before being merged, becaus a change to the protocol could make new clients incompatible to the old server and vice versa.
 
-You can find more information on how we use Protobuf on [our wiki!](
-https://github.com/Cockatrice/Cockatrice/wiki/Client-server-protocol)
+You can find more information on how we use Protobuf on [our wiki!](https://github.com/Cockatrice/Cockatrice/wiki/Client-server-protocol)
 
-# Reviewing Pull Requests #
-
-After you have finished your changes to the project you should put them on a
-separate branch of your fork on GitHub and open a [pull request](
-https://docs.github.com/en/free-pro-team@latest/desktop/contributing-and-collaborating-using-github-desktop/creating-an-issue-or-pull-request
-).
-Your code will then be automatically compiled by GitHub actions for Linux and
-macOS, and by Appveyor for Windows. Additionally GitHub will perform a [Linting
-check](#formatting-and-continuous-integration-ci). If any issues come up you
-can check their status at the bottom of the pull request page, click on details
-to go to the CI website and see the different build logs.
-
-If your pull request passes our tests and has no merge conflicts, it will be
-reviewed by our team members. You can then address any requested changes. When
-all changes have been approved your pull request will be squashed into a single
-commit and merged into the master branch by a team member. Your change will then
-be included in the next release 👍
 
 # Translations #
 
 Basic workflow for translations:
  1. Developer adds a `tr("foo")` string in the code;
- 2. Every few days, a maintainer updates the `*_en@source.ts files` with the new strings;
- 3. Transifex picks up the new files from GitHub every 24 hours;
+ 2. Every few days, a maintainer updates the `*_en.ts files` with the new strings;
+ 3. Transifex picks up the new files from github every 24 hours;
  4. Translators translate the new untranslated strings on Transifex;
  5. Before a release, a maintainer fetches the updated translations from Transifex.
 
 ### Using Translations (for developers) ###
 
-All the user-interface strings inside Cockatrice's source code must be written
-in English(US).
-Translations to other languages are managed using [Transifex](
-https://www.transifex.com/projects/p/cockatrice/).
+All the user-interface strings inside Cockatrice's source code must be written in english.
+Translations to other languages are managed using [Transifex](https://www.transifex.com/projects/p/cockatrice/).
 
-Adding a new string to translate is as easy as adding the string in the
-'tr("")' function, the string will be picked up as translatable automatically
-and translated as needed.
-For example, setting the text of a label in the way that the string
-`"My name is:"` can be translated:
+Adding a new string to translate is as easy as adding the string in the 'tr("")' function, the string will be picked up as translatable automatically and translated as needed.
+For example setting the text of this label in a way that the string "My name is:" can be translated:
 ```c++
 nameLabel.setText(tr("My name is:"));
 ```
 
-To translate a string that would have plural forms you can add the amount to
-the tr call, also you can add an extra string as a hint for translators:
-```c++
-QString message = tr("Everyone draws %n cards", "pop up message", amount);
-```
-See [QT's wiki on translations](
-https://doc.qt.io/qt-5/i18n-source-translation.html#handling-plurals)
-
-If you're about to propose a change that adds or modifies any translatable
-string in the code, you don't need to take care of adding the new strings to
-the translation files.
-Every few days, or when a lot of new strings have been added, someone from the
-development team will take care of extracting all the new strings and adding
-them to the english translation files and making them available to translators
-on Transifex.
+If you're about to propose a change that adds or modifies any translatable string in the code, you don't need to take care of adding the new strings to the translation files.
+Every few days, or when a lot of new strings have been added, someone from the development team will take care of extracting all the new strings and adding them to the english translation files and making them available to translators on Transifex.
 
 ### Maintaining Translations (for maintainers) ###
 
@@ -344,14 +238,14 @@ make
 If the parameter has been enabled correctly, when running "make" you should see
 a line similar to this one (the numbers may vary):
 ```sh
-[ 76%] Generating ../../cockatrice/translations/cockatrice_en@source.ts
-Updating '../../cockatrice/translations/cockatrice_en@source.ts'...
+[ 76%] Generating ../../cockatrice/translations/cockatrice_en.ts
+Updating '../../cockatrice/translations/cockatrice_en.ts'...
 Found 857 source text(s) (8 new and 849 already existing)
 ```
 You should then notice that the following files have uncommitted changes:
 
-    cockatrice/translations/cockatrice_en@source.ts
-    oracle/translations/oracle_en@source.ts
+    cockatrice/translations/cockatrice_en.ts
+    oracle/translations/oracle_en.ts
 
 It is recommended to disable the parameter afterwards using:
 ```sh
@@ -359,9 +253,8 @@ cmake .. -DUPDATE_TRANSLATIONS=OFF
 ```
 Now you are ready to propose your change.
 
-Once your change gets merged, Transifex will pick up the modified files
-automatically (checked every 24 hours) and update the interface where
-translators will be able to translate the new strings.
+Once your change gets merged, Transifex will pick up the modified files automatically (checked every 24 hours)
+and update the interface where translators will be able to translate the new strings.
 
 ### Releasing Translations (for maintainers) ###
 
@@ -379,85 +272,51 @@ from Transifex to the source code and vice versa.
 
 ### Adding Translations (for translators) ###
 
-As a translator you can help translate the new strings on [Transifex](
-https://www.transifex.com/projects/p/cockatrice/).
-Please have a look at the specific [FAQ for translators](
-https://github.com/Cockatrice/Cockatrice/wiki/Translation-FAQ).
+As a translator you can help translate the new strings on [Transifex](https://www.transifex.com/projects/p/cockatrice/).
+Please have a look at the specific [FAQ for translators](https://github.com/Cockatrice/Cockatrice/wiki/Translation-FAQ).
 
 
 # Release Management #
 
-### Publishing A New Release ###
+### Publishing A New Beta Release ###
 
-We use [GitHub Releases](https://github.com/Cockatrice/Cockatrice/releases) to
-publish new stable versions and betas.
-Whenever a git tag is pushed to the repository github will create a draft
-release and upload binaries automatically.
+Travis and AppVeyor have been configured to upload files to GitHub Releases whenever a <kbd>tag</kbd> is pushed.<br>
+Usually, tags are created through publishing a (pre-)release, but there's a way around that.
 
-To create a tag, simply do the following:
+To trigger Travis and AppVeyor, simply do the following:
 ```bash
+cd $COCKATRICE_REPO
 git checkout master
 git remote update -p
 git pull
 git tag $TAG_NAME
-git push $UPSTREAM $TAG_NAME
+git push upstream $TAG_NAME
 ```
-
 You should define the variables as such:
 ```
-`$UPSTREAM` - the remote for git@github.com:Cockatrice/Cockatrice.git
-`$TAG_NAME` should be formatted as:
+upstream - git@github.com:Cockatrice/Cockatrice.git
+$COCKATRICE_REPO - /Location/of/repository/cockatrice.git
+`$TAG_NAME` should be:
   - `YYYY-MM-DD-Release-MAJ.MIN.PATCH` for **stable releases**
   - `YYYY-MM-DD-Development-MAJ.MIN.PATCH-beta.X` for **beta releases**<br>
     With *MAJ.MIN.PATCH* being the NEXT release version!
 ```
 
-This will cause a tagged release to be established on the GitHub repository,
-with the binaries being added to the release whenever they are ready.
-The release is initially a draft, where the path notes can be edited and after
-all is good and ready it can be published on GitHub.
-If you use a SemVer tag including "beta", the release that will be created at
-GitHub will be marked as a "Pre-release" automatically.
-The target of the `.../latest` URL will not be changed in that case, it always
-points to the latest stable release and not pre-releases/betas.
+This will cause a tagged release to be established on the GitHub repository, which will then lead to the upload of binaries. If you use this method, the tags (releases) that you create will be marked as a "Pre-release". The `/latest` URL will not be impacted (for stable release downloads) so that's good.
 
-If you accidentally push a tag incorrectly (the tag is outdated, you didn't
-pull in the latest branch accidentally, you named the tag wrong, etc.) you can
-revoke the tag by doing the following:
+If you accidentally push a tag incorrectly (the tag is outdated, you didn't pull in the latest branch accidentally, you named the tag wrong, etc.) you can revoke the tag by doing the following:
 ```bash
 git push --delete upstream $TAG_NAME
 git tag -d $TAG_NAME
 ```
-You can also do this on GitHub, you'll also want to delete the new release.
 
-In the first lines of [CMakeLists.txt](
-https://github.com/Cockatrice/Cockatrice/blob/master/CMakeLists.txt)
-there's an hardcoded version number and pretty name used when compiling from
-master or custom (not tagged) versions.
-While on tagged versions these numbers are overridden by the version numbers
-coming from the tag title, it's good practice to increment the ones at CMake
-after every full release to stress that master is ahead of the last stable
-release.
+**NOTE:** Unfortunately, due to the method of how Travis and AppVeyor work, to publish a stable release you will need to make a copy of the release notes locally and then paste them into the GitHub GUI once the binaries have been uploaded by them. These CI services will automatically overwrite the name of the release (to "Cockatrice $TAG_NAME"), the status of the release (to "Pre-release"), and the release body (to "Beta build of Cockatrice").
+
+**NOTE 2:** In the first lines of https://github.com/Cockatrice/Cockatrice/blob/master/CMakeLists.txt there's an hardcoded version number used when compiling custom (not tagged) versions. While on tagged versions these numbers are overridden by the version numbers coming from the tag title, it's good practice to keep them aligned with the real ones.
 The preferred flow of operation is:
- * Just before a release, make sure the version number in CMakeLists.txt is set
- to the same release version you are about to tag.
- * This is also the time to change the pretty name in CMakeLists.txt called
- GIT_TAG_RELEASENAME and commit and push these changes.
- * Tag the release following the previously described syntax in order to get it
- correctly built and deployed by CI.
- * Wait for the configure step to create the release and update the patch
- notes.
- * Check on the github actions page for build progress which should be the top
- listed [here](
- https://github.com/Cockatrice/Cockatrice/actions?query=event%3Apush+-branch%3Amaster
- ).
- * When the build has been completed you can verify all uploaded files on the
- release are in order and hit the publish button.
- * After the release is complete, update the CMake version number again to the
- next targeted beta version, typically increasing `PROJECT_VERSION_PATCH` by
- one.
+ * just before a release, update the version number in CMakeLists.txt to "next release version";
+ * tag the release following the previously described syntax in order to get it built by CI;
+ * wait for CI to upload the binaries, double check if everything is in order
+ * after the release is complete, update the version number again to "next targeted beta version", typically increasing `PROJECT_VERSION_PATCH` by one.
 
-When releasing a new stable version, all previous beta releases (and tags)
-should be deleted. This is needed for Cockatrice to update users of the "Beta"
-release channel correctly to the latest stable version as well.
-This can be done the same way as revoking tags, mentioned above.
+**NOTE 3:** When releasing a new stable version, all the previous beta versions should be deleted. This is needed for Cockatrice to update users of the "beta" release channel to the latest version like other users.

.github/FUNDING.yml

@@ -1,12 +0,0 @@
-# These are supported funding model platforms
-
-github: [ZeldaZach]
-patreon: mtgjson
-open_collective: # Replace with a single Open Collective username
-ko_fi: # Replace with a single Ko-fi username
-tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
-community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
-liberapay: # Replace with a single Liberapay username
-issuehunt: # Replace with a single IssueHunt username
-otechie: # Replace with a single Otechie username
-custom: ["paypal.me/zachhalpern"]

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,14 @@
+<b>System Information:</b>
+  <!-- Go to "Help → View Debug Log" and copy all lines above the separation here! -->
+
+  <!-- If you can't install Cockatrice to access that information, make
+       sure to include your OS and the app version from the setup file here -->
+__________________________________________________________________________________________
+
+  <!-- Explain your issue/request/suggestion in detail here! -->
+
+  <!-- This repository is ONLY about development of the Cockatrice app.
+       If you have any problems with a server (e.g. registering, connecting, ban...)
+       you have to contact that server's owner/admin. 
+       Check this list of public servers with webpage links and contact details:
+       https://github.com/Cockatrice/Cockatrice/wiki/Public-Servers -->

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,33 +0,0 @@
----
-name: "🐛 Bug Report"
-about: Report an issue encountered while using Cockatrice
-title: ''
-labels: 'Bug'
-assignees: ''
-
----
-
-<!--                   READ THIS BEFORE POSTING
-Go to "Help → View Debug Log" in Cockatrice and copy all information at the
-top (above the separation line) below "System Information" in this ticket!
-If you can't start Cockatrice to access these details, make
-sure to post your OS and the file name of the setup binary instead. -->
-
-**System Information:**
-
-
-_______________________________________________________________________________________
-
-<!-- Explain your issue in detail here! Please attach screenshots if possible. -->
-
-
-
-
-_______________________________________________________________________________________
-
-<!-- Describe the sequence of actions needed to experience the bug -->
-
-**Steps to reproduce:**
- - Do A
- - Do B
- - Do C ...

.github/ISSUE_TEMPLATE/config.yml

@@ -1,9 +0,0 @@
-blank_issues_enabled: false
-contact_links:
-  - name: 💬 Discord Community (Get help with server issues, e.g. Login)
-    url: https://discord.gg/3Z9yzmA
-    about: Need help with using the client? Want to find some games? Try the Discord server!
-  - name: 🌐 Translations (Help improve the localization of the app)
-    url: https://www.transifex.com/cockatrice/cockatrice/
-    # it is not possible to add a link to the wiki to this description
-    about: For more information and guidance check our Translation FAQ on our wiki!

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,23 +0,0 @@
----
-name: "💡 Feature Request"
-about: Request a new feature
-title: ''
-labels: 'Feature Request'
-assignees: ''
-
----
-
-<!--
-Please search the issue tracker for similar issues before posting!
-If your request is related to another request (but not the same!) list it here
--->
-**Similar Requests**
-
-
-<!-- Describe your feature idea here in detail -->
-**Description of New Feature**
-
-
-<!-- If your feature requires some context, provide it here -->
-**Additional Context**
-

.github/workflows/desktop-build.yml

@@ -1,378 +0,0 @@
-name: Build Desktop
-
-on:
-  push:
-    branches:
-      - master
-    paths-ignore:
-      - '**.md'
-      - 'webclient/**'
-      - '.github/workflows/web-*.yml'
-    tags:
-      - '*'
-  pull_request:
-    paths-ignore:
-      - '**.md'
-      - 'webclient/**'
-      - '.github/workflows/web-*.yml'
-
-jobs:
-  configure:
-    name: Configure
-    runs-on: ubuntu-latest
-    outputs:
-      tag: ${{steps.configure.outputs.tag}}
-      sha: ${{steps.configure.outputs.sha}}
-      upload_url: ${{steps.create_release.outputs.upload_url}}
-
-    steps:
-      - name: Cancel previous runs
-        uses: styfle/cancel-workflow-action@0.11.0
-        with:
-          access_token: ${{github.token}} # needs other token https://github.com/styfle/cancel-workflow-action/issues/7
-
-      - name: Configure
-        id: configure
-        shell: bash
-        run: |
-          tag_regex='^refs/tags/'
-          if [[ $GITHUB_EVENT_NAME == pull-request ]]; then # pull request
-            sha="${{github.event.pull_request.head.sha}}"
-          elif [[ $GITHUB_REF =~ $tag_regex ]]; then # release
-            sha="$GITHUB_SHA"
-            tag="${GITHUB_REF/refs\/tags\//}"
-            echo "tag=$tag" >>"$GITHUB_OUTPUT"
-          else # push to branch
-            sha="$GITHUB_SHA"
-          fi
-          echo "sha=$sha" >>"$GITHUB_OUTPUT"
-
-      - name: Checkout
-        if: steps.configure.outputs.tag != null
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
-
-      - name: Prepare release parameters
-        id: prepare
-        if: steps.configure.outputs.tag != null
-        shell: bash
-        env:
-          TAG: ${{steps.configure.outputs.tag}}
-        run: .ci/prep_release.sh
-
-      - name: Create release
-        if: steps.configure.outputs.tag != null
-        id: create_release
-        uses: actions/create-release@v1
-        env:
-          GITHUB_TOKEN: ${{github.token}}
-        with:
-          tag_name: ${{github.ref}}
-          release_name: ${{steps.prepare.outputs.title}}
-          body_path: ${{steps.prepare.outputs.body_path}}
-          draft: true
-          prerelease: ${{steps.prepare.outputs.is_beta == 'yes'}}
-
-  build-linux:
-    strategy:
-      fail-fast: false
-      matrix:
-        # these names correspond to the files in .ci/$distro
-        include:
-          - distro: ArchLinux
-            package: skip # we are packaged in arch already
-            allow-failure: yes
-
-          - distro: Debian10
-            package: DEB
-            test: skip # running tests on all distros is superfluous
-
-          - distro: Debian11
-            package: DEB
-
-          - distro: Fedora35
-            package: RPM
-            test: skip
-
-          - distro: Fedora36
-            package: RPM
-
-          - distro: UbuntuBionic
-            package: DEB
-
-          - distro: UbuntuFocal
-            package: DEB
-            test: skip # UbuntuFocal has a broken qt for debug builds
-
-          - distro: UbuntuJammy
-            package: DEB
-
-    name: ${{matrix.distro}}
-    needs: configure
-    runs-on: ubuntu-latest
-    continue-on-error: ${{matrix.allow-failure == 'yes'}}
-    env:
-      NAME: ${{matrix.distro}}
-      CACHE: /tmp/${{matrix.distro}}-cache # ${{runner.temp}} does not work?
-      # cache size over the entire repo is 10Gi link:
-      # https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#usage-limits-and-eviction-policy
-      CCACHE_SIZE: 200M
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-
-      - name: Get cache timestamp
-        id: cache_timestamp
-        shell: bash
-        run: echo "timestamp=$(date -u '+%Y%m%d%H%M%S')" >>"$GITHUB_OUTPUT"
-
-      - name: Restore cache
-        uses: actions/cache@v3
-        env:
-          timestamp: ${{steps.cache_timestamp.outputs.timestamp}}
-        with:
-          path: ${{env.CACHE}}
-          key: docker-${{matrix.distro}}-cache-${{env.timestamp}}
-          restore-keys: |
-            docker-${{matrix.distro}}-cache-
-
-      - name: Build ${{matrix.distro}} Docker image
-        shell: bash
-        run: source .ci/docker.sh --build
-
-      - name: Build debug and test
-        if: matrix.test != 'skip'
-        shell: bash
-        env:
-          distro: '${{matrix.distro}}'
-        run: |
-          source .ci/docker.sh
-          RUN --server --debug --test --ccache "$CCACHE_SIZE" --parallel 2
-
-      - name: Build release package
-        id: package
-        if: matrix.package != 'skip'
-        shell: bash
-        env:
-          BUILD_DIR: build
-          SUFFIX: '-${{matrix.distro}}'
-          distro: '${{matrix.distro}}'
-          type: '${{matrix.package}}'
-        run: |
-          source .ci/docker.sh
-          RUN --server --release --package "$type" --dir "$BUILD_DIR" \
-                  --ccache "$CCACHE_SIZE" --parallel 2
-          .ci/name_build.sh
-
-      - name: Upload artifact
-        if: matrix.package != 'skip'
-        uses: actions/upload-artifact@v3
-        with:
-          name: ${{matrix.distro}}-package
-          path: ${{steps.package.outputs.path}}
-          if-no-files-found: error
-
-      - name: Upload to release
-        if: matrix.package != 'skip' && needs.configure.outputs.tag != null
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{github.token}}
-        with:
-          upload_url: ${{needs.configure.outputs.upload_url}}
-          asset_path: ${{steps.package.outputs.path}}
-          asset_name: ${{steps.package.outputs.name}}
-          asset_content_type: application/octet-stream
-
-  build-macos:
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-          - target: Debug # tests only
-            os: macos-latest
-            xcode: 12.5.1
-            qt_version: 6
-            type: Debug
-            do_tests: 1
-
-          - target: 10.14_Mojave
-            os: macos-10.15 # runs on Catalina
-            xcode: 10.3 # allows compatibility with macOS 10.14
-            qt_version: 5
-            type: Release
-            # do_tests: 1 # tests do not work on qt5?
-            make_package: 1
-
-          - target: 10.15_Catalina
-            os: macos-10.15
-            xcode: 12.4
-            qt_version: 6
-            type: Release
-            do_tests: 1
-            make_package: 1
-
-          - target: 11_Big_Sur
-            os: macos-11
-            xcode: 13.2
-            qt_version: 6
-            type: Release
-            do_tests: 1
-            make_package: 1
-
-#          - target: 12_Monterey
-#            os: macos-12
-#            xcode: 13.3
-#            qt_version: 6
-#            type: Release
-#            do_tests: 1
-#            make_package: 1
-
-    name: macOS ${{matrix.target}}
-    needs: configure
-    runs-on: ${{matrix.os}}
-    continue-on-error: ${{matrix.allow-failure == 'yes'}}
-    env:
-      DEVELOPER_DIR:
-        /Applications/Xcode_${{matrix.xcode}}.app/Contents/Developer
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-
-      - name: Install dependencies using homebrew
-        shell: bash
-        # cmake cannot find the mysql connector
-        # neither of these works: mariadb-connector-c mysql-connector-c++
-        env:
-          qt_version: 'qt@${{matrix.qt_version}}'
-        run: |
-          brew update
-          brew install protobuf
-          brew install "$qt_version" --force-bottle
-
-      - name: Build on Xcode ${{matrix.xcode}}
-        shell: bash
-        id: build
-        env:
-          BUILDTYPE: '${{matrix.type}}'
-          MAKE_TEST: '${{matrix.do_tests}}'
-          MAKE_PACKAGE: '${{matrix.make_package}}'
-          PACKAGE_SUFFIX: '-macOS-${{matrix.target}}'
-          # set QTDIR to find qt5, qt6 can be found without this
-          QTDIR: '/usr/local/opt/qt5'
-        # Mac machines actually have 3 cores
-        run: .ci/compile.sh --server --parallel 3
-
-      - name: Upload artifact
-        if: matrix.make_package
-        uses: actions/upload-artifact@v3
-        with:
-          name: macOS-${{matrix.target}}-dmg
-          path: ${{steps.build.outputs.path}}
-          if-no-files-found: error
-
-      - name: Upload to release
-        if: matrix.make_package && needs.configure.outputs.tag != null
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{github.token}}
-        with:
-          upload_url: ${{needs.configure.outputs.upload_url}}
-          asset_path: ${{steps.build.outputs.path}}
-          asset_name: ${{steps.build.outputs.name}}
-          asset_content_type: application/octet-stream
-
-  build-windows:
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-          - target: Win-32bit
-            bit: 32
-            arch: x86
-            cmake_generator_platform: Win32
-            qt_version: 5.15.*
-            qt_arch: msvc2019
-            qt_tools: "tools_openssl_x86"
-
-          - target: Win7+-64bit
-            bit: 64
-            arch: x64
-            cmake_generator_platform: x64
-            qt_version: 5.15.*
-            qt_arch: msvc2019_64
-            qt_tools: "tools_openssl_x64"
-
-          - target: Win10+-64bit
-            bit: 64
-            arch: x64
-            cmake_generator_platform: x64
-            qt_version: 6.3.*
-            qt_arch: msvc2019_64
-            qt_tools: "tools_openssl_x64"
-            qt_modules: "qtmultimedia qtwebsockets"
-
-    name: ${{matrix.target}}
-    needs: configure
-    runs-on: windows-2019
-    env:
-      CMAKE_GENERATOR: 'Visual Studio 16 2019'
-
-    steps:
-      - name: Add msbuild to PATH
-        id: add-msbuild
-        uses: microsoft/setup-msbuild@v1.1
-
-      - name: Checkout
-        uses: actions/checkout@v3
-        with:
-          submodules: recursive
-
-      - name: Install Qt ${{matrix.qt_version}} for ${{matrix.target}}
-        uses: jurplel/install-qt-action@v3
-        with:
-          cache: true
-          setup-python: false
-          version: ${{matrix.qt_version}}
-          arch: win${{matrix.bit}}_${{matrix.qt_arch}}
-          tools: ${{matrix.qt_tools}}
-          modules: ${{matrix.qt_modules}}
-
-      - name: Run vcpkg
-        uses: lukka/run-vcpkg@v10.6
-        with:
-          runVcpkgInstall: true
-          appendedCacheKey: ${{matrix.bit}}-bit
-        env:
-          VCPKG_DEFAULT_TRIPLET: '${{matrix.arch}}-windows'
-          VCPKG_DISABLE_METRICS: 1
-
-      - name: Build Cockatrice
-        id: build
-        shell: bash
-        env:
-          PACKAGE_SUFFIX: '-${{matrix.target}}'
-          CMAKE_GENERATOR: '${{env.CMAKE_GENERATOR}}'
-          CMAKE_GENERATOR_PLATFORM: '${{matrix.cmake_generator_platform}}'
-          QTDIR: '${{github.workspace}}\Qt\${{matrix.qt_version}}\win${{matrix.bit}}_${{matrix.qt_arch}}'
-        run: .ci/compile.sh --server --release --test --package --parallel 2
-
-      - name: Upload artifact
-        uses: actions/upload-artifact@v3
-        with:
-          name: ${{matrix.target}}-installer
-          path: ${{steps.build.outputs.path}}
-          if-no-files-found: error
-
-      - name: Upload to release
-        if: needs.configure.outputs.tag != null
-        uses: actions/upload-release-asset@v1
-        env:
-          GITHUB_TOKEN: ${{github.token}}
-        with:
-          upload_url: ${{needs.configure.outputs.upload_url}}
-          asset_path: ${{steps.build.outputs.path}}
-          asset_name: ${{steps.build.outputs.name}}
-          asset_content_type: application/octet-stream

.github/workflows/desktop-lint.yml

@@ -1,28 +0,0 @@
-name: Code Style (C++) 
-
-on:
-  pull_request:
-    paths-ignore:
-      - '**.md'
-      - 'webclient/**'
-      - '.github/workflows/web-*.yml'
-
-jobs:
-  format:
-    runs-on: ubuntu-22.04
-
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v3
-      with:
-        fetch-depth: 20 # should be enough to find merge base
-
-    - name: Install dependencies
-      shell: bash
-      run: |
-        sudo apt-get update
-        sudo apt-get install -y --no-install-recommends clang-format cmake-format
-
-    - name: Check code formatting
-      shell: bash
-      run: ./.ci/lint_cpp.sh

.github/workflows/translations.yml

@@ -1,66 +0,0 @@
-name: Update translation source
-
-on:
-  workflow_dispatch:
-  schedule:
-    # runs once per month
-    - cron: '0 0 1 * *'
-
-jobs:
-  translations:
-    # Do not run the scheduled workflow on forks
-    if: github.event_name != 'schedule' || github.repository_owner == 'Cockatrice'
-
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Install lupdate
-        shell: bash
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y --no-install-recommends qttools5-dev-tools
-
-      - name: Checkout repo
-        uses: actions/checkout@v3
-
-      - name: Update cockatrice translations
-        shell: bash
-        run: |
-          shopt -s globstar # globstar is needed for recursive **
-          lupdate -version
-          echo "reading the following source files:"
-          # note: there are three strings to translate in common right now
-          echo {cockatrice,common}/**/*.{cpp,h}
-          echo "$(echo {cockatrice,common}/**/*.{cpp,h} | wc -w) files total"
-          lupdate {cockatrice,common}/**/*.{cpp,h} -ts cockatrice/translations/cockatrice_en@source.ts
-
-      - name: Update oracle translations
-        shell: bash
-        run: |
-          shopt -s globstar # globstar is needed for recursive **
-          lupdate -version
-          echo "reading the following source files:"
-          echo oracle/**/*.{cpp,h}
-          echo "$(echo oracle/**/*.{cpp,h} | wc -w) files total"
-          lupdate oracle/**/*.{cpp,h} -ts oracle/translations/oracle_en@source.ts
-
-      - name: Check for updates
-        id: check
-        shell: bash
-        run: |
-          set +e # do not fail, just save the exit state
-          git diff --exit-code
-          echo "deploy=$?" >>"$GITHUB_OUTPUT"
-
-      - name: Commit changes
-        if: steps.check.outputs.deploy == '1'
-        shell: bash
-        working-directory: ${{env.OUTPUT_PATH}}
-        run: |
-          git config user.name github-actions
-          git config user.email github-actions@github.com
-          git add cockatrice/translations/cockatrice_en@source.ts oracle/translations/oracle_en@source.ts
-          git commit -m "Automated translation update ( $GITHUB_SHA )"
-          git push
-          deploy_commit=$(git rev-parse HEAD)
-          echo "Created commit: $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/commit/$deploy_commit"

.github/workflows/web-build.yml

@@ -1,53 +0,0 @@
-name: Build Web
-
-on:
-  push:
-    branches:
-      - master
-    paths:
-      - '.github/workflows/web-*.yml'
-      - 'webclient/**'
-      - '!**.md'
-  pull_request:
-    paths:
-      - '.github/workflows/web-*.yml'
-      - 'webclient/**'
-      - '!**.md'
-
-jobs:
-  build-web:
-    name: React (Node ${{matrix.node_version}})
-
-    runs-on: ubuntu-latest
-
-    defaults:
-      run:
-        working-directory: webclient
-
-    strategy:
-      fail-fast: false
-      matrix:
-        node_version:
-          - 16
-          - lts/*
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v2
-        with:
-          node-version: ${{matrix.node_version}}
-          cache: 'npm'
-          cache-dependency-path: 'webclient/package-lock.json'
-
-      - name: Install dependencies
-        run: npm clean-install
-
-      - name: Build app
-        run: npm run build
-
-      - name: Test app
-        run: npm run test
-        

.github/workflows/web-lint.yml

@@ -1,32 +0,0 @@
-name: Code Style (TypeScript) 
-
-on:
-  pull_request:
-    paths:
-      - '.github/workflows/web-*.yml'
-      - 'webclient/**'
-      - '!**.md'
-
-jobs:
-  ESLint:
-    runs-on: ubuntu-latest
-    
-    defaults:
-      run:
-        working-directory: webclient
-
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v3
-
-    - name: Setup Node.js
-      uses: actions/setup-node@v2
-      with:
-        cache: 'npm'
-        cache-dependency-path: 'webclient/package-lock.json'
-
-    - name: Install ESLint
-      run: npm clean-install --ignore-scripts
-
-    - name: Run ESLint
-      run: npm run lint

.gitignore

@@ -6,8 +6,5 @@ mysql.cnf
 .DS_Store
 .idea/
 *.aps
-cmake-build-debug*
+cmake-build-debug/
 preferences
-compile_commands.json
-.vs/
-.vscode/

.gitlab-ci.yml

@@ -0,0 +1,139 @@
+---
+stages:
+  - build
+
+.artifacts: &artifacts
+  artifacts:
+    paths:
+      - build/
+
+.cache: &cache
+  cache:
+    key: "$CI_BUILD_NAME"
+    paths:
+      - cache/
+
+.branches: &branches
+  only:
+    - master
+
+.tags: &tags
+  tags:
+    - linux
+    - docker
+
+
+#================================ DEBIAN-BASED ================================
+
+.build_rc_package_deb: &build_rc_package_deb
+  stage: build
+  script:
+    - mkdir -p build
+    - cd build
+    - cmake .. -DWITH_SERVER=1 -DCMAKE_BUILD_TYPE=Release -DCPACK_GENERATOR=DEB
+    - make package -j2
+
+.build_debug_package_deb: &build_debug_package_deb
+  stage: build
+  script:
+    - mkdir -p build
+    - cd build
+    - cmake .. -DWITH_SERVER=1 -DCMAKE_BUILD_TYPE=Debug -DCPACK_GENERATOR=DEB
+    - make package -j2
+
+.deb-artifacts: &artifacts_deb
+  artifacts:
+    paths:
+      - build/*.deb
+      - build/CMakeFiles/*.log
+    when: always
+
+#----------------------------------- UBUNTU -----------------------------------
+
+.requirements_16xx: &install_requirements_16xx
+  before_script:
+    - apt-get -o dir::cache::archives="cache" update -qq
+    - apt-get -o dir::cache::archives="cache" install -y build-essential g++ cmake git
+    - apt-get -o dir::cache::archives="cache" install -y libprotobuf-dev protobuf-compiler
+    - apt-get -o dir::cache::archives="cache" install -y qt5-default qttools5-dev qttools5-dev-tools
+    - apt-get -o dir::cache::archives="cache" install -y qtmultimedia5-dev libqt5multimedia5-plugins
+    - apt-get -o dir::cache::archives="cache" install -y libqt5svg5-dev libqt5sql5-mysql
+    - apt-get -o dir::cache::archives="cache" install -y libqt5websockets5-dev
+
+.requirements_17xx: &install_requirements_17xx
+  before_script:
+    - apt-get -o dir::cache::archives="cache" update -qq
+    - apt-get -o dir::cache::archives="cache" install -y build-essential g++ cmake git
+    - apt-get -o dir::cache::archives="cache" install -y libprotobuf-dev protobuf-compiler
+    - apt-get -o dir::cache::archives="cache" install -y qt5-default qttools5-dev qttools5-dev-tools
+    - apt-get -o dir::cache::archives="cache" install -y qtmultimedia5-dev libqt5multimedia5-plugins
+    - apt-get -o dir::cache::archives="cache" install -y libqt5svg5-dev libqt5sql5-mysql
+    - apt-get -o dir::cache::archives="cache" install -y libqt5websockets5-dev
+
+.build_1604: &1604
+  image: ubuntu:16.04
+  <<: *tags
+  <<: *branches
+  <<: *install_requirements_16xx
+  <<: *artifacts_deb
+  <<: *cache
+
+.build_1710: &1710
+  image: ubuntu:17.10
+  <<: *tags
+  <<: *branches
+  <<: *install_requirements_17xx
+  <<: *artifacts_deb
+  <<: *cache
+
+build_rc_1604:
+  <<: *1604
+  <<: *build_rc_package_deb
+  when: always
+
+build_debug_1604:
+  <<: *1604
+  <<: *build_debug_package_deb
+  when: always
+
+build_rc_1710:
+  <<: *1710
+  <<: *build_rc_package_deb
+  when: always
+
+build_debug_1710:
+  <<: *1710
+  <<: *build_debug_package_deb
+  when: always
+  allow_failure: true
+
+#----------------------------------- DEBIAN -----------------------------------
+
+.requirements_stretch: &install_requirements_stretch
+  before_script:
+    - apt-get -o dir::cache::archives="cache" update -qq
+    - apt-get -o dir::cache::archives="cache" install -y build-essential g++ cmake git
+    - apt-get -o dir::cache::archives="cache" install -y qt5-default qtbase5-dev-tools
+    - apt-get -o dir::cache::archives="cache" install -y qttools5-dev-tools qtmultimedia5-dev
+    - apt-get -o dir::cache::archives="cache" install -y libqt5svg5-dev libqt5websockets5-dev
+    - apt-get -o dir::cache::archives="cache" install -y libprotobuf-dev protobuf-compiler
+
+.build_stretch: &stretch
+  image: debian:stretch
+  <<: *tags
+  <<: *branches
+  <<: *install_requirements_stretch
+  <<: *artifacts_deb
+  <<: *cache
+
+build_rc_stretch:
+  <<: *stretch
+  <<: *build_rc_package_deb
+  when: always
+
+build_debug_stretch:
+  <<: *stretch
+  <<: *build_debug_package_deb
+  when: always
+  allow_failure: true
+  

.gitmodules

@@ -1,3 +0,0 @@
-[submodule "vcpkg"]
-	path = vcpkg
-	url = https://github.com/microsoft/vcpkg.git

.husky/pre-commit

@@ -1,7 +0,0 @@
-#!/bin/sh
-. "$(dirname "$0")/_/husky.sh"
-
-cd webclient
-npm run translate
-
-git add src/i18n-default.json

.travis.yml

@@ -0,0 +1,163 @@
+language: cpp
+compiler: gcc
+
+matrix:
+  include:
+  #Ubuntu Xenial (Debug only)
+  - name: Ubuntu Xenial (Debug)
+    if: tag IS NOT present
+    os: linux
+    dist: xenial
+    group: stable
+    cache: ccache
+    addons:
+      apt:
+        packages:
+        - libprotobuf-dev
+        - protobuf-compiler
+        - liblzma-dev
+        - qt5-default
+        - qttools5-dev
+        - qttools5-dev-tools
+        - qtmultimedia5-dev
+        - libqt5multimedia5-plugins
+        - libqt5svg5-dev
+        - libqt5sql5-mysql
+        - libqt5websockets5-dev
+    script: bash ./.ci/travis-compile.sh --format --server --test --debug
+
+  #Ubuntu Bionic (on docker)
+  - name: Ubuntu Bionic (Debug)
+    if: tag IS NOT present
+    services: docker
+    env: NAME=UbuntuBionic
+    cache:
+      directories:
+        - $HOME/$NAME/
+    before_install: docker build -t "cockatrice_${NAME,,}" .ci/$NAME && mkdir -p $HOME/$NAME/.ccache
+    script: docker run --mount "type=bind,source=$(pwd),target=/src" -w="/src"
+          --mount "type=bind,source=$HOME/$NAME/.ccache,target=/.ccache" -e "CCACHE_DIR=/.ccache"
+          "cockatrice_${NAME,,}"
+          bash .ci/travis-compile.sh --server --debug
+
+  - name: Ubuntu Bionic (Release)
+    if: (branch = master AND NOT type = pull_request) OR tag IS present
+    services: docker
+    env: NAME=UbuntuBionic
+    cache:
+      directories:
+        - $HOME/$NAME/
+    before_install: docker build -t "cockatrice_${NAME,,}" .ci/$NAME && mkdir -p $HOME/$NAME/.ccache
+    script: docker run --mount "type=bind,source=$(pwd),target=/src" -w="/src"
+          --mount "type=bind,source=$HOME/$NAME/.ccache,target=/.ccache" -e "CCACHE_DIR=/.ccache"
+          "cockatrice_${NAME,,}"
+          bash .ci/travis-compile.sh --server --package "$NAME" --release
+
+  #Fedora 29 (on docker)
+  - name: Fedora 29 (Debug)
+    if: tag IS NOT present
+    services: docker
+    env: NAME=Fedora29
+    cache:
+      directories:
+        - $HOME/$NAME/
+    before_install: docker build -t "cockatrice_${NAME,,}" .ci/$NAME && mkdir -p $HOME/$NAME/.ccache
+    script: docker run --mount "type=bind,source=$(pwd),target=/src" -w="/src"
+          --mount "type=bind,source=$HOME/$NAME/.ccache,target=/.ccache" -e "CCACHE_DIR=/.ccache"
+          "cockatrice_${NAME,,}"
+          bash .ci/travis-compile.sh --server --debug
+
+  - name: Fedora 29 (Release)
+    if: (branch = master AND NOT type = pull_request) OR tag IS present
+    services: docker
+    env: NAME=Fedora29
+    cache:
+      directories:
+        - $HOME/$NAME/
+    before_install: docker build -t "cockatrice_${NAME,,}" .ci/$NAME && mkdir -p $HOME/$NAME/.ccache
+    script: docker run --mount "type=bind,source=$(pwd),target=/src" -w="/src"
+          --mount "type=bind,source=$HOME/$NAME/.ccache,target=/.ccache" -e "CCACHE_DIR=/.ccache"
+          "cockatrice_${NAME,,}"
+          bash .ci/travis-compile.sh --server --package "$NAME" "RPM" --release
+
+  #macOS
+  - name: macOS (Debug)
+    if: tag IS NOT present
+    os: osx
+    osx_image: xcode10.1
+    cache: ccache
+    addons:
+      homebrew:
+        packages:
+        - ccache
+        - protobuf
+        - qt
+        - xz
+    script: bash ./.ci/travis-compile.sh --server --install --debug
+
+  - name: macOS (Release)
+    if: (branch = master AND NOT type = pull_request) OR tag IS present
+    os: osx
+    osx_image: xcode9.2
+    cache: ccache
+    addons:
+      homebrew:
+        packages:
+        - ccache
+        - protobuf
+        - qt
+        - xz
+        update: true
+    script: bash ./.ci/travis-compile.sh --server --package "$TRAVIS_OS_NAME" --release
+
+# Builds for pull requests skip the deployment step altogether
+deploy:
+# Deploy configuration for "beta" releases
+  - provider: releases
+    api_key:
+      secure: mLMF41q7xgOR1sjczsilEy7HQis2PkZCzhfOGbn/8FoOQnmmPOZjrsdhn06ZSl3SFsbfCLuClDYXAbFscQmdgjcGN5AmHV+JYfW650QEuQa/f4/lQFsVRtEqUA1O3FQ0OuRxdpCfJubZBdFVH8SbZ93GLC5zXJbkWQNq+xCX1fU=
+    skip_cleanup: true
+    name: "Cockatrice $TRAVIS_TAG"
+    body: "Beta release of Cockatrice"
+    file_glob: true
+    file: "build/Cockatrice-*"
+    overwrite: true
+    draft: false
+    prerelease: true
+    on:
+      tags: true
+      repo: Cockatrice/Cockatrice
+      condition: $TRAVIS_TAG =~ ([0-9]|[1-9][0-9])(\.([0-9]|[1-9][0-9])){2}-beta(\.([2-9]|[1-9][0-9]))?$     # regex to match semver naming convention for beta pre-releases
+
+# Deploy configuration for "stable" releases
+  - provider: releases
+    api_key:
+      secure: mLMF41q7xgOR1sjczsilEy7HQis2PkZCzhfOGbn/8FoOQnmmPOZjrsdhn06ZSl3SFsbfCLuClDYXAbFscQmdgjcGN5AmHV+JYfW650QEuQa/f4/lQFsVRtEqUA1O3FQ0OuRxdpCfJubZBdFVH8SbZ93GLC5zXJbkWQNq+xCX1fU=
+    skip_cleanup: true
+    file_glob: true
+    file: "build/Cockatrice-*"
+    overwrite: true
+    draft: false
+    prerelease: false
+    on:
+      tags: true
+      repo: Cockatrice/Cockatrice
+      condition: $TRAVIS_TAG =~ ([0-9]|[1-9][0-9])(\.([0-9]|[1-9][0-9])){2}$    # regex to match semver naming convention for stable full releases
+
+
+notifications:
+  email: false
+  webhooks:
+    urls:
+    - https://webhooks.gitter.im/e/d94969c3b01b22cbdcb7
+    on_success: change
+    on_failure: change
+    on_start: never
+    on_cancel: change
+    on_error: change
+
+
+# Announcements of build image updates: https://docs.travis-ci.com/user/build-environment-updates/
+# For precise versions of preinstalled tools on the VM, check “Build system information” in the build log!
+# Official validator for ".travis.yml" config file: https://yaml.travis-ci.org
+# Travis CI config documentation: https://docs.travis-ci.com/user/customizing-the-build

.tx/config

@@ -1,13 +1,13 @@
 [main]
 host = https://www.transifex.com
 
-[cockatrice.cockatrice-translations-cockatrice-en-source-ts--master]
+[cockatrice.cockatrice]
 file_filter = cockatrice/translations/cockatrice_<lang>.ts
-source_file = cockatrice/translations/cockatrice_en@source.ts
+source_file = cockatrice/translations/cockatrice_en.ts
 source_lang = en
 
-[cockatrice.oracle-translations-oracle-en-source-ts--master]
+[cockatrice.oracle]
 file_filter = oracle/translations/oracle_<lang>.ts
-source_file = oracle/translations/oracle_en@source.ts
+source_file = oracle/translations/oracle_en.ts
 source_lang = en
 

CMakeLists.txt

@@ -5,96 +5,48 @@
 # This file sets all the variables shared between the projects
 # like the installation path, compilation flags etc..
 
-# cmake 3.16 is required if using qt6
-cmake_minimum_required(VERSION 3.10)
+# Cmake 3.1 is required to enable C++11 support correctly
+cmake_minimum_required(VERSION 3.1)
 
-# Early detect ccache
-option(USE_CCACHE "Cache the build results with ccache" ON)
-# Treat warnings as errors (Debug builds only)
-option(WARNING_AS_ERROR "Treat warnings as errors in debug builds" ON)
-# Check for translation updates
-option(UPDATE_TRANSLATIONS "Update translations on compile" OFF)
-# Compile servatrice
-option(WITH_SERVER "build servatrice" OFF)
-# Compile cockatrice
-option(WITH_CLIENT "build cockatrice" ON)
-# Compile oracle
-option(WITH_ORACLE "build oracle" ON)
-# Compile dbconverter
-option(WITH_DBCONVERTER "build dbconverter" ON)
-# Compile tests
-option(TEST "build tests" OFF)
+if(POLICY CMP0064)
+    cmake_policy(SET CMP0064 NEW)
+endif()
+
+if(POLICY CMP0071)
+    cmake_policy(SET CMP0071 NEW)
+endif()
 
 # Default to "Release" build type
 # User-provided value for CMAKE_BUILD_TYPE must be checked before the PROJECT() call
-if(DEFINED CMAKE_BUILD_TYPE)
-  set(CMAKE_BUILD_TYPE
-      ${CMAKE_BUILD_TYPE}
-      CACHE STRING "Type of build"
-  )
-else()
-  set(CMAKE_BUILD_TYPE
-      Release
-      CACHE STRING "Type of build"
-  )
-endif()
+IF(DEFINED CMAKE_BUILD_TYPE)
+   SET(CMAKE_BUILD_TYPE ${CMAKE_BUILD_TYPE} CACHE STRING "Type of build")
+ELSE()
+   SET(CMAKE_BUILD_TYPE Release CACHE STRING "Type of build")
+ENDIF()
 
-if(USE_CCACHE)
-  find_program(CCACHE_PROGRAM ccache)
-  if(CCACHE_PROGRAM)
+# Early detect ccache
+find_program(CCACHE_PROGRAM ccache)
+if(CCACHE_PROGRAM)
     # Support Unix Makefiles and Ninja
     set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE "${CCACHE_PROGRAM}")
-    message(STATUS "Found CCache ${CCACHE_PROGRAM}")
-  endif()
-endif()
-
-if(WIN32)
-  # Use vcpkg toolchain on Windows
-  set(CMAKE_TOOLCHAIN_FILE
-      ${CMAKE_CURRENT_SOURCE_DIR}/vcpkg/scripts/buildsystems/vcpkg.cmake
-      CACHE STRING "Vcpkg toolchain file"
-  )
-  # Qt path set by user or env var
-  if(QTDIR
-     OR DEFINED ENV{QTDIR}
-     OR DEFINED ENV{QTDIR32}
-     OR DEFINED ENV{QTDIR64}
-  )
-
-  else()
-    set(QTDIR
-        ""
-        CACHE PATH "Path to Qt (e.g. C:/Qt/5.7/msvc2015_64)"
-    )
-    message(
-      WARNING "QTDIR variable is missing.  Please set this variable to specify path to Qt (e.g. C:/Qt/5.7/msvc2015_64)"
-    )
-  endif()
+    MESSAGE(STATUS "Found CCache ${CCACHE_PROGRAM}")
 endif()
 
 # A project name is needed for CPack
 # Version can be overriden by git tags, see cmake/getversion.cmake
-project("Cockatrice" VERSION 2.8.1)
+PROJECT("Cockatrice" VERSION 2.6.3)
 
-# Set release name if not provided via env/cmake var
-if(NOT DEFINED GIT_TAG_RELEASENAME)
-  set(GIT_TAG_RELEASENAME "Prismatic Bridge")
-endif()
-
-# Use c++17 for all targets
-set(CMAKE_CXX_STANDARD
-    17
-    CACHE STRING "C++ ISO Standard"
-)
+# Use c++11 for all targets
+set(CMAKE_CXX_STANDARD 11 CACHE STRING "C++ ISO Standard")
 set(CMAKE_CXX_STANDARD_REQUIRED True)
 
 # Set conventional loops
 set(CMAKE_ALLOW_LOOSE_LOOP_CONSTRUCTS true)
 
 # Search path for cmake modules
-set(COCKATRICE_CMAKE_PATH "${PROJECT_SOURCE_DIR}/cmake")
-list(INSERT CMAKE_MODULE_PATH 0 "${COCKATRICE_CMAKE_PATH}")
+SET(CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/cmake)
 
+# Retrieve git version hash
 include(getversion)
 
 # Create a header and a cpp file containing the version hash
@@ -102,140 +54,126 @@ include(createversionfile)
 
 # Define a proper install path
 if(UNIX)
-  if(APPLE)
-    # macOS
-    # Due to the special bundle structure ignore
-    # the prefix eventually set by the user.
-    set(CMAKE_INSTALL_PREFIX ${CMAKE_BINARY_DIR}/release)
+    if(APPLE)
+        # macOS
+        # Due to the special bundle structure ignore
+        # the prefix eventually set by the user.
+        set(CMAKE_INSTALL_PREFIX ${CMAKE_BINARY_DIR}/release)
 
-    # Force ccache usage if available
-    get_property(RULE_LAUNCH_COMPILE GLOBAL PROPERTY RULE_LAUNCH_COMPILE)
-    if(RULE_LAUNCH_COMPILE)
-      message(STATUS "Force enabling CCache usage under macOS")
-      # Set up wrapper scripts
-      configure_file("${COCKATRICE_CMAKE_PATH}/launch-c.in" launch-c)
-      configure_file("${COCKATRICE_CMAKE_PATH}/launch-cxx.in" launch-cxx)
-      execute_process(COMMAND chmod a+rx "${CMAKE_BINARY_DIR}/launch-c" "${CMAKE_BINARY_DIR}/launch-cxx")
+        # Force ccache usage if available
+        get_property(RULE_LAUNCH_COMPILE GLOBAL PROPERTY RULE_LAUNCH_COMPILE)
+        if(RULE_LAUNCH_COMPILE)
+            MESSAGE(STATUS "Force enabling CCache usage under macOS")
+            # Set up wrapper scripts
+            configure_file(${CMAKE_MODULE_PATH}/launch-c.in   launch-c)
+            configure_file(${CMAKE_MODULE_PATH}/launch-cxx.in launch-cxx)
+            execute_process(COMMAND chmod a+rx
+                "${CMAKE_BINARY_DIR}/launch-c"
+                "${CMAKE_BINARY_DIR}/launch-cxx")
 
-      # Set Xcode project attributes to route compilation through our scripts
-      set(CMAKE_XCODE_ATTRIBUTE_CC "${CMAKE_BINARY_DIR}/launch-c")
-      set(CMAKE_XCODE_ATTRIBUTE_CXX "${CMAKE_BINARY_DIR}/launch-cxx")
-      set(CMAKE_XCODE_ATTRIBUTE_LD "${CMAKE_BINARY_DIR}/launch-c")
-      set(CMAKE_XCODE_ATTRIBUTE_LDPLUSPLUS "${CMAKE_BINARY_DIR}/launch-cxx")
+            # Set Xcode project attributes to route compilation through our scripts
+            set(CMAKE_XCODE_ATTRIBUTE_CC         "${CMAKE_BINARY_DIR}/launch-c")
+            set(CMAKE_XCODE_ATTRIBUTE_CXX        "${CMAKE_BINARY_DIR}/launch-cxx")
+            set(CMAKE_XCODE_ATTRIBUTE_LD         "${CMAKE_BINARY_DIR}/launch-c")
+            set(CMAKE_XCODE_ATTRIBUTE_LDPLUSPLUS "${CMAKE_BINARY_DIR}/launch-cxx")
+        endif()
+    else()
+        # Linux / BSD
+        if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)
+            #fix package build
+            if(PREFIX)
+                set(CMAKE_INSTALL_PREFIX ${PREFIX})
+            else()
+                set(CMAKE_INSTALL_PREFIX /usr/local)
+            endif()
+        endif()
     endif()
-  else()
-    # Linux / BSD
-    if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)
-      #fix package build
-      if(PREFIX)
-        set(CMAKE_INSTALL_PREFIX ${PREFIX})
-      else()
-        set(CMAKE_INSTALL_PREFIX /usr/local)
-      endif()
-    endif()
-  endif()
 elseif(WIN32)
-  set(CMAKE_INSTALL_PREFIX ${CMAKE_BINARY_DIR}/rundir/${CMAKE_BUILD_TYPE})
+    set(CMAKE_INSTALL_PREFIX ${CMAKE_BINARY_DIR}/release)
 endif()
 
+# Treat warnings as errors (Debug builds only)
+option(WARNING_AS_ERROR "Treat warnings as errors in debug builds" ON)
+
 # Define proper compilation flags
-if(MSVC)
-  # Visual Studio: Maximum optimization, disable warning C4251, establish C++17 compatibility
-  set(CMAKE_CXX_FLAGS_RELEASE "/Ox /MD /wd4251 /Zc:__cplusplus /std:c++17 /permissive-")
-  # Generate complete debugging information
-  #set(CMAKE_CXX_FLAGS_DEBUG "/Zi")
-elseif(CMAKE_COMPILER_IS_GNUCXX)
-  # linux/gcc, bsd/gcc, windows/mingw
-  include(CheckCXXCompilerFlag)
+IF(MSVC)
+    # Visual Studio:
+    # Maximum optimization
+    # Disable warning C4251
+    set(CMAKE_CXX_FLAGS_RELEASE "/Ox /MD /wd4251")
+    # Generate complete debugging information
+    #set(CMAKE_CXX_FLAGS_DEBUG "/Zi")
+ELSEIF (CMAKE_COMPILER_IS_GNUCXX)
+    # linux/gcc, bsd/gcc, windows/mingw
+    include(CheckCXXCompilerFlag)
 
-  set(CMAKE_CXX_FLAGS_RELEASE "-s -O2")
-  if(WARNING_AS_ERROR)
-    set(CMAKE_CXX_FLAGS_DEBUG "-ggdb -O0 -Wall -Wextra -Werror")
-  else()
-    set(CMAKE_CXX_FLAGS_DEBUG "-ggdb -O0 -Wall -Wextra")
-  endif()
-
-  if(APPLE)
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=gnu++17")
-  endif()
-
-  set(ADDITIONAL_DEBUG_FLAGS
-      -Wcast-align
-      -Wmissing-declarations
-      -Wno-long-long
-      -Wno-error=extra
-      -Wno-error=delete-non-virtual-dtor
-      -Wno-error=sign-compare
-      -Wno-error=missing-declarations
-  )
-
-  foreach(FLAG ${ADDITIONAL_DEBUG_FLAGS})
-    check_cxx_compiler_flag("${FLAG}" CXX_HAS_WARNING_${FLAG})
-    if(CXX_HAS_WARNING_${FLAG})
-      set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} ${FLAG}")
+    set(CMAKE_CXX_FLAGS_RELEASE "-s -O2")
+    if(WARNING_AS_ERROR)
+        set(CMAKE_CXX_FLAGS_DEBUG "-ggdb -O0 -Wall -Wextra -Werror")
+    else()
+        set(CMAKE_CXX_FLAGS_DEBUG "-ggdb -O0 -Wall -Wextra")
     endif()
-  endforeach()
-else()
-  # other: osx/llvm, bsd/llvm
-  set(CMAKE_CXX_FLAGS_RELEASE "-O2")
-  if(WARNING_AS_ERROR)
-    set(CMAKE_CXX_FLAGS_DEBUG "-g -O0 -Wall -Wextra -Werror")
-  else()
-    set(CMAKE_CXX_FLAGS_DEBUG "-g -O0 -Wall -Wextra")
-  endif()
-endif()
+
+    set(ADDITIONAL_DEBUG_FLAGS -Wcast-align -Wmissing-declarations -Wno-long-long -Wno-error=extra -Wno-error=delete-non-virtual-dtor -Wno-error=sign-compare -Wno-error=missing-declarations)
+
+    FOREACH(FLAG ${ADDITIONAL_DEBUG_FLAGS})
+        CHECK_CXX_COMPILER_FLAG("${FLAG}" CXX_HAS_WARNING_${FLAG})
+        IF(CXX_HAS_WARNING_${FLAG})
+            SET(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} ${FLAG}")
+        ENDIF()
+    ENDFOREACH()
+ELSE()
+    # other: osx/llvm, bsd/llvm
+    set(CMAKE_CXX_FLAGS_RELEASE "-O2")
+    set(CMAKE_CXX_FLAGS_DEBUG "-g -O0")
+ENDIF()
 
 # GNU systems need to define the Mersenne exponent for the RNG to compile w/o warning
-if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
-  add_definitions("-DSFMT_MEXP=19937")
-endif()
+IF(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
+    ADD_DEFINITIONS("-DSFMT_MEXP=19937")
+ENDIF()
 
-find_package(Threads REQUIRED)
+# Find Qt5
+OPTION(UPDATE_TRANSLATIONS "Update translations on compile" OFF)
+MESSAGE(STATUS "UPDATE TRANSLATIONS: ${UPDATE_TRANSLATIONS}")
 
-# Determine 32 or 64 bit build
-if(CMAKE_SIZEOF_VOID_P EQUAL 8)
-  set(_lib_suffix 64)
-else()
-  set(_lib_suffix 32)
-endif()
+FIND_PACKAGE(Qt5Core 5.5.0 REQUIRED)
 
-if(DEFINED QTDIR${_lib_suffix})
-  list(APPEND CMAKE_PREFIX_PATH "${QTDIR${_lib_suffix}}")
-elseif(DEFINED QTDIR)
-  list(APPEND CMAKE_PREFIX_PATH "${QTDIR}")
-elseif(DEFINED ENV{QTDIR${_lib_suffix}})
-  list(APPEND CMAKE_PREFIX_PATH "$ENV{QTDIR${_lib_suffix}}")
-elseif(DEFINED ENV{QTDIR})
-  list(APPEND CMAKE_PREFIX_PATH "$ENV{QTDIR}")
-endif()
+IF(Qt5Core_FOUND)
+    MESSAGE(STATUS "Found Qt ${Qt5Core_VERSION_STRING}")
 
-message(STATUS "Update Translations: ${UPDATE_TRANSLATIONS}")
+    # FIX: Qt was built with -reduce-relocations
+    if (Qt5_POSITION_INDEPENDENT_CODE)
+        SET(CMAKE_POSITION_INDEPENDENT_CODE ON)
+    endif()
 
-include(FindQtRuntime)
+    # guess plugins and libraries directory
+    set(QT_PLUGINS_DIR "${Qt5Core_DIR}/../../../plugins")
+    get_target_property(QT_LIBRARY_DIR Qt5::Core LOCATION)
+    get_filename_component(QT_LIBRARY_DIR ${QT_LIBRARY_DIR} PATH)
+
+ELSE()
+    MESSAGE(FATAL_ERROR "No Qt5 found!")
+ENDIF()
 
 set(CMAKE_AUTOMOC TRUE)
 
 # Find other needed libraries
-find_package(Protobuf REQUIRED)
-if(NOT EXISTS "${Protobuf_PROTOC_EXECUTABLE}")
-  message(FATAL_ERROR "No protoc command found!")
-else()
-  message(STATUS "Found Protobuf ${Protobuf_VERSION} at: ${Protobuf_LIBRARIES}")
-endif()
+FIND_PACKAGE(Protobuf REQUIRED)
 
 #Find OpenSSL
-if(WIN32)
-  find_package(Win32SslRuntime)
-endif()
+IF(WIN32)
+    FIND_PACKAGE(Win32SslRuntime)
+ENDIF()
 
 #Find VCredist
-if(MSVC)
-  find_package(VCredistRuntime)
-endif()
+IF(MSVC)
+    FIND_PACKAGE(VCredistRuntime)
+ENDIF()
 
 # Package builder
-set(CPACK_PACKAGE_CONTACT "Zach Halpern <zach@cockatrice.us>")
-set(CPACK_PACKAGE_DESCRIPTION_SUMMARY "${PROJECT_NAME}")
+set(CPACK_PACKAGE_CONTACT "Zach Halpern <zahalpern+github@gmail.com>")
+set(CPACK_PACKAGE_DESCRIPTION_SUMMARY ${PROJECT_NAME})
 set(CPACK_PACKAGE_VENDOR "Cockatrice Development Team")
 set(CPACK_PACKAGE_DESCRIPTION_FILE "${PROJECT_SOURCE_DIR}/README.md")
 set(CPACK_RESOURCE_FILE_LICENSE "${PROJECT_SOURCE_DIR}/LICENSE")
@@ -245,93 +183,75 @@ set(CPACK_PACKAGE_VERSION_PATCH "${PROJECT_VERSION_PATCH}")
 set(CPACK_PACKAGE_FILE_NAME "${PROJECT_VERSION_FILENAME}")
 
 if(UNIX)
-  if(APPLE)
-    set(CPACK_GENERATOR DragNDrop ${CPACK_GENERATOR})
-    set(CPACK_GENERATOR "DragNDrop")
-    set(CPACK_DMG_FORMAT "UDBZ")
-    set(CPACK_DMG_VOLUME_NAME "${PROJECT_NAME}")
-    set(CPACK_SYSTEM_NAME "OSX")
-    set(CPACK_PACKAGE_ICON "${CMAKE_CURRENT_SOURCE_DIR}/cockatrice/resources/appicon.icns")
-  else()
-    # linux
-    if(CPACK_GENERATOR STREQUAL "RPM")
-      set(CPACK_RPM_PACKAGE_LICENSE "GPLv2")
-      set(CPACK_RPM_MAIN_COMPONENT "cockatrice")
-      if(Qt6_FOUND)
-        set(CPACK_RPM_PACKAGE_REQUIRES "protobuf, qt6-qttools, qt6-qtsvg, qt6-qtmultimedia")
-      elseif(Qt5_FOUND)
-        set(CPACK_RPM_PACKAGE_REQUIRES "protobuf, qt5-qttools, qt5-qtsvg, qt5-qtmultimedia")
-      endif()
-      set(CPACK_RPM_PACKAGE_GROUP "Amusements/Games")
-      set(CPACK_RPM_PACKAGE_URL "http://github.com/Cockatrice/Cockatrice")
-      # stop directories from making package conflicts
-      set(CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION
-          /usr/share/applications
-          /usr/share/icons
-          /usr/share/icons/hicolor
-          /usr/share/icons/hicolor/48x48
-          /usr/share/icons/hicolor/48x48/apps
-          /usr/share/icons/hicolor/scalable
-          /usr/share/icons/hicolor/scalable/apps
-      )
+    if(APPLE)
+        set(CPACK_GENERATOR DragNDrop ${CPACK_GENERATOR})
+        set(CPACK_GENERATOR "DragNDrop")
+        set(CPACK_DMG_FORMAT "UDBZ")
+        set(CPACK_DMG_VOLUME_NAME "${PROJECT_NAME}")
+        set(CPACK_SYSTEM_NAME "OSX")
+        set(CPACK_PACKAGE_ICON "${CMAKE_CURRENT_SOURCE_DIR}/cockatrice/resources/appicon.icns")
     else()
-      set(CPACK_GENERATOR DEB)
-      set(CPACK_DEBIAN_PACKAGE_SHLIBDEPS ON)
-      set(CPACK_DEBIAN_PACKAGE_SECTION "games")
-      set(CPACK_DEBIAN_PACKAGE_HOMEPAGE "http://github.com/Cockatrice/Cockatrice")
-      if(Qt6_FOUND)
-        set(CPACK_DEBIAN_PACKAGE_DEPENDS "libqt6multimedia6, libqt6svg6, qt6-qpa-plugins")
-      elseif(Qt5_FOUND)
-        set(CPACK_DEBIAN_PACKAGE_DEPENDS "libqt5multimedia5-plugins, libqt5svg5")
-      endif()
+        # linux
+        IF(CPACK_GENERATOR STREQUAL "RPM")
+            set(CPACK_RPM_PACKAGE_LICENSE "GPLv2")
+            set(CPACK_RPM_PACKAGE_REQUIRES "protobuf, qt5-qttools, qt5-qtsvg, qt5-qtmultimedia")
+            set(CPACK_RPM_PACKAGE_GROUP "Amusements/Games")
+            set(CPACK_RPM_PACKAGE_URL "http://github.com/Cockatrice/Cockatrice")
+        ELSE()
+            set(CPACK_GENERATOR DEB)
+            set(CPACK_DEBIAN_PACKAGE_SHLIBDEPS ON)
+            set(CPACK_DEBIAN_PACKAGE_SECTION "games")
+            set(CPACK_DEBIAN_PACKAGE_HOMEPAGE "http://github.com/Cockatrice/Cockatrice")
+            set(CPACK_DEBIAN_PACKAGE_DEPENDS "libqt5multimedia5-plugins, libqt5svg5")
+        ENDIF()
     endif()
-  endif()
 elseif(WIN32)
-  set(CPACK_GENERATOR NSIS ${CPACK_GENERATOR})
-  if("${CMAKE_GENERATOR_PLATFORM}" MATCHES "(x64)")
-    set(TRICE_IS_64_BIT 1)
-  else()
-    set(TRICE_IS_64_BIT 0)
-  endif()
+    set(CPACK_GENERATOR NSIS ${CPACK_GENERATOR})
+    if("${CMAKE_GENERATOR}" MATCHES "(Win64|IA64)")
+        set(TRICE_IS_64_BIT 1)
+    else()
+        set(TRICE_IS_64_BIT 0)
+    endif()
 
-  # Configure file with custom definitions for NSIS.
-  configure_file("${COCKATRICE_CMAKE_PATH}/NSIS.definitions.nsh.in" "${PROJECT_BINARY_DIR}/NSIS.definitions.nsh")
+    # Configure file with custom definitions for NSIS.
+    configure_file(
+        ${CMAKE_MODULE_PATH}/NSIS.definitions.nsh.in
+        ${PROJECT_BINARY_DIR}/NSIS.definitions.nsh
+    )
 
-  # include vcredist into the package; NSIS will take care of running it
-  if(VCREDISTRUNTIME_FOUND)
-    install(FILES "${VCREDISTRUNTIME_FILE}" DESTINATION ./)
-  endif()
+    # include vcredist into the package; NSIS will take care of running it
+    if(VCREDISTRUNTIME_FOUND)
+        INSTALL(FILES "${VCREDISTRUNTIME_FILE}" DESTINATION ./)
+    endif()
 endif()
 
 include(CPack)
 
+# Compile servatrice (default off)
+option(WITH_SERVER "build servatrice" OFF)
 add_subdirectory(common)
 if(WITH_SERVER)
-  add_subdirectory(servatrice)
-  set(CPACK_INSTALL_CMAKE_PROJECTS "Servatrice;Servatrice;ALL;/" ${CPACK_INSTALL_CMAKE_PROJECTS})
+    add_subdirectory(servatrice)
+    SET(CPACK_INSTALL_CMAKE_PROJECTS "Servatrice;Servatrice;ALL;/" ${CPACK_INSTALL_CMAKE_PROJECTS})
 endif()
 
+# Compile cockatrice (default on)
+option(WITH_CLIENT "build cockatrice" ON)
 if(WITH_CLIENT)
-  add_subdirectory(cockatrice)
-  set(CPACK_INSTALL_CMAKE_PROJECTS "Cockatrice;Cockatrice;ALL;/" ${CPACK_INSTALL_CMAKE_PROJECTS})
+    add_subdirectory(cockatrice)
+    SET(CPACK_INSTALL_CMAKE_PROJECTS "Cockatrice;Cockatrice;ALL;/" ${CPACK_INSTALL_CMAKE_PROJECTS})
 endif()
 
+# Compile oracle (default on)
+option(WITH_ORACLE "build oracle" ON)
 if(WITH_ORACLE)
-  add_subdirectory(oracle)
-  set(CPACK_INSTALL_CMAKE_PROJECTS "Oracle;Oracle;ALL;/" ${CPACK_INSTALL_CMAKE_PROJECTS})
-endif()
-
-if(WITH_DBCONVERTER)
-  add_subdirectory(dbconverter)
-  set(CPACK_INSTALL_CMAKE_PROJECTS "Dbconverter;Dbconverter;ALL;/" ${CPACK_INSTALL_CMAKE_PROJECTS})
+    add_subdirectory(oracle)
+    SET(CPACK_INSTALL_CMAKE_PROJECTS "Oracle;Oracle;ALL;/" ${CPACK_INSTALL_CMAKE_PROJECTS})
 endif()
 
+# Compile tests (default off)
+option(TEST "build tests" OFF)
 if(TEST)
-  include(CTest)
-  add_subdirectory(tests)
-endif()
-
-if(Qt6_FOUND AND Qt6_VERSION_MINOR GREATER_EQUAL 3)
-  # Qt6.3+ requires project finalization to support translations
-  qt6_finalize_project()
+    include(CTest)
+    add_subdirectory(tests)
 endif()

Dockerfile

@@ -7,7 +7,6 @@ RUN apt-get update && apt-get install -y\
   git\
   libprotobuf-dev\
   libqt5sql5-mysql\
-  libmysqlclient-dev\
   libqt5websockets5-dev\
   protobuf-compiler\
   qt5-default\
@@ -19,7 +18,7 @@ COPY . /home/servatrice/code/
 WORKDIR /home/servatrice/code
 
 WORKDIR build
-RUN cmake .. -DWITH_SERVER=1 -DWITH_CLIENT=0 -DWITH_ORACLE=0 -DWITH_DBCONVERTER=0 &&\
+RUN cmake .. -DWITH_SERVER=1 -DWITH_CLIENT=0 -DWITH_ORACLE=0 &&\
   make &&\
   make install
 
@@ -27,5 +26,4 @@ WORKDIR /home/servatrice
 
 EXPOSE 4747
 
-ENTRYPOINT [ "servatrice", "--log-to-console" ]
-
+CMD [ "servatrice", "--log-to-console" ]

README.md

@@ -5,7 +5,7 @@
 <p align='center'>
    <a href="#cockatrice"><b>Cockatrice</b></a> <b>|</b>
    <a href="#download-">Download</a> <b>|</b>
-   <a href="#get-involved--">Get Involved</a> <b>|</b>
+   <a href="#get-involved-">Get Involved</a> <b>|</b>
    <a href="#community-resources">Community</a> <b>|</b>
    <a href="#translations-">Translations</a> <b>|</b>
    <a href="#build--">Build</a> <b>|</b>
@@ -18,7 +18,7 @@
 <br><pre>
 <b>To get started, &#8674; [view our webpage](https://cockatrice.github.io/)</b><br>
 <b>To get support or suggest changes &#8674; [file an issue](https://github.com/Cockatrice/Cockatrice/issues) ([How?](https://github.com/Cockatrice/Cockatrice/wiki/How-to-Create-a-GitHub-Ticket-Regarding-Cockatrice))</b>
-<b>To help with development, see how to [get involved](#get-involved--)</b>
+<b>To help with development, see how to [get involved](#get-involved-)</b>
 </pre><br>
 
 
@@ -29,21 +29,21 @@ Cockatrice is an open-source, multiplatform program for playing tabletop card ga
 
 # Download [![Cockatrice Eternal Download Count](https://img.shields.io/github/downloads/cockatrice/cockatrice/total.svg)](https://tooomm.github.io/github-release-stats/?username=Cockatrice&repository=Cockatrice)
 
-Downloads are available for full releases and the current beta version in development. There is no strict release schedule for either of them.
+Downloads are available for full releases and the current beta version in development.<br>
+Full releases are checkpoints featuring major feature or UI enhancements - we recommend to use those. There is no strict schedule for new full releases.
 
-- Latest `stable` release: [![Download from GitHub Releases](https://img.shields.io/github/release/cockatrice/cockatrice.svg)](https://github.com/cockatrice/cockatrice/releases/latest) [![DL Count on Latest Release](https://img.shields.io/github/downloads/cockatrice/cockatrice/latest/total.svg?label=downloads)](https://tooomm.github.io/github-release-stats/?username=Cockatrice&repository=Cockatrice)<br>
-  - Stable versions are checkpoints featuring major feature and UI enhancements.
-  - **Recommended for most users!**
+The beta release contains the most recently added features and bugfixes, but can be unstable. They are released as we feel need.
 
-- Latest `beta` release: [![Download from GitHub Pre-Releases](https://img.shields.io/github/release/cockatrice/cockatrice/all.svg)](https://github.com/cockatrice/cockatrice/releases) [![DL Count on Latest Pre-Release](https://img.shields.io/github/downloads-pre/cockatrice/cockatrice/latest/total.svg?label=downloads)](https://tooomm.github.io/github-release-stats/?username=Cockatrice&repository=Cockatrice)
-   - Beta versions include the most recently added features and bugfixes, but can be unstable.
+- Latest `stable` release (**recommended**): [![Download from GitHub Releases](https://img.shields.io/github/release/cockatrice/cockatrice.svg)](https://github.com/cockatrice/cockatrice/releases/latest) [![DL Count on Latest Release](https://img.shields.io/github/downloads/cockatrice/cockatrice/latest/total.svg)](https://tooomm.github.io/github-release-stats/?username=Cockatrice&repository=Cockatrice)<br>
+
+- Latest `beta` release: [![Download from GitHub Pre-Releases](https://img.shields.io/github/release/cockatrice/cockatrice/all.svg)](https://github.com/cockatrice/cockatrice/releases) [![DL Count on Latest Pre-Release](https://img.shields.io/github/downloads-pre/cockatrice/cockatrice/latest/total.svg)](https://tooomm.github.io/github-release-stats/?username=Cockatrice&repository=Cockatrice)
+   - Beta versions may be unstable and contain bugs.
    - To be a Cockatrice Beta Tester, use this version. Find more information [here](https://github.com/Cockatrice/Cockatrice/wiki/Release-Channels)!
 
 
-# Get Involved [![Discord](https://img.shields.io/discord/314987288398659595?label=Discord&logo=discord&logoColor=white)](https://discord.gg/3Z9yzmA) [![Gitter Chat](https://img.shields.io/gitter/room/Cockatrice/Cockatrice)](https://gitter.im/Cockatrice/Cockatrice)
+# Get Involved [![Gitter Chat](https://img.shields.io/gitter/room/Cockatrice/Cockatrice.svg)](https://gitter.im/Cockatrice/Cockatrice)
 
-Join our [Discord community](https://discord.gg/3Z9yzmA) to connect with the project or fellow users of the app. The Cockatrice developers are also available on [Gitter](https://gitter.im/Cockatrice/Cockatrice). Come here to talk about the application, features, or just to hang out.<br>
-For support regarding specific servers, please contact that server's admin or forum for support rather than asking here.<br>
+[Chat](https://gitter.im/Cockatrice/Cockatrice) with the Cockatrice developers on Gitter. Come here to talk about the application, features, or just to hang out. For support regarding specific servers, please contact that server's admin or forum for support rather than asking here.<br>
 
 To contribute code to the project, please review [the guidelines](https://github.com/Cockatrice/Cockatrice/blob/master/.github/CONTRIBUTING.md).
 We maintain two tags for contributors to find issues to work on:
@@ -52,6 +52,8 @@ We maintain two tags for contributors to find issues to work on:
 
 For both tags, we're willing to provide help to contributors in showing them where and how they can make changes, as well as code review for changes they submit.
 
+Read the long-term project **roadmap** to see planned edits and milestones [here](https://docs.google.com/document/d/1Ewe5uSaRE2nR2pNPMaGmP6gVZdqgFbBgwSscGqIr4W0/edit).
+
 We try to be responsive to new issues. We'll provide advice on how best to implement a feature; alternately, we can show you where the codebase is doing something similar before you get too far along.
 
 Cockatrice uses the [Google Developer Documentation Style Guide](https://developers.google.com/style/) to ensure consistent documentation. We encourage you to improve the documentation by suggesting edits based on this guide.
@@ -65,7 +67,7 @@ Cockatrice uses the [Google Developer Documentation Style Guide](https://develop
 - [reddit r/Cockatrice](https://reddit.com/r/cockatrice)
 
 
-# Translations [![Transifex Project](https://img.shields.io/badge/translate-on%20transifex-brightgreen)](https://www.transifex.com/projects/p/cockatrice/)
+# Translations [![Cockatrice on Transiflex](https://tx-assets.scdn5.secure.raxcdn.com/static/charts/images/tx-logo-micro.c5603f91c780.png)](https://www.transifex.com/projects/p/cockatrice/)
 
 Cockatrice uses Transifex for translations. You can help us bring Cockatrice and Oracle to your language or just edit single wordings right from within your browser by visiting our [Transifex project page](https://www.transifex.com/projects/p/cockatrice/).<br>
 
@@ -76,18 +78,18 @@ Cockatrice uses Transifex for translations. You can help us bring Cockatrice and
 Check out our [Translator FAQ](https://github.com/Cockatrice/Cockatrice/wiki/Translation-FAQ) for more information about contributing!<br>
 
 
-# Build [![CI Desktop](https://github.com/Cockatrice/Cockatrice/actions/workflows/desktop-build.yml/badge.svg?branch=master&event=push)](https://github.com/Cockatrice/Cockatrice/actions/workflows/desktop-build.yml?query=branch%3Amaster+event%3Apush) [![CI Web](https://github.com/Cockatrice/Cockatrice/actions/workflows/web-build.yml/badge.svg?branch=master&event=push)](https://github.com/Cockatrice/Cockatrice/actions/workflows/web-build.yml?query=branch%3Amaster+event%3Apush)
+# Build [![Travis Build Status - master](https://travis-ci.org/Cockatrice/Cockatrice.svg?branch=master)](https://travis-ci.org/Cockatrice/Cockatrice) [![Appveyor Build Status - master](https://ci.appveyor.com/api/projects/status/lp5h0dhk4mhmeps7/branch/master?svg=true)](https://ci.appveyor.com/project/Daenyth/cockatrice/branch/master)
 
-**Detailed compiling instructions can be found on the Cockatrice wiki under [Compiling Cockatrice](https://github.com/Cockatrice/Cockatrice/wiki/Compiling-Cockatrice)**
+**Detailed compiling instructions are on the Cockatrice wiki under [Compiling Cockatrice](https://github.com/Cockatrice/Cockatrice/wiki/Compiling-Cockatrice)**
 
 Dependencies: *(for minimum requirements search our [CMake file](https://github.com/Cockatrice/Cockatrice/blob/master/CMakeLists.txt))*
 - [Qt](https://www.qt.io/developers/)
-- [protobuf](https://github.com/protocolbuffers/protobuf)
+- [protobuf](https://github.com/google/protobuf)
 - [CMake](https://www.cmake.org/)
 
 Oracle can optionally use zlib and xz to load compressed files:
-- [xz](https://tukaani.org/xz/)
 - [zlib](https://www.zlib.net/)
+- [xz](https://tukaani.org/xz/)
 
 To compile:
 
@@ -115,7 +117,6 @@ The following flags can be passed to `cmake`:
 - `-DWARNING_AS_ERROR=0` Whether to treat compilation warnings as errors in debug mode (default 1 = yes).
 - `-DUPDATE_TRANSLATIONS=1` Configure `make` to update the translation .ts files for new strings in the source code. Note: Running `make clean` will remove the .ts files (default 0 = no).
 - `-DTEST=1` Enable regression tests (default 0 = no). Note: needs googletest, will be downloaded on the fly if unavailable. To run tests: ```make test```.
-- `-DFORCE_USE_QT5=1` Skip looking for Qt6 before trying to find Qt5
 
 
 # Run
@@ -124,6 +125,7 @@ The following flags can be passed to `cmake`:
 `Oracle` fetches card data<br>
 `Servatrice` is the server<br>
 
+
 **Servatrice Docker container**
 
 You can run an instance of Servatrice (the Cockatrice server) using [Docker](https://www.docker.com/what-docker) and the Cockatrice Dockerfile.<br>
@@ -139,26 +141,6 @@ to permit connections to the server.
 
 Find more information on how to use Servatrice with Docker in our [wiki](https://github.com/Cockatrice/Cockatrice/wiki/Setting-up-Servatrice#using-docker).
 
-**Docker compose**
-
-There is also a docker-compose file available which will configure and run both a MySQL server and Servatrice. The docker-compose setup scripts can be found in the `servatrice/docker` folder and vary only slightly from the default sql and server .ini files. The setup scripts can either be modified in place, or docker-compose can mount alternative files into the images, as you prefer.
-
-To run Servatrice via docker-compose, first install docker-compose following the [install instructions](https://docs.docker.com/compose/install/). Once installed, run the following from the root of the repository:
-```bash
-docker-compose build    # Build the Servatrice image using the same Dockerfile as above.
-docker-compose up       # Setup and run both the MySQL server and Servatrice.
-```
-
->Note: Similar to the above Docker setup, this will expose TCP ports 4747 and 4748.
-
->Note: The first time running the docker-compose setup, the MySQL server will take a little time to run the initial setup scripts. Due to this, the Servatrice instance may fail the first few attempts to connect to the database. Servatrice is set to `restart: always` in the docker-compose.yml, which will allow it to continue attempting to start up. Once the MySQL scripts have completed, Servatrice should then connect automatically on the next attempt.
-
-**Docker compose in Windows**
-A out of box working docker-compose file has been added to help setup in Windows.
-
-Docker in Windows requires additional steps in form of using Docker Desktop to allow resource sharing from the drive the volumes are mapped from, as well as potential workarounds needed to get file sharing working in Windows. This [StackOverflow discussion sheds some light on it](https://stackoverflow.com/questions/42203488/settings-to-windows-firewall-to-allow-docker-for-windows-to-share-drive)
-
-
 # License [![GPLv2 License](https://img.shields.io/github/license/Cockatrice/Cockatrice.svg)](https://github.com/Cockatrice/Cockatrice/blob/master/LICENSE)
 
 Cockatrice is free software, licensed under the [GPLv2](https://github.com/Cockatrice/Cockatrice/blob/master/LICENSE).

clangify.sh

@@ -1,56 +1,42 @@
 #!/bin/bash
 
 # This script will run clang-format on all modified, non-3rd-party C++/Header files.
-# Optionally runs cmake-format on all modified cmake files.
-# Uses clang-format cmake-format git diff find
-# Never, ever, should this receive a path with a newline in it. Don't bother proofing it for that.
+# Never, ever, should this recieve a path with a newline in it. Don't bother proofing it for that.
 
-set -o pipefail
 
 # go to the project root directory, this file should be located in the project root directory
-olddir="$PWD"
 cd "${BASH_SOURCE%/*}/" || exit 2 # could not find path, this could happen with special links etc.
 
 # defaults
 include=("common" \
 "cockatrice/src" \
-"dbconverter/src" \
 "oracle/src" \
-"servatrice/src" \
-"tests")
+"servatrice/src")
 exclude=("servatrice/src/smtp" \
 "common/sfmt" \
 "common/lib" \
 "oracle/src/zip" \
 "oracle/src/lzma" \
 "oracle/src/qt-json")
-exts=("cpp" "h" "proto")
+exts=("cpp" "h")
 cf_cmd="clang-format"
 branch="origin/master"
-cmakefile="CMakeLists.txt"
-cmakedir="cmake/.*\\.cmake"
-cmakeinclude=("cmake/gtest-CMakeLists.txt.in")
-color="--"
 
 # parse options
-while [[ $* ]]; do
+while [[ $@ ]]; do
   case "$1" in
     '-b'|'--branch')
       branch=$2
       set_branch=1
       shift 2
       ;;
-    '--cmake')
-      do_cmake=1
-      shift
-      ;;
     '-c'|'--color-diff')
-      color="--color=always"
-      mode="diff"
+      color=" --color=always"
+      mode=diff
       shift
       ;;
     '-d'|'--diff')
-      mode="diff"
+      mode=diff
       shift
       ;;
     '-h'|'--help')
@@ -62,6 +48,7 @@ If <dir>s are given, all source files in those directories of the project root
 path are formatted. To only format changed files in these directories use the
 --branch option in combination. <dir> has to be a path relative to the project
 root path or a full path inside $PWD.
+. can not be specified as a dir, if you really want to format everything use */.
 
 USAGE: $0 [option] [--branch <git branch or object>] [<dir> ...]
 
@@ -80,9 +67,6 @@ OPTIONS:
         When not comparing to a branch, git will not be used at all and every
         source file in the entire project will be parsed.
 
-    --cmake
-        Use cmake-format to format cmake files as well.
-
     -c, --color-diff
         Display a colored diff. Implies --diff.
         Only available on systems which support 'diff --color'.
@@ -109,25 +93,22 @@ EXIT CODES:
     3 if clang-format could not be found.
 
 EXAMPLES:
-    $0 --branch $USER/patch-2 ${include[0]}
-        Formats all changed files compared to the git branch "$USER/patch-2"
-        in the directory ${include[0]}.
-
-    $0 --test . || echo "code requires formatting"
+    $0 --test \$PWD || echo "code requires formatting"
         Tests if the source files in the current directory are correctly
         formatted and prints an error message if formatting is required.
 
-    $0 --cmake --branch "" ""
-        Unconditionally format all cmake files and no source files.
+    $0 --branch $USER/patch-2 ${include[0]}
+        Formats all changed files compared to the git branch "$USER/patch-2"
+        in the directory ${include[0]}.
 EOM
       exit 0
       ;;
     '-n'|'--names')
-      mode="name"
+      mode=name
       shift
       ;;
     '-t'|'--test')
-      mode="code"
+      mode=code
       shift
       ;;
     '--cf-version')
@@ -135,28 +116,20 @@ EOM
       shift
       ;;
     '--')
-      dashdash=1
       shift
       ;;
     *)
-      if [[ ! $dashdash && $1 =~ ^-- ]]; then
-        echo "error in parsing arguments of $0: $1 is an unrecognized option" >&2
-        exit 2 # input error
-      fi
-      if [[ ! $1 ]] || next_dir=$(cd "$olddir" && cd -- "$1" && pwd); then
-        if ! [[ $set_include ]]; then
+      if next_dir=$(cd "$1" && pwd); then
+        if [[ ${next_dir#$PWD/} == /* ]]; then
+          echo "error in parsing arguments of $0: $next_dir is not in $PWD" >&2
+          exit 2 # input error
+        elif ! [[ $set_include ]]; then
           include=() # remove default includes
           set_include=1
         fi
-        if [[ $1 ]]; then
-          if [[ $next_dir != $PWD/* ]]; then
-            echo "error in parsing arguments of $0: $next_dir is not in $PWD" >&2
-            exit 2 # input error
-          fi
-          include+=("$next_dir")
-        fi
+        include+=("${next_dir#$PWD/}")
       else
-        echo "error in parsing arguments of $0: $1 is not a directory" >&2
+        echo "error in parsing arguments of $0: $PWD/$1 is not a directory" >&2
         exit 2 # input error
       fi
       if ! [[ $set_branch ]]; then
@@ -179,93 +152,37 @@ if ! hash $cf_cmd 2>/dev/null; then
   fi
 fi
 
-# check availability of cmake-format
-if [[ $do_cmake ]] && ! hash cmake-format 2>/dev/null; then
-  echo "could not find cmake-format" >&2
-  exit 3
-fi
-
 if [[ $branch ]]; then
   # get all dirty files through git
-  if ! base=$(git merge-base "$branch" HEAD); then
+  if ! base=$(git merge-base ${branch} HEAD); then
     echo "could not find git merge base" >&2
     exit 2 # input error
   fi
-  mapfile -t basenames < <(git diff --diff-filter=d --name-only "$base")
-  names=()
-  for ex in "${exts[@]}"; do
-    for path in "${include[@]}"; do
-      for name in "${basenames[@]}"; do
-        rx="^$path/.*\\.$ex$"
-        if [[ $name =~ $rx ]]; then
-          names+=("$name")
-        fi
-      done
-    done
+  declare -a reg
+  for ex in ${exts[@]}; do
+    reg+=(${include[@]/%/.*\\.$ex\$})
   done
-  if [[ $do_cmake ]]; then
-    cmake_names=()
-    for name in "${basenames[@]}"; do
-      dirrx="^$cmakedir$"
-      filerx="(^|/)$cmakefile$"
-      if [[ $name =~ $dirrx || $name =~ $filerx ]]; then
-        cmake_names+=("$name")
-      fi
-      for include in "${cmakeinclude[@]}"; do
-        if [[ $name == "$include" ]]; then
-          cmake_names+=("$name")
-        fi
-      done
-    done
-  fi
+  names=$(git diff --name-only $base | grep ${reg[@]/#/-e ^})
 else
-  exts_o=()
-  for ext in "${exts[@]}"; do
-    exts_o+=(-o -name "*\\.$ext")
-  done
-  unset "exts_o[0]" # remove first -o
-  mapfile -t names < <(find "${include[@]}" -type f "${exts_o[@]}")
-  if [[ $do_cmake ]]; then
-    mapfile -t cmake_names < <(find . -maxdepth 2 -type f -name "$cmakefile" -o -path "./${cmakedir/.}")
-    cmake_names+=("${cmakeinclude[@]}")
-  fi
+  names=$(find ${include[@]} -type f -false ${exts[@]/#/-o -name *\\.})
 fi
 
 # filter excludes
-for path in "${exclude[@]}"; do
-  for i in "${!names[@]}"; do
-    rx="^$path/"
-    if [[ ${names[$i]} =~ $rx ]]; then
-      unset "names[$i]"
-    fi
-  done
-done
+names=$(<<<"$names" grep -v ${exclude[@]/#/-e ^})
 
-# optionally print version
-if [[ $print_version ]]; then
-  $cf_cmd -version
-  [[ $do_cmake ]] && echo "cmake-format $(cmake-format --version)"
-  echo "----------"
-fi
-
-if [[ ! ${cmake_names[*]} ]]; then
-  unset do_cmake
-fi
-if [[ ! ( ${names[*]} || $do_cmake ) ]]; then
+if ! [[ $names ]]; then
   exit 0 # nothing to format means format is successful!
 fi
 
+# optionally print version
+[[ $print_version ]] && $cf_cmd -version
+
 # format
 case $mode in
   diff)
     declare -i code=0
-    for name in "${names[@]}"; do
-      if ! $cf_cmd "$name" | diff "$name" - -p "$color"; then
-        code=1
-      fi
-    done
-    for name in "${cmake_names[@]}"; do
-      if ! cmake-format "$name" | diff "$name" - -p "$color"; then
+    for name in ${names[@]}; do
+      if ! $cf_cmd "$name" | diff "$name" - -p $color; then
         code=1
       fi
     done
@@ -273,34 +190,20 @@ case $mode in
     ;;
   name)
     declare -i code=0
-    for name in "${names[@]}"; do
+    for name in ${names[@]}; do
       if ! $cf_cmd "$name" | diff "$name" - -q >/dev/null; then
         echo "$name"
         code=1
       fi
     done
-    for name in "${cmake_names[@]}"; do
-      if ! cmake-format "$name" --check; then
-        echo "$name"
-        code=1
-      fi
-    done
     exit $code
     ;;
   code)
-    for name in "${names[@]}"; do
+    for name in ${names[@]}; do
       $cf_cmd "$name" | diff "$name" - -q >/dev/null || exit 1
     done
-    for name in "${cmake_names[@]}"; do
-      cmake-format "$name" --check || exit 1
-    done
     ;;
   *)
-    if [[ "${names[*]}" ]]; then
-      $cf_cmd -i "${names[@]}"
-    fi
-    if [[ $do_cmake ]]; then
-      cmake-format -i "${cmake_names[@]}"
-    fi
+    $cf_cmd -i $names
     ;;
 esac

cmake/FindLibexecinfo.cmake

@@ -1,18 +1,18 @@
 # Find the LibExecinfo library - FreeBSD only
 
-find_path(LIBEXECINFO_INCLUDE_DIR execinfo.h)
-find_library(LIBEXECINFO_LIBRARY NAMES execinfo)
+FIND_PATH(LIBEXECINFO_INCLUDE_DIR execinfo.h)
+FIND_LIBRARY(LIBEXECINFO_LIBRARY NAMES execinfo)
 
-if(LIBEXECINFO_INCLUDE_DIR AND LIBEXECINFO_LIBRARY)
-  set(LIBEXECINFO_FOUND TRUE)
-endif()
+IF(LIBEXECINFO_INCLUDE_DIR AND LIBEXECINFO_LIBRARY)
+	SET(LIBEXECINFO_FOUND TRUE)
+ENDIF()
 
-if(LIBEXECINFO_FOUND)
-  if(NOT LIBEXECINFO_FIND_QUIETLY)
-    message(STATUS "Found LibExecinfo: ${EXECINFO_LIBRARY}")
-  endif()
-else()
-  if(LIBEXECINFO_FIND_REQUIRED)
-    message(FATAL_ERROR "Could not find LibExecinfo")
-  endif()
-endif()
+IF(LIBEXECINFO_FOUND)
+	IF(NOT LIBEXECINFO_FIND_QUIETLY)
+		MESSAGE(STATUS "Found LibExecinfo: ${EXECINFO_LIBRARY}")
+	ENDIF()
+ELSE()
+	IF(LIBEXECINFO_FIND_REQUIRED)
+		MESSAGE(FATAL_ERROR "Could not find LibExecinfo")
+	ENDIF()
+ENDIF()

cmake/FindQtRuntime.cmake

@@ -1,117 +0,0 @@
-# Find a compatible Qt version
-# Inputs: WITH_SERVER, WITH_CLIENT, WITH_ORACLE, WITH_DBCONVERTER, FORCE_USE_QT5
-# Optional Input: QT6_DIR -- Hint as to where Qt6 lives on the system
-# Optional Input: QT5_DIR -- Hint as to where Qt5 lives on the system
-# Output: COCKATRICE_QT_VERSION_NAME -- Example values: Qt5, Qt6
-# Output: SERVATRICE_QT_MODULES
-# Output: COCKATRICE_QT_MODULES
-# Output: ORACLE_QT_MODULES
-# Output: DBCONVERTER_QT_MODULES
-# Output: TEST_QT_MODULES
-
-set(REQUIRED_QT_COMPONENTS Core)
-if(WITH_SERVER)
-  set(_SERVATRICE_NEEDED Network Sql WebSockets)
-endif()
-if(WITH_CLIENT)
-  set(_COCKATRICE_NEEDED
-      Concurrent
-      Gui
-      Multimedia
-      Network
-      PrintSupport
-      Svg
-      WebSockets
-      Widgets
-  )
-endif()
-if(WITH_ORACLE)
-  set(_ORACLE_NEEDED Concurrent Network Svg Widgets)
-endif()
-if(WITH_DBCONVERTER)
-  set(_DBCONVERTER_NEEDED Network Widgets)
-endif()
-if(TEST)
-  set(_TEST_NEEDED Widgets)
-endif()
-
-set(REQUIRED_QT_COMPONENTS ${REQUIRED_QT_COMPONENTS} ${_SERVATRICE_NEEDED} ${_COCKATRICE_NEEDED} ${_ORACLE_NEEDED}
-                           ${_DBCONVERTER_NEEDED} ${_TEST_NEEDED}
-)
-list(REMOVE_DUPLICATES REQUIRED_QT_COMPONENTS)
-
-if(NOT FORCE_USE_QT5)
-  # Linguist is now a component in Qt6 instead of an external package
-  find_package(
-    Qt6 6.2.3
-    COMPONENTS ${REQUIRED_QT_COMPONENTS} Linguist
-    QUIET HINTS ${Qt6_DIR}
-  )
-endif()
-if(Qt6_FOUND)
-  set(COCKATRICE_QT_VERSION_NAME Qt6)
-
-  list(FIND Qt6LinguistTools_TARGETS Qt6::lrelease QT6_LRELEASE_INDEX)
-  if(QT6_LRELEASE_INDEX EQUAL -1)
-    message(WARNING "Qt6 lrelease not found.")
-  endif()
-
-  list(FIND Qt6LinguistTools_TARGETS Qt6::lupdate QT6_LUPDATE_INDEX)
-  if(QT6_LUPDATE_INDEX EQUAL -1)
-    message(WARNING "Qt6 lupdate not found.")
-  endif()
-else()
-  find_package(
-    Qt5 5.8.0
-    COMPONENTS ${REQUIRED_QT_COMPONENTS}
-    QUIET HINTS ${Qt5_DIR}
-  )
-  if(Qt5_FOUND)
-    set(COCKATRICE_QT_VERSION_NAME Qt5)
-  else()
-    message(FATAL_ERROR "No suitable version of Qt was found")
-  endif()
-
-  # Qt5 Linguist is in a separate package
-  find_package(Qt5LinguistTools QUIET)
-  if(Qt5LinguistTools_FOUND)
-    if(NOT Qt5_LRELEASE_EXECUTABLE)
-      message(WARNING "Qt5 lrelease not found.")
-    endif()
-    if(NOT Qt5_LUPDATE_EXECUTABLE)
-      message(WARNING "Qt5 lupdate not found.")
-    endif()
-  else()
-    message(WARNING "Linguist Tools not found, cannot handle translations")
-  endif()
-endif()
-
-if(Qt5_POSITION_INDEPENDENT_CODE OR Qt6_FOUND)
-  set(CMAKE_POSITION_INDEPENDENT_CODE ON)
-endif()
-
-# Establish Qt Plugins directory & Library directories
-get_target_property(QT_LIBRARY_DIR ${COCKATRICE_QT_VERSION_NAME}::Core LOCATION)
-get_filename_component(QT_LIBRARY_DIR ${QT_LIBRARY_DIR} DIRECTORY)
-if(Qt6_FOUND)
-  get_filename_component(QT_PLUGINS_DIR "${Qt6Core_DIR}/../../../${QT6_INSTALL_PLUGINS}" ABSOLUTE)
-  get_filename_component(QT_LIBRARY_DIR "${QT_LIBRARY_DIR}/../../.." ABSOLUTE)
-  if(UNIX AND APPLE)
-    # Mac needs a bit more help finding all necessary components
-    list(APPEND QT_LIBRARY_DIR "/usr/local/lib")
-  endif()
-elseif(Qt5_FOUND)
-  get_filename_component(QT_PLUGINS_DIR "${Qt5Core_DIR}/../../../plugins" ABSOLUTE)
-  get_filename_component(QT_LIBRARY_DIR "${QT_LIBRARY_DIR}/.." ABSOLUTE)
-endif()
-message(DEBUG "QT_PLUGINS_DIR = ${QT_PLUGINS_DIR}")
-message(DEBUG "QT_LIBRARY_DIR = ${QT_LIBRARY_DIR}")
-
-# Establish exports
-string(REGEX REPLACE "([^;]+)" "${COCKATRICE_QT_VERSION_NAME}::\\1" SERVATRICE_QT_MODULES "${_SERVATRICE_NEEDED}")
-string(REGEX REPLACE "([^;]+)" "${COCKATRICE_QT_VERSION_NAME}::\\1" COCKATRICE_QT_MODULES "${_COCKATRICE_NEEDED}")
-string(REGEX REPLACE "([^;]+)" "${COCKATRICE_QT_VERSION_NAME}::\\1" ORACLE_QT_MODULES "${_ORACLE_NEEDED}")
-string(REGEX REPLACE "([^;]+)" "${COCKATRICE_QT_VERSION_NAME}::\\1" DB_CONVERTER_QT_MODULES "${_DBCONVERTER_NEEDED}")
-string(REGEX REPLACE "([^;]+)" "${COCKATRICE_QT_VERSION_NAME}::\\1" TEST_QT_MODULES "${_TEST_NEEDED}")
-
-message(STATUS "Found Qt ${${COCKATRICE_QT_VERSION_NAME}_VERSION} at: ${${COCKATRICE_QT_VERSION_NAME}_DIR}")

cmake/FindVCredistRuntime.cmake

@@ -1,39 +1,36 @@
 # Find the MS Visual Studio VC redistributable package
 
-if(WIN32)
-  set(VCREDISTRUNTIME_FOUND "NO")
+if (WIN32)
+    set(VCREDISTRUNTIME_FOUND "NO")
 
-  if(CMAKE_SIZEOF_VOID_P EQUAL 8) # 64-bit
-    set(REDIST_ARCH x64)
-  else()
-    set(REDIST_ARCH x86)
-  endif()
-
-  set(REDIST_FILE vc_redist.${REDIST_ARCH}.exe)
-
-  set(CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP TRUE)
-  include(InstallRequiredSystemLibraries)
-
-  # Check if the list contains minimum one element, to get the path from
-  list(LENGTH CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS libsCount)
-  if(libsCount GREATER 0)
-    list(GET CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS 0 _path)
-
-    get_filename_component(_path ${_path} DIRECTORY)
-    get_filename_component(_path ${_path}/../../ ABSOLUTE)
-
-    if(EXISTS "${_path}/${REDIST_FILE}") # VS 2017
-      set(VCREDISTRUNTIME_FOUND "YES")
-      set(VCREDISTRUNTIME_FILE ${_path}/${REDIST_FILE})
+    if(CMAKE_SIZEOF_VOID_P EQUAL 8) # 64-bit
+        set(REDIST_ARCH x64)
+    else()
+        set(REDIST_ARCH x86)
     endif()
-  endif()
 
-  if(VCREDISTRUNTIME_FOUND)
-    message(STATUS "Found VCredist ${VCREDISTRUNTIME_FILE}")
-  else()
-    message(
-      WARNING
-        "Could not find VCredist package in \"${_path}/${REDIST_FILE}\". It's not required for compiling, but needs to be available at runtime."
-    )
-  endif()
+    set(REDIST_FILE vcredist_${REDIST_ARCH}.exe)
+
+    set(CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP TRUE)
+    include(InstallRequiredSystemLibraries)
+
+    # Check if the list contains minimum one element, to get the path from
+    list(LENGTH CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS libsCount)
+    if (libsCount GREATER 0)
+        list(GET CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS 0 _path)
+
+        get_filename_component(_path ${_path} DIRECTORY)
+        get_filename_component(_path ${_path}/../../ ABSOLUTE)
+
+        if (EXISTS "${_path}/${REDIST_FILE}") # VS 2017
+            set(VCREDISTRUNTIME_FOUND "YES")
+            set(VCREDISTRUNTIME_FILE ${_path}/${REDIST_FILE})
+        endif()
+    endif()
+
+    if(VCREDISTRUNTIME_FOUND)
+      message(STATUS "Found VCredist ${VCREDISTRUNTIME_FILE}")
+    else()
+      message(WARNING "Could not find VCredist package. It's not required for compiling, but needs to be available at runtime.")
+    endif()
 endif()

cmake/FindWin32SslRuntime.cmake

@@ -1,81 +1,71 @@
 # Find the OpenSSL runtime libraries (.dll) for Windows that
 # will be needed by Qt in order to access https urls.
-if(NOT DEFINED WIN32 OR NOT ${WIN32})
-  message(STATUS "Non-Windows device trying to execute FindWin32SslRuntime, skipping")
-  return()
-endif()
 
-if("${CMAKE_GENERATOR_PLATFORM}" STREQUAL "x64")
-  message(STATUS "Looking for OpenSSL for ${CMAKE_GENERATOR_PLATFORM}")
-  file(TO_CMAKE_PATH "$ENV{PROGRAMFILES}" _programfiles)
-  set(_OPENSSL_ROOT_PATHS
-      "$ENV{VCPKG_PACKAGES_DIR}/x64-windows/bin"
-      "C:/OpenSSL-Win64/bin"
-      "C:/OpenSSL-Win64"
+if (WIN32)
+  # Get standard installation paths for OpenSSL under Windows
+
+  # http://www.slproweb.com/products/Win32OpenSSL.html
+
+  if( CMAKE_SIZEOF_VOID_P EQUAL 8 )
+    # target win64
+    set(_OPENSSL_ROOT_HINTS
+      ${OPENSSL_ROOT_DIR}
+      "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\OpenSSL (64-bit)_is1;Inno Setup: App Path]"
+      ENV OPENSSL_ROOT_DIR
+      )
+    file(TO_CMAKE_PATH "$ENV{PROGRAMFILES}" _programfiles)
+    set(_OPENSSL_ROOT_PATHS
       "C:/Tools/vcpkg/installed/x64-windows/bin"
       "${_programfiles}/OpenSSL-Win64"
-      "D:/a/Cockatrice/Qt/Tools/OpenSSL/Win_x64/bin"
-      expanduser
-      ("~/Documents/Development/Qt/Tools/OpenSSL/Win_x64/bin")
-  )
-  unset(_programfiles)
-elseif("${CMAKE_GENERATOR_PLATFORM}" STREQUAL "Win32")
-  message(STATUS "Looking for OpenSSL for ${CMAKE_GENERATOR_PLATFORM}")
-  file(TO_CMAKE_PATH "$ENV{PROGRAMFILES}" _programfiles)
-  set(_OPENSSL_ROOT_PATHS
-      "$ENV{VCPKG_PACKAGES_DIR}/x86-windows/bin"
-      "C:/OpenSSL-Win32/bin"
-      "C:/OpenSSL-Win32"
-      "C:/OpenSSL"
+      "C:/OpenSSL-Win64/"
+      )
+    unset(_programfiles)
+  else( CMAKE_SIZEOF_VOID_P EQUAL 8 )
+    # target win32
+    set(_OPENSSL_ROOT_HINTS
+      ${OPENSSL_ROOT_DIR}
+      "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\OpenSSL (32-bit)_is1;Inno Setup: App Path]"
+      ENV OPENSSL_ROOT_DIR
+      )
+    file(TO_CMAKE_PATH "$ENV{PROGRAMFILES}" _programfiles)
+    set(_OPENSSL_ROOT_PATHS
       "C:/Tools/vcpkg/installed/x86-windows/bin"
       "${_programfiles}/OpenSSL"
       "${_programfiles}/OpenSSL-Win32"
-      "D:/a/Cockatrice/Qt/Tools/OpenSSL/Win_x86/bin"
-      expanduser
-      ("~/Documents/Development/Qt/Tools/OpenSSL/Win_x86/bin")
-  )
-  unset(_programfiles)
-endif()
+      "C:/OpenSSL/"
+      "C:/OpenSSL-Win32/"
+      )
+    unset(_programfiles)
+  endif( CMAKE_SIZEOF_VOID_P EQUAL 8 )
 
-message(STATUS "Looking for OpenSSL @ ${CMAKE_GENERATOR_PLATFORM} in ${_OPENSSL_ROOT_PATHS}")
-if("${CMAKE_GENERATOR_PLATFORM}" STREQUAL "x64")
-  find_file(
-    WIN32SSLRUNTIME_LIBEAY
-    NAMES libcrypto-1_1-x64.dll libcrypto.dll
-    PATHS ${_OPENSSL_ROOT_PATHS}
-    NO_DEFAULT_PATH
-  )
-  find_file(
-    WIN32SSLRUNTIME_SSLEAY
-    NAMES libssl-1_1-x64.dll libssl.dll
-    PATHS ${_OPENSSL_ROOT_PATHS}
-    NO_DEFAULT_PATH
-  )
-elseif("${CMAKE_GENERATOR_PLATFORM}" STREQUAL "Win32")
-  find_file(
-    WIN32SSLRUNTIME_LIBEAY
-    NAMES libcrypto-1_1.dll libcrypto.dll
-    PATHS ${_OPENSSL_ROOT_PATHS}
-    NO_DEFAULT_PATH
-  )
-  find_file(
-    WIN32SSLRUNTIME_SSLEAY
-    NAMES libssl-1_1.dll libssl.dll
-    PATHS ${_OPENSSL_ROOT_PATHS}
-    NO_DEFAULT_PATH
-  )
-endif()
+else ()
+  set(_OPENSSL_ROOT_HINTS
+    ${OPENSSL_ROOT_DIR}
+    ENV OPENSSL_ROOT_DIR
+    )
+endif ()
 
-if(WIN32SSLRUNTIME_LIBEAY AND WIN32SSLRUNTIME_SSLEAY)
-  set(WIN32SSLRUNTIME_LIBRARIES "${WIN32SSLRUNTIME_LIBEAY}" "${WIN32SSLRUNTIME_SSLEAY}")
-  set(WIN32SSLRUNTIME_FOUND "YES")
+set(_OPENSSL_ROOT_HINTS_AND_PATHS
+    HINTS ${_OPENSSL_ROOT_HINTS}
+    PATHS ${_OPENSSL_ROOT_PATHS}
+    )
+
+# For OpenSSL < 1.1, they are named libeay32 and ssleay32 and even if the dll is 64bit, it's still suffixed as *32.dll
+# For OpenSSL >= 1.1, they are named libcrypto and libssl with no suffix
+FIND_FILE(WIN32SSLRUNTIME_LIBEAY NAMES libeay32.dll libcrypto.dll ${_OPENSSL_ROOT_HINTS_AND_PATHS})
+FIND_FILE(WIN32SSLRUNTIME_SSLEAY NAMES ssleay32.dll libssl.dll ${_OPENSSL_ROOT_HINTS_AND_PATHS})
+
+
+IF(WIN32SSLRUNTIME_LIBEAY AND WIN32SSLRUNTIME_SSLEAY)
+  SET(WIN32SSLRUNTIME_LIBRARIES "${WIN32SSLRUNTIME_LIBEAY}" "${WIN32SSLRUNTIME_SSLEAY}")
+  SET(WIN32SSLRUNTIME_FOUND "YES")
   message(STATUS "Found OpenSSL ${WIN32SSLRUNTIME_LIBRARIES}")
-else()
-  set(WIN32SSLRUNTIME_FOUND "NO")
-  message(
-    WARNING
-      "Could not find OpenSSL runtime libraries. They are not required for compiling, but needs to be available at runtime."
-  )
-endif()
+ELSE()
+  SET(WIN32SSLRUNTIME_FOUND "NO")
+  message(WARNING "Could not find OpenSSL runtime libraries. They are not required for compiling, but needs to be available at runtime.")
+ENDIF()
 
-mark_as_advanced(WIN32SSLRUNTIME_LIBEAY WIN32SSLRUNTIME_SSLEAY)
+MARK_AS_ADVANCED(
+  WIN32SSLRUNTIME_LIBEAY
+  WIN32SSLRUNTIME_SSLEAY
+  )

cmake/Info.plist

@@ -34,5 +34,7 @@
     <string>${MACOSX_BUNDLE_COPYRIGHT}</string>
     <key>NSHighResolutionCapable</key>
     <true/>
+    <key>NSRequiresAquaSystemAppearance</key>
+    <true/>
 </dict>
 </plist>

cmake/NSIS.template.in

@@ -213,7 +213,6 @@ ${AndIf} ${FileExists} "$INSTDIR\portable.dat"
 	Delete "$INSTDIR\uninstall.exe"
 	Delete "$INSTDIR\cockatrice.exe"
 	Delete "$INSTDIR\oracle.exe"
-	Delete "$INSTDIR\dbconverter.exe"
 	Delete "$INSTDIR\servatrice.exe"
 	Delete "$INSTDIR\Qt*.dll"
 	Delete "$INSTDIR\libmysql.dll"
@@ -251,7 +250,7 @@ ${If} $PortableMode = 0
 	IfFileExists "$INSTDIR\vcredist_x86.exe" VcRedist86Exists PastVcRedist86Check
 	VcRedist86Exists:
 		ExecWait '"$INSTDIR\vcredist_x86.exe" /passive /norestart'
-		DetailPrint "Wait to ensure unlock of vc_redist file after installation..."
+		DetailPrint "Sleep to ensure unlock of vc_redist file after installation..."
 		Sleep 3000
 		Delete "$INSTDIR\vcredist_x86.exe"
 	PastVcRedist86Check:

cmake/createversionfile.cmake

@@ -1,24 +1,21 @@
 set(VERSION_STRING_CPP "${PROJECT_BINARY_DIR}/version_string.cpp")
 set(VERSION_STRING_H "${PROJECT_BINARY_DIR}/version_string.h")
-include_directories(${PROJECT_BINARY_DIR})
+INCLUDE_DIRECTORIES(${PROJECT_BINARY_DIR})
 
-set(hstring
-    "extern const char *VERSION_STRING\;
+set( hstring "extern const char *VERSION_STRING\;
 extern const char *VERSION_COMMIT\;
-extern const char *VERSION_DATE\;\n"
-)
-set(cppstring
-    "const char *VERSION_STRING = \"${PROJECT_VERSION_FRIENDLY}\"\;
+extern const char *VERSION_DATE\;\n" )
+set( cppstring "const char *VERSION_STRING = \"${PROJECT_VERSION_FRIENDLY}\"\;
 const char *VERSION_COMMIT = \"${GIT_COMMIT_ID}\"\;
-const char *VERSION_DATE = \"${GIT_COMMIT_DATE_FRIENDLY}\"\;\n"
-)
+const char *VERSION_DATE = \"${GIT_COMMIT_DATE_FRIENDLY}\"\;\n")
 
-file(WRITE ${PROJECT_BINARY_DIR}/version_string.cpp.txt ${cppstring})
-file(WRITE ${PROJECT_BINARY_DIR}/version_string.h.txt ${hstring})
+file(WRITE ${PROJECT_BINARY_DIR}/version_string.cpp.txt ${cppstring} )
+file(WRITE ${PROJECT_BINARY_DIR}/version_string.h.txt ${hstring} )
 
 execute_process(
-  COMMAND ${CMAKE_COMMAND} -E copy_if_different ${PROJECT_BINARY_DIR}/version_string.h.txt ${VERSION_STRING_H}
+	COMMAND ${CMAKE_COMMAND} -E copy_if_different ${PROJECT_BINARY_DIR}/version_string.h.txt ${VERSION_STRING_H}
 )
 execute_process(
-  COMMAND ${CMAKE_COMMAND} -E copy_if_different ${PROJECT_BINARY_DIR}/version_string.cpp.txt ${VERSION_STRING_CPP}
+	COMMAND ${CMAKE_COMMAND} -E copy_if_different ${PROJECT_BINARY_DIR}/version_string.cpp.txt ${VERSION_STRING_CPP}
 )
+

cmake/expanduser.cmake

@@ -1,19 +0,0 @@
-# expands ~ to user home directory
-#
-# usage:
-# expanduser("~/code" x)
-
-function(expanduser in outvar)
-
-  if(CMAKE_VERSION VERSION_LESS 3.21)
-    get_filename_component(out ${in} ABSOLUTE)
-  else()
-    file(REAL_PATH ${in} out EXPAND_TILDE)
-  endif()
-
-  set(${outvar}
-      ${out}
-      PARENT_SCOPE
-  )
-
-endfunction(expanduser)

cmake/getversion.cmake

@@ -1,187 +1,188 @@
 # HELPER FUNCTIONS
 
 function(get_commit_id)
-  # get last commit hash
-  execute_process(
-    COMMAND ${GIT_EXECUTABLE} log -1 --abbrev=7 --date=short "--pretty=%h"
-    WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
-    RESULT_VARIABLE res_var
-    OUTPUT_VARIABLE GIT_COM_ID
-  )
-  if(NOT ${res_var} EQUAL 0)
-    message(WARNING "Git failed (not a repo, or no tags). Build will not contain git revision info.")
-    return()
-  endif()
+	# get last commit hash
+	execute_process(
+		COMMAND ${GIT_EXECUTABLE} log -1 --abbrev=7 --date=short "--pretty=%h"
+		WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
+		RESULT_VARIABLE res_var
+		OUTPUT_VARIABLE GIT_COM_ID
+	)
+	if(NOT ${res_var} EQUAL 0)
+		message(WARNING "Git failed (not a repo, or no tags). Build will not contain git revision info.")
+		return()
+	endif()
 
-  string(REPLACE "\n" "" GIT_COM_ID "${GIT_COM_ID}")
-  set(GIT_COMMIT_ID
-      "${GIT_COM_ID}"
-      PARENT_SCOPE
-  )
-  set(PROJECT_VERSION_LABEL
-      "custom(${GIT_COM_ID})"
-      PARENT_SCOPE
-  )
+	string(REPLACE "\n" "" GIT_COM_ID "${GIT_COM_ID}")
+	set(GIT_COMMIT_ID "${GIT_COM_ID}" PARENT_SCOPE)
+	set(PROJECT_VERSION_LABEL "custom(${GIT_COM_ID})" PARENT_SCOPE)
 endfunction()
 
 function(get_commit_date)
-  # get last commit date
-  execute_process(
-    COMMAND ${GIT_EXECUTABLE} log -1 --date=short "--pretty=%cd"
-    WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
-    RESULT_VARIABLE res_var
-    OUTPUT_VARIABLE GIT_COM_DATE
-  )
-  if(NOT ${res_var} EQUAL 0)
-    message(WARNING "Git failed (not a repo, or no tags). Build will not contain git revision info.")
-    return()
-  endif()
+	# get last commit date
+	execute_process(
+		COMMAND ${GIT_EXECUTABLE} log -1 --date=short "--pretty=%cd"
+		WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
+		RESULT_VARIABLE res_var
+		OUTPUT_VARIABLE GIT_COM_DATE
+	)
+	if(NOT ${res_var} EQUAL 0)
+		message(WARNING "Git failed (not a repo, or no tags). Build will not contain git revision info.")
+		return()
+	endif()
 
-  string(REPLACE "\n" "" GIT_COM_DATE "${GIT_COM_DATE}")
-  set(GIT_COMMIT_DATE_FRIENDLY
-      "${GIT_COM_DATE}"
-      PARENT_SCOPE
-  )
+	string(REPLACE "\n" "" GIT_COM_DATE "${GIT_COM_DATE}")
+	set(GIT_COMMIT_DATE_FRIENDLY "${GIT_COM_DATE}" PARENT_SCOPE)
 
-  string(REPLACE "-" "" GIT_COM_DATE "${GIT_COM_DATE}")
-  set(GIT_COMMIT_DATE
-      "${GIT_COM_DATE}"
-      PARENT_SCOPE
-  )
+	string(REPLACE "-" "" GIT_COM_DATE "${GIT_COM_DATE}")
+	set(GIT_COMMIT_DATE "${GIT_COM_DATE}" PARENT_SCOPE)
+endfunction()
+
+function(clean_release_name name)
+	# "name": "Cockatrice: Thopter Pie Network, Revision 2"
+
+	# Remove all double quotes
+	STRING(REPLACE "\"" "" name "${name}")
+	# Remove json prefix "name: "
+	STRING(REPLACE "  name: " "" name "${name}")
+	# Remove "cockatrice" name
+	STRING(REPLACE "Cockatrice" "" name "${name}")
+	# Remove all unwanted chars
+	STRING(REGEX REPLACE "[^A-Za-z0-9_ ]" "" name "${name}")
+	# Strip (trim) whitespaces
+	STRING(STRIP "${name}" name)
+	# Replace all spaces with underscores
+	STRING(REPLACE " " "_" name "${name}")
+
+	set(GIT_TAG_RELEASENAME "${name}" PARENT_SCOPE)
 endfunction()
 
 function(get_tag_name commit)
-  if(${commit} STREQUAL "unknown")
-    return()
-  endif()
+	if(${commit} STREQUAL "unknown")
+		return()
+	endif()
 
-  execute_process(
-    COMMAND ${GIT_EXECUTABLE} describe --exact-match --tags ${commit}
-    WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
-    RESULT_VARIABLE res_var
-    OUTPUT_VARIABLE GIT_TAG
-    ERROR_VARIABLE GIT_TAG_ERR
-  )
+	execute_process(
+		COMMAND ${GIT_EXECUTABLE} describe --exact-match --tags ${commit}
+		WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
+		RESULT_VARIABLE res_var
+		OUTPUT_VARIABLE GIT_TAG
+		ERROR_VARIABLE GIT_TAG_ERR
+	)
 
-  if((NOT ${res_var} EQUAL 0) OR (${GIT_TAG_ERR} MATCHES "fatal: no tag exactly matches.*"))
-    message(STATUS "Commit is not a release or prerelease (no git tag found)")
-    return()
-  endif()
+	if((NOT ${res_var} EQUAL 0) OR (${GIT_TAG_ERR} MATCHES "fatal: no tag exactly matches.*"))
+		message(STATUS "Commit is not a release or prerelease (no git tag found)")
+		return()
+	endif()
 
-  string(REPLACE "\n" "" GIT_TAG "${GIT_TAG}")
-  message(STATUS "Commit is a release or prerelease, git tag: ${GIT_TAG}")
+	string(REPLACE "\n" "" GIT_TAG "${GIT_TAG}")
+	message(STATUS "Commit is a release or prerelease, git tag: ${GIT_TAG}")
 
-  # Extract information from tag:
-  # YYYY-MM-DD-Release-MAJ.MIN.PATCH
-  # YYYY-MM-DD-Development-MAJ.MIN.PATCH-beta.X
-  string(REPLACE "-" ";" GIT_TAG_EXPLODED "${GIT_TAG}")
-  string(REPLACE "." ";" GIT_TAG_EXPLODED "${GIT_TAG_EXPLODED}")
+	# Extract information from tag:
+	# YYYY-MM-DD-Release-MAJ.MIN.PATCH
+	# YYYY-MM-DD-Development-MAJ.MIN.PATCH-beta.X
+	string(REPLACE "-" ";" GIT_TAG_EXPLODED "${GIT_TAG}")
+	string(REPLACE "." ";" GIT_TAG_EXPLODED "${GIT_TAG_EXPLODED}")
 
-  # Sanity checks: length
-  list(LENGTH GIT_TAG_EXPLODED GIT_TAG_LISTCOUNT)
-  if(${GIT_TAG_LISTCOUNT} LESS 7 OR ${GIT_TAG_LISTCOUNT} GREATER 9)
-    message(WARNING "Invalid tag format, got ${GIT_TAG_LISTCOUNT} tokens")
-    return()
-  endif()
+	# Sanity checks: length
+	list(LENGTH GIT_TAG_EXPLODED GIT_TAG_LISTCOUNT)
+	if(${GIT_TAG_LISTCOUNT} LESS 7 OR ${GIT_TAG_LISTCOUNT} GREATER 9)
+		message(WARNING "Invalid tag format, got ${GIT_TAG_LISTCOUNT} tokens")
+		return()
+	endif()
 
-  # Year
-  list(GET GIT_TAG_EXPLODED 0 GIT_TAG_YEAR)
-  if(${GIT_TAG_YEAR} LESS 2017 OR ${GIT_TAG_LISTCOUNT} GREATER 2100)
-    message(WARNING "Invalid tag year ${GIT_TAG_YEAR}")
-    return()
-  endif()
+	# Year
+	list(GET GIT_TAG_EXPLODED 0 GIT_TAG_YEAR)
+	if(${GIT_TAG_YEAR} LESS 2017 OR ${GIT_TAG_LISTCOUNT} GREATER 2100)
+		message(WARNING "Invalid tag year ${GIT_TAG_YEAR}")
+		return()
+	endif()
 
-  # Month
-  list(GET GIT_TAG_EXPLODED 1 GIT_TAG_MONTH)
-  if(${GIT_TAG_MONTH} LESS 1 OR ${GIT_TAG_MONTH} GREATER 12)
-    message(WARNING "Invalid tag month ${GIT_TAG_MONTH}")
-    return()
-  endif()
+	# Month
+	list(GET GIT_TAG_EXPLODED 1 GIT_TAG_MONTH)
+	if(${GIT_TAG_MONTH} LESS 1 OR ${GIT_TAG_MONTH} GREATER 12)
+		message(WARNING "Invalid tag month ${GIT_TAG_MONTH}")
+		return()
+	endif()
 
-  # Day
-  list(GET GIT_TAG_EXPLODED 2 GIT_TAG_DAY)
-  if(${GIT_TAG_DAY} LESS 1 OR ${GIT_TAG_DAY} GREATER 31)
-    message(WARNING "Invalid tag day ${GIT_TAG_DAY}")
-    return()
-  endif()
+	# Day
+	list(GET GIT_TAG_EXPLODED 2 GIT_TAG_DAY)
+	if(${GIT_TAG_DAY} LESS 1 OR ${GIT_TAG_DAY} GREATER 31)
+		message(WARNING "Invalid tag day ${GIT_TAG_DAY}")
+		return()
+	endif()
 
-  # Type
-  list(GET GIT_TAG_EXPLODED 3 GIT_TAG_TYPE)
-  if(NOT (${GIT_TAG_TYPE} STREQUAL "Release" OR ${GIT_TAG_TYPE} STREQUAL "Development"))
-    message(WARNING "Invalid tag type ${GIT_TAG_TYPE}")
-    return()
-  endif()
+	# Type
+	list(GET GIT_TAG_EXPLODED 3 GIT_TAG_TYPE)
+	if(NOT(${GIT_TAG_TYPE} STREQUAL "Release" OR ${GIT_TAG_TYPE} STREQUAL "Development"))
+		message(WARNING "Invalid tag type ${GIT_TAG_TYPE}")
+		return()
+	endif()
 
-  # Major
-  list(GET GIT_TAG_EXPLODED 4 GIT_TAG_MAJOR)
-  if(${GIT_TAG_MAJOR} LESS 0 OR ${GIT_TAG_MAJOR} GREATER 99)
-    message(WARNING "Invalid tag major version ${GIT_TAG_MAJOR}")
-    return()
-  endif()
+	# Major
+	list(GET GIT_TAG_EXPLODED 4 GIT_TAG_MAJOR)
+	if(${GIT_TAG_MAJOR} LESS 0 OR ${GIT_TAG_MAJOR} GREATER 99)
+		message(WARNING "Invalid tag major version ${GIT_TAG_MAJOR}")
+		return()
+	endif()
 
-  # Minor
-  list(GET GIT_TAG_EXPLODED 5 GIT_TAG_MINOR)
-  if(${GIT_TAG_MINOR} LESS 0 OR ${GIT_TAG_MINOR} GREATER 99)
-    message(WARNING "Invalid tag minor version ${GIT_TAG_MINOR}")
-    return()
-  endif()
+	# Minor
+	list(GET GIT_TAG_EXPLODED 5 GIT_TAG_MINOR)
+	if(${GIT_TAG_MINOR} LESS 0 OR ${GIT_TAG_MINOR} GREATER 99)
+		message(WARNING "Invalid tag minor version ${GIT_TAG_MINOR}")
+		return()
+	endif()
 
-  # Patch
-  list(GET GIT_TAG_EXPLODED 6 GIT_TAG_PATCH)
-  if(${GIT_TAG_PATCH} LESS 0 OR ${GIT_TAG_PATCH} GREATER 99)
-    message(WARNING "Invalid tag patch version ${GIT_TAG_PATCH}")
-    return()
-  endif()
+	# Patch
+	list(GET GIT_TAG_EXPLODED 6 GIT_TAG_PATCH)
+	if(${GIT_TAG_PATCH} LESS 0 OR ${GIT_TAG_PATCH} GREATER 99)
+		message(WARNING "Invalid tag patch version ${GIT_TAG_PATCH}")
+		return()
+	endif()
 
-  # Label
-  # 7 = Stable release
-  # 8 = Dev release, first beta so only "beta" attached
-  # 9 = Dev release, subsequent beta so "beta.N" attached (N>=2)
-  if(${GIT_TAG_LISTCOUNT} EQUAL 8)
-    list(GET GIT_TAG_EXPLODED 7 GIT_TAG_LABEL)
-  elseif(${GIT_TAG_LISTCOUNT} EQUAL 9)
-    list(GET GIT_TAG_EXPLODED 7 GIT_TAG_LABEL)
-    list(GET GIT_TAG_EXPLODED 8 GIT_TAG_LABEL_NUM)
-    set(GIT_TAG_LABEL ${GIT_TAG_LABEL} ${GIT_TAG_LABEL_NUM})
-    string(REPLACE ";" "." GIT_TAG_LABEL "${GIT_TAG_LABEL}")
-  else()
-    set(GIT_TAG_LABEL "")
-  endif()
+	# Label
+	# 7 = Stable release
+	# 8 = Dev release, first beta so only "beta" attached
+	# 9 = Dev release, subsequent beta so "beta.N" attached (N>=2)
+	if(${GIT_TAG_LISTCOUNT} EQUAL 8)
+		list(GET GIT_TAG_EXPLODED 7 GIT_TAG_LABEL)
+	elseif(${GIT_TAG_LISTCOUNT} EQUAL 9)
+		list(GET GIT_TAG_EXPLODED 7 GIT_TAG_LABEL)
+		list(GET GIT_TAG_EXPLODED 8 GIT_TAG_LABEL_NUM)
+		set(GIT_TAG_LABEL ${GIT_TAG_LABEL} ${GIT_TAG_LABEL_NUM})
+		string(REPLACE ";" "." GIT_TAG_LABEL "${GIT_TAG_LABEL}")
+	else()
+		SET(GIT_TAG_LABEL "")
+	endif()
 
-  # Override hardcoded version with the informations from the tag
-  set(PROJECT_VERSION_MAJOR
-      ${GIT_TAG_MAJOR}
-      PARENT_SCOPE
-  )
-  set(PROJECT_VERSION_MINOR
-      ${GIT_TAG_MINOR}
-      PARENT_SCOPE
-  )
-  set(PROJECT_VERSION_PATCH
-      ${GIT_TAG_PATCH}
-      PARENT_SCOPE
-  )
-  set(PROJECT_VERSION_LABEL
-      ${GIT_TAG_LABEL}
-      PARENT_SCOPE
-  )
+	# Override hardcoded version with the informations from the tag
+	set(PROJECT_VERSION_MAJOR ${GIT_TAG_MAJOR} PARENT_SCOPE)
+	set(PROJECT_VERSION_MINOR ${GIT_TAG_MINOR} PARENT_SCOPE)
+	set(PROJECT_VERSION_PATCH ${GIT_TAG_PATCH} PARENT_SCOPE)
+	set(PROJECT_VERSION_LABEL ${GIT_TAG_LABEL} PARENT_SCOPE)
 
-  if(${GIT_TAG_TYPE} STREQUAL "Development")
-    set(PROJECT_VERSION_LABEL
-        ${GIT_TAG_LABEL}
-        PARENT_SCOPE
-    )
-  elseif(${GIT_TAG_TYPE} STREQUAL "Release")
-    set(PROJECT_VERSION_LABEL
-        ""
-        PARENT_SCOPE
-    )
-    # set release name from env var
-    set(PROJECT_VERSION_RELEASENAME
-        "${GIT_TAG_RELEASENAME}"
-        PARENT_SCOPE
-    )
-  endif()
+	if(${GIT_TAG_TYPE} STREQUAL "Development")
+		set(PROJECT_VERSION_LABEL ${GIT_TAG_LABEL} PARENT_SCOPE)
+	elseif(${GIT_TAG_TYPE} STREQUAL "Release")
+		set(PROJECT_VERSION_LABEL "" PARENT_SCOPE)
+
+		# get version name from github
+		set(GIT_TAG_TEMP_FILE "${PROJECT_BINARY_DIR}/tag_informations.txt")
+		set(GIT_TAG_TEMP_URL "https://api.github.com/repos/Cockatrice/Cockatrice/releases/tags/${GIT_TAG}")
+		message(STATUS "Fetching tag informations from ${GIT_TAG_TEMP_URL}")
+		file(REMOVE "${GIT_TAG_TEMP_FILE}")
+		file(DOWNLOAD "${GIT_TAG_TEMP_URL}" "${GIT_TAG_TEMP_FILE}" STATUS status LOG log INACTIVITY_TIMEOUT 30 TIMEOUT 300 SHOW_PROGRESS)
+    	list(GET status 0 err)
+    	list(GET status 1 msg)
+	    if(err)
+	    	message(WARNING "Download failed with error ${msg}: ${log}")
+	    	return()
+    	endif()
+    	file(STRINGS "${GIT_TAG_TEMP_FILE}" GIT_TAG_RAW_RELEASENAME REGEX "\"name\": \"" LIMIT_COUNT 1)
+
+    	clean_release_name("${GIT_TAG_RAW_RELEASENAME}")
+    	set(PROJECT_VERSION_RELEASENAME "${GIT_TAG_RELEASENAME}" PARENT_SCOPE)
+	endif()
 
 endfunction()
 
@@ -189,23 +190,23 @@ endfunction()
 
 # fallback defaults
 set(GIT_COMMIT_ID "unknown")
-set(GIT_COMMIT_DATE "")
-set(GIT_COMMIT_DATE_FRIENDLY "")
-set(PROJECT_VERSION_LABEL "")
+set(GIT_COMMIT_DATE "unknown")
+set(GIT_COMMIT_DATE_FRIENDLY "unknown")
+set(PROJECT_VERSION_LABEL "custom(unknown)")
 set(PROJECT_VERSION_RELEASENAME "")
 
 find_package(Git)
 if(GIT_FOUND)
-  get_commit_id()
-  get_commit_date()
-  get_tag_name(${GIT_COMMIT_ID})
+	get_commit_id()
+	get_commit_date()
+	get_tag_name(${GIT_COMMIT_ID})
 else()
-  message(WARNING "Git not found. Build will not contain git revision info.")
+	message( WARNING "Git not found. Build will not contain git revision info." )
 endif()
 
 set(PROJECT_VERSION "${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}")
 if(PROJECT_VERSION_LABEL)
-  set(PROJECT_VERSION "${PROJECT_VERSION}-${PROJECT_VERSION_LABEL}")
+	set(PROJECT_VERSION "${PROJECT_VERSION}-${PROJECT_VERSION_LABEL}")
 endif()
 
 set(PROJECT_VERSION_FRIENDLY "${PROJECT_VERSION} (${GIT_COMMIT_DATE_FRIENDLY})")
@@ -213,7 +214,7 @@ set(PROJECT_VERSION_FRIENDLY "${PROJECT_VERSION} (${GIT_COMMIT_DATE_FRIENDLY})")
 # Format: <program name>[-ReleaseName]-MAJ.MIN.PATCH[-prerelease_label]
 set(PROJECT_VERSION_FILENAME "${PROJECT_NAME}")
 if(PROJECT_VERSION_RELEASENAME)
-  set(PROJECT_VERSION_FILENAME "${PROJECT_VERSION_FILENAME}-${PROJECT_VERSION_RELEASENAME}")
+	set(PROJECT_VERSION_FILENAME "${PROJECT_VERSION_FILENAME}-${PROJECT_VERSION_RELEASENAME}")
 endif()
 set(PROJECT_VERSION_FILENAME "${PROJECT_VERSION_FILENAME}-${PROJECT_VERSION}")
 

cmake/gtest-CMakeLists.txt.in

@@ -4,8 +4,8 @@ project(gtest-download LANGUAGES NONE)
 
 include(ExternalProject)
 ExternalProject_Add(googletest
-  URL https://github.com/google/googletest/archive/release-1.11.0.zip
-  URL_HASH SHA1=9ffb7b5923f4a8fcdabf2f42c6540cce299f44c0
+  URL https://github.com/google/googletest/archive/release-1.7.0.zip
+  URL_HASH SHA1=f89bc9f55477df2fde082481e2d709bfafdb057b
   SOURCE_DIR "${CMAKE_BINARY_DIR}/gtest-src"
   BINARY_DIR "${CMAKE_BINARY_DIR}/gtest-build"
   CONFIGURE_COMMAND ""

cockatrice/CMakeLists.txt

@@ -2,391 +2,282 @@
 #
 # provides the cockatrice binary
 
-project(Cockatrice VERSION "${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}")
+PROJECT(Cockatrice VERSION "${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}")
 
-set(cockatrice_SOURCES
-    src/abstractcarddragitem.cpp
-    src/abstractcarditem.cpp
-    src/abstractclient.cpp
+SET(cockatrice_SOURCES
     src/abstractcounter.cpp
-    src/abstractgraphicsitem.cpp
-    src/arrowitem.cpp
-    src/arrowtarget.cpp
-    src/carddatabase.cpp
-    src/carddatabasemodel.cpp
-    src/carddbparser/carddatabaseparser.cpp
-    src/carddbparser/cockatricexml3.cpp
-    src/carddbparser/cockatricexml4.cpp
-    src/carddragitem.cpp
-    src/cardfilter.cpp
-    src/cardframe.cpp
-    src/cardinfopicture.cpp
-    src/cardinfotext.cpp
-    src/cardinfowidget.cpp
-    src/carditem.cpp
-    src/cardlist.cpp
-    src/cardzone.cpp
-    src/chatview/chatview.cpp
     src/counter_general.cpp
-    src/customlineedit.cpp
-    src/deck_loader.cpp
-    src/decklistmodel.cpp
-    src/deckstats_interface.cpp
-    src/deckview.cpp
+    src/dlg_creategame.cpp
+    src/dlg_filter_games.cpp
     src/dlg_connect.cpp
     src/dlg_create_token.cpp
-    src/dlg_creategame.cpp
     src/dlg_edit_avatar.cpp
     src/dlg_edit_password.cpp
     src/dlg_edit_tokens.cpp
     src/dlg_edit_user.cpp
-    src/dlg_filter_games.cpp
-    src/dlg_forgotpasswordchallenge.cpp
     src/dlg_forgotpasswordrequest.cpp
     src/dlg_forgotpasswordreset.cpp
-    src/dlg_load_deck_from_clipboard.cpp
-    src/dlg_load_remote_deck.cpp
-    src/dlg_manage_sets.cpp
+    src/dlg_forgotpasswordchallenge.cpp
     src/dlg_register.cpp
-    src/dlg_settings.cpp
     src/dlg_tip_of_the_day.cpp
+    src/tip_of_the_day.cpp
     src/dlg_update.cpp
     src/dlg_viewlog.cpp
-    src/filter_string.cpp
-    src/filterbuilder.cpp
-    src/filtertree.cpp
-    src/filtertreemodel.cpp
-    src/gamescene.cpp
-    src/gameselector.cpp
-    src/gamesmodel.cpp
-    src/gameview.cpp
-    src/gettextwithmax.cpp
-    src/handcounter.cpp
-    src/handle_public_servers.cpp
-    src/handzone.cpp
-    src/keysignals.cpp
-    src/lineeditcompleter.cpp
-    src/localclient.cpp
-    src/localserver.cpp
-    src/localserverinterface.cpp
-    src/logger.cpp
-    src/main.cpp
-    src/messagelogwidget.cpp
-    src/pending_command.cpp
-    src/phase.cpp
-    src/phasestoolbar.cpp
-    src/pictureloader.cpp
-    src/pilezone.cpp
-    src/pixmapgenerator.cpp
-    src/player.cpp
-    src/playerlistwidget.cpp
-    src/playertarget.cpp
-    src/releasechannel.cpp
+    src/abstractclient.cpp
     src/remoteclient.cpp
+    src/main.cpp
+    src/window_main.cpp
+    src/gamesmodel.cpp
+    src/player.cpp
+    src/playertarget.cpp
+    src/cardzone.cpp
+    src/selectzone.cpp
+    src/cardlist.cpp
+    src/abstractcarditem.cpp
+    src/carditem.cpp
+    src/tablezone.cpp
+    src/handzone.cpp
+    src/handcounter.cpp
+    src/carddatabase.cpp
+    src/keysignals.cpp
+    src/gameview.cpp
+    src/gameselector.cpp
+    src/decklistmodel.cpp
+    src/deck_loader.cpp
+    src/dlg_load_deck_from_clipboard.cpp
+    src/dlg_load_remote_deck.cpp
+    src/cardinfowidget.cpp
+    src/cardframe.cpp
+    src/cardinfopicture.cpp
+    src/cardinfotext.cpp
+    src/filterbuilder.cpp
+    src/cardfilter.cpp
+    src/filtertreemodel.cpp
+    src/filtertree.cpp
+    src/messagelogwidget.cpp
+    src/zoneviewzone.cpp
+    src/zoneviewwidget.cpp
+    src/pilezone.cpp
+    src/stackzone.cpp
+    src/carddragitem.cpp
+    src/carddatabasemodel.cpp
+    src/setsmodel.cpp
+    src/window_sets.cpp
+    src/abstractgraphicsitem.cpp
+    src/abstractcarddragitem.cpp
+    src/dlg_settings.cpp
+    src/phasestoolbar.cpp
+    src/gamescene.cpp
+    src/arrowitem.cpp
+    src/arrowtarget.cpp
+    src/tab.cpp
+    src/tab_server.cpp
+    src/tab_room.cpp
+    src/tab_message.cpp
+    src/tab_game.cpp
+    src/tab_deck_storage.cpp
+    src/tab_replays.cpp
+    src/tab_supervisor.cpp
+    src/tab_admin.cpp
+    src/tab_userlists.cpp
+    src/tab_deck_editor.cpp
+    src/tab_logs.cpp
+    src/replay_timeline_widget.cpp
+    src/deckstats_interface.cpp
+    src/tappedout_interface.cpp
+    src/chatview/chatview.cpp
+    src/chatview/userlistProxy.h
+    src/userlist.cpp
+    src/userinfobox.cpp
+    src/user_context_menu.cpp
     src/remotedecklist_treewidget.cpp
     src/remotereplaylist_treewidget.cpp
-    src/replay_timeline_widget.cpp
-    src/selectzone.cpp
+    src/deckview.cpp
+    src/playerlistwidget.cpp
+    src/pixmapgenerator.cpp
+    src/settingscache.cpp
+    src/thememanager.cpp
+    src/localserver.cpp
+    src/localserverinterface.cpp
+    src/localclient.cpp
+    src/soundengine.cpp
+    src/pending_command.cpp
+    src/pictureloader.cpp
+    src/shortcutssettings.cpp
     src/sequenceEdit/sequenceedit.cpp
-    src/setsmodel.cpp
+    src/sequenceEdit/shortcutstab.cpp
+    src/lineeditcompleter.cpp
+    src/settings/settingsmanager.cpp
     src/settings/carddatabasesettings.cpp
-    src/settings/downloadsettings.cpp
+    src/settings/serverssettings.cpp
+    src/settings/messagesettings.cpp
     src/settings/gamefilterssettings.cpp
     src/settings/layoutssettings.cpp
-    src/settings/messagesettings.cpp
-    src/settings/serverssettings.cpp
-    src/settings/settingsmanager.cpp
-    src/settingscache.cpp
-    src/shortcutssettings.cpp
-    src/soundengine.cpp
-    src/spoilerbackgroundupdater.cpp
-    src/stackzone.cpp
-    src/tab.cpp
-    src/tab_account.cpp
-    src/tab_admin.cpp
-    src/tab_deck_editor.cpp
-    src/tab_deck_storage.cpp
-    src/tab_game.cpp
-    src/tab_logs.cpp
-    src/tab_message.cpp
-    src/tab_replays.cpp
-    src/tab_room.cpp
-    src/tab_server.cpp
-    src/tab_supervisor.cpp
-    src/tablezone.cpp
-    src/tappedout_interface.cpp
-    src/thememanager.cpp
-    src/tip_of_the_day.cpp
-    src/translatecountername.cpp
+    src/settings/downloadsettings.cpp
     src/update_downloader.cpp
-    src/user_context_menu.cpp
+    src/logger.cpp
+    src/releasechannel.cpp
     src/userconnection_information.cpp
-    src/userinfobox.cpp
-    src/userlist.cpp
-    src/window_main.cpp
-    src/zoneviewwidget.cpp
-    src/zoneviewzone.cpp
+    src/spoilerbackgroundupdater.cpp
+    src/handle_public_servers.cpp
+    src/carddbparser/carddatabaseparser.cpp
+    src/carddbparser/cockatricexml3.cpp
+    src/carddbparser/cockatricexml4.cpp
     ${VERSION_STRING_CPP}
-)
+    )
 
 add_subdirectory(sounds)
 add_subdirectory(themes)
 
 set(cockatrice_RESOURCES cockatrice.qrc)
 
-if(UPDATE_TRANSLATIONS)
-  file(GLOB_RECURSE translate_cockatrice_SRCS ${CMAKE_SOURCE_DIR}/cockatrice/src/*.cpp
-       ${CMAKE_SOURCE_DIR}/cockatrice/src/*.h
-  )
-  file(GLOB_RECURSE translate_common_SRCS ${CMAKE_SOURCE_DIR}/common/*.cpp ${CMAKE_SOURCE_DIR}/common/*.h)
-  set(translate_SRCS ${translate_cockatrice_SRCS} ${translate_common_SRCS})
-  set(cockatrice_TS "${CMAKE_CURRENT_SOURCE_DIR}/cockatrice_en@source.ts")
-else()
-  file(GLOB cockatrice_TS "${CMAKE_CURRENT_SOURCE_DIR}/translations/*.ts")
-endif(UPDATE_TRANSLATIONS)
+IF(UPDATE_TRANSLATIONS)
+    FILE(GLOB_RECURSE translate_cockatrice_SRCS ${CMAKE_SOURCE_DIR}/cockatrice/src/*.cpp ${CMAKE_SOURCE_DIR}/cockatrice/src/*.h)
+    FILE(GLOB_RECURSE translate_common_SRCS ${CMAKE_SOURCE_DIR}/common/*.cpp ${CMAKE_SOURCE_DIR}/common/*.h)
+    SET(translate_SRCS ${translate_cockatrice_SRCS} ${translate_common_SRCS})
+    SET(cockatrice_TS "${CMAKE_CURRENT_SOURCE_DIR}/translations/cockatrice_en.ts")
+ELSE()
+    FILE(GLOB cockatrice_TS "${CMAKE_CURRENT_SOURCE_DIR}/translations/*.ts")
+ENDIF(UPDATE_TRANSLATIONS)
 
 if(WIN32)
-  set(cockatrice_SOURCES ${cockatrice_SOURCES} cockatrice.rc)
+    set(cockatrice_SOURCES ${cockatrice_SOURCES} cockatrice.rc)
 endif(WIN32)
 
 if(APPLE)
-  set(MACOSX_BUNDLE_ICON_FILE appicon.icns)
-  set_source_files_properties(
-    ${CMAKE_CURRENT_SOURCE_DIR}/resources/appicon.icns PROPERTIES MACOSX_PACKAGE_LOCATION Resources
-  )
-  set(cockatrice_SOURCES ${cockatrice_SOURCES} ${CMAKE_CURRENT_SOURCE_DIR}/resources/appicon.icns)
-endif(APPLE)
+    set(MACOSX_BUNDLE_ICON_FILE appicon.icns)
+    set_source_files_properties(${CMAKE_CURRENT_SOURCE_DIR}/resources/appicon.icns PROPERTIES MACOSX_PACKAGE_LOCATION Resources)
+    set(cockatrice_SOURCES ${cockatrice_SOURCES} ${CMAKE_CURRENT_SOURCE_DIR}/resources/appicon.icns)
+ENDIF(APPLE)
 
-if(Qt6_FOUND)
-  qt6_add_resources(cockatrice_RESOURCES_RCC ${cockatrice_RESOURCES})
-elseif(Qt5_FOUND)
-  qt5_add_resources(cockatrice_RESOURCES_RCC ${cockatrice_RESOURCES})
+# Qt5
+find_package(Qt5 COMPONENTS Concurrent Multimedia Network PrintSupport Svg WebSockets Widgets REQUIRED)
+set(COCKATRICE_QT_MODULES Qt5::Concurrent Qt5::Multimedia Qt5::Network Qt5::PrintSupport Qt5::Svg Qt5::Widgets Qt5::WebSockets)
+
+# Qt5LinguistTools
+find_package(Qt5LinguistTools)
+if(Qt5LinguistTools_FOUND)
+    list(APPEND COCKATRICE_LIBS Qt5::LinguistTools)
+
+    if(NOT Qt5_LRELEASE_EXECUTABLE)
+        MESSAGE(WARNING "Qt's lrelease not found.")
+    endif()
+
+    if(UPDATE_TRANSLATIONS)
+        if(NOT Qt5_LUPDATE_EXECUTABLE)
+            MESSAGE(WARNING "Qt's lupdate not found.")
+        endif()
+        QT5_CREATE_TRANSLATION(cockatrice_QM ${translate_SRCS} ${cockatrice_TS})
+    else()
+        QT5_ADD_TRANSLATION(cockatrice_QM ${cockatrice_TS})
+    endif()
 endif()
 
+QT5_ADD_RESOURCES(cockatrice_RESOURCES_RCC ${cockatrice_RESOURCES})
+
 # Declare path variables
-set(ICONDIR
-    share/icons
-    CACHE STRING "icon dir"
-)
-set(DESKTOPDIR
-    share/applications
-    CACHE STRING "desktop file destination"
-)
+set(ICONDIR share/icons CACHE STRING "icon dir")
+set(DESKTOPDIR share/applications CACHE STRING "desktop file destination")
 
 # Include directories
-include_directories(../common)
-include_directories(${PROTOBUF_INCLUDE_DIR})
-include_directories(${CMAKE_BINARY_DIR}/common)
-include_directories(${CMAKE_CURRENT_BINARY_DIR})
+INCLUDE_DIRECTORIES(../common)
+INCLUDE_DIRECTORIES(${PROTOBUF_INCLUDE_DIR})
+INCLUDE_DIRECTORIES(${CMAKE_BINARY_DIR}/common)
+INCLUDE_DIRECTORIES(${CMAKE_CURRENT_BINARY_DIR})
 
-set(COCKATRICE_MAC_QM_INSTALL_DIR "cockatrice.app/Contents/Resources/translations")
-set(COCKATRICE_UNIX_QM_INSTALL_DIR "share/cockatrice/translations")
-set(COCKATRICE_WIN32_QM_INSTALL_DIR "translations")
+# Build cockatrice binary and link it
+ADD_EXECUTABLE(cockatrice WIN32 MACOSX_BUNDLE ${cockatrice_SOURCES} ${cockatrice_QM} ${cockatrice_RESOURCES_RCC} ${cockatrice_MOC_SRCS})
 
-if(Qt6_FOUND)
-  qt6_add_executable(
-    cockatrice
-    WIN32
-    MACOSX_BUNDLE
-    ${cockatrice_SOURCES}
-    ${cockatrice_RESOURCES_RCC}
-    ${cockatrice_MOC_SRCS}
-    MANUAL_FINALIZATION
-  )
-elseif(Qt5_FOUND)
-  # Qt5 Translations need to be linked at executable creation time
-  if(Qt5LinguistTools_FOUND)
-    if(UPDATE_TRANSLATIONS)
-      qt5_create_translation(cockatrice_QM ${translate_SRCS} ${cockatrice_TS})
-    else()
-      qt5_add_translation(cockatrice_QM ${cockatrice_TS})
-    endif()
-  endif()
-  add_executable(
-    cockatrice WIN32 MACOSX_BUNDLE ${cockatrice_MOC_SRCS} ${cockatrice_QM} ${cockatrice_RESOURCES_RCC}
-                                   ${cockatrice_SOURCES}
-  )
-  if(UNIX)
-    if(APPLE)
-      install(FILES ${cockatrice_QM} DESTINATION ${COCKATRICE_MAC_QM_INSTALL_DIR})
-    else()
-      install(FILES ${cockatrice_QM} DESTINATION ${COCKATRICE_UNIX_QM_INSTALL_DIR})
-    endif()
-  elseif(WIN32)
-    install(FILES ${cockatrice_QM} DESTINATION ${COCKATRICE_WIN32_QM_INSTALL_DIR})
-  endif()
-endif()
-
-if(Qt5_FOUND)
-  target_link_libraries(cockatrice cockatrice_common ${COCKATRICE_QT_MODULES})
-else()
-  target_link_libraries(cockatrice PUBLIC cockatrice_common ${COCKATRICE_QT_MODULES})
-endif()
+TARGET_LINK_LIBRARIES(cockatrice cockatrice_common ${COCKATRICE_QT_MODULES})
 
 if(UNIX)
-  if(APPLE)
-    set(MACOSX_BUNDLE_INFO_STRING "${PROJECT_NAME}")
-    set(MACOSX_BUNDLE_GUI_IDENTIFIER "com.cockatrice.${PROJECT_NAME}")
-    set(MACOSX_BUNDLE_LONG_VERSION_STRING "${PROJECT_NAME}-${PROJECT_VERSION}")
-    set(MACOSX_BUNDLE_BUNDLE_NAME "${PROJECT_NAME}")
-    set(MACOSX_BUNDLE_SHORT_VERSION_STRING ${PROJECT_VERSION})
-    set(MACOSX_BUNDLE_BUNDLE_VERSION ${PROJECT_VERSION})
+    if(APPLE)
+        set(MACOSX_BUNDLE_INFO_STRING "${PROJECT_NAME}")
+        set(MACOSX_BUNDLE_GUI_IDENTIFIER "com.cockatrice.${PROJECT_NAME}")
+        set(MACOSX_BUNDLE_LONG_VERSION_STRING "${PROJECT_NAME}-${PROJECT_VERSION}")
+        set(MACOSX_BUNDLE_BUNDLE_NAME "${PROJECT_NAME}")
+        set(MACOSX_BUNDLE_SHORT_VERSION_STRING ${PROJECT_VERSION})
+        set(MACOSX_BUNDLE_BUNDLE_VERSION ${PROJECT_VERSION})
 
-    set_target_properties(cockatrice PROPERTIES MACOSX_BUNDLE_INFO_PLIST ${CMAKE_SOURCE_DIR}/cmake/Info.plist)
+        set_target_properties(cockatrice PROPERTIES MACOSX_BUNDLE_INFO_PLIST ${CMAKE_SOURCE_DIR}/cmake/Info.plist)
 
-    install(TARGETS cockatrice BUNDLE DESTINATION ./)
-  else()
-    # Assume linux
-    install(TARGETS cockatrice RUNTIME DESTINATION bin/)
-    install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/resources/cockatrice.png DESTINATION ${ICONDIR}/hicolor/48x48/apps)
-    install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/resources/cockatrice.svg DESTINATION ${ICONDIR}/hicolor/scalable/apps)
-    install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/cockatrice.desktop DESTINATION ${DESKTOPDIR})
-  endif()
+        INSTALL(TARGETS cockatrice BUNDLE DESTINATION ./)
+        INSTALL(FILES ${cockatrice_QM} DESTINATION ./cockatrice.app/Contents/Resources/translations)
+    else()
+        # Assume linux
+        INSTALL(TARGETS cockatrice RUNTIME DESTINATION bin/)
+        INSTALL(FILES ${CMAKE_CURRENT_SOURCE_DIR}/resources/cockatrice.png DESTINATION ${ICONDIR}/hicolor/48x48/apps)
+        INSTALL(FILES ${CMAKE_CURRENT_SOURCE_DIR}/resources/cockatrice.svg DESTINATION ${ICONDIR}/hicolor/scalable/apps)
+        INSTALL(FILES ${CMAKE_CURRENT_SOURCE_DIR}/cockatrice.desktop DESTINATION ${DESKTOPDIR})
+        INSTALL(FILES ${cockatrice_QM} DESTINATION share/cockatrice/translations)
+    endif()
 elseif(WIN32)
-  install(TARGETS cockatrice RUNTIME DESTINATION ./)
+        INSTALL(TARGETS cockatrice RUNTIME DESTINATION ./)
+        INSTALL(FILES ${cockatrice_QM} DESTINATION ./translations)
 endif()
 
 if(APPLE)
-  # these needs to be relative to CMAKE_INSTALL_PREFIX
-  set(plugin_dest_dir cockatrice.app/Contents/Plugins)
-  set(qtconf_dest_dir cockatrice.app/Contents/Resources)
+    # these needs to be relative to CMAKE_INSTALL_PREFIX
+    set(plugin_dest_dir cockatrice.app/Contents/Plugins)
+    set(qtconf_dest_dir cockatrice.app/Contents/Resources)
+    get_filename_component(QT_LIBRARY_DIR "${QT_LIBRARY_DIR}/.." ABSOLUTE)
 
-  # Qt plugins: audio (Qt5), iconengines, imageformats, platforms, printsupport (Qt5), styles, tls (Qt6)
-  install(
-    DIRECTORY "${QT_PLUGINS_DIR}/"
-    DESTINATION ${plugin_dest_dir}
-    COMPONENT Runtime
-    FILES_MATCHING
-    PATTERN "*.dSYM" EXCLUDE
-    PATTERN "*_debug.dylib" EXCLUDE
-    PATTERN "audio/*.dylib"
-    PATTERN "iconengines/*.dylib"
-    PATTERN "imageformats/*.dylib"
-    PATTERN "platforms/*.dylib"
-    PATTERN "printsupport/*.dylib"
-    PATTERN "styles/*.dylib"
-    PATTERN "tls/*.dylib"
-  )
+    # qt5 plugins: audio, iconengines, imageformats, platforms, printsupport
+    install(DIRECTORY "${QT_PLUGINS_DIR}/" DESTINATION ${plugin_dest_dir} COMPONENT Runtime
+        FILES_MATCHING
+        PATTERN "*.dSYM" EXCLUDE
+        PATTERN "*_debug.dylib" EXCLUDE
+        PATTERN "audio/*.dylib"
+        PATTERN "iconengines/*.dylib"
+        PATTERN "imageformats/*.dylib"
+        PATTERN "platforms/*.dylib"
+        PATTERN "printsupport/*.dylib"
+        PATTERN "styles/*.dylib"
+    )
 
-  install(
-    CODE "
+    install(CODE "
         file(WRITE \"\${CMAKE_INSTALL_PREFIX}/${qtconf_dest_dir}/qt.conf\" \"[Paths]
 Plugins = Plugins
 Translations = Resources/translations
 Data = Resources\")
-    "
-    COMPONENT Runtime
-  )
+    " COMPONENT Runtime)
 
-  install(
-    CODE "
+    install(CODE "
         file(GLOB_RECURSE QTPLUGINS
             \"\${CMAKE_INSTALL_PREFIX}/${plugin_dest_dir}/*.dylib\")
         set(BU_CHMOD_BUNDLE_ITEMS ON)
         include(BundleUtilities)
         fixup_bundle(\"\${CMAKE_INSTALL_PREFIX}/cockatrice.app\" \"\${QTPLUGINS}\" \"${QT_LIBRARY_DIR}\")
-        "
-    COMPONENT Runtime
-  )
+        " COMPONENT Runtime)
 endif()
 
 if(WIN32)
-  # these needs to be relative to CMAKE_INSTALL_PREFIX
-  set(plugin_dest_dir Plugins)
-  set(qtconf_dest_dir .)
+    # these needs to be relative to CMAKE_INSTALL_PREFIX
+    set(plugin_dest_dir Plugins)
+    set(qtconf_dest_dir .)
 
-  install(
-    DIRECTORY "${CMAKE_BINARY_DIR}/${PROJECT_NAME}/${CMAKE_BUILD_TYPE}/"
-    DESTINATION ./
-    FILES_MATCHING
-    PATTERN "*.dll"
-  )
+    install(DIRECTORY "${CMAKE_BINARY_DIR}/${PROJECT_NAME}/${CMAKE_BUILD_TYPE}/" DESTINATION ./ FILES_MATCHING PATTERN "*.dll")
 
-  # Qt plugins: audio (Qt5), iconengines, imageformats, platforms, printsupport (Qt5), styles, tls (Qt6)
-  install(
-    DIRECTORY "${QT_PLUGINS_DIR}/"
-    DESTINATION ${plugin_dest_dir}
-    COMPONENT Runtime
-    FILES_MATCHING
-    PATTERN "audio/qtaudio_wasapi.dll"
-    PATTERN "audio/qtaudio_windows.dll"
-    PATTERN "iconengines/qsvgicon.dll"
-    PATTERN "imageformats/qgif.dll"
-    PATTERN "imageformats/qicns.dll"
-    PATTERN "imageformats/qico.dll"
-    PATTERN "imageformats/qjpeg.dll"
-    PATTERN "imageformats/qsvg.dll"
-    PATTERN "imageformats/qtga.dll"
-    PATTERN "imageformats/qtiff.dll"
-    PATTERN "imageformats/qwbmp.dll"
-    PATTERN "imageformats/qwebp.dll"
-    PATTERN "platforms/qdirect2d.dll"
-    PATTERN "platforms/qminimal.dll"
-    PATTERN "platforms/qoffscreen.dll"
-    PATTERN "platforms/qwindows.dll"
-    PATTERN "printsupport/windowsprintersupport.dll"
-    PATTERN "styles/qcertonlybackend.dll"
-    PATTERN "styles/qopensslbackend.dll"
-    PATTERN "styles/qschannelbackend.dll"
-    PATTERN "styles/qwindowsvistastyle.dll"
-    PATTERN "tls/qcertonlybackend.dll"
-    PATTERN "tls/qopensslbackend.dll"
-    PATTERN "tls/qschannelbackend.dll"
-  )
+    # qt5 plugins: audio, iconengines, imageformats, platforms, printsupport
+    install(DIRECTORY "${QT_PLUGINS_DIR}/" DESTINATION ${plugin_dest_dir} COMPONENT Runtime
+        FILES_MATCHING REGEX "(audio|iconengines|imageformats|platforms|printsupport)/.*[^d]\\.dll")
 
-  install(
-    CODE "
+    install(CODE "
         file(WRITE \"\${CMAKE_INSTALL_PREFIX}/${qtconf_dest_dir}/qt.conf\" \"[Paths]
 Plugins = Plugins
 Translations = Resources/translations
 Data = Resources\")
-    "
-    COMPONENT Runtime
-  )
+    " COMPONENT Runtime)
 
-  install(
-    CODE "
+    install(CODE "
         file(GLOB_RECURSE QTPLUGINS
             \"\${CMAKE_INSTALL_PREFIX}/${plugin_dest_dir}/*.dll\")
         set(BU_CHMOD_BUNDLE_ITEMS ON)
         include(BundleUtilities)
         fixup_bundle(\"\${CMAKE_INSTALL_PREFIX}/Cockatrice.exe\" \"\${QTPLUGINS}\" \"${QT_LIBRARY_DIR}\")
-        "
-    COMPONENT Runtime
-  )
+        " COMPONENT Runtime)
 
-  if(WIN32SSLRUNTIME_FOUND)
-    install(FILES ${WIN32SSLRUNTIME_LIBRARIES} DESTINATION ./)
-  endif()
-endif()
-
-if(Qt6_FOUND AND Qt6LinguistTools_FOUND)
-  #Qt6 Translations happen after the executable is built up
-  if(UPDATE_TRANSLATIONS)
-    qt6_add_translations(
-      cockatrice
-      TS_FILES
-      ${cockatrice_TS}
-      SOURCES
-      ${translate_SRCS}
-      QM_FILES_OUTPUT_VARIABLE
-      cockatrice_QM
-    )
-  else()
-    qt6_add_translations(cockatrice TS_FILES ${cockatrice_TS} QM_FILES_OUTPUT_VARIABLE cockatrice_QM)
-  endif()
-
-  if(UNIX)
-    if(APPLE)
-      install(FILES ${cockatrice_QM} DESTINATION ${COCKATRICE_MAC_QM_INSTALL_DIR})
-    else()
-      install(FILES ${cockatrice_QM} DESTINATION ${COCKATRICE_UNIX_QM_INSTALL_DIR})
+    if(WIN32SSLRUNTIME_FOUND)
+        install(FILES ${WIN32SSLRUNTIME_LIBRARIES} DESTINATION ./)
     endif()
-  elseif(WIN32)
-    install(FILES ${cockatrice_QM} DESTINATION ${COCKATRICE_WIN32_QM_INSTALL_DIR})
-  endif()
-endif()
-
-if(Qt6_FOUND)
-  qt6_finalize_target(cockatrice)
 endif()

cockatrice/cockatrice.qrc

@@ -18,14 +18,12 @@
         <file>resources/icons/delete.svg</file>
         <file>resources/icons/forgot_password.svg</file>
         <file>resources/icons/increment.svg</file>
-        <file>resources/icons/info.svg</file>
         <file>resources/icons/lock.svg</file>
         <file>resources/icons/not_ready_start.svg</file>
         <file>resources/icons/pencil.svg</file>
         <file>resources/icons/player.svg</file>
         <file>resources/icons/ready_start.svg</file>
         <file>resources/icons/remove_row.svg</file>
-        <file>resources/icons/scales.svg</file>
         <file>resources/icons/search.svg</file>
         <file>resources/icons/settings.svg</file>
         <file>resources/icons/spectator.svg</file>
@@ -126,7 +124,6 @@
         <file>resources/countries/er.svg</file>
         <file>resources/countries/es.svg</file>
         <file>resources/countries/et.svg</file>
-        <file>resources/countries/eu.svg</file>
         <file>resources/countries/fi.svg</file>
         <file>resources/countries/fj.svg</file>
         <file>resources/countries/fk.svg</file>
@@ -302,13 +299,16 @@
         <file>resources/countries/vu.svg</file>
         <file>resources/countries/wf.svg</file>
         <file>resources/countries/ws.svg</file>
-        <file>resources/countries/xk.svg</file>
         <file>resources/countries/ye.svg</file>
         <file>resources/countries/yt.svg</file>
         <file>resources/countries/za.svg</file>
         <file>resources/countries/zm.svg</file>
         <file>resources/countries/zw.svg</file>
 
+        <file>resources/genders/male.svg</file>
+        <file>resources/genders/female.svg</file>
+        <file>resources/genders/unknown.svg</file>
+
         <file>resources/phases/untap.svg</file>
         <file>resources/phases/upkeep.svg</file>
         <file>resources/phases/draw.svg</file>
@@ -345,6 +345,7 @@
         <file>resources/userlevels/admin_vip_buddy.svg</file>
 
         <!-- ADD TIP OF THE DAY IMAGES HERE -->
+        <file>resources/tips/tips_of_the_day.xml</file>
         <file>resources/tips/images/accounts_tab.png</file>
         <file>resources/tips/images/arrows.png</file>
         <file>resources/tips/images/cockatrice_register.png</file>
@@ -355,12 +356,8 @@
         <file>resources/tips/images/filter_games.png</file>
         <file>resources/tips/images/github_logo.png</file>
         <file>resources/tips/images/gitter.png</file>
-        <file>resources/tips/images/setpt.png</file>
-        <file>resources/tips/images/shortcuts.png</file>
         <file>resources/tips/images/themes.png</file>
         <file>resources/tips/images/tip_of_the_day.png</file>
-        <file>resources/tips/tips_of_the_day.xml</file>
 
-        <file>resources/help/search.md</file>
     </qresource>
 </RCC>

cockatrice/resources/genders/female.svg

@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!-- Created with Inkscape (http://www.inkscape.org/) -->
+<svg
+   xmlns:svg="http://www.w3.org/2000/svg"
+   xmlns="http://www.w3.org/2000/svg"
+   version="1.0"
+   width="75"
+   height="75"
+   id="svg34864">
+  <defs
+     id="defs34866" />
+  <g
+     transform="translate(-348.7552,-478.0905)"
+     id="layer1">
+    <g
+       transform="matrix(1.071197,0,0,1.075147,-13.30677,-36.99488)"
+       id="g3773">
+      <path
+         d="M 176 33 A 11 11 0 1 1  154,33 A 11 11 0 1 1  176 33 z"
+         transform="matrix(1.540096,0,0,1.5384,118.8893,454.0543)"
+         style="color:black;fill:none;fill-opacity:1;fill-rule:evenodd;stroke:black;stroke-width:3;stroke-linecap:butt;stroke-linejoin:miter;marker:none;marker-start:none;marker-mid:none;marker-end:none;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;visibility:visible;display:inline;overflow:visible"
+         id="path3939" />
+      <path
+         d="M 373.00525,521.74399 L 373.00525,543.28159"
+         style="fill:none;fill-opacity:0.75;fill-rule:evenodd;stroke:black;stroke-width:4.61774349;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
+         id="path3941" />
+      <path
+         d="M 363.76467,534.05119 L 382.24582,534.05119"
+         style="fill:none;fill-opacity:0.75;fill-rule:evenodd;stroke:black;stroke-width:4.61774349;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
+         id="path4816" />
+    </g>
+  </g>
+</svg>

cockatrice/resources/genders/male.svg

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!-- Created with Inkscape (http://www.inkscape.org/) -->
+<svg xmlns:svg="http://www.w3.org/2000/svg" xmlns="http://www.w3.org/2000/svg" version="1.0" width="75" height="75" id="svg34864">
+  <defs id="defs34866"/>
+  <g transform="translate(-348.755, -478.091)" id="layer1">
+    <g transform="matrix(1.94812, 0, 0, 1.93731, -342.43, -460.01)" id="g1872">
+      <path d="M 387.95009,489.60348 L 378.66214,498.89143" style="opacity: 1; color: black; fill: none; fill-opacity: 0.75; fill-rule: evenodd; stroke: black; stroke-width: 3; stroke-linecap: butt; stroke-linejoin: miter; marker: none; stroke-miterlimit: 4; stroke-dasharray: none; stroke-dashoffset: 0pt; stroke-opacity: 1; visibility: visible; display: inline; overflow: visible;" id="path26867"/>
+      <path d="M 49.396475 36.70454 A 15.623922 16.319134 0 1 1  18.14863,36.70454 A 15.623922 16.319134 0 1 1  49.396475 36.70454 z" transform="matrix(0.48802, 0.48802, -0.467594, 0.467594, 371.609, 473.136)" style="opacity: 1; color: black; fill: none; fill-opacity: 1; fill-rule: evenodd; stroke: black; stroke-width: 4.44072; stroke-linecap: butt; stroke-linejoin: miter; marker: none; stroke-miterlimit: 4; stroke-dasharray: none; stroke-dashoffset: 0pt; stroke-opacity: 1; visibility: visible; display: inline; overflow: visible;" id="path26871"/>
+      <path d="M 379.92823,489.70212 C 387.842,489.70212 387.842,489.70212 387.842,489.70212 L 387.842,497.61589" style="fill: none; fill-rule: evenodd; stroke: black; stroke-width: 3; stroke-linecap: butt; stroke-linejoin: miter; stroke-miterlimit: 4; stroke-dasharray: none; stroke-opacity: 1;" id="path27759"/>
+    </g>
+  </g>
+</svg>

cockatrice/resources/genders/unknown.svg

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!-- Intersexual/Transgendered symbol by Gregory Maxwell. Copyright 2005. GFDL-1.2 only -->
+<svg
+   xmlns="http://www.w3.org/2000/svg"
+   version="1.1"
+   width="210"
+   height="280">
+  <path d="M 188,38 v 20 l 14,-8 v -42 h -42 l -8,14 h 20 l -37,37 a 79,79 0 1,0 -59,141 v 22 h -27 v 23 h 27 v 27 h 23 v -27 h 27 v -23 h -27 v -22 a 79,79 0 0,0 52,-125 zm -100,27 a 57,57 0 1,1 0,114 a 57,57 0 1,1 0,-114 z"/>
+<!-- 88,65 // -63,-10 -->
+</svg>

cockatrice/resources/help/search.md

@@ -1,61 +0,0 @@
-## Syntax Help
------
-The search bar recognizes a set of special commands similar to some other card databases. Here is a list with examples. Each entry can be clicked to test the query and has a small explanation. Note that all searches are case insensitive.
-<dl>
-<dt>Name:</dt>
-<dd>[birds of paradise](#birds of paradise) <small>(Any card name containing the words birds, of, and paradise)</small></dd>
-<dd>["birds of paradise"](#%22birds of paradise%22) <small>(Any card name containing the exact phrase "birds of paradise")</small></dd>
-
-<dt>Rules Text (<u>O</u>racle):</dt>
-<dd>[o:flying](#o:flying) <small>(Any card text that has the word flying)</small></dd>
-<dd>[o:"first strike"](#o:%22first strike%22) <small>(Any card text that has the exact phrase "first strike")</small></dd>
-<dd>[o:"{T}" o:"add one mana of any color"](#o:%22{T}%22 o:%22add one mana of any color%22) <small>(Any card text that has a tap symbol and the phrase "add one mana of any color")</small></dd>
-
-<dt><u>T</u>ypes:</dt>
-<dd>[t:angel](#t:angel) <small>(Any card with the type angel)</small></dd>
-<dd>[t:angel t:legendary](#t:angel t:legendary) <small>(Any angel that's also legendary)</small></dd>
-<dd>[t:basic](#t:basic) <small>(Any card with the type basic)</small></dd>
-<dd>[t:arcane t:instant](#t:arcane t:instant) <small>(Any card with the types arcane and instant)</small></dd>
-
-<dt><u>C</u>olors:</dt>
-<dd>[c:w](#c:w) <small>(Any card that is white)</small></dd>
-<dd>[c:wu](#c:wu) <small>(Any card that is white or blue)</small></dd>
-<dd>[c:wum](#c:wum) <small>(Any card that is white or blue, and multicolored)</small></dd>
-<!--
-<dd>[c!w](#c!w) <small>(Cards that are only white)</small></dd>
-<dd>[c!wu](#c!wu) <small>(Cards that are only white or blue, or both)</small></dd>
-<dd>[c!wum](#c!wum) <small>(Cards that are only white and blue, and multicolored)</small></dd>
-<dd>[c=wubrg](#c%3Dwubrg) <small>(Cards that are all five colors)</small></dd>
--->
-<dd>[c:c](#c:c) <small>(Any colorless card)</small></dd>
-<dd>[ci:w](#ci:w) <small>(Any card that has white in it's color identity)</small></dd>
-
-<dt><u>Pow</u>er, <u>Tou</u>ghness, <u>M</u>ana <u>V</u>alue:</dt>
-<dd>[tou:1](#tou:1) <small>(Any card with a toughness of 1)</small></dd>
-<dd>[pow>=8](#pow>=8) <small>(Any card with a power greater than or equal to 8)</small></dd>
-<dd>[mv=7](#mv=7) <small>(Any card with a mana value equal to 7)</small></dd>
-
-<dt><u>R</u>arity:</dt>
-<dd>[r:mythic](#r:mythic) <small>(Any card that has the mythic-rare rarity)</small></dd>
-
-<dt><u>F</u>ormat:</dt>
-<dd>[f:standard](#f:standard) <small>(Any card that can be played in standard)</small></dd>
-<dd>[banned:modern](#banned:modern) <small>(Any card that is banned in modern)</small></dd>
-<dd>[restricted:vintage](#restricted:vintage) <small>(Any card that is restricted in vintage)</small></dd>
-<dd>[legal:pauper](#legal:pauper) <small>(Any card that is legal in pauper)</small></dd>
-
-<dt><u>E</u>dition:</dt>
-<dd>[set:lea](#set:lea) <small>(Cards that appear in Alpha, which has the set code LEA)</small></dd>
-<dd>[e:lea,leb](#e:lea,leb) <small>(Cards that appear in Alpha or Beta)</small></dd>
-<dd><a href="#e:lea,leb -(e:lea e:leb)">e:lea,leb -(e:lea e:leb)</a> <small>(Cards that appear in Alpha or Beta but not in both editions)</small></dd>
-
-<dt>Negate:</dt>
-<dd>[c:wu -c:m](#c:wu -c:m) <small>(Any card that is white or blue, but not multicolored)</small></dd>
-
-<dt>Branching:</dt>
-<dd>[t:sliver or o:changeling](#t:sliver or o:changeling) <small>(Any card that is either a sliver or has changeling)</small></dd>
-
-<dt>Grouping:</dt>
-<dd><a href="#t:angel -(angel or c:w)">t:angel -(angel or c:w)</a> <small>(Any angel that doesn't have angel in its name and isn't white)</small></dd>
-
-</dl>

cockatrice/resources/icons/info.svg

@@ -1,43 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<!-- Created with Inkscape (http://www.inkscape.org/) -->
-
-<svg
-   xmlns:dc="http://purl.org/dc/elements/1.1/"
-   xmlns:cc="http://creativecommons.org/ns#"
-   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
-   xmlns:svg="http://www.w3.org/2000/svg"
-   xmlns="http://www.w3.org/2000/svg"
-   xmlns:xlink="http://www.w3.org/1999/xlink"
-   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
-   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
-   width="100"
-   height="100"
-   id="svg2858"
-   version="1.1"
-   inkscape:version="0.48.5 r10040"
-   sodipodi:docname="info.svg">
-  <g
-     inkscape:groupmode="layer"
-     id="layer2"
-     inkscape:label="Triangle"
-     style="display:inline">
-    <path
-       sodipodi:type="arc"
-       style="fill:#aaaaaa;fill-opacity:1;fill-rule:nonzero;stroke:none;display:inline"
-       id="path3758-1"
-       sodipodi:cx="53.900002"
-       sodipodi:cy="78.5"
-       sodipodi:rx="46.5"
-       sodipodi:ry="46.5"
-       d="M 100.4,78.5 A 46.5,46.5 0 1 1 7.4000015,78.5 46.5,46.5 0 1 1 100.4,78.5 z"
-       transform="matrix(1.05866,0,0,1.05866,-7.0617752,-32.704809)" />
-    <g
-       style="font-size:133.49534607px;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;line-height:125%;letter-spacing:0px;word-spacing:0px;fill:#ffffff;fill-opacity:1;stroke:#ffffff;stroke-width:1.06498075;stroke-opacity:1;font-family:'Magic:the Gathering';-inkscape-font-specification:'Magic:the Gathering'"
-       id="text3759">
-      <path
-         d="m 46.854005,16.085692 c 0.977733,-2.411704 1.683885,-4.193378 2.118456,-5.345028 0.369355,-1.1514901 0.771318,-1.9988718 1.205891,-2.5421482 0.456264,-0.4344718 1.347101,-0.825571 2.672514,-1.1732989 1.23846,-0.2823765 2.705082,-0.4670623 4.399871,-0.5540578 0.369346,8.46e-5 0.727854,8.46e-5 1.075524,0 1.694737,8.46e-5 2.672485,0.5758696 2.933248,1.7273567 -3e-5,0.1956326 -3e-5,0.3803183 0,0.5540579 -3e-5,1.3254743 -0.662726,2.9224633 -1.98809,4.7909703 -1.520969,2.238035 -3.43301,4.24785 -5.736128,6.029453 -2.32489,1.760018 -4.551983,2.781222 -6.681286,3.063614 -1.260224,-0.543125 -1.977239,-1.075454 -2.151048,-1.59699 -1.3e-5,-0.08684 -1.3e-5,-0.184616 0,-0.293325 -1.3e-5,-0.434484 0.228128,-1.010269 0.684424,-1.727357 0.521453,-0.890765 1.010327,-1.868513 1.466624,-2.933247 z M 31.372977,37.856906 c 2.650785,-0.716962 6.159814,-1.651255 10.527099,-2.802881 4.280354,-1.173242 7.398284,-1.803346 9.3538,-1.890315 0.08689,5.8e-5 0.173803,5.8e-5 0.260733,0 1.06464,5.8e-5 1.82511,0.358566 2.281415,1.075524 0.260711,0.630161 0.391077,1.520998 0.391099,2.672514 -2.2e-5,0.260787 -2.2e-5,0.532384 0,0.814791 -0.173844,1.586178 -0.260755,2.781204 -0.260733,3.58508 l 0,39.533656 c 1.238459,1e-5 2.976678,-0.673549 5.214662,-2.020681 1.673009,-0.977736 2.868034,-1.46661 3.58508,-1.466624 0.173791,1.4e-5 0.304158,0.04347 0.3911,0.130367 0.543162,0.369385 0.814759,0.771348 0.814791,1.20589 -3.2e-5,1.151583 -1.868617,2.66166 -5.605762,4.530238 -1.238507,0.717023 -3.063637,1.922912 -5.475395,3.617671 -2.49871,1.781679 -4.769259,3.204846 -6.811652,4.269505 -0.347658,0.347644 -0.923443,0.662696 -1.727357,0.945157 -0.260745,0.08691 -0.532342,0.130366 -0.814791,0.130367 -0.521477,-10e-7 -1.010351,-0.271598 -1.466623,-0.814791 C 41.856611,91.111641 41.7697,81.594892 41.76971,62.8221 c -1e-5,-1.955468 -1e-5,-4.008739 0,-6.15982 -1e-5,-2.129283 -0.08692,-4.128235 -0.260734,-5.996861 -0.260742,-1.781634 -0.706161,-3.204801 -1.336257,-4.269504 -0.717023,-1.347075 -1.60786,-2.368279 -2.672514,-3.063614 -1.151576,-0.630057 -2.357465,-1.260161 -3.617672,-1.890315 -1.325394,-0.521416 -2.161911,-1.053746 -2.509556,-1.59699 -0.195549,-0.173771 -0.293324,-0.434504 -0.293324,-0.7822 -0.08691,-0.369319 0.01086,-0.771282 0.293324,-1.20589 z"
-         style=""
-         id="path2993" />
-    </g>
-  </g>
-</svg>

cockatrice/resources/icons/scales.svg

@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="52pt" height="52pt" viewBox="0 0 52 52" version="1.1">
-<g id="surface1">
-<path style=" stroke:none;fill-rule:nonzero;fill:#000000;fill-opacity:1;" d="M 25.605469 0.125 C 25.605469 0.125 23.265625 3.140625 23.265625 4.433594 C 23.265625 5.316406 23.765625 6.070313 24.5 6.464844 C 23.898438 6.65625 23.375 6.992188 22.960938 7.449219 C 22.011719 6.640625 20.628906 5.910156 18.710938 5.910156 C 16.640625 5.910156 14.863281 6.753906 13.355469 7.507813 C 12.601563 7.886719 11.925781 8.25 11.324219 8.496094 C 10.964844 8.09375 10.425781 7.878906 9.847656 7.878906 C 8.75 7.878906 7.878906 8.75 7.878906 9.847656 C 7.878906 10.949219 8.75 11.816406 9.847656 11.816406 C 10.757813 11.816406 11.519531 11.234375 11.757813 10.402344 C 12.578125 10.078125 13.386719 9.648438 14.21875 9.234375 C 15.671875 8.507813 17.179688 7.878906 18.710938 7.878906 C 20.496094 7.878906 21.519531 8.679688 22.097656 9.355469 C 22.074219 9.519531 22.035156 9.6875 22.035156 9.847656 C 22.035156 11.816406 23.636719 13.417969 25.605469 13.417969 C 27.574219 13.417969 29.175781 11.816406 29.175781 9.847656 C 29.175781 9.6875 29.136719 9.519531 29.113281 9.355469 C 29.691406 8.679688 30.714844 7.878906 32.5 7.878906 C 34.03125 7.878906 35.539063 8.507813 36.992188 9.234375 C 37.824219 9.648438 38.632813 10.078125 39.457031 10.402344 C 39.695313 11.234375 40.457031 11.816406 41.363281 11.816406 C 42.464844 11.816406 43.332031 10.949219 43.332031 9.847656 C 43.332031 8.75 42.464844 7.878906 41.363281 7.878906 C 40.785156 7.878906 40.246094 8.09375 39.886719 8.496094 C 39.285156 8.25 38.609375 7.886719 37.855469 7.507813 C 36.347656 6.753906 34.570313 5.910156 32.5 5.910156 C 30.585938 5.910156 29.199219 6.640625 28.253906 7.449219 C 27.835938 6.992188 27.3125 6.65625 26.714844 6.464844 C 27.445313 6.070313 27.945313 5.316406 27.945313 4.433594 C 27.945313 3.140625 25.605469 0.125 25.605469 0.125 Z M 9.539063 13.234375 C 9.25 13.332031 9.023438 13.558594 8.925781 13.847656 L 2.277344 31.515625 L 0 31.515625 C 1.445313 35.578125 5.285156 38.53125 9.847656 38.53125 C 14.410156 38.53125 18.25 35.578125 19.695313 31.515625 L 17.417969 31.515625 L 10.773438 13.847656 C 10.601563 13.402344 10.132813 13.140625 9.664063 13.234375 C 9.625 13.234375 9.578125 13.234375 9.539063 13.234375 Z M 41.054688 13.234375 C 40.761719 13.332031 40.539063 13.558594 40.441406 13.847656 L 33.792969 31.515625 L 31.515625 31.515625 C 32.960938 35.578125 36.800781 38.53125 41.363281 38.53125 C 45.925781 38.53125 49.765625 35.578125 51.210938 31.515625 L 48.933594 31.515625 L 42.285156 13.847656 C 42.117188 13.402344 41.648438 13.140625 41.179688 13.234375 C 41.140625 13.234375 41.09375 13.234375 41.054688 13.234375 Z M 21.914063 15.757813 C 21.914063 17.082031 22.589844 18.242188 23.636719 18.898438 L 23.636719 41.980469 C 21.429688 42.773438 19.796875 44.816406 19.695313 47.273438 L 15.757813 47.273438 C 14.671875 47.273438 13.789063 48.15625 13.789063 49.242188 L 13.789063 51.210938 L 37.425781 51.210938 L 37.425781 49.242188 C 37.425781 48.15625 36.539063 47.273438 35.453125 47.273438 L 31.515625 47.273438 C 31.414063 44.816406 29.785156 42.773438 27.574219 41.980469 L 27.574219 18.898438 C 28.621094 18.242188 29.300781 17.082031 29.300781 15.757813 Z M 9.847656 17.050781 L 15.328125 31.515625 L 4.371094 31.515625 Z M 41.363281 17.050781 L 46.84375 31.515625 L 35.886719 31.515625 Z "/>
-</g>
-</svg>

cockatrice/resources/tips/tips_of_the_day.xml

@@ -63,7 +63,6 @@
             <br>Change Life: CTRL + L
             <br>All shortcuts can be customized via Settings->Shortcuts!
         </text>
-        <image>shortcuts.png</image>
         <date>2018-03-01</date>
     </tip>
     <tip>
@@ -90,10 +89,4 @@
         <image>counter_expression.png</image>
         <date>2019-02-02</date>
     </tip>
-    <tip>
-        <title>Power and Toughness</title>
-        <text>You can add and subtract to a creature's stats.&lt;br&gt;With a card selected, set the power and toughness ( default: ctrl + p ) and enter +3/-1 to increase power by three while decreasing toughness by one.&lt;br&gt;You can also reset it to the original value ( default: ctrl + alt + 0 ).</text>
-        <image>setpt.png</image>
-        <date>2019-03-02</date>
-    </tip>
 </tips>

cockatrice/sounds/CMakeLists.txt

@@ -2,15 +2,18 @@
 #
 # add sounds subfolders
 
-set(defsounds Default Legacy)
+SET(defsounds
+    Default
+    Legacy
+)
 
 if(UNIX)
-  if(APPLE)
-    install(DIRECTORY ${defsounds} DESTINATION Cockatrice.app/Contents/Resources/sounds/)
-  else()
-    # Assume linux
-    install(DIRECTORY ${defsounds} DESTINATION share/cockatrice/sounds/)
-  endif()
+    if(APPLE)
+        INSTALL(DIRECTORY ${defsounds} DESTINATION Cockatrice.app/Contents/Resources/sounds/)
+    else()
+        # Assume linux
+        INSTALL(DIRECTORY ${defsounds} DESTINATION share/cockatrice/sounds/)
+    endif()
 elseif(WIN32)
-  install(DIRECTORY ${defsounds} DESTINATION sounds/)
+    INSTALL(DIRECTORY ${defsounds} DESTINATION sounds/)
 endif()

cockatrice/src/abstractcarddragitem.cpp

@@ -1,7 +1,5 @@
 #include "abstractcarddragitem.h"
-
 #include "carddatabase.h"
-
 #include <QCursor>
 #include <QDebug>
 #include <QGraphicsSceneMouseEvent>
@@ -41,6 +39,7 @@ AbstractCardDragItem::AbstractCardDragItem(AbstractCardItem *_item,
 
 AbstractCardDragItem::~AbstractCardDragItem()
 {
+    qDebug("CardDragItem destructor");
     for (int i = 0; i < childDrags.size(); i++)
         delete childDrags[i];
 }

cockatrice/src/abstractcarditem.cpp

@@ -1,16 +1,18 @@
-#include "abstractcarditem.h"
-
-#include "carddatabase.h"
-#include "gamescene.h"
-#include "main.h"
-#include "pictureloader.h"
-#include "settingscache.h"
-
 #include <QCursor>
 #include <QGraphicsScene>
 #include <QGraphicsSceneMouseEvent>
 #include <QPainter>
 #include <algorithm>
+#include <cmath>
+#ifdef _WIN32
+#include "round.h"
+#endif /* _WIN32 */
+#include "abstractcarditem.h"
+#include "carddatabase.h"
+#include "gamescene.h"
+#include "main.h"
+#include "pictureloader.h"
+#include "settingscache.h"
 
 AbstractCardItem::AbstractCardItem(const QString &_name, Player *_owner, int _id, QGraphicsItem *parent)
     : ArrowTarget(_owner, parent), id(_id), name(_name), tapped(false), facedown(false), tapAngle(0),
@@ -20,7 +22,7 @@ AbstractCardItem::AbstractCardItem(const QString &_name, Player *_owner, int _id
     setFlag(ItemIsSelectable);
     setCacheMode(DeviceCoordinateCache);
 
-    connect(&SettingsCache::instance(), SIGNAL(displayCardNamesChanged()), this, SLOT(callUpdate()));
+    connect(settingsCache, SIGNAL(displayCardNamesChanged()), this, SLOT(callUpdate()));
     cardInfoUpdated();
 }
 
@@ -43,16 +45,8 @@ void AbstractCardItem::pixmapUpdated()
 void AbstractCardItem::cardInfoUpdated()
 {
     info = db->getCard(name);
-
-    if (!info && !name.isEmpty()) {
-        QVariantHash properties = QVariantHash();
-
-        info = CardInfo::newInstance(name, "", true, QVariantHash(), QList<CardRelation *>(), QList<CardRelation *>(),
-                                     CardInfoPerSetMap(), false, -1, false);
-    }
-    if (info.data()) {
+    if (info)
         connect(info.data(), SIGNAL(pixmapUpdated()), this, SLOT(pixmapUpdated()));
-    }
 
     cacheBgColor();
     update();
@@ -72,19 +66,21 @@ QSizeF AbstractCardItem::getTranslatedSize(QPainter *painter) const
 
 void AbstractCardItem::transformPainter(QPainter *painter, const QSizeF &translatedSize, int angle)
 {
-    const int MAX_FONT_SIZE = SettingsCache::instance().getMaxFontSize();
+    const int MAX_FONT_SIZE = settingsCache->getMaxFontSize();
     const int fontSize = std::max(9, MAX_FONT_SIZE);
 
     QRectF totalBoundingRect = painter->combinedTransform().mapRect(boundingRect());
 
-    int scale = resetPainterTransform(painter);
+    painter->resetTransform();
 
-    painter->translate(totalBoundingRect.width() / 2, totalBoundingRect.height() / 2);
-    painter->rotate(angle);
-    painter->translate(-translatedSize.width() / 2, -translatedSize.height() / 2);
+    QTransform pixmapTransform;
+    pixmapTransform.translate(totalBoundingRect.width() / 2, totalBoundingRect.height() / 2);
+    pixmapTransform.rotate(angle);
+    pixmapTransform.translate(-translatedSize.width() / 2, -translatedSize.height() / 2);
+    painter->setTransform(pixmapTransform);
 
     QFont f;
-    f.setPixelSize(fontSize * scale);
+    f.setPixelSize(fontSize);
 
     painter->setFont(f);
 }
@@ -131,7 +127,7 @@ void AbstractCardItem::paintPicture(QPainter *painter, const QSizeF &translatedS
     else
         painter->drawRect(QRectF(1, 1, CARD_WIDTH - 2, CARD_HEIGHT - 1.5));
 
-    if (translatedPixmap.isNull() || SettingsCache::instance().getDisplayCardNames() || facedown) {
+    if (translatedPixmap.isNull() || settingsCache->getDisplayCardNames() || facedown) {
         painter->save();
         transformPainter(painter, translatedSize, angle);
         painter->setPen(Qt::white);
@@ -201,7 +197,7 @@ void AbstractCardItem::setHovered(bool _hovered)
         processHoverEvent();
     isHovered = _hovered;
     setZValue(_hovered ? 2000000004 : realZValue);
-    setScale(_hovered && SettingsCache::instance().getScaleCards() ? 1.1 : 1);
+    setScale(_hovered && settingsCache->getScaleCards() ? 1.1 : 1);
     setTransformOriginPoint(_hovered ? CARD_WIDTH / 2 : 0, _hovered ? CARD_HEIGHT / 2 : 0);
     update();
 }
@@ -254,7 +250,7 @@ void AbstractCardItem::setTapped(bool _tapped, bool canAnimate)
         return;
 
     tapped = _tapped;
-    if (SettingsCache::instance().getTapAnimation() && canAnimate)
+    if (settingsCache->getTapAnimation() && canAnimate)
         static_cast<GameScene *>(scene())->registerAnimationItem(this);
     else {
         tapAngle = tapped ? 90 : 0;
@@ -270,6 +266,7 @@ void AbstractCardItem::setFaceDown(bool _facedown)
 {
     facedown = _facedown;
     update();
+    emit updateCardMenu(this);
 }
 
 void AbstractCardItem::mousePressEvent(QGraphicsSceneMouseEvent *event)
@@ -284,14 +281,14 @@ void AbstractCardItem::mousePressEvent(QGraphicsSceneMouseEvent *event)
     }
     if (event->button() == Qt::LeftButton)
         setCursor(Qt::ClosedHandCursor);
-    else if (event->button() == Qt::MiddleButton)
+    else if (event->button() == Qt::MidButton)
         emit showCardInfoPopup(event->screenPos(), name);
     event->accept();
 }
 
 void AbstractCardItem::mouseReleaseEvent(QGraphicsSceneMouseEvent *event)
 {
-    if (event->button() == Qt::MiddleButton)
+    if (event->button() == Qt::MidButton)
         emit deleteCardInfoPopup(name);
 
     // This function ensures the parent function doesn't mess around with our selection.

cockatrice/src/abstractcarditem.h

@@ -36,6 +36,7 @@ signals:
     void hovered(AbstractCardItem *card);
     void showCardInfoPopup(QPoint pos, QString cardName);
     void deleteCardInfoPopup(QString cardName);
+    void updateCardMenu(AbstractCardItem *card);
     void sigPixmapUpdated();
     void cardShiftClicked(QString cardName);
 
@@ -48,10 +49,7 @@ public:
     {
         return Type;
     }
-    AbstractCardItem(const QString &_name = QString(),
-                     Player *_owner = nullptr,
-                     int _id = -1,
-                     QGraphicsItem *parent = nullptr);
+    AbstractCardItem(const QString &_name = QString(), Player *_owner = 0, int _id = -1, QGraphicsItem *parent = 0);
     ~AbstractCardItem();
     QRectF boundingRect() const;
     QSizeF getTranslatedSize(QPainter *painter) const;

cockatrice/src/abstractclient.cpp

@@ -19,11 +19,9 @@
 #include "pb/event_user_message.pb.h"
 #include "pb/server_message.pb.h"
 #include "pending_command.h"
-
 #include <google/protobuf/descriptor.h>
 
-AbstractClient::AbstractClient(QObject *parent)
-    : QObject(parent), nextCmdId(0), status(StatusDisconnected), serverSupportsPasswordHash(false)
+AbstractClient::AbstractClient(QObject *parent) : QObject(parent), nextCmdId(0), status(StatusDisconnected)
 {
     qRegisterMetaType<QVariant>("QVariant");
     qRegisterMetaType<CommandContainer>("CommandContainer");
@@ -48,7 +46,6 @@ AbstractClient::AbstractClient(QObject *parent)
     qRegisterMetaType<QList<ServerInfo_User>>("QList<ServerInfo_User>");
     qRegisterMetaType<Event_ReplayAdded>("Event_ReplayAdded");
     qRegisterMetaType<QList<QString>>("missingFeatures");
-    qRegisterMetaType<PendingCommand *>("pendingCommand");
 
     FeatureSet features;
     features.initalizeFeatureList(clientFeatures);

cockatrice/src/abstractclient.h

@@ -3,7 +3,6 @@
 
 #include "pb/response.pb.h"
 #include "pb/serverinfo_user.pb.h"
-
 #include <QMutex>
 #include <QObject>
 #include <QVariant>
@@ -40,7 +39,6 @@ enum ClientStatus
     StatusRequestingForgotPassword,
     StatusSubmitForgotPasswordReset,
     StatusSubmitForgotPasswordChallenge,
-    StatusGettingPasswordSalt,
 };
 
 class AbstractClient : public QObject
@@ -88,7 +86,7 @@ protected slots:
 protected:
     QMap<int, PendingCommand *> pendingCommands;
     QString userName, password, email, country, realName, token;
-    bool serverSupportsPasswordHash;
+    int gender;
     void setStatus(ClientStatus _status);
     int getNewCmdId()
     {
@@ -97,7 +95,7 @@ protected:
     virtual void sendCommandContainer(const CommandContainer &cont) = 0;
 
 public:
-    AbstractClient(QObject *parent = nullptr);
+    AbstractClient(QObject *parent = 0);
     ~AbstractClient();
 
     ClientStatus getStatus() const
@@ -108,11 +106,7 @@ public:
     void sendCommand(const CommandContainer &cont);
     void sendCommand(PendingCommand *pend);
 
-    bool getServerSupportsPasswordHash() const
-    {
-        return serverSupportsPasswordHash;
-    }
-    const QString &getUserName() const
+    const QString getUserName()
     {
         return userName;
     }

cockatrice/src/abstractcounter.cpp

@@ -1,20 +1,15 @@
 #include "abstractcounter.h"
-
 #include "expression.h"
 #include "pb/command_inc_counter.pb.h"
 #include "pb/command_set_counter.pb.h"
 #include "player.h"
 #include "settingscache.h"
-#include "translatecountername.h"
-
 #include <QAction>
 #include <QApplication>
 #include <QGraphicsSceneHoverEvent>
 #include <QGraphicsSceneMouseEvent>
-#include <QKeyEvent>
 #include <QMenu>
 #include <QPainter>
-#include <QString>
 
 AbstractCounter::AbstractCounter(Player *_player,
                                  int _id,
@@ -22,24 +17,22 @@ AbstractCounter::AbstractCounter(Player *_player,
                                  bool _shownInCounterArea,
                                  int _value,
                                  bool _useNameForShortcut,
-                                 QGraphicsItem *parent,
-                                 QWidget *_game)
+                                 QGraphicsItem *parent)
     : QGraphicsItem(parent), player(_player), id(_id), name(_name), value(_value),
       useNameForShortcut(_useNameForShortcut), hovered(false), aDec(nullptr), aInc(nullptr), dialogSemaphore(false),
-      deleteAfterDialog(false), shownInCounterArea(_shownInCounterArea), game(_game)
+      deleteAfterDialog(false), shownInCounterArea(_shownInCounterArea)
 {
     setAcceptHoverEvents(true);
 
     shortcutActive = false;
 
-    if (player->getLocalOrJudge()) {
-        QString displayName = TranslateCounterName::getDisplayName(_name);
-        menu = new TearOffMenu(displayName);
+    if (player->getLocal()) {
+        menu = new QMenu(name);
         aSet = new QAction(this);
         connect(aSet, SIGNAL(triggered()), this, SLOT(setCounter()));
         menu->addAction(aSet);
         menu->addSeparator();
-        for (int i = 10; i >= -10; --i) {
+        for (int i = 10; i >= -10; --i)
             if (i == 0) {
                 menu->addSeparator();
             } else {
@@ -52,12 +45,10 @@ AbstractCounter::AbstractCounter(Player *_player,
                 connect(aIncrement, SIGNAL(triggered()), this, SLOT(incrementCounter()));
                 menu->addAction(aIncrement);
             }
-        }
-    } else {
+    } else
         menu = nullptr;
-    }
 
-    connect(&SettingsCache::instance().shortcuts(), SIGNAL(shortCutChanged()), this, SLOT(refreshShortcuts()));
+    connect(&settingsCache->shortcuts(), SIGNAL(shortCutChanged()), this, SLOT(refreshShortcuts()));
     refreshShortcuts();
     retranslateUi();
 }
@@ -87,17 +78,16 @@ void AbstractCounter::setShortcutsActive()
     if (!player->getLocal()) {
         return;
     }
-    ShortcutsSettings &shortcuts = SettingsCache::instance().shortcuts();
     if (name == "life") {
         shortcutActive = true;
-        aSet->setShortcuts(shortcuts.getShortcut("Player/aSet"));
-        aDec->setShortcuts(shortcuts.getShortcut("Player/aDec"));
-        aInc->setShortcuts(shortcuts.getShortcut("Player/aInc"));
+        aSet->setShortcuts(settingsCache->shortcuts().getShortcut("Player/aSet"));
+        aDec->setShortcuts(settingsCache->shortcuts().getShortcut("Player/aDec"));
+        aInc->setShortcuts(settingsCache->shortcuts().getShortcut("Player/aInc"));
     } else if (useNameForShortcut) {
         shortcutActive = true;
-        aSet->setShortcuts(shortcuts.getShortcut("Player/aSetCounter_" + name));
-        aDec->setShortcuts(shortcuts.getShortcut("Player/aDecCounter_" + name));
-        aInc->setShortcuts(shortcuts.getShortcut("Player/aIncCounter_" + name));
+        aSet->setShortcuts(settingsCache->shortcuts().getShortcut("Player/aSetCounter_" + name));
+        aDec->setShortcuts(settingsCache->shortcuts().getShortcut("Player/aDecCounter_" + name));
+        aInc->setShortcuts(settingsCache->shortcuts().getShortcut("Player/aIncCounter_" + name));
     }
 }
 
@@ -113,9 +103,8 @@ void AbstractCounter::setShortcutsInactive()
 
 void AbstractCounter::refreshShortcuts()
 {
-    if (shortcutActive) {
+    if (shortcutActive)
         setShortcutsActive();
-    }
 }
 
 void AbstractCounter::setValue(int _value)
@@ -126,8 +115,8 @@ void AbstractCounter::setValue(int _value)
 
 void AbstractCounter::mousePressEvent(QGraphicsSceneMouseEvent *event)
 {
-    if (isUnderMouse() && player->getLocalOrJudge()) {
-        if (event->button() == Qt::MiddleButton || (QApplication::keyboardModifiers() & Qt::ShiftModifier)) {
+    if (isUnderMouse() && player->getLocal()) {
+        if (event->button() == Qt::MidButton || (QApplication::keyboardModifiers() & Qt::ShiftModifier)) {
             if (menu)
                 menu->exec(event->screenPos());
             event->accept();
@@ -171,60 +160,24 @@ void AbstractCounter::incrementCounter()
 
 void AbstractCounter::setCounter()
 {
+    bool ok;
     dialogSemaphore = true;
-    AbstractCounterDialog dialog(name, QString::number(value), game);
-    const int ok = dialog.exec();
+    QString expression = QInputDialog::getText(nullptr, tr("Set counter"), tr("New value for counter '%1':").arg(name),
+                                               QLineEdit::Normal, QString::number(value), &ok);
+
+    Expression exp(value);
+    int newValue = static_cast<int>(exp.parse(expression));
 
     if (deleteAfterDialog) {
         deleteLater();
         return;
     }
     dialogSemaphore = false;
-
     if (!ok)
         return;
 
-    Expression exp(value);
-    int newValue = static_cast<int>(exp.parse(dialog.textValue()));
-
     Command_SetCounter cmd;
     cmd.set_counter_id(id);
     cmd.set_value(newValue);
     player->sendGameCommand(cmd);
 }
-
-AbstractCounterDialog::AbstractCounterDialog(const QString &name, const QString &value, QWidget *parent)
-    : QInputDialog(parent)
-{
-    setWindowTitle(tr("Set counter"));
-    setLabelText(tr("New value for counter '%1':").arg(name));
-    setTextValue(value);
-    qApp->installEventFilter(this);
-}
-
-bool AbstractCounterDialog::eventFilter(QObject *obj, QEvent *event)
-{
-    Q_UNUSED(obj);
-    if (event->type() == QEvent::KeyPress) {
-        QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event);
-        switch (keyEvent->key()) {
-            case Qt::Key_Up:
-                changeValue(+1);
-                return true;
-            case Qt::Key_Down:
-                changeValue(-1);
-                return true;
-        }
-    }
-    return false;
-}
-
-void AbstractCounterDialog::changeValue(int diff)
-{
-    bool ok;
-    int curValue = textValue().toInt(&ok);
-    if (!ok)
-        return;
-    curValue += diff;
-    setTextValue(QString::number(curValue));
-}

cockatrice/src/abstractcounter.h

@@ -1,16 +1,11 @@
 #ifndef COUNTER_H
 #define COUNTER_H
 
-#include "tearoffmenu.h"
-
 #include <QGraphicsItem>
-#include <QInputDialog>
 
 class Player;
-class QAction;
-class QKeyEvent;
 class QMenu;
-class QString;
+class QAction;
 
 class AbstractCounter : public QObject, public QGraphicsItem
 {
@@ -30,11 +25,10 @@ protected:
 
 private:
     QAction *aSet, *aDec, *aInc;
-    TearOffMenu *menu;
+    QMenu *menu;
     bool dialogSemaphore, deleteAfterDialog;
     bool shownInCounterArea;
     bool shortcutActive;
-    QWidget *game;
 
 private slots:
     void refreshShortcuts();
@@ -48,8 +42,7 @@ public:
                     bool _shownInCounterArea,
                     int _value,
                     bool _useNameForShortcut = false,
-                    QGraphicsItem *parent = nullptr,
-                    QWidget *game = nullptr);
+                    QGraphicsItem *parent = nullptr);
     ~AbstractCounter() override;
 
     void retranslateUi();
@@ -81,15 +74,4 @@ public:
     }
 };
 
-class AbstractCounterDialog : public QInputDialog
-{
-    Q_OBJECT
-public:
-    AbstractCounterDialog(const QString &name, const QString &value, QWidget *parent = nullptr);
-
-protected:
-    bool eventFilter(QObject *obj, QEvent *event);
-    void changeValue(int diff);
-};
-
 #endif

cockatrice/src/abstractgraphicsitem.cpp

@@ -1,5 +1,4 @@
 #include "abstractgraphicsitem.h"
-
 #include <QPainter>
 
 void AbstractGraphicsItem::paintNumberEllipse(int number,
@@ -17,12 +16,7 @@ void AbstractGraphicsItem::paintNumberEllipse(int number,
     font.setWeight(QFont::Bold);
 
     QFontMetrics fm(font);
-    double w = 1.3 *
-#if (QT_VERSION >= QT_VERSION_CHECK(5, 11, 0))
-               fm.horizontalAdvance(numStr);
-#else
-               fm.width(numStr);
-#endif
+    double w = fm.width(numStr) * 1.3;
     double h = fm.height() * 1.3;
     if (w < h)
         w = h;
@@ -55,11 +49,3 @@ void AbstractGraphicsItem::paintNumberEllipse(int number,
 
     painter->restore();
 }
-
-int resetPainterTransform(QPainter *painter)
-{
-    painter->resetTransform();
-    auto tx = painter->deviceTransform().inverted();
-    painter->setTransform(tx);
-    return tx.isScaling() ? 1.0 / tx.m11() : 1;
-}

cockatrice/src/abstractgraphicsitem.h

@@ -21,11 +21,9 @@ protected:
     void paintNumberEllipse(int number, int radius, const QColor &color, int position, int count, QPainter *painter);
 
 public:
-    AbstractGraphicsItem(QGraphicsItem *parent = nullptr) : QObject(), QGraphicsItem(parent)
+    AbstractGraphicsItem(QGraphicsItem *parent = 0) : QObject(), QGraphicsItem(parent)
     {
     }
 };
 
-int resetPainterTransform(QPainter *painter);
-
 #endif

cockatrice/src/arrowitem.cpp

@@ -1,22 +1,22 @@
 #define _USE_MATH_DEFINES
-#include "arrowitem.h"
+#include <cmath>
 
+#include "arrowitem.h"
 #include "carddatabase.h"
 #include "carditem.h"
 #include "cardzone.h"
-#include "color.h"
-#include "pb/command_attach_card.pb.h"
-#include "pb/command_create_arrow.pb.h"
-#include "pb/command_delete_arrow.pb.h"
 #include "player.h"
 #include "playertarget.h"
 #include "settingscache.h"
-
 #include <QDebug>
 #include <QGraphicsScene>
 #include <QGraphicsSceneMouseEvent>
 #include <QPainter>
-#include <QtMath>
+
+#include "color.h"
+#include "pb/command_attach_card.pb.h"
+#include "pb/command_create_arrow.pb.h"
+#include "pb/command_delete_arrow.pb.h"
 
 ArrowItem::ArrowItem(Player *_player, int _id, ArrowTarget *_startItem, ArrowTarget *_targetItem, const QColor &_color)
     : QGraphicsItem(), player(_player), id(_id), startItem(_startItem), targetItem(_targetItem), color(_color),
@@ -71,7 +71,7 @@ void ArrowItem::updatePath(const QPointF &endPoint)
     const double arrowWidth = 15.0;
     const double headWidth = 40.0;
     const double headLength =
-        headWidth / qPow(2, 0.5); // aka headWidth / sqrt (2) but this produces a compile error with MSVC++
+        headWidth / pow(2, 0.5); // aka headWidth / sqrt (2) but this produces a compile error with MSVC++
     const double phi = 15;
 
     if (!startItem)
@@ -86,7 +86,7 @@ void ArrowItem::updatePath(const QPointF &endPoint)
     if (lineLength < 30)
         path = QPainterPath();
     else {
-        QPointF c(lineLength / 2, qTan(phi * M_PI / 180) * lineLength);
+        QPointF c(lineLength / 2, tan(phi * M_PI / 180) * lineLength);
 
         QPainterPath centerLine;
         centerLine.moveTo(0, 0);
@@ -97,22 +97,22 @@ void ArrowItem::updatePath(const QPointF &endPoint)
         QLineF testLine(arrowBodyEndPoint, centerLine.pointAtPercent(percentage + 0.001));
         qreal alpha = testLine.angle() - 90;
         QPointF endPoint1 =
-            arrowBodyEndPoint + arrowWidth / 2 * QPointF(qCos(alpha * M_PI / 180), -qSin(alpha * M_PI / 180));
+            arrowBodyEndPoint + arrowWidth / 2 * QPointF(cos(alpha * M_PI / 180), -sin(alpha * M_PI / 180));
         QPointF endPoint2 =
-            arrowBodyEndPoint + arrowWidth / 2 * QPointF(-qCos(alpha * M_PI / 180), qSin(alpha * M_PI / 180));
+            arrowBodyEndPoint + arrowWidth / 2 * QPointF(-cos(alpha * M_PI / 180), sin(alpha * M_PI / 180));
         QPointF point1 =
-            endPoint1 + (headWidth - arrowWidth) / 2 * QPointF(qCos(alpha * M_PI / 180), -qSin(alpha * M_PI / 180));
+            endPoint1 + (headWidth - arrowWidth) / 2 * QPointF(cos(alpha * M_PI / 180), -sin(alpha * M_PI / 180));
         QPointF point2 =
-            endPoint2 + (headWidth - arrowWidth) / 2 * QPointF(-qCos(alpha * M_PI / 180), qSin(alpha * M_PI / 180));
+            endPoint2 + (headWidth - arrowWidth) / 2 * QPointF(-cos(alpha * M_PI / 180), sin(alpha * M_PI / 180));
 
-        path = QPainterPath(-arrowWidth / 2 * QPointF(qCos((phi - 90) * M_PI / 180), qSin((phi - 90) * M_PI / 180)));
+        path = QPainterPath(-arrowWidth / 2 * QPointF(cos((phi - 90) * M_PI / 180), sin((phi - 90) * M_PI / 180)));
         path.quadTo(c, endPoint1);
         path.lineTo(point1);
         path.lineTo(QPointF(lineLength, 0));
         path.lineTo(point2);
         path.lineTo(endPoint2);
-        path.quadTo(c, arrowWidth / 2 * QPointF(qCos((phi - 90) * M_PI / 180), qSin((phi - 90) * M_PI / 180)));
-        path.lineTo(-arrowWidth / 2 * QPointF(qCos((phi - 90) * M_PI / 180), qSin((phi - 90) * M_PI / 180)));
+        path.quadTo(c, arrowWidth / 2 * QPointF(cos((phi - 90) * M_PI / 180), sin((phi - 90) * M_PI / 180)));
+        path.lineTo(-arrowWidth / 2 * QPointF(cos((phi - 90) * M_PI / 180), sin((phi - 90) * M_PI / 180)));
     }
 
     setPos(startPoint);
@@ -138,8 +138,8 @@ void ArrowItem::mousePressEvent(QGraphicsSceneMouseEvent *event)
     }
 
     QList<QGraphicsItem *> colliding = scene()->items(event->scenePos());
-    for (QGraphicsItem *item : colliding) {
-        if (qgraphicsitem_cast<CardItem *>(item)) {
+    for (int i = 0; i < colliding.size(); ++i) {
+        if (qgraphicsitem_cast<CardItem *>(colliding[i])) {
             event->ignore();
             return;
         }
@@ -205,8 +205,8 @@ void ArrowDragItem::mouseMoveEvent(QGraphicsSceneMouseEvent *event)
     }
     update();
 
-    for (ArrowDragItem *child : childArrows) {
-        child->mouseMoveEvent(event);
+    for (int i = 0; i < childArrows.size(); ++i) {
+        childArrows[i]->mouseMoveEvent(event);
     }
 }
 
@@ -240,20 +240,19 @@ void ArrowDragItem::mouseReleaseEvent(QGraphicsSceneMouseEvent *event)
         if (startZone->getName().compare("hand") == 0) {
             startCard->playCard(false);
             CardInfoPtr ci = startCard->getInfo();
-            if (ci && (((!SettingsCache::instance().getPlayToStack() && ci->getTableRow() == 3) ||
-                        ((SettingsCache::instance().getPlayToStack() && ci->getTableRow() != 0) &&
+            if (ci && (((!settingsCache->getPlayToStack() && ci->getTableRow() == 3) ||
+                        ((settingsCache->getPlayToStack() && ci->getTableRow() != 0) &&
                          startCard->getZone()->getName().toStdString() != "stack"))))
                 cmd.set_start_zone("stack");
             else
-                cmd.set_start_zone(SettingsCache::instance().getPlayToStack() ? "stack" : "table");
+                cmd.set_start_zone(settingsCache->getPlayToStack() ? "stack" : "table");
         }
         player->sendGameCommand(cmd);
     }
     delArrow();
 
-    for (ArrowDragItem *child : childArrows) {
-        child->mouseReleaseEvent(event);
-    }
+    for (int i = 0; i < childArrows.size(); ++i)
+        childArrows[i]->mouseReleaseEvent(event);
 }
 
 ArrowAttachItem::ArrowAttachItem(ArrowTarget *_startItem)
@@ -261,11 +260,6 @@ ArrowAttachItem::ArrowAttachItem(ArrowTarget *_startItem)
 {
 }
 
-void ArrowAttachItem::addChildArrow(ArrowAttachItem *childArrow)
-{
-    childArrows.append(childArrow);
-}
-
 void ArrowAttachItem::mouseMoveEvent(QGraphicsSceneMouseEvent *event)
 {
     if (!startItem)
@@ -301,13 +295,9 @@ void ArrowAttachItem::mouseMoveEvent(QGraphicsSceneMouseEvent *event)
         updatePath();
     }
     update();
-
-    for (ArrowAttachItem *child : childArrows) {
-        child->mouseMoveEvent(event);
-    }
 }
 
-void ArrowAttachItem::mouseReleaseEvent(QGraphicsSceneMouseEvent *event)
+void ArrowAttachItem::mouseReleaseEvent(QGraphicsSceneMouseEvent * /*event*/)
 {
     if (!startItem)
         return;
@@ -329,8 +319,4 @@ void ArrowAttachItem::mouseReleaseEvent(QGraphicsSceneMouseEvent *event)
     }
 
     delArrow();
-
-    for (ArrowAttachItem *child : childArrows) {
-        child->mouseReleaseEvent(event);
-    }
 }

cockatrice/src/arrowitem.h

@@ -85,12 +85,8 @@ protected:
 class ArrowAttachItem : public ArrowItem
 {
     Q_OBJECT
-private:
-    QList<ArrowAttachItem *> childArrows;
-
 public:
     ArrowAttachItem(ArrowTarget *_startItem);
-    void addChildArrow(ArrowAttachItem *childArrow);
 
 protected:
     void mouseMoveEvent(QGraphicsSceneMouseEvent *event);

cockatrice/src/arrowtarget.cpp

@@ -1,5 +1,4 @@
 #include "arrowtarget.h"
-
 #include "arrowitem.h"
 #include "player.h"
 

cockatrice/src/arrowtarget.h

@@ -2,7 +2,6 @@
 #define ARROWTARGET_H
 
 #include "abstractgraphicsitem.h"
-
 #include <QList>
 
 class Player;
@@ -19,7 +18,7 @@ private:
     QList<ArrowItem *> arrowsFrom, arrowsTo;
 
 public:
-    ArrowTarget(Player *_owner, QGraphicsItem *parent = nullptr);
+    ArrowTarget(Player *_owner, QGraphicsItem *parent = 0);
     ~ArrowTarget();
 
     Player *getOwner() const
@@ -43,8 +42,9 @@ public:
     }
     void removeArrowFrom(ArrowItem *arrow)
     {
-        arrowsFrom.removeOne(arrow);
+        arrowsFrom.removeAt(arrowsFrom.indexOf(arrow));
     }
+
     const QList<ArrowItem *> &getArrowsTo() const
     {
         return arrowsTo;
@@ -55,7 +55,8 @@ public:
     }
     void removeArrowTo(ArrowItem *arrow)
     {
-        arrowsTo.removeOne(arrow);
+        arrowsTo.removeAt(arrowsTo.indexOf(arrow));
     }
 };
+
 #endif

cockatrice/src/carddatabase.cpp

@@ -1,5 +1,4 @@
 #include "carddatabase.h"
-
 #include "carddbparser/cockatricexml3.h"
 #include "carddbparser/cockatricexml4.h"
 #include "game_specific_terms.h"
@@ -10,11 +9,8 @@
 #include <QCryptographicHash>
 #include <QDebug>
 #include <QDir>
-#include <QDirIterator>
 #include <QFile>
 #include <QMessageBox>
-#include <QRegularExpression>
-#include <algorithm>
 #include <utility>
 
 const char *CardDatabase::TOKENS_SETNAME = "TK";
@@ -70,27 +66,27 @@ QString CardSet::getCorrectedShortName() const
 
 void CardSet::loadSetOptions()
 {
-    sortKey = SettingsCache::instance().cardDatabase().getSortKey(shortName);
-    enabled = SettingsCache::instance().cardDatabase().isEnabled(shortName);
-    isknown = SettingsCache::instance().cardDatabase().isKnown(shortName);
+    sortKey = settingsCache->cardDatabase().getSortKey(shortName);
+    enabled = settingsCache->cardDatabase().isEnabled(shortName);
+    isknown = settingsCache->cardDatabase().isKnown(shortName);
 }
 
 void CardSet::setSortKey(unsigned int _sortKey)
 {
     sortKey = _sortKey;
-    SettingsCache::instance().cardDatabase().setSortKey(shortName, _sortKey);
+    settingsCache->cardDatabase().setSortKey(shortName, _sortKey);
 }
 
 void CardSet::setEnabled(bool _enabled)
 {
     enabled = _enabled;
-    SettingsCache::instance().cardDatabase().setEnabled(shortName, _enabled);
+    settingsCache->cardDatabase().setEnabled(shortName, _enabled);
 }
 
 void CardSet::setIsKnown(bool _isknown)
 {
     isknown = _isknown;
-    SettingsCache::instance().cardDatabase().setIsKnown(shortName, _isknown);
+    settingsCache->cardDatabase().setIsKnown(shortName, _isknown);
 }
 
 class SetList::KeyCompareFunctor
@@ -109,7 +105,7 @@ public:
 
 void SetList::sortByKey()
 {
-    std::sort(begin(), end(), KeyCompareFunctor());
+    qSort(begin(), end(), KeyCompareFunctor());
 }
 
 int SetList::getEnabledSetsNum()
@@ -293,23 +289,22 @@ void CardInfo::refreshCachedSetNames()
 
 QString CardInfo::simplifyName(const QString &name)
 {
-    static const QRegularExpression spaceOrSplit("(\\s+|\\/\\/.*)");
-    static const QRegularExpression nonAlnum("[^a-z0-9]");
-
-    QString simpleName = name.toLower();
-
-    // remove spaces and right halves of split cards
-    simpleName.remove(spaceOrSplit);
+    QString simpleName(name);
 
     // So Aetherling would work, but not Ætherling since 'Æ' would get replaced
     // with nothing.
     simpleName.replace("æ", "ae");
+    simpleName.replace("Æ", "AE");
 
     // Replace Jötun Grunt with Jotun Grunt.
     simpleName = simpleName.normalized(QString::NormalizationForm_KD);
 
-    // remove all non alphanumeric characters from the name
-    simpleName.remove(nonAlnum);
+    // Replace dashes with spaces so that we can say "garruk the veil cursed"
+    // instead of the unintuitive "garruk the veilcursed".
+    simpleName = simpleName.replace("-", " ");
+
+    simpleName.remove(QRegExp("[^a-zA-Z0-9 ]"));
+    simpleName = simpleName.toLower();
     return simpleName;
 }
 
@@ -332,15 +327,15 @@ CardDatabase::CardDatabase(QObject *parent) : QObject(parent), loadStatus(NotLoa
     qRegisterMetaType<CardInfoPtr>("CardSetPtr");
 
     // add new parsers here
-    availableParsers << new CockatriceXml4Parser;
     availableParsers << new CockatriceXml3Parser;
+    availableParsers << new CockatriceXml4Parser;
 
     for (auto &parser : availableParsers) {
         connect(parser, SIGNAL(addCard(CardInfoPtr)), this, SLOT(addCard(CardInfoPtr)), Qt::DirectConnection);
         connect(parser, SIGNAL(addSet(CardSetPtr)), this, SLOT(addSet(CardSetPtr)), Qt::DirectConnection);
     }
 
-    connect(&SettingsCache::instance(), SIGNAL(cardDatabasePathChanged()), this, SLOT(loadCardDatabases()));
+    connect(settingsCache, SIGNAL(cardDatabasePathChanged()), this, SLOT(loadCardDatabases()));
 }
 
 CardDatabase::~CardDatabase()
@@ -440,19 +435,6 @@ CardInfoPtr CardDatabase::getCardBySimpleName(const QString &cardName) const
     return getCardFromMap(simpleNameCards, CardInfo::simplifyName(cardName));
 }
 
-CardInfoPtr CardDatabase::guessCard(const QString &cardName) const
-{
-    CardInfoPtr temp = getCard(cardName);
-    if (temp == nullptr) { // get card by simple name instead
-        temp = getCardBySimpleName(cardName);
-        if (temp == nullptr) { // still could not find the card, so simplify the cardName too
-            QString simpleCardName = CardInfo::simplifyName(cardName);
-            temp = getCardBySimpleName(simpleCardName);
-        }
-    }
-    return temp; // returns nullptr if not found
-}
-
 CardSetPtr CardDatabase::getSet(const QString &setName)
 {
     if (sets.contains(setName)) {
@@ -510,7 +492,6 @@ LoadStatus CardDatabase::loadFromFile(const QString &fileName)
 
 LoadStatus CardDatabase::loadCardDatabase(const QString &path)
 {
-    auto startTime = QTime::currentTime();
     LoadStatus tempLoadStatus = NotLoaded;
     if (!path.isEmpty()) {
         loadFromFileMutex->lock();
@@ -518,9 +499,8 @@ LoadStatus CardDatabase::loadCardDatabase(const QString &path)
         loadFromFileMutex->unlock();
     }
 
-    int msecs = startTime.msecsTo(QTime::currentTime());
     qDebug() << "[CardDatabase] loadCardDatabase(): Path =" << path << "Status =" << tempLoadStatus
-             << "Cards =" << cards.size() << "Sets =" << sets.size() << QString("%1ms").arg(msecs);
+             << "Cards =" << cards.size() << "Sets=" << sets.size();
 
     return tempLoadStatus;
 }
@@ -533,25 +513,15 @@ LoadStatus CardDatabase::loadCardDatabases()
 
     clear(); // remove old db
 
-    loadStatus = loadCardDatabase(SettingsCache::instance().getCardDatabasePath()); // load main card database
-    loadCardDatabase(SettingsCache::instance().getTokenDatabasePath());             // load tokens database
-    loadCardDatabase(SettingsCache::instance().getSpoilerCardDatabasePath());       // load spoilers database
+    loadStatus = loadCardDatabase(settingsCache->getCardDatabasePath()); // load main card database
+    loadCardDatabase(settingsCache->getTokenDatabasePath());             // load tokens database
+    loadCardDatabase(settingsCache->getSpoilerCardDatabasePath());       // load spoilers database
 
-    // find all custom card databases, recursively & following symlinks
-    // then load them alphabetically
-    QDirIterator customDatabaseIterator(SettingsCache::instance().getCustomCardDatabasePath(), QStringList() << "*.xml",
-                                        QDir::Files, QDirIterator::Subdirectories | QDirIterator::FollowSymlinks);
-    QStringList databasePaths;
-    while (customDatabaseIterator.hasNext()) {
-        customDatabaseIterator.next();
-        databasePaths.push_back(customDatabaseIterator.filePath());
-    }
-    databasePaths.sort();
-
-    for (auto i = 0; i < databasePaths.size(); ++i) {
-        const auto &databasePath = databasePaths.at(i);
-        qDebug() << "Loading Custom Set" << i << "(" << databasePath << ")";
-        loadCardDatabase(databasePath);
+    // load custom card databases
+    QDir dir(settingsCache->getCustomCardDatabasePath());
+    for (const QString &fileName :
+         dir.entryList(QStringList("*.xml"), QDir::Files | QDir::Readable, QDir::Name | QDir::IgnoreCase)) {
+        loadCardDatabase(dir.absoluteFilePath(fileName));
     }
 
     // AFTER all the cards have been loaded
@@ -602,7 +572,7 @@ QStringList CardDatabase::getAllMainCardTypes() const
     while (cardIterator.hasNext()) {
         types.insert(cardIterator.next().value()->getMainCardType());
     }
-    return types.values();
+    return types.toList();
 }
 
 void CardDatabase::checkUnknownSets()
@@ -653,8 +623,7 @@ void CardDatabase::notifyEnabledSetsChanged()
 
 bool CardDatabase::saveCustomTokensToFile()
 {
-    QString fileName =
-        SettingsCache::instance().getCustomCardDatabasePath() + "/" + CardDatabase::TOKENS_SETNAME + ".xml";
+    QString fileName = settingsCache->getCustomCardDatabasePath() + "/" + CardDatabase::TOKENS_SETNAME + ".xml";
 
     SetNameMap tmpSets;
     CardSetPtr customTokensSet = getSet(CardDatabase::TOKENS_SETNAME);
@@ -675,10 +644,9 @@ CardRelation::CardRelation(const QString &_name,
                            bool _doesAttach,
                            bool _isCreateAllExclusion,
                            bool _isVariableCount,
-                           int _defaultCount,
-                           bool _isPersistent)
+                           int _defaultCount)
     : name(_name), doesAttach(_doesAttach), isCreateAllExclusion(_isCreateAllExclusion),
-      isVariableCount(_isVariableCount), defaultCount(_defaultCount), isPersistent(_isPersistent)
+      isVariableCount(_isVariableCount), defaultCount(_defaultCount)
 {
 }
 

cockatrice/src/carddatabase.h

@@ -21,6 +21,7 @@ class CardRelation;
 class ICardDatabaseParser;
 
 typedef QMap<QString, QString> QStringMap;
+typedef QMap<QString, int> MuidMap;
 typedef QSharedPointer<CardInfo> CardInfoPtr;
 typedef QSharedPointer<CardSet> CardSetPtr;
 typedef QMap<QString, CardInfoPerSet> CardInfoPerSetMap;
@@ -247,10 +248,6 @@ public:
         properties.insert(_name, _value);
         emit cardInfoChanged(smartThis);
     }
-    bool hasProperty(const QString &propertyName) const
-    {
-        return properties.contains(propertyName);
-    }
     const CardInfoPerSetMap &getSets() const
     {
         return sets;
@@ -287,13 +284,6 @@ public:
     {
         return reverseRelatedCardsToMe;
     }
-    const QList<CardRelation *> getAllRelatedCards() const
-    {
-        QList<CardRelation *> result;
-        result.append(getRelatedCards());
-        result.append(getReverseRelatedCards2Me());
-        return result;
-    }
     void resetReverseRelatedCards2Me();
     void addReverseRelatedCards2Me(CardRelation *cardRelation)
     {
@@ -409,7 +399,6 @@ public:
     void removeCard(CardInfoPtr card);
     CardInfoPtr getCard(const QString &cardName) const;
     QList<CardInfoPtr> getCards(const QStringList &cardNames) const;
-    CardInfoPtr guessCard(const QString &cardName) const;
 
     /*
      * Get a card by its simple name. The name will be simplified in this
@@ -438,7 +427,7 @@ public slots:
     LoadStatus loadCardDatabases();
     void addCard(CardInfoPtr card);
     void addSet(CardSetPtr set);
-protected slots:
+private slots:
     LoadStatus loadCardDatabase(const QString &path);
 signals:
     void cardDatabaseLoadingFailed();
@@ -458,15 +447,13 @@ private:
     bool isCreateAllExclusion;
     bool isVariableCount;
     int defaultCount;
-    bool isPersistent;
 
 public:
     explicit CardRelation(const QString &_name = QString(),
                           bool _doesAttach = false,
                           bool _isCreateAllExclusion = false,
                           bool _isVariableCount = false,
-                          int _defaultCount = 1,
-                          bool _isPersistent = false);
+                          int _defaultCount = 1);
 
     inline const QString &getName() const
     {
@@ -492,9 +479,5 @@ public:
     {
         return defaultCount;
     }
-    bool getIsPersistent() const
-    {
-        return isPersistent;
-    }
 };
 #endif

cockatrice/src/carddatabasemodel.cpp

@@ -1,7 +1,5 @@
 #include "carddatabasemodel.h"
-
 #include "filtertree.h"
-
 #include <QMap>
 
 #define CARDDBMODEL_COLUMNS 6
@@ -145,16 +143,12 @@ void CardDatabaseModel::cardRemoved(CardInfoPtr card)
     endRemoveRows();
 }
 
-CardDatabaseDisplayModel::CardDatabaseDisplayModel(QObject *parent)
-    : QSortFilterProxyModel(parent), isToken(ShowAll), filterString(nullptr)
+CardDatabaseDisplayModel::CardDatabaseDisplayModel(QObject *parent) : QSortFilterProxyModel(parent), isToken(ShowAll)
 {
     filterTree = nullptr;
     setFilterCaseSensitivity(Qt::CaseInsensitive);
     setSortCaseSensitivity(Qt::CaseInsensitive);
 
-    dirtyTimer.setSingleShot(true);
-    connect(&dirtyTimer, &QTimer::timeout, this, &CardDatabaseDisplayModel::invalidate);
-
     loadedRowCount = 0;
 }
 
@@ -291,13 +285,6 @@ bool CardDatabaseDisplayModel::filterAcceptsRow(int sourceRow, const QModelIndex
     if (((isToken == ShowTrue) && !info->getIsToken()) || ((isToken == ShowFalse) && info->getIsToken()))
         return false;
 
-    if (filterString != nullptr) {
-        if (filterTree != nullptr && !filterTree->acceptsCard(info)) {
-            return false;
-        }
-        return filterString->check(info);
-    }
-
     return rowMatchesCardName(info);
 }
 
@@ -351,7 +338,6 @@ const QString CardDatabaseDisplayModel::sanitizeCardName(const QString &dirtyNam
     }
     return QString::fromStdWString(toReturn);
 }
-
 TokenDisplayModel::TokenDisplayModel(QObject *parent) : CardDatabaseDisplayModel(parent)
 {
 }
@@ -367,19 +353,3 @@ int TokenDisplayModel::rowCount(const QModelIndex &parent) const
     // always load all tokens at start
     return QSortFilterProxyModel::rowCount(parent);
 }
-
-TokenEditModel::TokenEditModel(QObject *parent) : CardDatabaseDisplayModel(parent)
-{
-}
-
-bool TokenEditModel::filterAcceptsRow(int sourceRow, const QModelIndex & /*sourceParent*/) const
-{
-    CardInfoPtr info = static_cast<CardDatabaseModel *>(sourceModel())->getCard(sourceRow);
-    return info->getIsToken() && info->getSets().contains(CardDatabase::TOKENS_SETNAME) && rowMatchesCardName(info);
-}
-
-int TokenEditModel::rowCount(const QModelIndex &parent) const
-{
-    // always load all tokens at start
-    return QSortFilterProxyModel::rowCount(parent);
-}

cockatrice/src/carddatabasemodel.h

@@ -2,13 +2,10 @@
 #define CARDDATABASEMODEL_H
 
 #include "carddatabase.h"
-#include "filter_string.h"
-
 #include <QAbstractListModel>
 #include <QList>
 #include <QSet>
 #include <QSortFilterProxyModel>
-#include <QTimer>
 
 class FilterTree;
 
@@ -70,12 +67,11 @@ public:
 
 private:
     FilterBool isToken;
-    QString cardName, cardText;
+    QString cardNameBeginning, cardName, cardText;
+    QString searchTerm;
     QSet<QString> cardNameSet, cardTypes, cardColors;
     FilterTree *filterTree;
-    FilterString *filterString;
     int loadedRowCount;
-    QTimer dirtyTimer;
 
     /** The translation table that will be used for sanitizeCardName. */
     static QMap<wchar_t, wchar_t> characterTranslation;
@@ -86,33 +82,41 @@ public:
     void setIsToken(FilterBool _isToken)
     {
         isToken = _isToken;
-        dirty();
+        invalidate();
+    }
+    void setCardNameBeginning(const QString &_beginning)
+    {
+        cardNameBeginning = _beginning;
+        invalidate();
     }
-
     void setCardName(const QString &_cardName)
     {
-        if (filterString != nullptr) {
-            delete filterString;
-            filterString = nullptr;
-        }
         cardName = sanitizeCardName(_cardName, characterTranslation);
-        dirty();
-    }
-    void setStringFilter(const QString &_src)
-    {
-        delete filterString;
-        filterString = new FilterString(_src);
-        dirty();
+        invalidate();
     }
     void setCardNameSet(const QSet<QString> &_cardNameSet)
     {
         cardNameSet = _cardNameSet;
-        dirty();
+        invalidate();
     }
-
-    void dirty()
+    void setSearchTerm(const QString &_searchTerm)
     {
-        dirtyTimer.start(20);
+        searchTerm = _searchTerm;
+    }
+    void setCardText(const QString &_cardText)
+    {
+        cardText = _cardText;
+        invalidate();
+    }
+    void setCardTypes(const QSet<QString> &_cardTypes)
+    {
+        cardTypes = _cardTypes;
+        invalidate();
+    }
+    void setCardColors(const QSet<QString> &_cardColors)
+    {
+        cardColors = _cardColors;
+        invalidate();
     }
     void clearFilterAll();
     int rowCount(const QModelIndex &parent = QModelIndex()) const override;
@@ -141,15 +145,4 @@ protected:
     bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const override;
 };
 
-class TokenEditModel : public CardDatabaseDisplayModel
-{
-    Q_OBJECT
-public:
-    explicit TokenEditModel(QObject *parent = nullptr);
-    int rowCount(const QModelIndex &parent = QModelIndex()) const override;
-
-protected:
-    bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const override;
-};
-
 #endif

cockatrice/src/carddbparser/carddatabaseparser.h

@@ -1,12 +1,10 @@
 #ifndef CARDDATABASE_PARSER_H
 #define CARDDATABASE_PARSER_H
 
-#include "../carddatabase.h"
-
 #include <QIODevice>
 #include <QString>
 
-#define COCKATRICE_XML_XSI_NAMESPACE "http://www.w3.org/2001/XMLSchema-instance"
+#include "../carddatabase.h"
 
 class ICardDatabaseParser : public QObject
 {
@@ -15,11 +13,7 @@ public:
 
     virtual bool getCanParseFile(const QString &name, QIODevice &device) = 0;
     virtual void parseFile(QIODevice &device) = 0;
-    virtual bool saveToFile(SetNameMap sets,
-                            CardNameMap cards,
-                            const QString &fileName,
-                            const QString &sourceUrl = "unknown",
-                            const QString &sourceVersion = "unknown") = 0;
+    virtual bool saveToFile(SetNameMap sets, CardNameMap cards, const QString &fileName) = 0;
     static void clearSetlist();
 
 protected:

cockatrice/src/carddbparser/cockatricexml3.cpp

@@ -1,15 +1,11 @@
 #include "cockatricexml3.h"
 
-#include <QCoreApplication>
 #include <QDebug>
 #include <QFile>
 #include <QXmlStreamReader>
-#include <version_string.h>
 
 #define COCKATRICE_XML3_TAGNAME "cockatrice_carddatabase"
 #define COCKATRICE_XML3_TAGVER 3
-#define COCKATRICE_XML3_SCHEMALOCATION                                                                                 \
-    "https://raw.githubusercontent.com/Cockatrice/Cockatrice/master/doc/carddatabase_v3/cards.xsd"
 
 bool CockatriceXml3Parser::getCanParseFile(const QString &fileName, QIODevice &device)
 {
@@ -23,7 +19,7 @@ bool CockatriceXml3Parser::getCanParseFile(const QString &fileName, QIODevice &d
     QXmlStreamReader xml(&device);
     while (!xml.atEnd()) {
         if (xml.readNext() == QXmlStreamReader::StartElement) {
-            if (xml.name().toString() == COCKATRICE_XML3_TAGNAME) {
+            if (xml.name() == COCKATRICE_XML3_TAGNAME) {
                 int version = xml.attributes().value("version").toString().toInt();
                 if (version == COCKATRICE_XML3_TAGVER) {
                     return true;
@@ -52,13 +48,12 @@ void CockatriceXml3Parser::parseFile(QIODevice &device)
                     break;
                 }
 
-                auto name = xml.name().toString();
-                if (name == "sets") {
+                if (xml.name() == "sets") {
                     loadSetsFromXml(xml);
-                } else if (name == "cards") {
+                } else if (xml.name() == "cards") {
                     loadCardsFromXml(xml);
-                } else if (!name.isEmpty()) {
-                    qDebug() << "[CockatriceXml3Parser] Unknown item" << name << ", trying to continue anyway";
+                } else if (xml.name() != "") {
+                    qDebug() << "[CockatriceXml3Parser] Unknown item" << xml.name() << ", trying to continue anyway";
                     xml.skipCurrentElement();
                 }
             }
@@ -73,27 +68,25 @@ void CockatriceXml3Parser::loadSetsFromXml(QXmlStreamReader &xml)
             break;
         }
 
-        auto name = xml.name().toString();
-        if (name == "set") {
+        if (xml.name() == "set") {
             QString shortName, longName, setType;
             QDate releaseDate;
             while (!xml.atEnd()) {
                 if (xml.readNext() == QXmlStreamReader::EndElement) {
                     break;
                 }
-                name = xml.name().toString();
 
-                if (name == "name") {
-                    shortName = xml.readElementText(QXmlStreamReader::IncludeChildElements);
-                } else if (name == "longname") {
-                    longName = xml.readElementText(QXmlStreamReader::IncludeChildElements);
-                } else if (name == "settype") {
-                    setType = xml.readElementText(QXmlStreamReader::IncludeChildElements);
-                } else if (name == "releasedate") {
-                    releaseDate =
-                        QDate::fromString(xml.readElementText(QXmlStreamReader::IncludeChildElements), Qt::ISODate);
-                } else if (!name.isEmpty()) {
-                    qDebug() << "[CockatriceXml3Parser] Unknown set property" << name << ", trying to continue anyway";
+                if (xml.name() == "name") {
+                    shortName = xml.readElementText();
+                } else if (xml.name() == "longname") {
+                    longName = xml.readElementText();
+                } else if (xml.name() == "settype") {
+                    setType = xml.readElementText();
+                } else if (xml.name() == "releasedate") {
+                    releaseDate = QDate::fromString(xml.readElementText(), Qt::ISODate);
+                } else if (xml.name() != "") {
+                    qDebug() << "[CockatriceXml3Parser] Unknown set property" << xml.name()
+                             << ", trying to continue anyway";
                     xml.skipCurrentElement();
                 }
             }
@@ -148,8 +141,7 @@ void CockatriceXml3Parser::loadCardsFromXml(QXmlStreamReader &xml)
             break;
         }
 
-        auto xmlName = xml.name().toString();
-        if (xmlName == "card") {
+        if (xml.name() == "card") {
             QString name = QString("");
             QString text = QString("");
             QVariantHash properties = QVariantHash();
@@ -165,42 +157,40 @@ void CockatriceXml3Parser::loadCardsFromXml(QXmlStreamReader &xml)
                 if (xml.readNext() == QXmlStreamReader::EndElement) {
                     break;
                 }
-                xmlName = xml.name().toString();
-
                 // variable - assigned properties
-                if (xmlName == "name") {
-                    name = xml.readElementText(QXmlStreamReader::IncludeChildElements);
-                } else if (xmlName == "text") {
-                    text = xml.readElementText(QXmlStreamReader::IncludeChildElements);
-                } else if (xmlName == "color") {
-                    colors.append(xml.readElementText(QXmlStreamReader::IncludeChildElements));
-                } else if (xmlName == "token") {
-                    isToken = static_cast<bool>(xml.readElementText(QXmlStreamReader::IncludeChildElements).toInt());
+                if (xml.name() == "name") {
+                    name = xml.readElementText();
+                } else if (xml.name() == "text") {
+                    text = xml.readElementText();
+                } else if (xml.name() == "color") {
+                    colors.append(xml.readElementText());
+                } else if (xml.name() == "token") {
+                    isToken = static_cast<bool>(xml.readElementText().toInt());
                     // generic properties
-                } else if (xmlName == "manacost") {
-                    properties.insert("manacost", xml.readElementText(QXmlStreamReader::IncludeChildElements));
-                } else if (xmlName == "cmc") {
-                    properties.insert("cmc", xml.readElementText(QXmlStreamReader::IncludeChildElements));
-                } else if (xmlName == "type") {
-                    QString type = xml.readElementText(QXmlStreamReader::IncludeChildElements);
+                } else if (xml.name() == "manacost") {
+                    properties.insert("manacost", xml.readElementText());
+                } else if (xml.name() == "cmc") {
+                    properties.insert("cmc", xml.readElementText());
+                } else if (xml.name() == "type") {
+                    QString type = xml.readElementText();
                     properties.insert("type", type);
                     properties.insert("maintype", getMainCardType(type));
-                } else if (xmlName == "pt") {
-                    properties.insert("pt", xml.readElementText(QXmlStreamReader::IncludeChildElements));
-                } else if (xmlName == "loyalty") {
-                    properties.insert("loyalty", xml.readElementText(QXmlStreamReader::IncludeChildElements));
+                } else if (xml.name() == "pt") {
+                    properties.insert("pt", xml.readElementText());
+                } else if (xml.name() == "loyalty") {
+                    properties.insert("loyalty", xml.readElementText());
                     // positioning info
-                } else if (xmlName == "tablerow") {
-                    tableRow = xml.readElementText(QXmlStreamReader::IncludeChildElements).toInt();
-                } else if (xmlName == "cipt") {
-                    cipt = (xml.readElementText(QXmlStreamReader::IncludeChildElements) == "1");
-                } else if (xmlName == "upsidedown") {
-                    upsideDown = (xml.readElementText(QXmlStreamReader::IncludeChildElements) == "1");
+                } else if (xml.name() == "tablerow") {
+                    tableRow = xml.readElementText().toInt();
+                } else if (xml.name() == "cipt") {
+                    cipt = (xml.readElementText() == "1");
+                } else if (xml.name() == "upsidedown") {
+                    upsideDown = (xml.readElementText() == "1");
                     // sets
-                } else if (xmlName == "set") {
+                } else if (xml.name() == "set") {
                     // NOTE: attributes must be read before readElementText()
                     QXmlStreamAttributes attrs = xml.attributes();
-                    QString setName = xml.readElementText(QXmlStreamReader::IncludeChildElements);
+                    QString setName = xml.readElementText();
                     CardInfoPerSet setInfo(internalAddSet(setName));
                     if (attrs.hasAttribute("muId")) {
                         setInfo.setProperty("muid", attrs.value("muId").toString());
@@ -222,14 +212,14 @@ void CockatriceXml3Parser::loadCardsFromXml(QXmlStreamReader &xml)
                         setInfo.setProperty("rarity", attrs.value("rarity").toString());
                     }
                     sets.insert(setName, setInfo);
-                    // related cards
-                } else if (xmlName == "related" || xmlName == "reverse-related") {
+                    // relatd cards
+                } else if (xml.name() == "related" || xml.name() == "reverse-related") {
                     bool attach = false;
                     bool exclude = false;
                     bool variable = false;
                     int count = 1;
                     QXmlStreamAttributes attrs = xml.attributes();
-                    QString cardName = xml.readElementText(QXmlStreamReader::IncludeChildElements);
+                    QString cardName = xml.readElementText();
                     if (attrs.hasAttribute("count")) {
                         if (attrs.value("count").toString().indexOf("x=") == 0) {
                             variable = true;
@@ -254,13 +244,13 @@ void CockatriceXml3Parser::loadCardsFromXml(QXmlStreamReader &xml)
                     }
 
                     auto *relation = new CardRelation(cardName, attach, exclude, variable, count);
-                    if (xmlName == "reverse-related") {
+                    if (xml.name() == "reverse-related") {
                         reverseRelatedCards << relation;
                     } else {
                         relatedCards << relation;
                     }
-                } else if (!xmlName.isEmpty()) {
-                    qDebug() << "[CockatriceXml3Parser] Unknown card property" << xmlName
+                } else if (xml.name() != "") {
+                    qDebug() << "[CockatriceXml3Parser] Unknown card property" << xml.name()
                              << ", trying to continue anyway";
                     xml.skipCurrentElement();
                 }
@@ -412,11 +402,7 @@ static QXmlStreamWriter &operator<<(QXmlStreamWriter &xml, const CardInfoPtr &in
     return xml;
 }
 
-bool CockatriceXml3Parser::saveToFile(SetNameMap sets,
-                                      CardNameMap cards,
-                                      const QString &fileName,
-                                      const QString &sourceUrl,
-                                      const QString &sourceVersion)
+bool CockatriceXml3Parser::saveToFile(SetNameMap sets, CardNameMap cards, const QString &fileName)
 {
     QFile file(fileName);
     if (!file.open(QIODevice::WriteOnly)) {
@@ -429,15 +415,6 @@ bool CockatriceXml3Parser::saveToFile(SetNameMap sets,
     xml.writeStartDocument();
     xml.writeStartElement(COCKATRICE_XML3_TAGNAME);
     xml.writeAttribute("version", QString::number(COCKATRICE_XML3_TAGVER));
-    xml.writeAttribute("xmlns:xsi", COCKATRICE_XML_XSI_NAMESPACE);
-    xml.writeAttribute("xsi:schemaLocation", COCKATRICE_XML3_SCHEMALOCATION);
-
-    xml.writeStartElement("info");
-    xml.writeTextElement("author", QCoreApplication::applicationName() + QString(" %1").arg(VERSION_STRING));
-    xml.writeTextElement("createdAt", QDateTime::currentDateTimeUtc().toString(Qt::ISODate));
-    xml.writeTextElement("sourceUrl", sourceUrl);
-    xml.writeTextElement("sourceVersion", sourceVersion);
-    xml.writeEndElement();
 
     if (sets.count() > 0) {
         xml.writeStartElement("sets");

cockatrice/src/carddbparser/cockatricexml3.h

@@ -1,10 +1,10 @@
 #ifndef COCKATRICE_XML3_H
 #define COCKATRICE_XML3_H
 
-#include "carddatabaseparser.h"
-
 #include <QXmlStreamReader>
 
+#include "carddatabaseparser.h"
+
 class CockatriceXml3Parser : public ICardDatabaseParser
 {
     Q_OBJECT
@@ -14,11 +14,7 @@ public:
     ~CockatriceXml3Parser() override = default;
     bool getCanParseFile(const QString &name, QIODevice &device) override;
     void parseFile(QIODevice &device) override;
-    bool saveToFile(SetNameMap sets,
-                    CardNameMap cards,
-                    const QString &fileName,
-                    const QString &sourceUrl = "unknown",
-                    const QString &sourceVersion = "unknown") override;
+    bool saveToFile(SetNameMap sets, CardNameMap cards, const QString &fileName) override;
 
 private:
     void loadCardsFromXml(QXmlStreamReader &xml);

cockatrice/src/carddbparser/cockatricexml4.cpp

@@ -1,15 +1,11 @@
 #include "cockatricexml4.h"
 
-#include <QCoreApplication>
 #include <QDebug>
 #include <QFile>
 #include <QXmlStreamReader>
-#include <version_string.h>
 
 #define COCKATRICE_XML4_TAGNAME "cockatrice_carddatabase"
 #define COCKATRICE_XML4_TAGVER 4
-#define COCKATRICE_XML4_SCHEMALOCATION                                                                                 \
-    "https://raw.githubusercontent.com/Cockatrice/Cockatrice/master/doc/carddatabase_v4/cards.xsd"
 
 bool CockatriceXml4Parser::getCanParseFile(const QString &fileName, QIODevice &device)
 {
@@ -23,7 +19,7 @@ bool CockatriceXml4Parser::getCanParseFile(const QString &fileName, QIODevice &d
     QXmlStreamReader xml(&device);
     while (!xml.atEnd()) {
         if (xml.readNext() == QXmlStreamReader::StartElement) {
-            if (xml.name().toString() == COCKATRICE_XML4_TAGNAME) {
+            if (xml.name() == COCKATRICE_XML4_TAGNAME) {
                 int version = xml.attributes().value("version").toString().toInt();
                 if (version == COCKATRICE_XML4_TAGVER) {
                     return true;
@@ -52,13 +48,12 @@ void CockatriceXml4Parser::parseFile(QIODevice &device)
                     break;
                 }
 
-                auto xmlName = xml.name().toString();
-                if (xmlName == "sets") {
+                if (xml.name() == "sets") {
                     loadSetsFromXml(xml);
-                } else if (xmlName == "cards") {
+                } else if (xml.name() == "cards") {
                     loadCardsFromXml(xml);
-                } else if (!xmlName.isEmpty()) {
-                    qDebug() << "[CockatriceXml4Parser] Unknown item" << xmlName << ", trying to continue anyway";
+                } else if (xml.name() != "") {
+                    qDebug() << "[CockatriceXml4Parser] Unknown item" << xml.name() << ", trying to continue anyway";
                     xml.skipCurrentElement();
                 }
             }
@@ -73,27 +68,24 @@ void CockatriceXml4Parser::loadSetsFromXml(QXmlStreamReader &xml)
             break;
         }
 
-        auto xmlName = xml.name().toString();
-        if (xmlName == "set") {
+        if (xml.name() == "set") {
             QString shortName, longName, setType;
             QDate releaseDate;
             while (!xml.atEnd()) {
                 if (xml.readNext() == QXmlStreamReader::EndElement) {
                     break;
                 }
-                xmlName = xml.name().toString();
 
-                if (xmlName == "name") {
-                    shortName = xml.readElementText(QXmlStreamReader::IncludeChildElements);
-                } else if (xmlName == "longname") {
-                    longName = xml.readElementText(QXmlStreamReader::IncludeChildElements);
-                } else if (xmlName == "settype") {
-                    setType = xml.readElementText(QXmlStreamReader::IncludeChildElements);
-                } else if (xmlName == "releasedate") {
-                    releaseDate =
-                        QDate::fromString(xml.readElementText(QXmlStreamReader::IncludeChildElements), Qt::ISODate);
-                } else if (!xmlName.isEmpty()) {
-                    qDebug() << "[CockatriceXml4Parser] Unknown set property" << xmlName
+                if (xml.name() == "name") {
+                    shortName = xml.readElementText();
+                } else if (xml.name() == "longname") {
+                    longName = xml.readElementText();
+                } else if (xml.name() == "settype") {
+                    setType = xml.readElementText();
+                } else if (xml.name() == "releasedate") {
+                    releaseDate = QDate::fromString(xml.readElementText(), Qt::ISODate);
+                } else if (xml.name() != "") {
+                    qDebug() << "[CockatriceXml4Parser] Unknown set property" << xml.name()
                              << ", trying to continue anyway";
                     xml.skipCurrentElement();
                 }
@@ -112,9 +104,8 @@ QVariantHash CockatriceXml4Parser::loadCardPropertiesFromXml(QXmlStreamReader &x
             break;
         }
 
-        auto xmlName = xml.name().toString();
-        if (!xmlName.isEmpty()) {
-            properties.insert(xmlName, xml.readElementText(QXmlStreamReader::IncludeChildElements));
+        if (xml.name() != "") {
+            properties.insert(xml.name().toString(), xml.readElementText());
         }
     }
     return properties;
@@ -127,9 +118,7 @@ void CockatriceXml4Parser::loadCardsFromXml(QXmlStreamReader &xml)
             break;
         }
 
-        auto xmlName = xml.name().toString();
-
-        if (xmlName == "card") {
+        if (xml.name() == "card") {
             QString name = QString("");
             QString text = QString("");
             QVariantHash properties = QVariantHash();
@@ -144,51 +133,41 @@ void CockatriceXml4Parser::loadCardsFromXml(QXmlStreamReader &xml)
                 if (xml.readNext() == QXmlStreamReader::EndElement) {
                     break;
                 }
-
-                xmlName = xml.name().toString();
-
                 // variable - assigned properties
-                if (xmlName == "name") {
-                    name = xml.readElementText(QXmlStreamReader::IncludeChildElements);
-                } else if (xmlName == "text") {
-                    text = xml.readElementText(QXmlStreamReader::IncludeChildElements);
-                } else if (xmlName == "token") {
-                    isToken = static_cast<bool>(xml.readElementText(QXmlStreamReader::IncludeChildElements).toInt());
+                if (xml.name() == "name") {
+                    name = xml.readElementText();
+                } else if (xml.name() == "text") {
+                    text = xml.readElementText();
+                } else if (xml.name() == "token") {
+                    isToken = static_cast<bool>(xml.readElementText().toInt());
                     // generic properties
-                } else if (xmlName == "prop") {
+                } else if (xml.name() == "prop") {
                     properties = loadCardPropertiesFromXml(xml);
                     // positioning info
-                } else if (xmlName == "tablerow") {
-                    tableRow = xml.readElementText(QXmlStreamReader::IncludeChildElements).toInt();
-                } else if (xmlName == "cipt") {
-                    cipt = (xml.readElementText(QXmlStreamReader::IncludeChildElements) == "1");
-                } else if (xmlName == "upsidedown") {
-                    upsideDown = (xml.readElementText(QXmlStreamReader::IncludeChildElements) == "1");
+                } else if (xml.name() == "tablerow") {
+                    tableRow = xml.readElementText().toInt();
+                } else if (xml.name() == "cipt") {
+                    cipt = (xml.readElementText() == "1");
+                } else if (xml.name() == "upsidedown") {
+                    upsideDown = (xml.readElementText() == "1");
                     // sets
-                } else if (xmlName == "set") {
+                } else if (xml.name() == "set") {
                     // NOTE: attributes but be read before readElementText()
                     QXmlStreamAttributes attrs = xml.attributes();
-                    QString setName = xml.readElementText(QXmlStreamReader::IncludeChildElements);
-                    auto set = internalAddSet(setName);
-                    if (set->getEnabled()) {
-                        CardInfoPerSet setInfo(set);
-                        for (QXmlStreamAttribute attr : attrs) {
-                            QString attrName = attr.name().toString();
-                            if (attrName == "picURL")
-                                attrName = "picurl";
-                            setInfo.setProperty(attrName, attr.value().toString());
-                        }
-                        sets.insert(setName, setInfo);
+                    QString setName = xml.readElementText();
+                    CardInfoPerSet setInfo(internalAddSet(setName));
+                    for (QXmlStreamAttribute attr : attrs) {
+                        setInfo.setProperty(attr.name().toString(), attr.value().toString());
                     }
-                    // related cards
-                } else if (xmlName == "related" || xmlName == "reverse-related") {
+                    sets.insert(setName, setInfo);
+                    // relatd cards
+                } else if (xml.name() == "related" || xml.name() == "reverse-related") {
                     bool attach = false;
                     bool exclude = false;
                     bool variable = false;
-                    bool persistent = false;
                     int count = 1;
                     QXmlStreamAttributes attrs = xml.attributes();
-                    QString cardName = xml.readElementText(QXmlStreamReader::IncludeChildElements);
+                    QString cardName = xml.readElementText();
                     if (attrs.hasAttribute("count")) {
                         if (attrs.value("count").toString().indexOf("x=") == 0) {
                             variable = true;
@@ -212,18 +191,14 @@ void CockatriceXml4Parser::loadCardsFromXml(QXmlStreamReader &xml)
                         exclude = true;
                     }
 
-                    if (attrs.hasAttribute("persistent")) {
-                        persistent = true;
-                    }
-
-                    auto *relation = new CardRelation(cardName, attach, exclude, variable, count, persistent);
-                    if (xmlName == "reverse-related") {
+                    auto *relation = new CardRelation(cardName, attach, exclude, variable, count);
+                    if (xml.name() == "reverse-related") {
                         reverseRelatedCards << relation;
                     } else {
                         relatedCards << relation;
                     }
-                } else if (!xmlName.isEmpty()) {
-                    qDebug() << "[CockatriceXml4Parser] Unknown card property" << xmlName
+                } else if (xml.name() != "") {
+                    qDebug() << "[CockatriceXml4Parser] Unknown card property" << xml.name()
                              << ", trying to continue anyway";
                     xml.skipCurrentElement();
                 }
@@ -299,9 +274,7 @@ static QXmlStreamWriter &operator<<(QXmlStreamWriter &xml, const CardInfoPtr &in
         if (i->getIsCreateAllExclusion()) {
             xml.writeAttribute("exclude", "exclude");
         }
-        if (i->getIsPersistent()) {
-            xml.writeAttribute("persistent", "persistent");
-        }
+
         if (i->getIsVariable()) {
             if (1 == i->getDefaultCount()) {
                 xml.writeAttribute("count", "x");
@@ -325,9 +298,6 @@ static QXmlStreamWriter &operator<<(QXmlStreamWriter &xml, const CardInfoPtr &in
             xml.writeAttribute("exclude", "exclude");
         }
 
-        if (i->getIsPersistent()) {
-            xml.writeAttribute("persistent", "persistent");
-        }
         if (i->getIsVariable()) {
             if (1 == i->getDefaultCount()) {
                 xml.writeAttribute("count", "x");
@@ -355,11 +325,7 @@ static QXmlStreamWriter &operator<<(QXmlStreamWriter &xml, const CardInfoPtr &in
     return xml;
 }
 
-bool CockatriceXml4Parser::saveToFile(SetNameMap sets,
-                                      CardNameMap cards,
-                                      const QString &fileName,
-                                      const QString &sourceUrl,
-                                      const QString &sourceVersion)
+bool CockatriceXml4Parser::saveToFile(SetNameMap sets, CardNameMap cards, const QString &fileName)
 {
     QFile file(fileName);
     if (!file.open(QIODevice::WriteOnly)) {
@@ -372,15 +338,6 @@ bool CockatriceXml4Parser::saveToFile(SetNameMap sets,
     xml.writeStartDocument();
     xml.writeStartElement(COCKATRICE_XML4_TAGNAME);
     xml.writeAttribute("version", QString::number(COCKATRICE_XML4_TAGVER));
-    xml.writeAttribute("xmlns:xsi", COCKATRICE_XML_XSI_NAMESPACE);
-    xml.writeAttribute("xsi:schemaLocation", COCKATRICE_XML4_SCHEMALOCATION);
-
-    xml.writeStartElement("info");
-    xml.writeTextElement("author", QCoreApplication::applicationName() + QString(" %1").arg(VERSION_STRING));
-    xml.writeTextElement("createdAt", QDateTime::currentDateTimeUtc().toString(Qt::ISODate));
-    xml.writeTextElement("sourceUrl", sourceUrl);
-    xml.writeTextElement("sourceVersion", sourceVersion);
-    xml.writeEndElement();
 
     if (sets.count() > 0) {
         xml.writeStartElement("sets");

cockatrice/src/carddbparser/cockatricexml4.h

@@ -1,10 +1,10 @@
 #ifndef COCKATRICE_XML4_H
 #define COCKATRICE_XML4_H
 
-#include "carddatabaseparser.h"
-
 #include <QXmlStreamReader>
 
+#include "carddatabaseparser.h"
+
 class CockatriceXml4Parser : public ICardDatabaseParser
 {
     Q_OBJECT
@@ -14,11 +14,7 @@ public:
     ~CockatriceXml4Parser() override = default;
     bool getCanParseFile(const QString &name, QIODevice &device) override;
     void parseFile(QIODevice &device) override;
-    bool saveToFile(SetNameMap sets,
-                    CardNameMap cards,
-                    const QString &fileName,
-                    const QString &sourceUrl = "unknown",
-                    const QString &sourceVersion = "unknown") override;
+    bool saveToFile(SetNameMap sets, CardNameMap cards, const QString &fileName) override;
 
 private:
     QVariantHash loadCardPropertiesFromXml(QXmlStreamReader &xml);

cockatrice/src/carddragitem.cpp

@@ -1,11 +1,9 @@
 #include "carddragitem.h"
-
 #include "carditem.h"
 #include "cardzone.h"
 #include "gamescene.h"
 #include "tablezone.h"
 #include "zoneviewzone.h"
-
 #include <QCursor>
 #include <QGraphicsSceneMouseEvent>
 #include <QPainter>

cockatrice/src/cardfilter.cpp

@@ -32,7 +32,7 @@ const QString CardFilter::attrName(Attr a)
         case AttrManaCost:
             return tr("Mana Cost");
         case AttrCmc:
-            return tr("Mana Value");
+            return tr("CMC");
         case AttrRarity:
             return tr("Rarity");
         case AttrPow:
@@ -41,8 +41,6 @@ const QString CardFilter::attrName(Attr a)
             return tr("Toughness");
         case AttrLoyalty:
             return tr("Loyalty");
-        case AttrFormat:
-            return tr("Format");
         default:
             return QString("");
     }

cockatrice/src/cardfilter.h

@@ -3,7 +3,6 @@
 
 #include <QObject>
 #include <QString>
-#include <utility>
 
 class CardFilter : public QObject
 {
@@ -19,7 +18,7 @@ public:
         TypeEnd
     };
 
-    /* if you add an attribute here you also need to
+    /* if you add an atribute here you also need to
      * add its string representation in attrName */
     enum Attr
     {
@@ -34,7 +33,6 @@ public:
         AttrText,
         AttrTough,
         AttrType,
-        AttrFormat,
         AttrEnd
     };
 
@@ -44,7 +42,7 @@ private:
     enum Attr a;
 
 public:
-    CardFilter(QString &term, Type type, Attr attr) : trm(term), t(type), a(attr){};
+    CardFilter(QString term, Type type, Attr attr) : trm(term), t(type), a(attr){};
 
     Type type() const
     {

cockatrice/src/cardframe.cpp

@@ -1,3 +1,5 @@
+#include <utility>
+
 #include "cardframe.h"
 
 #include "cardinfopicture.h"
@@ -8,7 +10,6 @@
 
 #include <QSplitter>
 #include <QVBoxLayout>
-#include <utility>
 
 CardFrame::CardFrame(const QString &cardName, QWidget *parent) : QTabWidget(parent), info(nullptr), cardTextOnly(false)
 {
@@ -55,7 +56,7 @@ CardFrame::CardFrame(const QString &cardName, QWidget *parent) : QTabWidget(pare
     tab3Layout->addWidget(splitter);
     tab3->setLayout(tab3Layout);
 
-    setViewMode(SettingsCache::instance().getCardInfoViewMode());
+    setViewMode(settingsCache->getCardInfoViewMode());
 
     setCard(db->getCard(cardName));
 }
@@ -86,7 +87,7 @@ void CardFrame::setViewMode(int mode)
             break;
     }
 
-    SettingsCache::instance().setCardInfoViewMode(mode);
+    settingsCache->setCardInfoViewMode(mode);
 }
 
 void CardFrame::setCard(CardInfoPtr card)
@@ -107,7 +108,7 @@ void CardFrame::setCard(CardInfoPtr card)
 
 void CardFrame::setCard(const QString &cardName)
 {
-    setCard(db->guessCard(cardName));
+    setCard(db->getCardBySimpleName(cardName));
 }
 
 void CardFrame::setCard(AbstractCardItem *card)

cockatrice/src/cardframe.h

@@ -1,10 +1,10 @@
 #ifndef CARDFRAME_H
 #define CARDFRAME_H
 
-#include "carddatabase.h"
-
 #include <QTabWidget>
 
+#include "carddatabase.h"
+
 class AbstractCardItem;
 class CardInfoPicture;
 class CardInfoText;

cockatrice/src/cardinfopicture.cpp

@@ -1,13 +1,13 @@
 #include "cardinfopicture.h"
 
-#include "carditem.h"
-#include "main.h"
-#include "pictureloader.h"
-
 #include <QPainter>
 #include <QStyle>
 #include <QWidget>
 
+#include "carditem.h"
+#include "main.h"
+#include "pictureloader.h"
+
 CardInfoPicture::CardInfoPicture(QWidget *parent) : QWidget(parent), info(nullptr), pixmapDirty(true)
 {
     setMinimumHeight(100);

cockatrice/src/cardinfopicture.h

@@ -1,10 +1,10 @@
 #ifndef CARDINFOPICTURE_H
 #define CARDINFOPICTURE_H
 
-#include "carddatabase.h"
-
 #include <QWidget>
 
+#include "carddatabase.h"
+
 class AbstractCardItem;
 
 class CardInfoPicture : public QWidget
@@ -17,7 +17,7 @@ private:
     bool pixmapDirty;
 
 public:
-    CardInfoPicture(QWidget *parent = nullptr);
+    CardInfoPicture(QWidget *parent = 0);
 
 protected:
     void resizeEvent(QResizeEvent *event);

cockatrice/src/cardinfotext.cpp

@@ -1,5 +1,4 @@
 #include "cardinfotext.h"
-
 #include "carditem.h"
 #include "game_specific_terms.h"
 #include "main.h"
@@ -12,13 +11,12 @@ CardInfoText::CardInfoText(QWidget *parent) : QFrame(parent), info(nullptr)
 {
     nameLabel = new QLabel;
     nameLabel->setOpenExternalLinks(false);
-    nameLabel->setWordWrap(true);
     connect(nameLabel, SIGNAL(linkActivated(const QString &)), this, SIGNAL(linkActivated(const QString &)));
 
     textLabel = new QTextEdit();
     textLabel->setReadOnly(true);
 
-    auto *grid = new QGridLayout(this);
+    QGridLayout *grid = new QGridLayout(this);
     grid->addWidget(nameLabel, 0, 0);
     grid->addWidget(textLabel, 1, 0, -1, 2);
     grid->setRowStretch(1, 1);
@@ -40,20 +38,24 @@ void CardInfoText::setCard(CardInfoPtr card)
                 .arg(tr("Name:"), card->getName().toHtmlEscaped());
 
     QStringList cardProps = card->getProperties();
-    for (const QString &key : cardProps) {
-        if (key.contains("-"))
-            continue;
+    foreach (QString key, cardProps) {
         QString keyText = Mtg::getNicePropertyName(key).toHtmlEscaped() + ":";
         text +=
             QString("<tr><td>%1</td><td></td><td>%2</td></tr>").arg(keyText, card->getProperty(key).toHtmlEscaped());
     }
 
-    auto relatedCards = card->getAllRelatedCards();
-    if (!relatedCards.empty()) {
+    auto relatedCards = card->getRelatedCards();
+    auto reverserelatedCards2Me = card->getReverseRelatedCards2Me();
+    if (relatedCards.size() || reverserelatedCards2Me.size()) {
         text += QString("<tr><td>%1</td><td width=\"5\"></td><td>").arg(tr("Related cards:"));
 
-        for (auto *relatedCard : relatedCards) {
-            QString tmp = relatedCard->getName().toHtmlEscaped();
+        for (int i = 0; i < relatedCards.size(); ++i) {
+            QString tmp = relatedCards.at(i)->getName().toHtmlEscaped();
+            text += "<a href=\"" + tmp + "\">" + tmp + "</a><br>";
+        }
+
+        for (int i = 0; i < reverserelatedCards2Me.size(); ++i) {
+            QString tmp = reverserelatedCards2Me.at(i)->getName().toHtmlEscaped();
             text += "<a href=\"" + tmp + "\">" + tmp + "</a><br>";
         }
 

cockatrice/src/cardinfotext.h

@@ -1,9 +1,9 @@
 #ifndef CARDINFOTEXT_H
 #define CARDINFOTEXT_H
 
-#include "carddatabase.h"
-
 #include <QFrame>
+
+#include "carddatabase.h"
 class QLabel;
 class QTextEdit;
 
@@ -17,7 +17,7 @@ private:
     CardInfoPtr info;
 
 public:
-    explicit CardInfoText(QWidget *parent = nullptr);
+    CardInfoText(QWidget *parent = 0);
     void retranslateUi();
     void setInvalidCardName(const QString &cardName);
 

cockatrice/src/cardinfowidget.cpp

@@ -1,14 +1,12 @@
-#include "cardinfowidget.h"
+#include <utility>
 
 #include "cardinfopicture.h"
 #include "cardinfotext.h"
+#include "cardinfowidget.h"
 #include "carditem.h"
 #include "main.h"
-
-#include <QApplication>
-#include <QScreen>
+#include <QDesktopWidget>
 #include <QVBoxLayout>
-#include <utility>
 
 CardInfoWidget::CardInfoWidget(const QString &cardName, QWidget *parent, Qt::WindowFlags flags)
     : QFrame(parent, flags), aspectRatio((qreal)CARD_HEIGHT / (qreal)CARD_WIDTH), info(nullptr)
@@ -29,8 +27,8 @@ CardInfoWidget::CardInfoWidget(const QString &cardName, QWidget *parent, Qt::Win
     setLayout(layout);
 
     setFrameStyle(QFrame::Panel | QFrame::Raised);
-
-    int pixmapHeight = QGuiApplication::primaryScreen()->geometry().height() / 3;
+    QDesktopWidget desktopWidget;
+    int pixmapHeight = desktopWidget.screenGeometry().height() / 3;
     int pixmapWidth = static_cast<int>(pixmapHeight / aspectRatio);
     pic->setFixedWidth(pixmapWidth);
     pic->setFixedHeight(pixmapHeight);
@@ -56,10 +54,9 @@ void CardInfoWidget::setCard(CardInfoPtr card)
 
 void CardInfoWidget::setCard(const QString &cardName)
 {
-    setCard(db->guessCard(cardName));
-    if (info == nullptr) {
+    setCard(db->getCardBySimpleName(cardName));
+    if (!info)
         text->setInvalidCardName(cardName);
-    }
 }
 
 void CardInfoWidget::setCard(AbstractCardItem *card)

cockatrice/src/cardinfowidget.h

@@ -1,12 +1,12 @@
 #ifndef CARDINFOWIDGET_H
 #define CARDINFOWIDGET_H
 
-#include "carddatabase.h"
-
 #include <QComboBox>
 #include <QFrame>
 #include <QStringList>
 
+#include "carddatabase.h"
+
 class CardInfoPicture;
 class CardInfoText;
 class AbstractCardItem;
@@ -22,7 +22,7 @@ private:
     CardInfoText *text;
 
 public:
-    explicit CardInfoWidget(const QString &cardName, QWidget *parent = nullptr, Qt::WindowFlags f = {});
+    explicit CardInfoWidget(const QString &cardName, QWidget *parent = nullptr, Qt::WindowFlags f = nullptr);
 
 public slots:
     void setCard(CardInfoPtr card);

cockatrice/src/carditem.cpp

@@ -1,5 +1,4 @@
 #include "carditem.h"
-
 #include "arrowitem.h"
 #include "carddatabase.h"
 #include "carddragitem.h"
@@ -12,20 +11,14 @@
 #include "tab_game.h"
 #include "tablezone.h"
 #include "zoneviewzone.h"
-
 #include <QApplication>
 #include <QGraphicsSceneMouseEvent>
 #include <QMenu>
 #include <QPainter>
 
-CardItem::CardItem(Player *_owner,
-                   const QString &_name,
-                   int _cardid,
-                   bool _revealedCard,
-                   QGraphicsItem *parent,
-                   CardZone *_zone)
-    : AbstractCardItem(_name, _owner, _cardid, parent), zone(_zone), revealedCard(_revealedCard), attacking(false),
-      destroyOnZoneChange(false), doesntUntap(false), dragItem(nullptr), attachedTo(nullptr)
+CardItem::CardItem(Player *_owner, const QString &_name, int _cardid, bool _revealedCard, QGraphicsItem *parent)
+    : AbstractCardItem(_name, _owner, _cardid, parent), zone(0), revealedCard(_revealedCard), attacking(false),
+      destroyOnZoneChange(false), doesntUntap(false), dragItem(0), attachedTo(0)
 {
     owner->addCard(this);
 
@@ -34,6 +27,7 @@ CardItem::CardItem(Player *_owner,
     moveMenu = new QMenu;
 
     retranslateUi();
+    emit updateCardMenu(this);
 }
 
 CardItem::~CardItem()
@@ -52,22 +46,22 @@ CardItem::~CardItem()
 
 void CardItem::prepareDelete()
 {
-    if (owner != nullptr) {
+    if (owner) {
         if (owner->getCardMenu() == cardMenu) {
-            owner->setCardMenu(nullptr);
-            owner->getGame()->setActiveCard(nullptr);
+            owner->setCardMenu(0);
+            owner->getGame()->setActiveCard(0);
         }
-        owner = nullptr;
+        owner = 0;
     }
 
     while (!attachedCards.isEmpty()) {
-        attachedCards.first()->setZone(nullptr); // so that it won't try to call reorganizeCards()
-        attachedCards.first()->setAttachedTo(nullptr);
+        attachedCards.first()->setZone(0); // so that it won't try to call reorganizeCards()
+        attachedCards.first()->setAttachedTo(0);
     }
 
-    if (attachedTo != nullptr) {
+    if (attachedTo) {
         attachedTo->removeAttachedCard(this);
-        attachedTo = nullptr;
+        attachedTo = 0;
     }
 }
 
@@ -80,6 +74,7 @@ void CardItem::deleteLater()
 void CardItem::setZone(CardZone *_zone)
 {
     zone = _zone;
+    emit updateCardMenu(this);
 }
 
 void CardItem::retranslateUi()
@@ -111,12 +106,17 @@ void CardItem::paint(QPainter *painter, const QStyleOptionGraphicsItem *option,
         painter->save();
         transformPainter(painter, translatedSize, tapAngle);
 
-        if (!getFaceDown() && info && pt == info->getPowTough()) {
-            painter->setPen(Qt::white);
-        } else {
-            painter->setPen(QColor(255, 150, 0)); // dark orange
-        }
+        if (info) {
+            QStringList ptSplit = pt.split("/");
+            QStringList ptDbSplit = info->getPowTough().split("/");
 
+            if (getFaceDown() || ptDbSplit.at(0) != ptSplit.at(0) || ptDbSplit.at(1) != ptSplit.at(1))
+                painter->setPen(QColor(255, 150, 0));
+            else
+                painter->setPen(Qt::white);
+        } else {
+            painter->setPen(Qt::white);
+        }
         painter->setBackground(Qt::black);
         painter->setBackgroundMode(Qt::OpaqueMode);
 
@@ -142,6 +142,7 @@ void CardItem::paint(QPainter *painter, const QStyleOptionGraphicsItem *option,
 
     if (getBeingPointedAt()) {
         painter->fillRect(boundingRect(), QBrush(QColor(255, 0, 0, 100)));
+        painter->restore();
     }
 
     if (doesntUntap) {
@@ -159,8 +160,6 @@ void CardItem::paint(QPainter *painter, const QStyleOptionGraphicsItem *option,
 
         painter->restore();
     }
-
-    painter->restore();
 }
 
 void CardItem::setAttacking(bool _attacking)
@@ -198,25 +197,23 @@ void CardItem::setPT(const QString &_pt)
 
 void CardItem::setAttachedTo(CardItem *_attachedTo)
 {
-    if (attachedTo != nullptr) {
+    if (attachedTo)
         attachedTo->removeAttachedCard(this);
-    }
 
     gridPoint.setX(-1);
     attachedTo = _attachedTo;
-    if (attachedTo != nullptr) {
+    if (attachedTo) {
         setParentItem(attachedTo->getZone());
         attachedTo->addAttachedCard(this);
-        if (zone != attachedTo->getZone()) {
+        if (zone != attachedTo->getZone())
             attachedTo->getZone()->reorganizeCards();
-        }
-    } else {
+    } else
         setParentItem(zone);
-    }
 
-    if (zone != nullptr) {
+    if (zone)
         zone->reorganizeCards();
-    }
+
+    emit updateCardMenu(this);
 }
 
 void CardItem::resetState()
@@ -270,10 +267,9 @@ CardDragItem *CardItem::createDragItem(int _id, const QPointF &_pos, const QPoin
 
 void CardItem::deleteDragItem()
 {
-    if (dragItem) {
+    if (dragItem)
         dragItem->deleteLater();
-    }
-    dragItem = nullptr;
+    dragItem = NULL;
 }
 
 void CardItem::drawArrow(const QColor &arrowColor)
@@ -286,36 +282,15 @@ void CardItem::drawArrow(const QColor &arrowColor)
     scene()->addItem(arrow);
     arrow->grabMouse();
 
-    for (const auto &item : scene()->selectedItems()) {
-        CardItem *card = qgraphicsitem_cast<CardItem *>(item);
-        if (card == nullptr || card == this)
+    QListIterator<QGraphicsItem *> itemIterator(scene()->selectedItems());
+    while (itemIterator.hasNext()) {
+        CardItem *c = qgraphicsitem_cast<CardItem *>(itemIterator.next());
+        if (!c || (c == this))
             continue;
-        if (card->getZone() != zone)
+        if (c->getZone() != zone)
             continue;
 
-        ArrowDragItem *childArrow = new ArrowDragItem(arrowOwner, card, arrowColor);
-        scene()->addItem(childArrow);
-        arrow->addChildArrow(childArrow);
-    }
-}
-
-void CardItem::drawAttachArrow()
-{
-    if (static_cast<TabGame *>(owner->parent())->getSpectator())
-        return;
-
-    auto *arrow = new ArrowAttachItem(this);
-    scene()->addItem(arrow);
-    arrow->grabMouse();
-
-    for (const auto &item : scene()->selectedItems()) {
-        CardItem *card = qgraphicsitem_cast<CardItem *>(item);
-        if (card == nullptr)
-            continue;
-        if (card->getZone() != zone)
-            continue;
-
-        ArrowAttachItem *childArrow = new ArrowAttachItem(card);
+        ArrowDragItem *childArrow = new ArrowDragItem(arrowOwner, c, arrowColor);
         scene()->addItem(childArrow);
         arrow->addChildArrow(childArrow);
     }
@@ -345,7 +320,7 @@ void CardItem::mouseMoveEvent(QGraphicsSceneMouseEvent *event)
             const ZoneViewZone *view = static_cast<const ZoneViewZone *>(zone);
             if (view->getRevealZone() && !view->getWriteableRevealZone())
                 return;
-        } else if (!owner->getLocalOrJudge())
+        } else if (!owner->getLocal())
             return;
 
         bool forceFaceDown = event->modifiers().testFlag(Qt::ShiftModifier);
@@ -353,19 +328,19 @@ void CardItem::mouseMoveEvent(QGraphicsSceneMouseEvent *event)
         createDragItem(id, event->pos(), event->scenePos(), facedown || forceFaceDown);
         dragItem->grabMouse();
 
-        int childIndex = 0;
-        for (const auto &item : scene()->selectedItems()) {
-            CardItem *card = static_cast<CardItem *>(item);
-            if ((card == this) || (card->getZone() != zone))
+        QList<QGraphicsItem *> sel = scene()->selectedItems();
+        int j = 0;
+        for (int i = 0; i < sel.size(); i++) {
+            CardItem *c = static_cast<CardItem *>(sel.at(i));
+            if ((c == this) || (c->getZone() != zone))
                 continue;
-            ++childIndex;
+            ++j;
             QPointF childPos;
             if (zone->getHasCardAttr())
-                childPos = card->pos() - pos();
+                childPos = c->pos() - pos();
             else
-                childPos = QPointF(childIndex * CARD_WIDTH / 2, 0);
-            CardDragItem *drag =
-                new CardDragItem(card, card->getId(), childPos, card->getFaceDown() || forceFaceDown, dragItem);
+                childPos = QPointF(j * CARD_WIDTH / 2, 0);
+            CardDragItem *drag = new CardDragItem(c, c->getId(), childPos, c->getFaceDown() || forceFaceDown, dragItem);
             drag->setPos(dragItem->pos() + childPos);
             scene()->addItem(drag);
         }
@@ -376,7 +351,7 @@ void CardItem::mouseMoveEvent(QGraphicsSceneMouseEvent *event)
 void CardItem::playCard(bool faceDown)
 {
     // Do nothing if the card belongs to another player
-    if (!owner->getLocalOrJudge())
+    if (!owner->getLocal())
         return;
 
     TableZone *tz = qobject_cast<TableZone *>(zone);
@@ -389,15 +364,15 @@ void CardItem::playCard(bool faceDown)
 void CardItem::mouseReleaseEvent(QGraphicsSceneMouseEvent *event)
 {
     if (event->button() == Qt::RightButton) {
-        if (cardMenu != nullptr && !cardMenu->isEmpty() && owner != nullptr) {
-            cardMenu->popup(event->screenPos());
-            return;
+        if (cardMenu && !cardMenu->isEmpty() && owner) {
+            owner->updateCardMenu(this);
+            cardMenu->exec(event->screenPos());
         }
     } else if ((event->modifiers() != Qt::AltModifier) && (event->button() == Qt::LeftButton) &&
-               (!SettingsCache::instance().getDoubleClickToPlay())) {
+               (!settingsCache->getDoubleClickToPlay())) {
         bool hideCard = false;
         if (zone && zone->getIsView()) {
-            auto *view = static_cast<ZoneViewZone *>(zone);
+            ZoneViewZone *view = static_cast<ZoneViewZone *>(zone);
             if (view->getRevealZone() && !view->getWriteableRevealZone())
                 hideCard = true;
         }
@@ -408,15 +383,13 @@ void CardItem::mouseReleaseEvent(QGraphicsSceneMouseEvent *event)
         }
     }
 
-    if (owner != nullptr) { // cards without owner will be deleted
-        setCursor(Qt::OpenHandCursor);
-    }
+    setCursor(Qt::OpenHandCursor);
     AbstractCardItem::mouseReleaseEvent(event);
 }
 
 void CardItem::mouseDoubleClickEvent(QGraphicsSceneMouseEvent *event)
 {
-    if ((event->modifiers() != Qt::AltModifier) && (SettingsCache::instance().getDoubleClickToPlay()) &&
+    if ((event->modifiers() != Qt::AltModifier) && (settingsCache->getDoubleClickToPlay()) &&
         (event->buttons() == Qt::LeftButton)) {
         if (revealedCard)
             zone->removeCard(this);
@@ -455,13 +428,13 @@ bool CardItem::animationEvent()
 
 QVariant CardItem::itemChange(GraphicsItemChange change, const QVariant &value)
 {
-    if ((change == ItemSelectedHasChanged) && owner != nullptr) {
+    if ((change == ItemSelectedHasChanged) && owner) {
         if (value == true) {
             owner->setCardMenu(cardMenu);
             owner->getGame()->setActiveCard(this);
         } else if (owner->getCardMenu() == cardMenu) {
-            owner->setCardMenu(nullptr);
-            owner->getGame()->setActiveCard(nullptr);
+            owner->setCardMenu(0);
+            owner->getGame()->setActiveCard(0);
         }
     }
     return QGraphicsItem::itemChange(change, value);

cockatrice/src/carditem.h

@@ -2,7 +2,6 @@
 #define CARDITEM_H
 
 #include "abstractcarditem.h"
-#include "server_card.h"
 
 class CardDatabase;
 class CardDragItem;
@@ -53,8 +52,7 @@ public:
              const QString &_name = QString(),
              int _cardid = -1,
              bool revealedCard = false,
-             QGraphicsItem *parent = nullptr,
-             CardZone *_zone = nullptr);
+             QGraphicsItem *parent = 0);
     ~CardItem();
     void retranslateUi();
     CardZone *getZone() const
@@ -131,7 +129,7 @@ public:
     }
     void removeAttachedCard(CardItem *card)
     {
-        attachedCards.removeOne(card);
+        attachedCards.removeAt(attachedCards.indexOf(card));
     }
     const QList<CardItem *> &getAttachedCards() const
     {
@@ -157,7 +155,6 @@ public:
     CardDragItem *createDragItem(int _id, const QPointF &_pos, const QPointF &_scenePos, bool faceDown);
     void deleteDragItem();
     void drawArrow(const QColor &arrowColor);
-    void drawAttachArrow();
     void playCard(bool faceDown);
 
 protected:

cockatrice/src/cardlist.cpp

@@ -1,10 +1,7 @@
 #include "cardlist.h"
-
 #include "carddatabase.h"
 #include "carditem.h"
 
-#include <algorithm>
-
 CardList::CardList(bool _contentsKnown) : QList<CardItem *>(), contentsKnown(_contentsKnown)
 {
 }
@@ -59,5 +56,5 @@ public:
 void CardList::sort(int flags)
 {
     compareFunctor cf(flags);
-    std::sort(begin(), end(), cf);
+    qSort(begin(), end(), cf);
 }

cockatrice/src/cardzone.cpp

@@ -1,11 +1,9 @@
 #include "cardzone.h"
-
 #include "carditem.h"
 #include "pb/command_move_card.pb.h"
 #include "pb/serverinfo_user.pb.h"
 #include "player.h"
 #include "zoneviewzone.h"
-
 #include <QAction>
 #include <QDebug>
 #include <QGraphicsSceneMouseEvent>
@@ -18,7 +16,7 @@ CardZone::CardZone(Player *_p,
                    bool _contentsKnown,
                    QGraphicsItem *parent,
                    bool _isView)
-    : AbstractGraphicsItem(parent), player(_p), name(_name), cards(_contentsKnown), views{}, menu(nullptr),
+    : AbstractGraphicsItem(parent), player(_p), name(_name), cards(_contentsKnown), view(NULL), menu(NULL),
       doubleClickAction(0), hasCardAttr(_hasCardAttr), isShufflable(_isShufflable), isView(_isView)
 {
     if (!isView)
@@ -28,11 +26,7 @@ CardZone::CardZone(Player *_p,
 CardZone::~CardZone()
 {
     qDebug() << "CardZone destructor: " << name;
-    for (auto *view : views) {
-        if (view != nullptr) {
-            view->deleteLater();
-        }
-    }
+    delete view;
     clearContents();
 }
 
@@ -124,11 +118,9 @@ void CardZone::mousePressEvent(QGraphicsSceneMouseEvent *event)
 
 void CardZone::addCard(CardItem *card, bool reorganize, int x, int y)
 {
-    for (auto *view : views) {
-        if ((x <= view->getCards().size()) || (view->getNumberCards() == -1)) {
+    if (view)
+        if ((x <= view->getCards().size()) || (view->getNumberCards() == -1))
             view->addCard(new CardItem(player, card->getName(), card->getId()), reorganize, x, y);
-        }
-    }
 
     card->setZone(this);
     addCardImpl(card, x, y);
@@ -174,9 +166,8 @@ CardItem *CardZone::takeCard(int position, int cardId, bool /*canResize*/)
 
     CardItem *c = cards.takeAt(position);
 
-    for (auto *view : views) {
+    if (view)
         view->removeCard(position);
-    }
 
     c->setId(cardId);
 
@@ -187,7 +178,7 @@ CardItem *CardZone::takeCard(int position, int cardId, bool /*canResize*/)
 
 void CardZone::removeCard(CardItem *card)
 {
-    cards.removeOne(card);
+    cards.removeAt(cards.indexOf(card));
     reorganizeCards();
     emit cardCountChanged();
     player->deleteCard(card);