Cockatrice

gitea-mirror/Cockatrice

Fork 0

mirror of https://github.com/Cockatrice/Cockatrice.git synced 2026-07-28 14:47:11 -07:00

Files

T

History

DawnFire42andGitHub 05ae6f47a6 Unify counter clamp arithmetic into shared addClamped() helper (#7009 )

* Unify counter clamp arithmetic into shared addClamped() helper

- Add addClamped() in new header clamped_arithmetic.h; uses a 64-bit
  intermediate so the addition cannot overflow int.
- Use it in Server_Card::incrementCounter() (clamps [0, MAX_COUNTERS_ON_CARD])
  and Server_Counter::incrementCount() (clamps [INT_MIN, INT_MAX]), removing
  the duplicated overflow-safe logic and its keep-in-sync TODO.
- Inline incrementCount() into server_counter.h; server_counter.cpp now holds
  only the constructor and getInfo().
- Clarify the card-counter bounds comment in trice_limits.h.

* Rename MAX_COUNTERS_ON_CARD to MAX_COUNTER_VALUE

The constant caps the counter's value, not how many counters can be on the card

* Add direct unit tests for addClamped() helper

* Harden offsetCardCounter() against signed-int overflow

Replace the raw oldValue + offset sum with addClamped(), clamping to [0, MAX_COUNTER_VALUE] without overflow.

* Comment update

* Remove class names from addClamped() docstring

2026-06-28 16:10:57 -07:00

card_zone_algorithms

[Game/Zones] Simple move refactor to differentiate between logic and graphics for zones (#6903 )

2026-05-18 06:36:18 +02:00

carddatabase

Fix/cmake test only build (#6709 )

2026-03-15 17:24:50 +01:00

loading_from_clipboard

Fix/cmake test only build (#6709 )

2026-03-15 17:24:50 +01:00

movecard_tests

Fix #6659 : Correct logging for bottom-of-library card moves (#6764 )