gitea-mirror/basic-computer-games
1
0
Fork 0
mirror of https://github.com/coding-horror/basic-computer-games.git synced 2025-12-26 20:54:07 -08:00
Code Issues Packages Projects Releases Wiki Activity

Clean Code: Apply flake8-simplify to Python

Browse Source 
Also flake8-comprehensions which was added to the CI

For flake8-simplify, there are a few false-positives,
e.g. https://github.com/MartinThoma/flake8-simplify/issues/115
This commit is contained in:
Martin Thoma
2022-03-18 22:27:31 +01:00
parent d43ec589c8
commit 3b2739b8a2
28 changed files with 168 additions and 214 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
46_Hexapawn/python/hexapawn.py
View File

@@ -138,10 +138,10 @@ class BoardLayout:
self.moves = move_list
def _check_match_no_mirror(self, cell_list):
for space_index, board_contents in enumerate(self.cells):
if board_contents != cell_list[space_index]:
return False
return True
return all(
board_contents == cell_list[space_index]
for space_index, board_contents in enumerate(self.cells)
)
def _check_match_with_mirror(self, cell_list):
for space_index, board_contents in enumerate(self.cells):
@@ -286,17 +286,11 @@ def is_legal_human_move(board, m1, m2):
def player_piece_on_back_row(board):
for space in range(1, 4):
if board_contents(board, space) == HUMAN_PIECE:
return True
return False
return any(board_contents(board, space) == HUMAN_PIECE for space in range(1, 4))
def computer_piece_on_front_row(board):
for space in range(7, 10):
if board_contents(board, space) == COMPUTER_PIECE:
return True
return False
return any(board_contents(board, space) == COMPUTER_PIECE for space in range(7, 10))
def all_human_pieces_captured(board):