gitea-mirror/basic-computer-games
1
0
Fork 0
mirror of https://github.com/coding-horror/basic-computer-games.git synced 2025-12-26 04:41:52 -08:00
Code Issues Packages Projects Releases Wiki Activity

Refactor Game.play() to handle split hands more elegantly

Browse Source
This commit is contained in:
Dave Burke
2022-03-02 22:15:44 -06:00
parent ccbed873e5
commit 5e950275fa
3 changed files with 180 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files

135
10_Blackjack/java/src/Game.java
View File

@@ -138,119 +138,72 @@ public class Game {
* @param player
*/
protected void play(Player player) {
String action = userIo.prompt("PLAYER " + player.getPlayerNumber() + " ");
play(player, 1);
}
private void play(Player player, int handNumber) {
List<Card> hand = player.getHand(handNumber);
String action;
if(player.isSplit()){
action = userIo.prompt("HAND #" + handNumber);
} else {
action = userIo.prompt("PLAYER " + player.getPlayerNumber() + " ");
}
while(true){
if(action.equalsIgnoreCase("H")){ // HIT
Card c = deck.deal();
player.dealCard(c);
if(scoreHand(player.getHand()) > 21){
player.dealCard(c, handNumber);
if(scoreHand(hand) > 21){
userIo.println("...BUSTED");
return;
}
action = userIo.prompt("RECEIVED A " + c.toString() + " HIT");
} else if(action.equalsIgnoreCase("S")){ // STAY
return;
} else if(player.getHand().size() == 2 && action.equalsIgnoreCase("D")) { // DOUBLE DOWN
player.setCurrentBet(player.getCurrentBet() * 2);
player.dealCard(deck.deal());
} else if(action.equalsIgnoreCase("D") && player.canDoubleDown(handNumber)) { // DOUBLE DOWN
player.doubleDown(deck.deal(), handNumber);
return;
} else if(player.getHand().size() == 2 && action.equalsIgnoreCase("/")) { // SPLIT
if(player.getHand().get(0).equals(player.getHand().get(1))){
playSplit(player);
} else if(action.equalsIgnoreCase("/")) { // SPLIT
if(player.isSplit()) {
// The original basic code printed different output
// if a player tries to split twice vs if they try to split
// a non-pair hand.
action = userIo.prompt("TYPE H, S OR D, PLEASE");
} else if(player.canSplit()) {
player.split();
Card card = deck.deal();
player.dealCard(card, 1);
// TODO move the "a" vs "an" logic to userIo or Card
if(card.getValue() == 1 || card.getValue() == 8) {
userIo.println("FIRST HAND RECEIVES AN " + card.toString());
} else {
userIo.println("FIRST HAND RECEIVES A " + card.toString());
}
play(player, 1);
card = deck.deal();
player.dealCard(card, 2);
if(card.getValue() == 1 || card.getValue() == 8) {
userIo.println("SECOND HAND RECEIVES AN " + card.toString());
} else {
userIo.println("SECOND HAND RECEIVES A " + card.toString());
}
play(player, 2);
return;
} else {
userIo.println("SPLITTING NOT ALLOWED");
action = userIo.prompt("PLAYER " + player.getPlayerNumber() + " ");
}
} else {
if(player.getHand().size() > 2) {
action = userIo.prompt("TYPE H, OR S, PLEASE");
} else {
if(player.getHand(handNumber).size() == 2) {
action = userIo.prompt("TYPE H,S,D, OR /, PLEASE");
} else {
action = userIo.prompt("TYPE H, OR S, PLEASE");
}
}
}
}
/**
* Splits the players hand and deals a card to each hand then prompts the user to
* hit (H), stay (S), or double down (D), and then performs those actions.
*
* @param player
*/
protected void playSplit(Player player) {
// TODO refactor to avoid so much logic duplication
player.split();
// DEAL CARDS
Card card = deck.deal();
player.dealCard(card);
if(card.getValue() == 1 || card.getValue() == 8) {
userIo.println("FIRST HAND RECEIVES AN " + card.toString());
} else {
userIo.println("FIRST HAND RECEIVES A " + card.toString());
}
card = deck.deal();
player.dealSplitHandCard(card);
if(card.getValue() == 1 || card.getValue() == 8) {
userIo.println("SECOND HAND RECEIVES AN " + card.toString());
} else {
userIo.println("SECOND HAND RECEIVES A " + card.toString());
}
// Play hand 1
String action = userIo.prompt("HAND 1");
while(true){
if(action.equalsIgnoreCase("H")){ // HIT
Card c = deck.deal();
player.dealCard(c);
if(scoreHand(player.getHand()) > 21){
userIo.println("...BUSTED");
break;
}
action = userIo.prompt("RECEIVED A " + c.toString() + " HIT");
} else if(action.equalsIgnoreCase("S")){ // STAY
break;
} else if(player.getHand().size() == 2 && action.equalsIgnoreCase("D")) { // DOUBLE DOWN
player.setCurrentBet(player.getCurrentBet() * 2);
player.dealCard(deck.deal());
break;
} else {
if(player.getHand().size() > 2) {
action = userIo.prompt("TYPE H, OR S, PLEASE");
} else {
action = userIo.prompt("TYPE H, S OR D, PLEASE");
}
}
}
// Play hand 2
action = userIo.prompt("HAND 2");
while(true){
if(action.equalsIgnoreCase("H")){ // HIT
Card c = deck.deal();
player.dealSplitHandCard(card);
if(scoreHand(player.getSplitHand()) > 21){
userIo.println("...BUSTED");
break;
}
action = userIo.prompt("RECEIVED A " + c.toString() + " HIT");
} else if(action.equalsIgnoreCase("S")){ // STAY
break;
} else if(player.getSplitHand().size() == 2 && action.equalsIgnoreCase("D")) { // DOUBLE DOWN
player.setSplitBet(player.getSplitBet() * 2);
player.dealSplitHandCard(card);
break;
} else {
if(player.getSplitHand().size() > 2) {
action = userIo.prompt("TYPE H, OR S, PLEASE");
} else {
action = userIo.prompt("TYPE H, S OR D, PLEASE");
}
}
}
//TODO Uncomment playSplit tests and adjust as needed
}
/**
* Calculates the value of a hand. When the hand contains aces, it will

88
10_Blackjack/java/src/Player.java
View File

@@ -1,4 +1,6 @@
import java.util.Collections;
import java.util.LinkedList;
import java.util.List;
public class Player {
@@ -20,31 +22,23 @@ public class Player {
splitBet = 0;
total = 0;
hand = new LinkedList<>();
splitHand = new LinkedList<>();
}
public void setPlayerNumber(int playerNumber) {
this.playerNumber = playerNumber;
splitHand = null;
}
public int getPlayerNumber() {
return this.playerNumber;
}
public void setCurrentBet(double currentBet) {
this.currentBet = currentBet;
}
public double getCurrentBet() {
return this.currentBet;
}
public double getSplitBet() {
return splitBet;
public void setCurrentBet(double currentBet) {
this.currentBet = currentBet;
}
public void setSplitBet(double splitBet) {
this.splitBet = splitBet;
public double getSplitBet() {
return splitBet;
}
public double getInsuranceBet() {
@@ -79,31 +73,81 @@ public class Player {
// dealCard adds the given card to the player's hand
public void dealCard(Card card) {
hand.add(card);
dealCard(card, 1);
}
public void dealSplitHandCard(Card card) {
splitHand.add(card);
public void dealCard(Card card, int handNumber) {
if(handNumber == 1) {
hand.add(card);
} else if (handNumber == 2) {
splitHand.add(card);
} else {
throw new IllegalArgumentException("Invalid hand number " + handNumber);
}
}
public boolean canSplit() {
if(isSplit()) {
// Can't split twice
return false;
} else {
boolean isPair = this.hand.get(0).getValue() == this.hand.get(1).getValue();
return isPair;
}
}
public boolean isSplit() {
return this.splitHand != null;
}
/**
* Removes first card from hand to adds it to split hand
* Removes first card from hand to add it to new split hand
*/
public void split() {
this.splitBet = this.currentBet;
this.splitHand = new LinkedList<>();
splitHand.add(hand.pop());
}
public boolean canDoubleDown(int handNumber) {
if(handNumber == 1){
return this.hand.size() == 2;
} else if(handNumber == 2){
return this.splitHand.size() == 2;
} else {
throw new IllegalArgumentException("Invalid hand number " + handNumber);
}
}
public void doubleDown(Card card, int handNumber) {
if(handNumber == 1){
this.currentBet = this.currentBet * 2;
} else if(handNumber == 2){
this.splitBet = this.splitBet * 2;
} else {
throw new IllegalArgumentException("Invalid hand number " + handNumber);
}
this.dealCard(card, handNumber);
}
// resetHand resets 'hand' & 'splitHand' to empty lists
public void resetHand() {
this.hand = new LinkedList<>();
this.splitHand = new LinkedList<>();
this.splitHand = null;
}
public LinkedList<Card> getHand() {
return this.hand;
public List<Card> getHand() {
return getHand(1);
}
public LinkedList<Card> getSplitHand() {
return this.splitHand;
public List<Card> getHand(int handNumber) {
if(handNumber == 1){
return Collections.unmodifiableList(this.hand);
} else if(handNumber == 2){
return Collections.unmodifiableList(this.splitHand);
} else {
throw new IllegalArgumentException("Invalid hand number " + handNumber);
}
}
}