gitea-mirror/basic-computer-games
1
0
Fork 0
mirror of https://github.com/coding-horror/basic-computer-games.git synced 2025-12-22 23:26:40 -08:00
Code Issues Packages Projects Releases Wiki Activity

Simplify player input

Browse Source
This commit is contained in:
Andrew Cooper
2022-09-08 07:53:02 +10:00
parent 96a0d7bee5
commit c1d43a742a
2 changed files with 35 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
56_Life_for_Two/csharp/IOExtensions.cs Normal file
View File

@@ -0,0 +1,22 @@
internal static class IOExtensions
{
internal static Coordinates ReadCoordinates(this IReadWrite io, int player, Board board)
{
io.WriteLine(Formats.Player, player);
return io.ReadCoordinates(board);
}
internal static Coordinates ReadCoordinates(this IReadWrite io, Board board)
{
while (true)
{
io.WriteLine("X,Y");
var values = io.Read2Numbers("&&&&&&\r");
if (Coordinates.TryCreate(values, out var coordinates) && board[coordinates] == 0)
{
return coordinates;
}
io.Write(Streams.IllegalCoords);
}
}
}

47
56_Life_for_Two/csharp/Program.cs
View File

@@ -7,7 +7,6 @@ var io = new ConsoleIO();
io.Write(Streams.Title); io.Write(Streams.Title);
var _board = new Board(); var _board = new Board();
var _coordinates = new Coordinates[3];
int _player1Count, _player2Count; int _player1Count, _player2Count;
for (var _player = 1; _player <= 2; _player++) for (var _player = 1; _player <= 2; _player++)
@@ -16,8 +15,7 @@ for (var _player = 1; _player <= 2; _player++)
io.WriteLine(Formats.InitialPieces, _player); io.WriteLine(Formats.InitialPieces, _player);
for (var i = 1; i <= 3; i++) for (var i = 1; i <= 3; i++)
{ {
ReadCoordinates(_player); _board[io.ReadCoordinates(_board)] = P1;
_board[_coordinates[_player]] = P1;
} }
} }
@@ -33,14 +31,19 @@ while (true)
if (_player1Count == 0 || _player2Count == 0) { break; } if (_player1Count == 0 || _player2Count == 0) { break; }
for (var _player = 1; _player <= 2; _player++) var player1Coordinate = io.ReadCoordinates(1, _board);
var player2Coordinate = io.ReadCoordinates(2, _board);
if (player1Coordinate == player2Coordinate)
{ {
io.WriteLine(Formats.Player, _player); io.Write(Streams.SameCoords);
if (ReadCoordinates(_player)) // This is a bug existing in the original code. The line should be _board[_coordinates[_player]] = 0;
{ _board[player1Coordinate + 1] = 0;
_board[_coordinates[1]] = 0x0100; }
_board[_coordinates[2]] = 0x1000; else
} {
_board[player1Coordinate] = 0x0100;
_board[player2Coordinate] = 0x1000;
} }
} }
@@ -52,27 +55,3 @@ else
{ {
io.WriteLine(Formats.Winner, _player2Count == 0 ? 1 : 2); io.WriteLine(Formats.Winner, _player2Count == 0 ? 1 : 2);
} }
bool ReadCoordinates(int _player)
{
while (true)
{
io.WriteLine("X,Y");
var values = io.Read2Numbers("&&&&&&\r");
if (Coordinates.TryCreate(values, out _coordinates[_player]) && _board[_coordinates[_player]] == 0)
{
break;
}
io.Write(Streams.IllegalCoords);
}
if (_player == 2 && _coordinates[1] == _coordinates[2])
{
io.Write(Streams.SameCoords);
// This is a bug existing in the original code. The line should be _board[_coordinates[_player]] = 0;
_board[_coordinates[_player] + 1] = 0;
return false;
}
return _player == 2;
}