gitea-mirror/basic-computer-games
1
0
Fork 0
mirror of https://github.com/coding-horror/basic-computer-games.git synced 2025-12-26 12:51:29 -08:00
Code Issues Packages Projects Releases Wiki Activity

MAINT: Apply pre-commit

Browse Source 
Remove byte-order-marker pre-commit check as there would be
many adjustments necessary
This commit is contained in:
Martin Thoma
2022-03-05 09:29:23 +01:00
parent f5e33ae38f
commit e64fb6795c
536 changed files with 6267 additions and 5556 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
38_Fur_Trader/python/README.md
View File

@@ -5,21 +5,20 @@ Conversion to [Python](https://www.python.org/about/)
##### Translator Notes:
I tried to preserve as much of the original layout and flow of the code
as possible. However I did use quasi enumerated types for the Fort numbers
and Fur types. I think this was certainly a change for the better, and
and Fur types. I think this was certainly a change for the better, and
makes the code much easier to read.
I program in many different languages on a daily basis. Most languages
require brackets around expressions, so I just cannot bring myself to
write an expression without brackets. IMHO it makes the code easier to study,
require brackets around expressions, so I just cannot bring myself to
write an expression without brackets. IMHO it makes the code easier to study,
but it does contravene the Python PEP-8 Style guide.
Interestingly the code seems to have a bug around the prices of Fox Furs.
The commodity-rate for these is stored in the variable `D1`, however some
paths through the code do not set this price. So there was a chance of
using this uninitialised, or whatever the previous loop set. I don't
paths through the code do not set this price. So there was a chance of
using this uninitialised, or whatever the previous loop set. I don't
think this was the original authors intent. So I preserved the original flow
of the code (using the previous `D1` value), but also catching the
of the code (using the previous `D1` value), but also catching the
uninitialised path, and assigning a "best guess" value.
krt@krt.com.au 2020-10-10