gitea-mirror/basic-computer-games
1
0
Fork 0
mirror of https://github.com/coding-horror/basic-computer-games.git synced 2025-12-22 07:10:42 -08:00
Code Issues Packages Projects Releases Wiki Activity

Clean Code: Python

Browse Source 
Fix issues found by flake8-bugbear:

* Unused loop variables
* assert statements in non-test code
* mixing test code with production code
* mark one excessive test which takes ~10min to run
  as 'slow'
This commit is contained in:
Martin Thoma
2022-03-18 14:58:25 +01:00
parent f7deaba4a1
commit f52d9a0e54
27 changed files with 97 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
60_Mastermind/python/mastermind.py
View File

@@ -38,7 +38,7 @@ def main():
print("Guess my combination ...")
answer = int(possibilities * random.random())
numeric_answer = [-1] * num_positions
for i in range(0, answer):
for _ in range(0, answer):
numeric_answer = get_possibility(numeric_answer)
# human_readable_answer = make_human_readable(numeric_answer)
while num_moves < 10 and not turn_over:
@@ -122,7 +122,7 @@ def main():
inconsistent_information = True
else:
numeric_guess = [-1] * num_positions
for i in range(0, guess):
for _ in range(0, guess):
numeric_guess = get_possibility(numeric_guess)
human_readable_guess = make_human_readable(numeric_guess)
print(f"My guess is: {human_readable_guess}")
@@ -142,7 +142,7 @@ def main():
if all_possibilities[i] == 0: # already ruled out
continue
numeric_possibility = [-1] * num_positions
for j in range(0, i):
for _ in range(0, i):
numeric_possibility = get_possibility(
numeric_possibility
)