Commit Graph

32 Commits

Author SHA1 Message Date
Martin Thoma
3a63978d0e Super Star Trek (Python): Introduce OOP
* Avoid encoding values in int; use tuples instead (the memory overhead
  is OK today)
* Avoid encoding values in str, use lists instead (same story)
* Use variable names that speak for themselves
* Fix typo (NAVAGATION)
2022-04-01 17:04:14 +02:00
Martin Thoma
9972ee4073 Super Star Trek (Python): Refactoring
* Add 'Ship' class to group code / avoid some global variables /
  avoid passing so many parameters around
* Use docstrings
2022-03-31 22:41:16 +02:00
Martin Thoma
d511a22b5e Annotate superstartrek 2022-03-31 10:41:30 +02:00
Martin Thoma
17a75813b1 Remove tests and alternative Python implementations
Ad discussed here:
https://github.com/coding-horror/basic-computer-games/issues/548#issuecomment-1081008471
2022-03-29 07:02:10 +02:00
Jeff Atwood
05c998658d Merge pull request #679 from taciano-perez/update_superstartrek_java
updated implementation with proper OO design, provided link to video
2022-03-24 13:02:24 -05:00
Taciano Dreckmann Perez
a64aa983fe updated implementation with proper OO design, provided link to video 2022-03-24 18:58:47 +01:00
Jeff Atwood
859636240e Merge pull request #673 from drewjcooper/rework-with-common-lib
Rework with common lib
2022-03-22 15:57:46 -05:00
Andrew Cooper
42c21bbc62 Use common library in SuperStarTrek 2022-03-22 17:55:44 +11:00
Martin Thoma
1b1d50986b Python: Add type annotations to all 'print' functions (#662)
* Add test to superstartrek and fixes several issues in superstartrek - I probably introduced them 🙈
* Mastermind type annotations
2022-03-21 10:41:14 +01:00
Martin Thoma
83b3dc402c Python: Add type annotations 2022-03-20 19:16:39 +01:00
Jeff Atwood
f40a1fc465 add Porting Notes to readme.md for each game 2022-03-18 19:50:22 -07:00
Martin Thoma
3b2739b8a2 Clean Code: Apply flake8-simplify to Python
Also flake8-comprehensions which was added to the CI

For flake8-simplify, there are a few false-positives,
e.g. https://github.com/MartinThoma/flake8-simplify/issues/115
2022-03-18 22:29:56 +01:00
Martin Thoma
f52d9a0e54 Clean Code: Python
Fix issues found by flake8-bugbear:

* Unused loop variables
* assert statements in non-test code
* mixing test code with production code
* mark one excessive test which takes ~10min to run
  as 'slow'
2022-03-18 14:59:08 +01:00
Jeff Atwood
43f2ec013a add 00_Alternate_Langage folder and move alternate ports there 2022-03-15 20:49:07 -07:00
Martin Thoma
5374569063 Python: Fix string concatenation 2022-03-15 13:57:28 +01:00
Martin Thoma
0ba0307767 Python: Fix linting issues
The following Flake8 issues were fixed:

* W291
* W504

* F821
* F401
* F541

* E402
* E711
2022-03-14 13:13:20 +01:00
Martin Thoma
2e957b1b27 Fix mypy issues in superstartrek 2022-03-13 08:46:55 +01:00
Martin Thoma
af88007734 Python: Fix Flake8 E722 and E741
Additionally:

* Use functions to group blocks of code
* Use variable names (not just one character...)
2022-03-12 08:17:03 +01:00
Martin Thoma
e64fb6795c MAINT: Apply pre-commit
Remove byte-order-marker pre-commit check as there would be
many adjustments necessary
2022-03-05 09:29:23 +01:00
Taciano Dreckmann Perez
06c8d2be69 added 84_Super_Star_Trek Java port 2022-02-21 21:42:22 +01:00
Jeff Atwood
6ee2d5ee37 Merge pull request #512 from zspitz/main
Create missing sln/csproj/vbproj files
2022-01-16 11:13:47 -08:00
Andrew Regan
31c856d867 Update superstartrek.bas 2022-01-16 19:06:45 +00:00
Andrew Regan
379bee8b80 Fix some ORs 2022-01-16 18:53:55 +00:00
Andrew Regan
55edf21693 Clean up ON 2022-01-16 18:51:00 +00:00
Andrew Regan
c17bfa5dd0 Clean up PRINT commands 2022-01-16 18:48:01 +00:00
Andrew Regan
0996f041b9 Deminify 2022-01-16 18:44:43 +00:00
Zev Spitz
75def2707d Add sln and csroj/vbproj files where missing 2022-01-16 08:17:31 +02:00
Paul Holt
5b1aaadac1 Update with link to give credit where it is due, @jkboyce 2022-01-16 12:30:34 +11:00
Paul Holt
db0b1ffe4e Add bug descriptions discovered by Jack Boyce in Super Star Trek to the main game description. 2022-01-16 01:48:34 +11:00
Eric S Weilnau
cf9c2328b3 Format external links 2022-01-04 18:38:07 -05:00
LukasMurdock
76c5e1e995 add 17-96 2022-01-03 02:13:21 -05:00
Chris Reuter
d26dbf036a Removed spaces from top-level directory names.
Spaces tend to cause annoyances in a Unix-style shell environment.
This change fixes that.
2021-11-21 18:30:21 -05:00