From 2d1e7946e3eaa770850dd97b11b433c567cc46a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ana=20Mar=C3=ADa=20Mart=C3=ADnez=20G=C3=B3mez?= Date: Thu, 20 Aug 2020 15:20:04 +0200 Subject: [PATCH] extractors: Implement extract_insn_mnemonic_features Extract insn mnemonic features in miasm. --- capa/features/extractors/miasm/insn.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/capa/features/extractors/miasm/insn.py b/capa/features/extractors/miasm/insn.py index e8a628f3..9686049e 100644 --- a/capa/features/extractors/miasm/insn.py +++ b/capa/features/extractors/miasm/insn.py @@ -9,6 +9,7 @@ import miasm.expression.expression import capa.features.extractors.helpers +from capa.features.insn import Mnemonic # TODO: remove duplication (similar code in file.py) @@ -64,7 +65,7 @@ def extract_insn_nzxor_characteristic_features(extractor, f, bb, insn): def extract_insn_mnemonic_features(extractor, f, bb, insn): """parse mnemonic features from the given instruction.""" - raise NotImplementedError() + yield Mnemonic(insn.name), insn.offset def extract_insn_peb_access_characteristic_features(extractor, f, bb, insn): @@ -115,7 +116,7 @@ INSTRUCTION_HANDLERS = ( # extract_insn_bytes_features, # extract_insn_offset_features, # extract_insn_nzxor_characteristic_features, - # extract_insn_mnemonic_features, + extract_insn_mnemonic_features, # extract_insn_peb_access_characteristic_features, # extract_insn_cross_section_cflow, # extract_insn_segment_access_features,