From a6ddd044c702242b8d9ddf498a62b5d670029e34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ana=20Mar=C3=ADa=20Mart=C3=ADnez=20G=C3=B3mez?= Date: Tue, 7 Jul 2020 15:49:38 +0200 Subject: [PATCH] Fix style offenses pycodestyle is failing in master. --- capa/features/extractors/ida/__init__.py | 2 ++ capa/features/extractors/ida/basicblock.py | 5 +++-- capa/features/extractors/ida/file.py | 1 + capa/features/extractors/ida/function.py | 1 + capa/features/extractors/ida/insn.py | 1 + capa/ida/explorer/item.py | 1 + capa/ida/explorer/view.py | 4 +--- 7 files changed, 10 insertions(+), 5 deletions(-) diff --git a/capa/features/extractors/ida/__init__.py b/capa/features/extractors/ida/__init__.py index 7f50cb97..c994faad 100644 --- a/capa/features/extractors/ida/__init__.py +++ b/capa/features/extractors/ida/__init__.py @@ -47,6 +47,7 @@ class IdaFeatureExtractor(FeatureExtractor): def get_functions(self): import capa.features.extractors.ida.helpers as ida_helpers + # ignore library functions and thunk functions as identified by IDA for f in ida_helpers.get_functions(skip_thunks=True, skip_libs=True): yield add_ea_int_cast(f) @@ -65,6 +66,7 @@ class IdaFeatureExtractor(FeatureExtractor): def get_instructions(self, f, bb): import capa.features.extractors.ida.helpers as ida_helpers + for insn in ida_helpers.get_instructions_in_range(bb.start_ea, bb.end_ea): yield add_ea_int_cast(insn) diff --git a/capa/features/extractors/ida/basicblock.py b/capa/features/extractors/ida/basicblock.py index 75520b60..00ff9859 100644 --- a/capa/features/extractors/ida/basicblock.py +++ b/capa/features/extractors/ida/basicblock.py @@ -20,7 +20,6 @@ def get_printable_len(op): """ op_val = capa.features.extractors.ida.helpers.mask_op_val(op) - if op.dtype == idaapi.dt_byte: chars = struct.pack("