From 3f35b426dd95817a2c3bdd61dc7aff3cc702f2bd Mon Sep 17 00:00:00 2001 From: Yacine Elhamer <16624109+yelhamer@users.noreply.github.com> Date: Thu, 22 Jun 2023 21:58:01 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Moritz --- capa/main.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/capa/main.py b/capa/main.py index 421ebd6c..09cb2dfe 100644 --- a/capa/main.py +++ b/capa/main.py @@ -547,11 +547,11 @@ def get_extractor( import capa.features.extractors.cape.extractor - with open(path, "r+", encoding="utf-8") as f: + with open(path, "r", encoding="utf-8") as f: report = json.load(f) return capa.features.extractors.cape.extractor.CapeExtractor.from_report(report) - if format_ == FORMAT_DOTNET: + elif format_ == FORMAT_DOTNET: import capa.features.extractors.dnfile.extractor return capa.features.extractors.dnfile.extractor.DnfileFeatureExtractor(path) @@ -616,7 +616,7 @@ def get_file_extractors(sample: str, format_: str) -> List[FeatureExtractor]: elif format_ == capa.features.extractors.common.FORMAT_ELF: file_extractors.append(capa.features.extractors.elffile.ElfFeatureExtractor(sample)) - if format_ == FORMAT_CAPE: + elif format_ == FORMAT_CAPE: import json with open(sample, "r+", encoding="utf-8") as f: