From 51884fea2dd91d1429b0bd65886f82c8e01374e0 Mon Sep 17 00:00:00 2001 From: Ana Maria Martinez Gomez Date: Fri, 28 May 2021 12:06:37 +0200 Subject: [PATCH] doc: Fix link and add more details Fix broken link to `pull_request_template.md` and add some more details. Related #457 --- .github/CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 707d0932..8b641ee4 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -159,8 +159,8 @@ The process described here has several goals: Please follow these steps to have your contribution considered by the maintainers: -1. Follow all instructions in [the template](PULL_REQUEST_TEMPLATE.md) -2. Follow the [styleguides](#styleguides) +1. Follow the [styleguides](#styleguides) +2. Update the CHANGELOG and add tests and documentation. In case they are not needed, indicate it in [the PR template](pull_request_template.md). 3. After you submit your pull request, verify that all [status checks](https://help.github.com/articles/about-status-checks/) are passing
What if the status checks are failing? If a status check is failing, and you believe that the failure is unrelated to your change, please leave a comment on the pull request explaining why you believe the failure is unrelated. A maintainer will re-run the status check for you. If we conclude that the failure was a false positive, then we will open an issue to track that problem with our status check suite.
While the prerequisites above must be satisfied prior to having your pull request reviewed, the reviewer(s) may ask you to complete additional design work, tests, or other changes before your pull request can be ultimately accepted.