From 7406e75f968a3913a83ec3f85b153b5732b5c01c Mon Sep 17 00:00:00 2001 From: Willi Ballenthin Date: Wed, 22 Apr 2026 20:24:06 +0300 Subject: [PATCH] fix: remove dead view_tab_rulegen assignment from CapaExplorerForm self.view_tab_rulegen = None was assigned but never read or reassigned anywhere in the codebase. All other attributes in the same block are type-annotated declarations; this one was an actual assignment with no purpose. --- CHANGELOG.md | 3 +-- capa/ida/plugin/form.py | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1de1da2b..15cbf94c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,8 +48,7 @@ - fix: remove unreachable backports.functools_lru_cache fallback and dead dependency @williballenthin - fix: Scopes.from_dict uses cls instead of self so subclasses return the correct type @williballenthin - fix: correct wrong dict key in VMRay _compute_monitor_threads assertion (used thread_id instead of process_id) @williballenthin -fix: replace assert with isinstance guard in get_callee for invalid MethodSpec tokens @williballenthin -- fix: replace assert with isinstance guard in get_callee for invalid MethodSpec tokens @williballenthin +- fix: remove dead view_tab_rulegen assignment from CapaExplorerForm that was never read @williballenthin (SURF-70) - fix: remove dead reset_query method from CapaExplorerSearchProxyModel that was never called @williballenthin (SURF-69) - fix: remove unused imports of capa.rules and capa.engine from view.py @williballenthin (SURF-68) - fix: remove unused imports of capa.main, capa.render.json, and capa.features.extractors.ida.extractor from form.py @williballenthin (SURF-67) diff --git a/capa/ida/plugin/form.py b/capa/ida/plugin/form.py index 8af176e0..b639d9fc 100644 --- a/capa/ida/plugin/form.py +++ b/capa/ida/plugin/form.py @@ -204,7 +204,6 @@ class CapaExplorerForm(idaapi.PluginForm): self.view_search_bar: QtWidgets.QLineEdit self.view_tree: CapaExplorerQtreeView self.view_tabs: QtWidgets.QTabWidget - self.view_tab_rulegen = None self.view_status_label: QtWidgets.QLabel self.view_status_label_analysis_cache: str = "" self.view_status_label_rulegen_cache: str = ""