From 85b58d041b0ca9e31f450ca461f189fec8bf11c9 Mon Sep 17 00:00:00 2001 From: Willi Ballenthin Date: Thu, 10 Aug 2023 11:38:43 +0200 Subject: [PATCH] process: simplify string enumeration loop --- capa/features/extractors/cape/process.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/capa/features/extractors/cape/process.py b/capa/features/extractors/cape/process.py index 2119cef1..e94c43dd 100644 --- a/capa/features/extractors/cape/process.py +++ b/capa/features/extractors/cape/process.py @@ -44,9 +44,8 @@ def extract_environ_strings(behavior: Dict, ph: ProcessHandle) -> Iterator[Tuple if not environ: return - for _, value in environ.items(): - if value: - yield String(value), ph.address + for value in (value for value in environ.values() if value): + yield String(value), ph.address def extract_features(behavior: Dict, ph: ProcessHandle) -> Iterator[Tuple[Feature, Address]]: