From 9be35f9a8dc05182b41fe779b5ba9bef95439e9f Mon Sep 17 00:00:00 2001 From: Mike Hunhoff Date: Thu, 20 Jun 2024 15:19:55 -0600 Subject: [PATCH] vmray: remove unneeded unpacking --- capa/features/extractors/vmray/file.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/capa/features/extractors/vmray/file.py b/capa/features/extractors/vmray/file.py index 45b0d0af..16db80db 100644 --- a/capa/features/extractors/vmray/file.py +++ b/capa/features/extractors/vmray/file.py @@ -21,7 +21,7 @@ logger = logging.getLogger(__name__) def get_processes(analysis: VMRayAnalysis) -> Iterator[ProcessHandle]: processes: Dict[str, Process] = analysis.sv2.processes - for _, process in processes.items(): + for process in processes.values(): # TODO (meh): should we use the OS process ID or vmray-assigned ID? https://github.com/mandiant/capa/issues/2148 pid = process.monitor_id ppid = processes[process.ref_parent_process.path[1]].monitor_id if process.ref_parent_process else 0 @@ -46,27 +46,27 @@ def extract_section_names(analysis: VMRayAnalysis) -> Iterator[Tuple[Feature, Ad def extract_referenced_filenames(analysis: VMRayAnalysis) -> Iterator[Tuple[Feature, Address]]: - for _, filename in analysis.sv2.filenames.items(): + for filename in analysis.sv2.filenames.values(): yield String(filename.filename), NO_ADDRESS def extract_referenced_mutex_names(analysis: VMRayAnalysis) -> Iterator[Tuple[Feature, Address]]: - for _, mutex in analysis.sv2.mutexes.items(): + for mutex in analysis.sv2.mutexes.values(): yield String(mutex.name), NO_ADDRESS def extract_referenced_domain_names(analysis: VMRayAnalysis) -> Iterator[Tuple[Feature, Address]]: - for _, domain in analysis.sv2.domains.items(): + for domain in analysis.sv2.domains.values(): yield String(domain.domain), NO_ADDRESS def extract_referenced_ip_addresses(analysis: VMRayAnalysis) -> Iterator[Tuple[Feature, Address]]: - for _, ip_address in analysis.sv2.ip_addresses.items(): + for ip_address in analysis.sv2.ip_addresses.values(): yield String(ip_address.ip_address), NO_ADDRESS def extract_referenced_registry_key_names(analysis: VMRayAnalysis) -> Iterator[Tuple[Feature, Address]]: - for _, registry_record in analysis.sv2.registry_records.items(): + for registry_record in analysis.sv2.registry_records.values(): yield String(registry_record.reg_key_name), NO_ADDRESS