From a99ff813cb48cbbe8a00809d1813fb554c212583 Mon Sep 17 00:00:00 2001 From: Yacine Elhamer <16624109+yelhamer@users.noreply.github.com> Date: Tue, 27 Jun 2023 11:22:35 +0100 Subject: [PATCH] DynamicFeatureExtractor: remove get_base_address() method Co-authored-by: Willi Ballenthin --- capa/features/extractors/base_extractor.py | 7 ------- capa/features/extractors/cape/extractor.py | 4 ---- 2 files changed, 11 deletions(-) diff --git a/capa/features/extractors/base_extractor.py b/capa/features/extractors/base_extractor.py index 2011d849..7cac8bbc 100644 --- a/capa/features/extractors/base_extractor.py +++ b/capa/features/extractors/base_extractor.py @@ -309,13 +309,6 @@ class DynamicFeatureExtractor: This class is not instantiated directly; it is the base class for other implementations. """ - @abc.abstractmethod - def get_base_address(self) -> Union[AbsoluteVirtualAddress, capa.features.address._NoAddress]: - """ - fetch the preferred load address at which the sample was analyzed. - """ - raise NotImplementedError() - @abc.abstractmethod def extract_global_features(self) -> Iterator[Tuple[Feature, Address]]: """ diff --git a/capa/features/extractors/cape/extractor.py b/capa/features/extractors/cape/extractor.py index 01a1e3c9..2bd6a4ba 100644 --- a/capa/features/extractors/cape/extractor.py +++ b/capa/features/extractors/cape/extractor.py @@ -26,10 +26,6 @@ class CapeExtractor(DynamicFeatureExtractor): self.behavior = behavior self.global_features = capa.features.extractors.cape.global_.extract_features(self.static) - - def get_base_address(self): - return NO_ADDRESS - def extract_global_features(self) -> Iterator[Tuple[Feature, Address]]: yield from self.global_features