gitea-mirror/capa
1
0
Fork 0
mirror of https://github.com/mandiant/capa.git synced 2026-06-12 19:11:32 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: guard MissingStaticScope and MissingDynamicScope against absent scopes dict

Browse Source 
When rule.meta lacks a "scopes" key, rule.meta.get("scopes") returns None
and "static"/"dynamic" not in None raises TypeError, crashing lint_rule.
Add isinstance(scopes, dict) guard so both checks return False (no violation)
when scopes is absent, letting MissingScopes report the real problem.
This commit is contained in:
Willi Ballenthin
2026-04-22 22:02:35 +03:00
committed by Willi Ballenthin
parent c5ae9be3e1
commit bfa09f817b
3 changed files with 39 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/lint.py
+22 -7
View File
@@ -161,7 +161,10 @@ class MissingStaticScope(Lint):
recommendation = "Add a static scope for the rule (file, function, basic block, instruction, or unsupported)"
def check_rule(self, ctx: Context, rule: Rule):
return "static" not in rule.meta.get("scopes")
scopes = rule.meta.get("scopes")
if not isinstance(scopes, dict):
return False
return "static" not in scopes
class MissingDynamicScope(Lint):
@@ -169,7 +172,10 @@ class MissingDynamicScope(Lint):
recommendation = "Add a dynamic scope for the rule (file, process, thread, call, or unsupported)"
def check_rule(self, ctx: Context, rule: Rule):
return "dynamic" not in rule.meta.get("scopes")
scopes = rule.meta.get("scopes")
if not isinstance(scopes, dict):
return False
return "dynamic" not in scopes
class InvalidStaticScope(Lint):
@@ -177,7 +183,10 @@ class InvalidStaticScope(Lint):
recommendation = "For the static scope, use either: file, function, basic block, instruction, or unsupported"
def check_rule(self, ctx: Context, rule: Rule):
return rule.meta.get("scopes").get("static") not in (
scopes = rule.meta.get("scopes")
if not isinstance(scopes, dict):
return False
return scopes.get("static") not in (
"file",
"function",
"basic block",
@@ -187,11 +196,14 @@ class InvalidStaticScope(Lint):
class InvalidDynamicScope(Lint):
name = "invalid static scope"
name = "invalid dynamic scope"
recommendation = "For the dynamic scope, use either: file, process, thread, call, or unsupported"
def check_rule(self, ctx: Context, rule: Rule):
return rule.meta.get("scopes").get("dynamic") not in (
scopes = rule.meta.get("scopes")
if not isinstance(scopes, dict):
return False
return scopes.get("dynamic") not in (
"file",
"process",
"thread",
@@ -206,8 +218,11 @@ class InvalidScopes(Lint):
recommendation = "At least one scope (static or dynamic) must be specified"
def check_rule(self, ctx: Context, rule: Rule):
return (rule.meta.get("scopes").get("static") == "unsupported") and (
rule.meta.get("scopes").get("dynamic") == "unsupported"
scopes = rule.meta.get("scopes")
if not isinstance(scopes, dict):
return False
return (scopes.get("static") == "unsupported") and (
scopes.get("dynamic") == "unsupported"
)