From 854759cb433d5ffda7a54b2d63b70f603c8bfd61 Mon Sep 17 00:00:00 2001
From: Soufiane Fariss <rev.fariss@gmail.com>
Date: Fri, 16 Aug 2024 18:17:34 +0200
Subject: [PATCH 1/5] add tooltip to show decimal/octal rep

---
 .../src/components/columns/RuleColumn.vue     | 20 ++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/web/explorer/src/components/columns/RuleColumn.vue b/web/explorer/src/components/columns/RuleColumn.vue
index 6c4b1ca2..f5197737 100644
--- a/web/explorer/src/components/columns/RuleColumn.vue
+++ b/web/explorer/src/components/columns/RuleColumn.vue
@@ -31,7 +31,15 @@
         <template v-else-if="node.data.type === 'feature'">
             <span>
                 - {{ node.data.typeValue }}:
-                <span :class="{ 'text-green-700': node.data.typeValue !== 'regex' }" class="font-monospace">
+                <span
+                    :class="{ 'text-green-700': node.data.typeValue !== 'regex' }"
+                    class="font-monospace"
+                    v-tooltip.top="{
+                        value: getTooltipContent(node.data),
+                        showDelay: 1000,
+                        hideDelay: 300
+                    }"
+                >
                     {{ node.data.name }}
                 </span>
             </span>
@@ -63,4 +71,14 @@ defineProps({
         required: true
     }
 });
+
+const getTooltipContent = (data) => {
+    if (data.typeValue === "number" || data.typeValue === "offset") {
+        const decimalValue = parseInt(data.name, 16);
+        const octalValue = "0o" + decimalValue.toString(8);
+        return `Decimal: ${decimalValue}
+Octal: ${octalValue}`;
+    }
+    return null;
+};
 </script>

From b67bd4d0842d6008b88227d0e87ad9eedb68d488 Mon Sep 17 00:00:00 2001
From: Soufiane Fariss <rev.fariss@gmail.com>
Date: Fri, 16 Aug 2024 18:23:44 +0200
Subject: [PATCH 2/5] add file-level rules to capabilities by function

---
 web/explorer/src/utils/rdocParser.js | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/web/explorer/src/utils/rdocParser.js b/web/explorer/src/utils/rdocParser.js
index 8484d254..46a11e36 100644
--- a/web/explorer/src/utils/rdocParser.js
+++ b/web/explorer/src/utils/rdocParser.js
@@ -108,6 +108,9 @@ export function parseFunctionCapabilities(doc) {
     // Map to store capabilities matched to each function
     const matchesByFunction = new Map();
 
+    // Add a special entry for file-level matches
+    matchesByFunction.set("file", new Set());
+
     // Iterate through all rules in the document
     for (const [, rule] of Object.entries(doc.rules)) {
         if (rule.meta.scopes.static === "function") {
@@ -133,12 +136,26 @@ export function parseFunctionCapabilities(doc) {
                         .add({ name: rule.meta.name, namespace: rule.meta.namespace, lib: rule.meta.lib });
                 }
             }
+        } else if (rule.meta.scopes.static === "file") {
+            // Add file-level matches to the special 'file' entry
+            matchesByFunction.get("file").add({
+                name: rule.meta.name,
+                namespace: rule.meta.namespace,
+                lib: rule.meta.lib
+            });
         }
-        // (else) Ignoring file scope rules
     }
 
     const result = [];
 
+    // Add file-level matches if there are any
+    if (matchesByFunction.get("file").size > 0) {
+        result.push({
+            address: "file",
+            capabilities: Array.from(matchesByFunction.get("file"))
+        });
+    }
+
     // Iterate through all functions in the document
     for (const f of doc.meta.analysis.feature_counts.functions) {
         const addr = formatAddress(f.address);

From 19e2097f7945b6ad581d1610ad4b4db2faecc3ad Mon Sep 17 00:00:00 2001
From: Soufiane Fariss <rev.fariss@gmail.com>
Date: Fri, 16 Aug 2024 18:52:02 +0200
Subject: [PATCH 3/5] change placeholder text

---
 .../src/components/FunctionCapabilities.vue       | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/web/explorer/src/components/FunctionCapabilities.vue b/web/explorer/src/components/FunctionCapabilities.vue
index c3e9e463..b6fcba1e 100644
--- a/web/explorer/src/components/FunctionCapabilities.vue
+++ b/web/explorer/src/components/FunctionCapabilities.vue
@@ -26,7 +26,7 @@
             :showClearButton="false"
         >
             <template #filter v-if="props.showColumnFilters">
-                <InputText v-model="filters['address'].value" placeholder="Filter by name" />
+                <InputText v-model="filters['address'].value" placeholder="Filter by function address" />
             </template>
             <template #body="{ data }">
                 <span class="font-monospace text-base">{{ data.address }}</span>
@@ -36,9 +36,16 @@
             </template>
         </Column>
 
-        <Column field="rule" sortable header="Matches" class="w-min" :showFilterMenu="false" :showClearButton="false">
+        <Column
+            field="rule"
+            sortable
+            header="Rule Matches"
+            class="w-min"
+            :showFilterMenu="false"
+            :showClearButton="false"
+        >
             <template #filter v-if="props.showColumnFilters">
-                <InputText v-model="filters['rule'].value" placeholder="Filter by name" />
+                <InputText v-model="filters['rule'].value" placeholder="Filter by rule" />
             </template>
             <template #body="{ data }">
                 {{ data.rule }}
@@ -48,7 +55,7 @@
 
         <Column field="namespace" sortable header="Namespace" :showFilterMenu="false" :showClearButton="false">
             <template #filter v-if="props.showColumnFilters">
-                <InputText v-model="filters['namespace'].value" placeholder="Filter by name" />
+                <InputText v-model="filters['namespace'].value" placeholder="Filter by namespace" />
             </template>
         </Column>
     </DataTable>

From 00cce585d66e56b98747fd251dac751faf6b3efe Mon Sep 17 00:00:00 2001
From: Soufiane Fariss <rev.fariss@gmail.com>
Date: Fri, 16 Aug 2024 18:52:53 +0200
Subject: [PATCH 4/5] remove sorting from columns

---
 web/explorer/src/components/FunctionCapabilities.vue | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/web/explorer/src/components/FunctionCapabilities.vue b/web/explorer/src/components/FunctionCapabilities.vue
index b6fcba1e..bfa170b6 100644
--- a/web/explorer/src/components/FunctionCapabilities.vue
+++ b/web/explorer/src/components/FunctionCapabilities.vue
@@ -36,14 +36,7 @@
             </template>
         </Column>
 
-        <Column
-            field="rule"
-            sortable
-            header="Rule Matches"
-            class="w-min"
-            :showFilterMenu="false"
-            :showClearButton="false"
-        >
+        <Column field="rule" header="Rule Matches" class="w-min" :showFilterMenu="false" :showClearButton="false">
             <template #filter v-if="props.showColumnFilters">
                 <InputText v-model="filters['rule'].value" placeholder="Filter by rule" />
             </template>
@@ -53,7 +46,7 @@
             </template>
         </Column>
 
-        <Column field="namespace" sortable header="Namespace" :showFilterMenu="false" :showClearButton="false">
+        <Column field="namespace" header="Namespace" :showFilterMenu="false" :showClearButton="false">
             <template #filter v-if="props.showColumnFilters">
                 <InputText v-model="filters['namespace'].value" placeholder="Filter by namespace" />
             </template>

From 450195572855caf8a2f139d351722dd0047f218a Mon Sep 17 00:00:00 2001
From: Soufiane Fariss <rev.fariss@gmail.com>
Date: Fri, 16 Aug 2024 23:37:30 +0200
Subject: [PATCH 5/5] remove octal repr for hex values

---
 web/explorer/src/components/columns/RuleColumn.vue | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/web/explorer/src/components/columns/RuleColumn.vue b/web/explorer/src/components/columns/RuleColumn.vue
index f5197737..bafad25c 100644
--- a/web/explorer/src/components/columns/RuleColumn.vue
+++ b/web/explorer/src/components/columns/RuleColumn.vue
@@ -75,9 +75,7 @@ defineProps({
 const getTooltipContent = (data) => {
     if (data.typeValue === "number" || data.typeValue === "offset") {
         const decimalValue = parseInt(data.name, 16);
-        const octalValue = "0o" + decimalValue.toString(8);
-        return `Decimal: ${decimalValue}
-Octal: ${octalValue}`;
+        return `Decimal: ${decimalValue}`;
     }
     return null;
 };