diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index bdd6fbd8..a4876d0f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -167,7 +167,7 @@ jobs: - name: Set zip name run: echo "zip_name=capa-${GITHUB_REF#refs/tags/}-${{ matrix.asset_name }}.zip" >> $GITHUB_ENV - name: Zip ${{ matrix.artifact_name }} into ${{ env.zip_name }} - run: zip ${{ env.zip_name }} ${{ matrix.artifact_name }} + run: zip ${ZIP_NAME} ${{ matrix.artifact_name }} - name: Upload ${{ env.zip_name }} to GH Release uses: svenstaro/upload-release-action@2728235f7dc9ff598bd86ce3c274b74f802d2208 # v2 with: diff --git a/.github/workflows/tag.yml b/.github/workflows/tag.yml index 69151150..51be5f31 100644 --- a/.github/workflows/tag.yml +++ b/.github/workflows/tag.yml @@ -21,8 +21,10 @@ jobs: # user information is needed to create annotated tags (with a message) git config user.email 'capa-dev@mandiant.com' git config user.name 'Capa Bot' - name=${{ github.event.release.tag_name }} + name=${GITHUB_EVENT_RELEASE_TAG_NAME} git tag $name -m "https://github.com/mandiant/capa/releases/$name" + env: + GITHUB_EVENT_RELEASE_TAG_NAME: ${{ github.event.release.tag_name }} # TODO update branch name-major=${name%%.*} - name: Push tag to capa-rules uses: ad-m/github-push-action@d91a481090679876dfc4178fef17f286781251df # v0.8.0 diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 94032cff..77d2879d 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -155,7 +155,7 @@ jobs: run: | mkdir ./.github/binja curl "https://raw.githubusercontent.com/Vector35/binaryninja-api/6812c97/scripts/download_headless.py" -o ./.github/binja/download_headless.py - python ./.github/binja/download_headless.py --serial ${{ env.BN_SERIAL }} --output .github/binja/BinaryNinja-headless.zip + python ./.github/binja/download_headless.py --serial ${BN_SERIAL} --output .github/binja/BinaryNinja-headless.zip unzip .github/binja/BinaryNinja-headless.zip -d .github/binja/ python .github/binja/binaryninja/scripts/install_api.py --install-on-root --silent - name: Run tests diff --git a/.github/workflows/web-release.yml b/.github/workflows/web-release.yml index 8cf7667d..e81f35b2 100644 --- a/.github/workflows/web-release.yml +++ b/.github/workflows/web-release.yml @@ -18,14 +18,18 @@ jobs: - uses: actions/checkout@v4 - name: Set release name - run: echo "RELEASE_NAME=capa-explorer-web-v${{ github.event.inputs.version }}-${GITHUB_SHA::7}" >> $GITHUB_ENV + run: echo "RELEASE_NAME=capa-explorer-web-v${GITHUB_EVENT_INPUTS_VERSION}-${GITHUB_SHA::7}" >> $GITHUB_ENV + env: + GITHUB_EVENT_INPUTS_VERSION: ${{ github.event.inputs.version }} - name: Check if release already exists run: | - if ls web/explorer/releases/capa-explorer-web-v${{ github.event.inputs.version }}-* 1> /dev/null 2>&1; then - echo "::error:: A release with version ${{ github.event.inputs.version }} already exists" + if ls web/explorer/releases/capa-explorer-web-v${GITHUB_EVENT_INPUTS_VERSION}-* 1> /dev/null 2>&1; then + echo "::error:: A release with version ${GITHUB_EVENT_INPUTS_VERSION} already exists" exit 1 fi + env: + GITHUB_EVENT_INPUTS_VERSION: ${{ github.event.inputs.version }} - name: Set up Node.js uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4 @@ -43,24 +47,24 @@ jobs: working-directory: web/explorer - name: Compress bundle - run: zip -r ${{ env.RELEASE_NAME }}.zip capa-explorer-web + run: zip -r ${RELEASE_NAME}.zip capa-explorer-web working-directory: web/explorer - name: Create releases directory run: mkdir -vp web/explorer/releases - name: Move release to releases folder - run: mv web/explorer/${{ env.RELEASE_NAME }}.zip web/explorer/releases + run: mv web/explorer/${RELEASE_NAME}.zip web/explorer/releases - name: Compute release SHA256 hash run: | - echo "RELEASE_SHA256=$(sha256sum web/explorer/releases/${{ env.RELEASE_NAME }}.zip | awk '{print $1}')" >> $GITHUB_ENV + echo "RELEASE_SHA256=$(sha256sum web/explorer/releases/${RELEASE_NAME}.zip | awk '{print $1}')" >> $GITHUB_ENV - name: Update CHANGELOG.md run: | - echo "## ${{ env.RELEASE_NAME }}" >> web/explorer/releases/CHANGELOG.md + echo "## ${RELEASE_NAME}" >> web/explorer/releases/CHANGELOG.md echo "- Release Date: $(date -u '+%Y-%m-%d %H:%M:%S UTC')" >> web/explorer/releases/CHANGELOG.md - echo "- SHA256: ${{ env.RELEASE_SHA256 }}" >> web/explorer/releases/CHANGELOG.md + echo "- SHA256: ${RELEASE_SHA256}" >> web/explorer/releases/CHANGELOG.md echo "" >> web/explorer/releases/CHANGELOG.md cat web/explorer/releases/CHANGELOG.md @@ -73,7 +77,7 @@ jobs: run: | git config --local user.email "capa-dev@mandiant.com" git config --local user.name "Capa Bot" - git add -f web/explorer/releases/${{ env.RELEASE_NAME }}.zip web/explorer/releases/CHANGELOG.md + git add -f web/explorer/releases/${RELEASE_NAME}.zip web/explorer/releases/CHANGELOG.md git add -u web/explorer/releases/ - name: Create Pull Request