From d412e66ceab608cd1a5e8da696c6fd4faaf7cfa2 Mon Sep 17 00:00:00 2001 From: Ana Maria Martinez Gomez Date: Tue, 6 Apr 2021 21:34:03 +0200 Subject: [PATCH] ci: do not test Python 2.7 with Windows The Python 2.7 tests fail in Windows with vivisect because the Windows filesystem encoding is not UTF-8. This shouldn't be a problem when using capa as the given filename most likely uses the same encoding, but we force UTF-8 in our tests. As we are planing to remove Python 2 support is not wortwhile to invest time in making this test working. Instead, test Python 2.7 only in Ubuntu. --- .github/workflows/tests.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 597dc4b7..13b75be8 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -49,13 +49,11 @@ jobs: matrix: os: [ubuntu-20.04, windows-2019, macos-10.15] # across all operating systems - # TODO replace 2.7 with 3.6 once we're Python 3 only - python-version: [2.7, 3.9] + python-version: [3.6, 3.9] include: # on Ubuntu run these as well - os: ubuntu-20.04 - # TODO remove 3.6 here once we're Python 3 only - python-version: 3.6 + python-version: 2.7 - os: ubuntu-20.04 python-version: 3.7 - os: ubuntu-20.04