From ffd926c84cc2d656e8e26a72682d2bda41913c8a Mon Sep 17 00:00:00 2001 From: William Ballenthin Date: Mon, 22 Jun 2020 06:59:10 -0600 Subject: [PATCH] scripts: migrate-rules: detect rules that aren't in the migration plan --- scripts/migrate-rules.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/scripts/migrate-rules.py b/scripts/migrate-rules.py index e42d24da..d2eb3bf9 100644 --- a/scripts/migrate-rules.py +++ b/scripts/migrate-rules.py @@ -72,6 +72,15 @@ def main(argv=None): rules = read_rules(args.source) logger.info("read %d rules", len(rules)) + planned_rules = set([row["existing name"] for row in plan]) + missing = [rule for (name, rule) in rules.items() if name not in planned_rules] + + if missing: + logger.error("plan does not account for %d rules:" % (len(missing))) + for rule in missing: + logger.error(" " + rule.name) + return -1 + for row in plan: if not row["existing name"]: continue