gitea-mirror/hate_crack
1
0
Fork 0
mirror of https://github.com/trustedsec/hate_crack.git synced 2026-07-28 14:47:22 -07:00
Code Issues Packages Projects Releases Wiki Activity

refactor(update): replace custom dep install with make install

Browse Source 
_run_upgrade now runs `git pull && git fetch --tags && make install`
instead of the bespoke _install_system_deps function. make install is
idempotent, handles all platforms, installs system deps (transmission-
daemon, p7zip), rebuilds the Python package, and updates the CLI shim.

Remove the now-unnecessary uv binary pre-check (make install locates
it) and its stale test.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Justin Bollinger
2026-04-25 19:40:43 -04:00
co-authored by Claude Sonnet 4.6
parent e238c9bb66
commit 57181ddf13
2 changed files with 8 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_version_check.py
+3 -30
View File
@@ -151,18 +151,14 @@ class TestCheckForUpdates:
hc_module, "REQUESTS_AVAILABLE", True
), patch("builtins.input", return_value="y"), patch(
"subprocess.run", side_effect=[git_root_proc, make_proc]
) as mock_run, patch("shutil.which", return_value="/usr/local/bin/uv"), patch(
"os.path.isfile", return_value=True
), patch.object(hc_module, "_install_system_deps"), pytest.raises(
SystemExit
):
) as mock_run, pytest.raises(SystemExit):
mock_requests.get.return_value = mock_resp
hc_module.check_for_updates()
assert mock_run.call_count == 2
make_cmd = mock_run.call_args_list[1][0][0]
assert "git pull" in make_cmd
assert "uv sync --reinstall-package hate_crack" in make_cmd
assert "make install" in make_cmd
assert mock_run.call_args_list[1][1]["cwd"] == "/fake/repo"
output = capsys.readouterr().out
assert "Upgrade complete" in output
@@ -220,14 +216,6 @@ class TestCheckForUpdates:
class TestRunUpgrade:
"""Tests for _run_upgrade() called directly via --update flag."""
@pytest.fixture(autouse=True)
def mock_uv(self):
"""Patch shutil.which and os.path.isfile so uv is always 'found'."""
with patch("shutil.which", return_value="/usr/local/bin/uv"), patch(
"os.path.isfile", return_value=True
):
yield
def test_run_upgrade_success(self, hc_module, capsys):
git_root_proc = MagicMock()
git_root_proc.returncode = 0
@@ -237,7 +225,6 @@ class TestRunUpgrade:
make_proc.returncode = 0
with patch("subprocess.run", side_effect=[git_root_proc, make_proc]) as mock_run, \
patch.object(hc_module, "_install_system_deps"), \
pytest.raises(SystemExit) as exc:
hc_module._run_upgrade()
@@ -245,7 +232,7 @@ class TestRunUpgrade:
assert mock_run.call_count == 2
make_cmd = mock_run.call_args_list[1][0][0]
assert "git pull" in make_cmd
assert "uv sync --reinstall-package hate_crack" in make_cmd
assert "make install" in make_cmd
assert mock_run.call_args_list[1][1]["cwd"] == "/fake/repo"
output = capsys.readouterr().out
assert "Upgrade complete" in output
@@ -277,20 +264,6 @@ class TestRunUpgrade:
output = capsys.readouterr().out
assert "Run manually" in output
def test_run_upgrade_uv_not_found(self, hc_module, capsys):
git_root_proc = MagicMock()
git_root_proc.returncode = 0
git_root_proc.stdout = "/fake/repo\n"
with patch("subprocess.run", return_value=git_root_proc), patch(
"shutil.which", return_value=None
), patch("os.path.isfile", return_value=False), pytest.raises(SystemExit) as exc:
hc_module._run_upgrade()
assert exc.value.code == 1
output = capsys.readouterr().out
assert "uv binary" in output
def test_upgrade_prompt_ctrl_c_continues(self, hc_module, capsys):
mock_resp = MagicMock()
mock_resp.json.return_value = {"tag_name": "v99.0.0"}