From d51158c1d3651f018be9d4902403acdc98948426 Mon Sep 17 00:00:00 2001 From: Justin Bollinger Date: Fri, 20 Feb 2026 16:25:48 -0500 Subject: [PATCH] fix: Docker build now compiles submodules correctly - Remove .gitmodules from .dockerignore so the build loop can discover which directories to compile - Add git to Dockerfile apt installs (needed for git config --file parsing) - Gate git submodule update --init on .git presence, not .gitmodules; the compile loop still runs in Docker since .gitmodules is now present - hashcat skipped in Docker build loop since system hashcat is in PATH Co-Authored-By: Claude Sonnet 4.6 --- .dockerignore | 1 - Dockerfile.test | 1 + Makefile | 4 ++-- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.dockerignore b/.dockerignore index 421374b..1459219 100644 --- a/.dockerignore +++ b/.dockerignore @@ -1,5 +1,4 @@ .git -.gitmodules .gitignore .DS_Store .idea diff --git a/Dockerfile.test b/Dockerfile.test index a36f5bb..f1ae865 100644 --- a/Dockerfile.test +++ b/Dockerfile.test @@ -7,6 +7,7 @@ RUN apt-get update \ build-essential \ ca-certificates \ curl \ + git \ gzip \ hashcat \ ocl-icd-libopencl1 \ diff --git a/Makefile b/Makefile index 099b72c..3fa3ea2 100644 --- a/Makefile +++ b/Makefile @@ -5,8 +5,8 @@ hashcat-utils: submodules $(MAKE) -C hashcat-utils submodules: - @# Initialize submodules when present - @if [ -f .gitmodules ] && command -v git >/dev/null 2>&1; then \ + @# Initialize submodules only when inside a git repo (not in Docker/CI copies) + @if [ -d .git ] && [ -f .gitmodules ] && command -v git >/dev/null 2>&1; then \ git submodule update --init --recursive; \ fi; \ $(MAKE) submodules-pre; \