mirror of
https://github.com/trustedsec/hate_crack.git
synced 2026-06-25 16:04:21 -07:00
Justin Bollinger
3d79d2d101
Three unrelated test issues were masking the fingerprint regression above and need to be green for the suite to be trustworthy: 1. tests/test_cli_flags.py: 7 tests monkeypatched input() to return "5", but in the no-hashfile main menu "5" enters the Wordlist Tools submenu and then loops forever on "Split by Length" / "File not found". Changed to "7" (Exit), the documented exit option. 2. tests/test_fingerprint_expander_and_hybrid.py: the iter-based lineCount mock (iter([1,1,1])) raised StopIteration because _run_hcat_cmd now also calls lineCount once per invocation when notifications fire. Replaced with a constant `lambda _p: 1` so the test no longer couples to internal call counts. 3. tests/test_submodule_hashcat_utils.py: `git submodule update --init` exits 0 in git worktrees but does not populate submodule directories. The test failed environmentally for anyone running it from a worktree. After the init attempt, if the dir is still empty, pytest.skip with a clear message rather than fail - preserves the original intent for normal checkouts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
46 lines
1.6 KiB
Python
46 lines
1.6 KiB
Python
import os
|
|
import subprocess
|
|
import shutil
|
|
|
|
|
|
def _is_hashcat_utils_empty(path):
|
|
if not os.path.isdir(path):
|
|
return True
|
|
entries = [e for e in os.listdir(path) if e not in (".git", ".gitignore")]
|
|
return len(entries) == 0
|
|
|
|
|
|
def test_hashcat_utils_submodule_initialized():
|
|
import pytest
|
|
|
|
if shutil.which("git") is None:
|
|
pytest.skip("git not available")
|
|
|
|
repo_root = os.path.abspath(os.path.join(os.path.dirname(__file__), os.pardir))
|
|
submodule_path = os.path.join(repo_root, "hashcat-utils")
|
|
|
|
if _is_hashcat_utils_empty(submodule_path):
|
|
result = subprocess.run(
|
|
["git", "submodule", "update", "--init", "--recursive"],
|
|
cwd=repo_root,
|
|
capture_output=True,
|
|
text=True,
|
|
)
|
|
assert result.returncode == 0, (
|
|
"git submodule update failed: "
|
|
f"stdout={result.stdout} stderr={result.stderr}"
|
|
)
|
|
# Git worktrees share the parent repo's submodules — `submodule update`
|
|
# exits 0 but does not populate the worktree's submodule dirs. When that
|
|
# happens, skip rather than fail: the test's intent is to flag missing
|
|
# initialization in normal checkouts, not to gate worktree workflows.
|
|
if _is_hashcat_utils_empty(submodule_path):
|
|
pytest.skip(
|
|
"hashcat-utils submodule not populated (likely a git worktree); "
|
|
"run `git submodule update --init --recursive` in the main checkout"
|
|
)
|
|
|
|
assert not _is_hashcat_utils_empty(submodule_path), (
|
|
"hashcat-utils submodule is empty. Run: git submodule update --init --recursive"
|
|
)
|