mirror of
https://github.com/trustedsec/hate_crack.git
synced 2026-04-28 12:03:11 -07:00
dc9d52d758
_run_upgrade now runs `git pull && git fetch --tags && make install` instead of the bespoke _install_system_deps function. make install is idempotent, handles all platforms, installs system deps (transmission- daemon, p7zip), rebuilds the Python package, and updates the CLI shim. Remove the now-unnecessary uv binary pre-check (make install locates it) and its stale test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
281 lines
10 KiB
Python
281 lines
10 KiB
Python
"""Tests for the startup version check feature."""
|
|
|
|
import json
|
|
from unittest.mock import MagicMock, call, patch
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def hc_module():
|
|
"""Load hate_crack.main with SKIP_INIT enabled."""
|
|
import os
|
|
import importlib
|
|
|
|
os.environ["HATE_CRACK_SKIP_INIT"] = "1"
|
|
mod = importlib.import_module("hate_crack.main")
|
|
return mod
|
|
|
|
|
|
class TestCheckForUpdates:
|
|
"""Tests for check_for_updates()."""
|
|
|
|
def test_newer_version_prints_update_notice(self, hc_module, capsys):
|
|
mock_resp = MagicMock()
|
|
mock_resp.json.return_value = {"tag_name": "v99.0.0"}
|
|
mock_resp.raise_for_status = MagicMock()
|
|
|
|
with patch.object(hc_module, "requests") as mock_requests, patch.object(
|
|
hc_module, "REQUESTS_AVAILABLE", True
|
|
), patch("builtins.input", return_value="n"):
|
|
mock_requests.get.return_value = mock_resp
|
|
hc_module.check_for_updates()
|
|
|
|
output = capsys.readouterr().out
|
|
assert "Update available: 99.0.0" in output
|
|
assert "github.com/trustedsec/hate_crack/releases" in output
|
|
|
|
def test_same_version_prints_nothing(self, hc_module, capsys):
|
|
from hate_crack import __version__
|
|
|
|
local_base = __version__.split("+")[0]
|
|
mock_resp = MagicMock()
|
|
mock_resp.json.return_value = {"tag_name": f"v{local_base}"}
|
|
mock_resp.raise_for_status = MagicMock()
|
|
|
|
with patch.object(hc_module, "requests") as mock_requests, patch.object(
|
|
hc_module, "REQUESTS_AVAILABLE", True
|
|
):
|
|
mock_requests.get.return_value = mock_resp
|
|
hc_module.check_for_updates()
|
|
|
|
output = capsys.readouterr().out
|
|
assert "Update available" not in output
|
|
|
|
def test_older_version_prints_nothing(self, hc_module, capsys):
|
|
mock_resp = MagicMock()
|
|
mock_resp.json.return_value = {"tag_name": "v0.0.1"}
|
|
mock_resp.raise_for_status = MagicMock()
|
|
|
|
with (
|
|
patch.object(hc_module, "requests") as mock_requests,
|
|
patch.object(hc_module, "REQUESTS_AVAILABLE", True),
|
|
patch("hate_crack.__version__", "2.0"),
|
|
):
|
|
mock_requests.get.return_value = mock_resp
|
|
hc_module.check_for_updates()
|
|
|
|
output = capsys.readouterr().out
|
|
assert "Update available" not in output
|
|
|
|
def test_network_error_silently_handled(self, hc_module, capsys):
|
|
with patch.object(hc_module, "requests") as mock_requests, patch.object(
|
|
hc_module, "REQUESTS_AVAILABLE", True
|
|
):
|
|
mock_requests.get.side_effect = ConnectionError("no network")
|
|
hc_module.check_for_updates()
|
|
|
|
output = capsys.readouterr().out
|
|
assert "Update available" not in output
|
|
assert "Error" not in output
|
|
|
|
def test_requests_unavailable_skips_check(self, hc_module, capsys):
|
|
with patch.object(hc_module, "requests") as mock_requests, patch.object(
|
|
hc_module, "REQUESTS_AVAILABLE", False
|
|
):
|
|
hc_module.check_for_updates()
|
|
mock_requests.get.assert_not_called()
|
|
|
|
def test_config_disabled_skips_check(self, hc_module):
|
|
"""Verify that check_for_updates_enabled=False prevents the call in main()."""
|
|
# The config flag is checked in main() before calling check_for_updates().
|
|
# We verify the flag loads correctly from config.
|
|
assert hasattr(hc_module, "check_for_updates_enabled")
|
|
|
|
def test_tag_without_v_prefix(self, hc_module, capsys):
|
|
mock_resp = MagicMock()
|
|
mock_resp.json.return_value = {"tag_name": "99.0.0"}
|
|
mock_resp.raise_for_status = MagicMock()
|
|
|
|
with patch.object(hc_module, "requests") as mock_requests, patch.object(
|
|
hc_module, "REQUESTS_AVAILABLE", True
|
|
), patch("builtins.input", return_value="n"):
|
|
mock_requests.get.return_value = mock_resp
|
|
hc_module.check_for_updates()
|
|
|
|
output = capsys.readouterr().out
|
|
assert "Update available: 99.0.0" in output
|
|
|
|
def test_empty_tag_name_handled(self, hc_module, capsys):
|
|
mock_resp = MagicMock()
|
|
mock_resp.json.return_value = {"tag_name": ""}
|
|
mock_resp.raise_for_status = MagicMock()
|
|
|
|
with patch.object(hc_module, "requests") as mock_requests, patch.object(
|
|
hc_module, "REQUESTS_AVAILABLE", True
|
|
):
|
|
mock_requests.get.return_value = mock_resp
|
|
hc_module.check_for_updates()
|
|
|
|
output = capsys.readouterr().out
|
|
assert "Update available" not in output
|
|
|
|
def test_upgrade_declined_does_not_run_make(self, hc_module):
|
|
mock_resp = MagicMock()
|
|
mock_resp.json.return_value = {"tag_name": "v99.0.0"}
|
|
mock_resp.raise_for_status = MagicMock()
|
|
|
|
with patch.object(hc_module, "requests") as mock_requests, patch.object(
|
|
hc_module, "REQUESTS_AVAILABLE", True
|
|
), patch("builtins.input", return_value="n"), patch(
|
|
"subprocess.run"
|
|
) as mock_run:
|
|
mock_requests.get.return_value = mock_resp
|
|
hc_module.check_for_updates()
|
|
|
|
mock_run.assert_not_called()
|
|
|
|
def test_upgrade_accepted_runs_make_and_exits(self, hc_module, capsys):
|
|
mock_resp = MagicMock()
|
|
mock_resp.json.return_value = {"tag_name": "v99.0.0"}
|
|
mock_resp.raise_for_status = MagicMock()
|
|
|
|
git_root_proc = MagicMock()
|
|
git_root_proc.returncode = 0
|
|
git_root_proc.stdout = "/fake/repo\n"
|
|
|
|
make_proc = MagicMock()
|
|
make_proc.returncode = 0
|
|
|
|
with patch.object(hc_module, "requests") as mock_requests, patch.object(
|
|
hc_module, "REQUESTS_AVAILABLE", True
|
|
), patch("builtins.input", return_value="y"), patch(
|
|
"subprocess.run", side_effect=[git_root_proc, make_proc]
|
|
) as mock_run, pytest.raises(SystemExit):
|
|
mock_requests.get.return_value = mock_resp
|
|
hc_module.check_for_updates()
|
|
|
|
assert mock_run.call_count == 2
|
|
make_cmd = mock_run.call_args_list[1][0][0]
|
|
assert "git pull" in make_cmd
|
|
assert "make install" in make_cmd
|
|
assert mock_run.call_args_list[1][1]["cwd"] == "/fake/repo"
|
|
output = capsys.readouterr().out
|
|
assert "Upgrade complete" in output
|
|
|
|
def test_upgrade_failure_prints_error(self, hc_module, capsys):
|
|
mock_resp = MagicMock()
|
|
mock_resp.json.return_value = {"tag_name": "v99.0.0"}
|
|
mock_resp.raise_for_status = MagicMock()
|
|
|
|
git_root_proc = MagicMock()
|
|
git_root_proc.returncode = 0
|
|
git_root_proc.stdout = "/fake/repo\n"
|
|
|
|
make_proc = MagicMock()
|
|
make_proc.returncode = 1
|
|
|
|
with patch.object(hc_module, "requests") as mock_requests, patch.object(
|
|
hc_module, "REQUESTS_AVAILABLE", True
|
|
), patch("builtins.input", return_value="y"), patch(
|
|
"subprocess.run", side_effect=[git_root_proc, make_proc]
|
|
), patch("shutil.which", return_value="/usr/local/bin/uv"), patch(
|
|
"os.path.isfile", return_value=True
|
|
), pytest.raises(
|
|
SystemExit
|
|
):
|
|
mock_requests.get.return_value = mock_resp
|
|
hc_module.check_for_updates()
|
|
|
|
output = capsys.readouterr().out
|
|
assert "Upgrade failed" in output
|
|
|
|
def test_upgrade_no_git_repo_prints_manual_instructions(self, hc_module, capsys):
|
|
mock_resp = MagicMock()
|
|
mock_resp.json.return_value = {"tag_name": "v99.0.0"}
|
|
mock_resp.raise_for_status = MagicMock()
|
|
|
|
git_root_proc = MagicMock()
|
|
git_root_proc.returncode = 128
|
|
git_root_proc.stdout = ""
|
|
|
|
with patch.object(hc_module, "requests") as mock_requests, patch.object(
|
|
hc_module, "REQUESTS_AVAILABLE", True
|
|
), patch("builtins.input", return_value="y"), patch(
|
|
"subprocess.run", return_value=git_root_proc
|
|
), pytest.raises(
|
|
SystemExit
|
|
):
|
|
mock_requests.get.return_value = mock_resp
|
|
hc_module.check_for_updates()
|
|
|
|
output = capsys.readouterr().out
|
|
assert "Run manually" in output
|
|
|
|
|
|
class TestRunUpgrade:
|
|
"""Tests for _run_upgrade() called directly via --update flag."""
|
|
|
|
def test_run_upgrade_success(self, hc_module, capsys):
|
|
git_root_proc = MagicMock()
|
|
git_root_proc.returncode = 0
|
|
git_root_proc.stdout = "/fake/repo\n"
|
|
|
|
make_proc = MagicMock()
|
|
make_proc.returncode = 0
|
|
|
|
with patch("subprocess.run", side_effect=[git_root_proc, make_proc]) as mock_run, \
|
|
pytest.raises(SystemExit) as exc:
|
|
hc_module._run_upgrade()
|
|
|
|
assert exc.value.code == 0
|
|
assert mock_run.call_count == 2
|
|
make_cmd = mock_run.call_args_list[1][0][0]
|
|
assert "git pull" in make_cmd
|
|
assert "make install" in make_cmd
|
|
assert mock_run.call_args_list[1][1]["cwd"] == "/fake/repo"
|
|
output = capsys.readouterr().out
|
|
assert "Upgrade complete" in output
|
|
|
|
def test_run_upgrade_make_failure(self, hc_module, capsys):
|
|
git_root_proc = MagicMock()
|
|
git_root_proc.returncode = 0
|
|
git_root_proc.stdout = "/fake/repo\n"
|
|
|
|
make_proc = MagicMock()
|
|
make_proc.returncode = 1
|
|
|
|
with patch("subprocess.run", side_effect=[git_root_proc, make_proc]), pytest.raises(SystemExit) as exc:
|
|
hc_module._run_upgrade()
|
|
|
|
assert exc.value.code == 1
|
|
output = capsys.readouterr().out
|
|
assert "Upgrade failed" in output
|
|
|
|
def test_run_upgrade_no_git_repo(self, hc_module, capsys):
|
|
git_root_proc = MagicMock()
|
|
git_root_proc.returncode = 128
|
|
git_root_proc.stdout = ""
|
|
|
|
with patch("subprocess.run", return_value=git_root_proc), pytest.raises(SystemExit) as exc:
|
|
hc_module._run_upgrade()
|
|
|
|
assert exc.value.code == 1
|
|
output = capsys.readouterr().out
|
|
assert "Run manually" in output
|
|
|
|
def test_upgrade_prompt_ctrl_c_continues(self, hc_module, capsys):
|
|
mock_resp = MagicMock()
|
|
mock_resp.json.return_value = {"tag_name": "v99.0.0"}
|
|
mock_resp.raise_for_status = MagicMock()
|
|
|
|
with patch.object(hc_module, "requests") as mock_requests, patch.object(
|
|
hc_module, "REQUESTS_AVAILABLE", True
|
|
), patch("builtins.input", side_effect=KeyboardInterrupt), patch(
|
|
"subprocess.run"
|
|
) as mock_run:
|
|
mock_requests.get.return_value = mock_resp
|
|
hc_module.check_for_updates()
|
|
|
|
mock_run.assert_not_called()
|