chore(deps): update dependency eslint-plugin-unicorn to v70 - abandoned (#29684)

* chore(deps): update dependency eslint-plugin-unicorn to v70

* fix: linting

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Dietzler <mail@ddietzler.dev>

server/src/controllers/asset-media.controller.ts

@@ -131,7 +131,7 @@ export class AssetMediaController {
       const [_, reqSearch] = req.url.split('?');
       const redirSearchParams = new URLSearchParams(reqSearch);
       redirSearchParams.delete('size');
-      return res.redirect('original' + '?' + redirSearchParams.toString());
+      return res.redirect('original?' + redirSearchParams.toString());
     }
 
     const viewThumbnailRes = await this.service.viewThumbnail(auth, id, dto);

server/src/controllers/download.controller.spec.ts

@@ -32,7 +32,9 @@ describe(DownloadController.name, () => {
     it('should be an authenticated route', async () => {
       const stream = new Readable({
         read() {
+          // eslint-disable-next-line unicorn/no-this-outside-of-class
           this.push('test');
+          // eslint-disable-next-line unicorn/no-this-outside-of-class
           this.push(null);
         },
       });

server/src/controllers/maintenance.controller.ts

@@ -65,12 +65,14 @@ export class MaintenanceController {
     @GetLoginDetails() loginDetails: LoginDetails,
     @Res({ passthrough: true }) res: Response,
   ): Promise<void> {
-    if (dto.action !== MaintenanceAction.End) {
-      const { jwt } = await this.service.startMaintenance(dto, auth.user.name);
-      return respondWithCookie(res, undefined, {
-        isSecure: loginDetails.isSecure,
-        values: [{ key: ImmichCookie.MaintenanceToken, value: jwt }],
-      });
+    if (dto.action === MaintenanceAction.End) {
+      return;
     }
+
+    const { jwt } = await this.service.startMaintenance(dto, auth.user.name);
+    return respondWithCookie(res, undefined, {
+      isSecure: loginDetails.isSecure,
+      values: [{ key: ImmichCookie.MaintenanceToken, value: jwt }],
+    });
   }
 }

server/src/controllers/system-config.controller.spec.ts

@@ -14,10 +14,10 @@ function validConfig() {
     notifications: { smtp: { from: string; transport: { host: string } } };
     server: { externalDomain: string };
   };
-  config.oauth.mobileRedirectUri = config.oauth.mobileRedirectUri || 'https://example.com';
-  config.server.externalDomain = config.server.externalDomain || 'https://example.com';
-  config.notifications.smtp.from = config.notifications.smtp.from || 'noreply@example.com';
-  config.notifications.smtp.transport.host = config.notifications.smtp.transport.host || 'localhost';
+  config.oauth.mobileRedirectUri ||= 'https://example.com';
+  config.server.externalDomain ||= 'https://example.com';
+  config.notifications.smtp.from ||= 'noreply@example.com';
+  config.notifications.smtp.transport.host ||= 'localhost';
   return config;
 }
 

server/src/controllers/timeline.controller.spec.ts

@@ -33,7 +33,7 @@ describe(TimelineController.name, () => {
       expect(service.getTimeBuckets).toHaveBeenCalledWith(
         undefined,
         expect.objectContaining({
-          bbox: { west: 11.075_683, south: 49.416_711, east: 11.117_589, north: 49.454_875 },
+          bbox: { west: 11.075683, south: 49.416711, east: 11.117589, north: 49.454875 },
         }),
       );
     });