gitea-mirror/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2026-07-28 14:47:15 -07:00
Code Issues Packages Projects Releases Wiki Activity

Optimized handle_notify_new_transactions's duplicate tx check

Browse Source 
- Check sha256 digests instead of full blobs (much less memory used)
- Replace `find->insert` sequence with a single `insert` - 2x fewer hashset accesses
- Preallocate the required size for the hashset (no full-table rehashes)
This commit is contained in:
SChernykh
2026-06-29 08:06:31 +02:00
parent 85d5a6f95b
commit 330062a004
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/cryptonote_protocol/cryptonote_protocol_handler.inl
+9 -3
View File
@@ -915,17 +915,23 @@ namespace cryptonote
return 1; return 1;
} }
std::unordered_set<blobdata> seen; std::unordered_set<crypto::hash> seen;
seen.reserve(arg.txs.size());
for (const auto &blob: arg.txs) for (const auto &blob: arg.txs)
{ {
MLOGIF_P2P_MESSAGE(cryptonote::transaction tx; crypto::hash hash; bool ret = cryptonote::parse_and_validate_tx_from_blob(blob, tx, hash);, ret, "Including transaction " << hash); MLOGIF_P2P_MESSAGE(cryptonote::transaction tx; crypto::hash hash; bool ret = cryptonote::parse_and_validate_tx_from_blob(blob, tx, hash);, ret, "Including transaction " << hash);
if (seen.find(blob) != seen.end())
crypto::hash digest{};
if (!blob.empty())
tools::sha256sum(reinterpret_cast<const uint8_t*>(blob.data()), blob.size(), digest);
if (!seen.insert(digest).second)
{ {
LOG_PRINT_CCONTEXT_L1("Duplicate transaction in notification, dropping connection"); LOG_PRINT_CCONTEXT_L1("Duplicate transaction in notification, dropping connection");
drop_connection(context, false, false); drop_connection(context, false, false);
return 1; return 1;
} }
seen.insert(blob);
} }
/* If the txes were received over i2p/tor, the default is to "forward" /* If the txes were received over i2p/tor, the default is to "forward"