gitea-mirror/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2026-01-27 07:14:35 -08:00
Code Issues Packages Projects Releases Wiki Activity

logging: Generalize terminal color detection

Browse Source 
Assume the terminal supports color codes if TERM ends with `-color` or
`-256color`, rather than special-casing a handful of such terminals.

Add tests for terminal color detection.

Co-authored-by: laanwj <126646+laanwj@users.noreply.github.com>
This commit is contained in:
iamamyth
2025-02-19 13:09:35 -08:00
parent 915c5dc1d9
commit 446d9622f8
3 changed files with 49 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tests/unit_tests/logging.cpp
View File

@@ -195,6 +195,41 @@ TEST(logging, multiline)
cleanup();
}
class LoggingTermSupportsColorSuite : public testing::TestWithParam<std::tuple<std::string, bool>> {};
TEST_P(LoggingTermSupportsColorSuite, Detection)
{
std::tuple<std::string, bool> param = GetParam();
auto term = std::get<0>(param);
auto is_color = std::get<1>(param);
ASSERT_EQ(el::base::utils::OS::termSupportsColor(term), is_color) << term;
}
INSTANTIATE_TEST_SUITE_P(
TerminalStrings,
LoggingTermSupportsColorSuite,
testing::Values(
std::make_tuple("", false),
// unrecognized terminals
std::make_tuple("basic", false),
std::make_tuple("vt100", false),
// known color terminals
std::make_tuple("xterm", true),
std::make_tuple("screen", true),
std::make_tuple("linux", true),
std::make_tuple("cygwin", true),
std::make_tuple("xterm-color", true),
std::make_tuple("xterm-256color", true),
std::make_tuple("screen-256color", true),
std::make_tuple("screen.xterm-256color", true),
// generic color terminal detection by suffix
std::make_tuple("unrecognized-color", true),
std::make_tuple("unrecognized-256color", true),
std::make_tuple("basic-nocolor", false),
std::make_tuple("basic-no256color", false),
std::make_tuple("basic-color-unsupported", false),
std::make_tuple("basic-256color-unsupported", false)
));
// These operations might segfault
TEST(logging, copy_ctor_segfault)
{