gitea-mirror/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2026-01-09 11:45:11 -08:00
Code Issues Packages Projects Releases Wiki Activity

dns: make ctor private

Browse Source 
This ensures one can't instanciate a DNSResolver object by
mistake, but uses the singleton. A separate create static
function is added for cases where a new object is explicitely
needed.
This commit is contained in:
moneromooo-monero
2015-08-27 21:06:09 +01:00
parent a1af0feb06
commit 5990344cb0
3 changed files with 21 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/unit_tests/dns_resolver.cpp
View File

@@ -35,7 +35,7 @@
TEST(DNSResolver, IPv4Success)
{
tools::DNSResolver resolver;
tools::DNSResolver resolver = tools::DNSResolver::create();
bool avail, valid;
@@ -55,7 +55,7 @@ TEST(DNSResolver, IPv4Success)
TEST(DNSResolver, IPv4Failure)
{
// guaranteed by IANA/ICANN/RFC to be invalid
tools::DNSResolver resolver;
tools::DNSResolver resolver = tools::DNSResolver::create();
bool avail, valid;
@@ -70,7 +70,7 @@ TEST(DNSResolver, IPv4Failure)
TEST(DNSResolver, DNSSECSuccess)
{
tools::DNSResolver resolver;
tools::DNSResolver resolver = tools::DNSResolver::create();
bool avail, valid;
@@ -86,7 +86,7 @@ TEST(DNSResolver, DNSSECSuccess)
TEST(DNSResolver, DNSSECFailure)
{
tools::DNSResolver resolver;
tools::DNSResolver resolver = tools::DNSResolver::create();
bool avail, valid;
@@ -103,7 +103,7 @@ TEST(DNSResolver, DNSSECFailure)
// It would be great to include an IPv6 test and assume it'll pass, but not every ISP / resolver plays nicely with IPv6;)
/*TEST(DNSResolver, IPv6Success)
{
tools::DNSResolver resolver;
tools::DNSResolver resolver = tools::DNSResolver::create();
bool avail, valid;
@@ -123,7 +123,7 @@ TEST(DNSResolver, DNSSECFailure)
TEST(DNSResolver, IPv6Failure)
{
// guaranteed by IANA/ICANN/RFC to be invalid
tools::DNSResolver resolver;
tools::DNSResolver resolver = tools::DNSResolver::create();
bool avail, valid;