From b1f456140a12c123ae9f39cfaffb94c5639fbcf9 Mon Sep 17 00:00:00 2001 From: selsta Date: Fri, 26 Jun 2026 02:45:33 +0200 Subject: [PATCH] wallet2: remove unused pool tx removed callback on_pool_tx_removed has no implementation beyond the empty default callback and is not wired through the wallet API layer. The only call site passed txid after erasing the payment entry that owned it, leaving a dangling reference. --- src/wallet/wallet2.cpp | 2 -- src/wallet/wallet2.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/wallet/wallet2.cpp b/src/wallet/wallet2.cpp index 8496cf600..d1a08e642 100644 --- a/src/wallet/wallet2.cpp +++ b/src/wallet/wallet2.cpp @@ -3596,8 +3596,6 @@ void wallet2::remove_obsolete_pool_txs(const std::vector &tx_hashe { MDEBUG("Removing " << txid << " from unconfirmed payments"); m_unconfirmed_payments.erase(pit); - if (0 != m_callback) - m_callback->on_pool_tx_removed(txid); } } } diff --git a/src/wallet/wallet2.h b/src/wallet/wallet2.h index 90149b11b..57900da63 100644 --- a/src/wallet/wallet2.h +++ b/src/wallet/wallet2.h @@ -136,8 +136,6 @@ private: virtual boost::optional on_device_pin_request() { return boost::none; } virtual boost::optional on_device_passphrase_request(bool & on_device) { on_device = true; return boost::none; } virtual void on_device_progress(const hw::device_progress& event) {}; - // Common callbacks - virtual void on_pool_tx_removed(const crypto::hash &txid) {} virtual ~i_wallet2_callback() {} };