gitea-mirror/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2026-07-28 14:47:15 -07:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10863

Browse Source 
2f2409d wallet: rpc; req. ssl cert params w/ proxy when daemon not onion/i2p (nahuhh)

ACKs: selsta, plowsof
This commit is contained in:
tobtoht
2026-07-22 16:17:55 +00:00
parent d13ac35f23 2f2409dfca
commit a3adf4ce62
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wallet/wallet_rpc_server.cpp
+6 -3
View File
@@ -4827,14 +4827,17 @@ namespace tools
std::move(req.ssl_private_key_path), std::move(req.ssl_certificate_path)
};
// If a proxy or SSL is explicitly enabled, then ssl_allow_any_cert, ssl_ca_file, ssl_allowed_fingerprints, or use of a .onion or .i2p address is required
const boost::string_ref real_daemon = boost::string_ref{req.address}.substr(0, req.address.rfind(':'));
const bool use_proxy = !req.proxy.empty();
const bool verification_required =
ssl_options.verification != epee::net_utils::ssl_verification_t::none &&
ssl_options.support == epee::net_utils::ssl_support_t::e_ssl_support_enabled;
(ssl_options.support == epee::net_utils::ssl_support_t::e_ssl_support_enabled || use_proxy);
if (verification_required && !ssl_options.has_strong_verification(boost::string_ref{}))
if (verification_required && !ssl_options.has_strong_verification(real_daemon))
{
er.code = WALLET_RPC_ERROR_CODE_NO_DAEMON_CONNECTION;
er.message = "SSL is enabled but no user certificate or fingerprints were provided";
er.message = "SSL or proxy is enabled but no strong verification was configured; set ssl_allow_any_cert, ssl_ca_file, or ssl_allowed_fingerprints, or use a .onion or .i2p address";
return false;
}