gitea-mirror/monero
1
0
Fork 0
mirror of https://github.com/monero-project/monero.git synced 2026-06-13 03:21:34 -07:00
Code Issues Packages Projects Releases Wiki Activity

rpc: reject invalid JSON-RPC ids in ZMQ requests

Browse Source
This commit is contained in:
selsta
2026-05-10 14:01:05 +02:00
parent cabeafa01a
commit f3128c6e5a
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/rpc/message.cpp
+12
View File
@@ -62,6 +62,17 @@ const rapidjson::Value& get_method_field(const rapidjson::Value& src)
}
}
void validate_id_field(const rapidjson::Value& src)
{
const auto member = src.FindMember(id_field);
if (member == src.MemberEnd())
return;
// If present, JSON-RPC 2.0 request ids must be String, Number, or Null.
if (!member->value.IsString() && !member->value.IsNumber() && !member->value.IsNull())
throw cryptonote::json::WRONG_TYPE{"Expected string, number or null"};
}
void Message::toJson(rapidjson::Writer<epee::byte_stream>& dest) const
{
dest.StartObject();
@@ -92,6 +103,7 @@ FullMessage::FullMessage(std::string&& json_string, bool request)
{
get_method_field(doc); // throws on errors
OBJECT_HAS_MEMBER_OR_THROW(doc, params_field)
validate_id_field(doc);
}
else
{