From f855ffe87ddc593b286ad02f84b24b804872773a Mon Sep 17 00:00:00 2001 From: tobtoht Date: Tue, 28 Apr 2026 16:40:32 +0200 Subject: [PATCH] wallet2: throw if reserve proof can't be parsed --- src/wallet/wallet2.cpp | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/wallet/wallet2.cpp b/src/wallet/wallet2.cpp index b57ae3b69..f06cfce8b 100644 --- a/src/wallet/wallet2.cpp +++ b/src/wallet/wallet2.cpp @@ -13396,13 +13396,19 @@ bool wallet2::check_reserve_proof(const cryptonote::account_public_address &addr loaded = true; } catch(...) {} - if (!loaded && m_load_deprecated_formats) + try { - std::istringstream iss(sig_decoded); - boost::archive::portable_binary_iarchive ar(iss); - ar >> proofs >> subaddr_spendkeys.parent(); + if (!loaded && m_load_deprecated_formats) + { + std::istringstream iss(sig_decoded); + boost::archive::portable_binary_iarchive ar(iss); + ar >> proofs >> subaddr_spendkeys.parent(); + loaded = true; + } } + catch(...) {} + THROW_WALLET_EXCEPTION_IF(!loaded, error::wallet_internal_error, "Failed to parse reserve proof signature data"); THROW_WALLET_EXCEPTION_IF(subaddr_spendkeys.count(address.m_spend_public_key) == 0, error::wallet_internal_error, "The given address isn't found in the proof");