Commit Graph
92 Commits
Author SHA1 Message Date
Thomas fecef767c9 Fix spelling typos in comments and string literals 2026-06-27 09:53:48 +02:00
jeffro256 03018306a9 ledger: lazy view key loading
Defer loading of private view key from device until first time it is needed.
Do not fail if this fails. This has two effects:

1. The prompt to export the view key is only needed once when creating a `cryptonote::account_base`
2. The call to `connect()` doesn't fail if the user decies to not export the viewkey, and thus usage of the device without exporting view keys is possible

This is a small convenience for Ledger users, but will be an even larger convenience for Ledger device testing
2026-06-04 13:52:33 -05:00
jpk68andSNeedlewoods 7d12b568c9 device fix typos 2026-04-22 19:41:32 +02:00
tobtoht b937f8616d ledger: add nano gen5 id 2025-12-01 01:48:32 +01:00
tobtoht e89922a2fd ledger: throw on secret view key export rejection 2025-11-11 21:21:41 +01:00
tobtoht bd2b226572 device: add ledger flex support
See: https://github.com/LedgerHQ/ledger-live/blob/bd1b09970f2f5a27eb08352a67a73dfa2fce29f6/libs/ledgerjs/packages/devices/src/index.ts#L111
2024-08-09 10:31:16 +02:00
copyCat 341771ac3e copyright: bump to 2024 2024-05-21 16:29:33 +00:00
selsta 5136974da9 device: boost -> std locks to fix c++17 compilation 2023-10-26 04:02:26 +02:00
luigi1111 9bf06ea75d Merge pull request #8698
5b4fea7 Copyright: Update to 2023 (mj-xmr)
2023-04-25 11:12:56 -04:00
Francois Beutin 1b27fcdf77 device: Add ledger Stax device id to device detection 2023-03-14 10:31:20 +01:00
mj-xmrandmj-xmr 5b4fea72cf Copyright: Update to 2023
Co-authored-by: plowsof <plowsof@protonmail.com>
extra files
2023-01-16 13:00:18 +01:00
luigi1111 ab63fbc549 Merge pull request #8465
04a1e28 ledger support for hf 15 (BP+, view tags) (j-berman)
2022-08-22 22:49:47 -05:00
luigi1111 df02b56289 Merge pull request #8359
4d7f6f5 GCC: fix some unused warnings (Jeffrey Ryan)
2022-08-22 22:40:09 -05:00
j-berman 04a1e2875d ledger support for hf 15 (BP+, view tags) 2022-08-06 15:00:49 -07:00
Jeffrey Ryan 4d7f6f5cd5 GCC: fix some unused warnings
hash_extra: don't test for success in `jh_hash` and `skein_hash` since its guaranteed
device_ledger: move anonymous global variable apdu_verbose into .cpp file
Add comments to `refreshed` method variable in wallet2
2022-07-11 20:32:03 -05:00
moneromooo-monero 4278a3a7e3 cryptonote_basic: catch crypto api errors 2022-06-20 22:17:57 +00:00
luigi1111 8ddbe18277 Merge pull request #8232
0f7b20a Added support for Ledger Nano S Plus (Mathias Herberts)
2022-04-19 22:15:10 -05:00
j-berman ea87b30f89 Add view tags to outputs to reduce wallet scanning time
Implements view tags as proposed by @UkoeHB in MRL issue
https://github.com/monero-project/research-lab/issues/73

At tx construction, the sender adds a 1-byte view tag to each
output. The view tag is derived from the sender-receiver
shared secret. When scanning for outputs, the receiver can
check the view tag for a match, in order to reduce scanning
time. When the view tag does not match, the wallet avoids the
more expensive EC operations when deriving the output public
key using the shared secret.
2022-04-18 00:49:53 -07:00
Mathias Herberts 0f7b20a1ce Added support for Ledger Nano S Plus 2022-03-31 18:25:09 +02:00
mj-xmr da9aa1f7f8 Copyright: Update to 2022 2022-03-04 06:59:20 +01:00
selsta 1efe624e30 device_ledger: fix incorrect macro
The current code does work by accident, but it might break if
someone uses ASSERT_SW in a different place, or if variables
get renamed.
2021-11-12 02:56:20 +01:00
selsta fbe8358c9f device: fix ledger error strings, add human friendly messages 2021-11-03 00:10:12 +01:00
luigi1111 69e714c749 Merge pull request #7745
d52d21b ledger: don't lock for software device (tobtoht)
2021-07-27 16:56:37 -04:00
tobtoht d52d21bd46 ledger: don't lock for software device 2021-06-04 17:41:42 +02:00
tobtoht ce40c33a33 ledger: use software device if we have view key 2021-06-04 15:02:06 +02:00
xiphon 593ae2e9f9 device: Ledger - update status codes 2020-10-13 22:53:19 +00:00
François Colas 975ae22211 Fix send scalar z in plaintext
The scalar z has not been generated on the HW thus it can't be sent
encrypted. The value is derived from the exported private view key.
2020-08-28 12:01:57 +02:00
François Colas 0a3c5a605b Update protocol version with Ledger's HW 2020-08-28 11:59:02 +02:00
cslashmandmoneromooo-monero 1660fe8a25 draft support of clsag 2020-08-27 12:44:18 +00:00
moneromooo-monero 82ee01699c Integrate CLSAGs into monero
They are allowed from v12, and MLSAGs are rejected from v13.
2020-08-27 12:44:04 +00:00
Alexander Blair bc48494731 Merge pull request #6661
267ce5b71 avoid a couple needless copies (moneromooo-monero)
2020-08-16 12:45:37 -07:00
Alexander Blair 9871fefbf9 Merge pull request #6565
72cdfa4a2 fix a few typos in error messages (moneromooo-monero)
2020-07-19 03:40:19 -07:00
Alexander Blair a0d179e528 Merge pull request #6512
5ef0607da Update copyright year to 2020 (SomaticFanatic)
2020-07-19 03:32:59 -07:00
moneromooo-monero 267ce5b718 avoid a couple needless copies 2020-06-14 18:05:35 +00:00
François Colas ec46069248 Fix incorrect lenght of command INS_PREFIX_HASH
buffer_send[4] (LC) is an unsigned char, len should not
exceed 254 (255 - 1 for the option).
2020-05-27 18:06:19 +02:00
moneromooo-monero 72cdfa4a20 fix a few typos in error messages
Reported by adrelanos
2020-05-19 15:59:26 +00:00
SomaticFanatic 5ef0607da6 Update copyright year to 2020
Update copyright year to 2020
2020-05-06 22:36:54 -04:00
luigi1111 443f5c6bda Merge pull request #6436
688a3e8 Add timelock verification on device (cslashm)
2020-05-01 15:20:05 -05:00
cslashm 688a3e87e7 Add timelock verification on device 2020-04-08 11:12:32 +02:00
xiphon 29b7cd1351 device_ledger: include status code name in error message 2020-02-08 01:46:39 +00:00
xiphon 296ec7c9bb device: bounds checking in Ledger send_secret/receive_secret 2019-10-25 13:13:23 +00:00
cslashm 32febd277d Fix debug feature 2019-10-03 16:05:40 +02:00
cslashm 235b94eb59 Revert PR #5835 (export view key) 2019-10-03 16:05:40 +02:00
cslashm 34f28a79bc Add display address 2019-10-03 16:05:32 +02:00
cslashm d25acd7a1d Add hmac over encrypted value during transaction 2019-10-03 16:01:34 +02:00
luigi1111 4ef3848423 Merge pull request #5835
26f7a26 device: fix ledger requesting secret keys export twice (xiphon)
2019-09-08 19:42:49 -05:00
moneromooo-monero 7c894fc7fd device_ledger: add paranoid buffer overflow check
Coverity 200183
2019-08-26 12:50:26 +00:00
xiphon 26f7a26ee3 device: fix ledger requesting secret keys export twice 2019-08-20 16:08:09 +00:00
moneromooo-monero 35c20c4332 Fix GCC 9.1 build warnings
GCC wants operator= aand copy ctor to be both defined, or neither
2019-06-09 09:39:18 +00:00
cslashm 83fc45a413 Add NanoX support 2019-04-01 17:40:24 +02:00