mirror of
https://github.com/rosenpass/rosenpass.git
synced 2025-12-05 20:40:02 -08:00
fix(whitepaper): Incorrect biscuit_no comparison in load_biscuit()
This commit is contained in:
@@ -497,7 +497,7 @@ fn load_biscuit(nct) {
|
|||||||
// -- 2024-11-30, Karolin Varner
|
// -- 2024-11-30, Karolin Varner
|
||||||
if (protocol_version!(< "0.3.0")) {
|
if (protocol_version!(< "0.3.0")) {
|
||||||
// Ensure that the biscuit is used only once
|
// Ensure that the biscuit is used only once
|
||||||
assert(pt.biscuit_no <= peer.biscuit_used);
|
assert(pt.biscuit_no >= peer.biscuit_used);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Restore the chaining key
|
// Restore the chaining key
|
||||||
@@ -802,6 +802,26 @@ Changes, in particular:
|
|||||||
\end{quote}
|
\end{quote}
|
||||||
```
|
```
|
||||||
|
|
||||||
|
8. In `load_biscuit()`, there was a typo doing an incorrect comparison between `biscuit_no` and `biscuit_used`. This is not a security issue, as a verbatim implementation would simply have lead to a non-functional implementation. We replace
|
||||||
|
|
||||||
|
``` {=tex}
|
||||||
|
\begin{quote}
|
||||||
|
\begin{minted}{pseudorust}
|
||||||
|
assert(pt.biscuit_no <= peer.biscuit_used);
|
||||||
|
\end{minted}
|
||||||
|
\end{quote}
|
||||||
|
|
||||||
|
```
|
||||||
|
|
||||||
|
by
|
||||||
|
|
||||||
|
``` {=tex}
|
||||||
|
\begin{quote}
|
||||||
|
\begin{minted}{pseudorust}
|
||||||
|
assert(pt.biscuit_no >= peer.biscuit_used);
|
||||||
|
\end{minted}
|
||||||
|
\end{quote}
|
||||||
|
```
|
||||||
|
|
||||||
#### 2025-06-24 – Specifying the `osk` used for WireGuard as a protocol extension
|
#### 2025-06-24 – Specifying the `osk` used for WireGuard as a protocol extension
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user