chore: Warnings & clippy hints

This commit is contained in:
Karolin Varner
2024-08-03 14:06:58 +02:00
parent 40c5bbd167
commit 54ac5eecdb
5 changed files with 13 additions and 5 deletions

View File

@@ -15,8 +15,7 @@ pub struct Input {
} }
fuzz_target!(|input: Input| { fuzz_target!(|input: Input| {
let mut ciphertext: Vec<u8> = Vec::with_capacity(input.plaintext.len() + 16); let mut ciphertext = vec![0u8; input.plaintext.len() + 16];
ciphertext.resize(input.plaintext.len() + 16, 0);
aead::encrypt( aead::encrypt(
ciphertext.as_mut_slice(), ciphertext.as_mut_slice(),

View File

@@ -283,6 +283,7 @@ struct MockBrokerInner {
interface: Option<String>, interface: Option<String>,
} }
#[allow(dead_code)]
#[derive(Debug, Default)] #[derive(Debug, Default)]
struct MockBroker { struct MockBroker {
inner: Arc<Mutex<MockBrokerInner>>, inner: Arc<Mutex<MockBrokerInner>>,
@@ -321,7 +322,7 @@ impl rosenpass_wireguard_broker::WireGuardBroker for MockBroker {
if let Ok(ref mut mutex) = lock { if let Ok(ref mut mutex) = lock {
**mutex = MockBrokerInner { **mutex = MockBrokerInner {
psk: Some(config.psk.clone()), psk: Some(config.psk.clone()),
peer_id: Some(config.peer_id.clone()), peer_id: Some(*config.peer_id),
interface: Some(std::str::from_utf8(config.interface).unwrap().to_string()), interface: Some(std::str::from_utf8(config.interface).unwrap().to_string()),
}; };
break Ok(()); break Ok(());

View File

@@ -317,6 +317,7 @@ impl<const N: usize> StoreValueB64Writer for PublicBox<N> {
mod tests { mod tests {
#[cfg(test)] #[cfg(test)]
#[allow(clippy::module_inception)]
mod tests { mod tests {
use crate::{Public, PublicBox}; use crate::{Public, PublicBox};
use rosenpass_util::{ use rosenpass_util::{
@@ -346,7 +347,7 @@ mod tests {
// Store the original bytes to an example file in the temporary directory // Store the original bytes to an example file in the temporary directory
let example_file = temp_dir.path().join("example_file"); let example_file = temp_dir.path().join("example_file");
std::fs::write(example_file.clone(), &original_bytes).unwrap(); std::fs::write(&example_file, original_bytes).unwrap();
// Load the value from the example file into our generic type // Load the value from the example file into our generic type
let loaded_public = T::load(&example_file).unwrap(); let loaded_public = T::load(&example_file).unwrap();

View File

@@ -386,7 +386,7 @@ mod test {
// Store the original secret to an example file in the temporary directory // Store the original secret to an example file in the temporary directory
let example_file = temp_dir.path().join("example_file"); let example_file = temp_dir.path().join("example_file");
std::fs::write(example_file.clone(), &original_bytes).unwrap(); std::fs::write(&example_file, original_bytes).unwrap();
// Load the secret from the example file // Load the secret from the example file
let loaded_secret = Secret::load(&example_file).unwrap(); let loaded_secret = Secret::load(&example_file).unwrap();

View File

@@ -19,15 +19,22 @@ pub trait IntoConst<T> {
const VALUE: T; const VALUE: T;
} }
#[allow(dead_code)]
struct ConstApplyNegSign<T: AssociatedUnsigned, Param: IntoConst<<T as AssociatedUnsigned>::Type>>( struct ConstApplyNegSign<T: AssociatedUnsigned, Param: IntoConst<<T as AssociatedUnsigned>::Type>>(
*const T, *const T,
*const Param, *const Param,
); );
#[allow(dead_code)]
struct ConstApplyPosSign<T: AssociatedUnsigned, Param: IntoConst<<T as AssociatedUnsigned>::Type>>( struct ConstApplyPosSign<T: AssociatedUnsigned, Param: IntoConst<<T as AssociatedUnsigned>::Type>>(
*const T, *const T,
*const Param, *const Param,
); );
#[allow(dead_code)]
struct ConstLshift<T, Param: IntoConst<T>, const SHIFT: i32>(*const T, *const Param); // impl IntoConst<T> struct ConstLshift<T, Param: IntoConst<T>, const SHIFT: i32>(*const T, *const Param); // impl IntoConst<T>
#[allow(dead_code)]
struct ConstAdd<T, Lhs: IntoConst<T>, Rhs: IntoConst<T>>(*const T, *const Lhs, *const Rhs); // impl IntoConst<T> struct ConstAdd<T, Lhs: IntoConst<T>, Rhs: IntoConst<T>>(*const T, *const Lhs, *const Rhs); // impl IntoConst<T>
/// Assigns an unsigned type to a signed type /// Assigns an unsigned type to a signed type