From a5ae83e7261e9c09c6720858c865e64715b02fc6 Mon Sep 17 00:00:00 2001 From: Benjamin Lipp Date: Tue, 22 Jul 2025 17:42:13 +0200 Subject: [PATCH] chore: add TODOs --- marzipan/README.md | 2 +- marzipan/TODO.md | 15 +++++++++++++++ marzipan/src/__init__.py | 1 - 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/marzipan/README.md b/marzipan/README.md index b6750f3..5354c6b 100644 --- a/marzipan/README.md +++ b/marzipan/README.md @@ -5,4 +5,4 @@ * call the old script from the Rosenpass repository's root directory with `./analyze.sh` * call the new script: - * `nix run .# -- analyze analyze $repo` where `$repo` is the absolute(?) path to the root directory of the Rosenpass repository. + * `nix run .# -- analyze $repo` where `$repo` is the absolute(?) path to the root directory of the Rosenpass repository. diff --git a/marzipan/TODO.md b/marzipan/TODO.md index a70a968..691454f 100644 --- a/marzipan/TODO.md +++ b/marzipan/TODO.md @@ -23,6 +23,18 @@ ## Next Steps +* rebase from main +* see if we still need the `extra_args is None` check in `_run_proverif` +* set colors differently to prevent injection attack + * by calling a function + * by prepared statements +* standalone function parse_result_line is no longer necessary +* is the clean function still necessary? +* implement better main function for click +* return an exit status that is meaningful for CI +* rewrite marzipan.awk into Python/LARK +* rewrite cpp into Python/LARK +* integrate the Nix flake into the main Nix flake * think about next steps * integrate this upstream, into the CI? * “make it beautiful” steps? more resiliency to working directory? @@ -31,3 +43,6 @@ * and rewrite the AST within Python * reconstruct ProVerif input file for ProVerif * rewrite our CPP usages into Python/…? + + +“it replaces the Bash script and is idiomatic Python code” diff --git a/marzipan/src/__init__.py b/marzipan/src/__init__.py index d779f71..679df20 100644 --- a/marzipan/src/__init__.py +++ b/marzipan/src/__init__.py @@ -111,7 +111,6 @@ def _awk(cpp_prep, awk_prep): file.write("\nprocess main") - def pretty_output_line(prefix, mark, color, text): # Vulnerable to injection attacks. Use better API. -- karo prefix = f"[grey42]{prefix}[/grey42]"