From 57b1bd711388bf8b42de4b3dba0e4044d214d097 Mon Sep 17 00:00:00 2001 From: vmfunc Date: Wed, 10 Jun 2026 16:08:47 -0700 Subject: [PATCH] fix(favicon): use twmb/murmur3; spaolacci does checkptr-unsafe pointer math that crashes under -race (which CI runs) --- go.mod | 3 ++- internal/scan/favicon.go | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/go.mod b/go.mod index 33e86ea..cb47e5a 100644 --- a/go.mod +++ b/go.mod @@ -14,7 +14,7 @@ require ( github.com/projectdiscovery/retryabledns v1.0.114 github.com/projectdiscovery/utils v0.10.1 github.com/rocketlaunchr/google-search v1.1.6 - github.com/spaolacci/murmur3 v1.1.0 + github.com/twmb/murmur3 v1.1.6 golang.org/x/net v0.53.0 golang.org/x/time v0.14.0 gopkg.in/yaml.v3 v3.0.1 @@ -313,6 +313,7 @@ require ( github.com/sirupsen/logrus v1.9.3 // indirect github.com/skeema/knownhosts v1.3.1 // indirect github.com/sorairolake/lzip-go v0.3.8 // indirect + github.com/spaolacci/murmur3 v1.1.0 // indirect github.com/spf13/afero v1.15.0 // indirect github.com/spf13/cast v1.9.2 // indirect github.com/syndtr/goleveldb v1.0.0 // indirect diff --git a/internal/scan/favicon.go b/internal/scan/favicon.go index 7e80f19..6455739 100644 --- a/internal/scan/favicon.go +++ b/internal/scan/favicon.go @@ -25,7 +25,7 @@ import ( "github.com/dropalldatabases/sif/internal/httpx" "github.com/dropalldatabases/sif/internal/logger" "github.com/dropalldatabases/sif/internal/output" - "github.com/spaolacci/murmur3" + "github.com/twmb/murmur3" ) // FaviconResult is the computed shodan-style favicon hash plus the pivot query