gitea-mirror/trivy
1
0
Fork 0
mirror of https://github.com/aquasecurity/trivy.git synced 2025-12-23 07:29:00 -08:00
Code Issues Packages Projects Releases Wiki Activity

docker_test: Add sad paths for Extract()

Browse Source 
Signed-off-by: Simarpreet Singh <simar@linux.com>
This commit is contained in:
Simarpreet Singh
2019-11-19 14:28:51 -08:00
parent e41cf57454
commit 1e66346f29
1 changed files with 113 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

92
extractor/docker/docker_test.go
View File

@@ -223,12 +223,18 @@ func TestDockerExtractor_SaveLocalImage(t *testing.T) {
}
func TestDockerExtractor_Extract(t *testing.T) {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
httpPath := r.URL.String()
switch {
case strings.Contains(httpPath, "/v2/library/fooimage/manifests/latest"):
w.Header().Set("Content-Type", "application/vnd.docker.distribution.manifest.v2+json")
_, _ = fmt.Fprint(w, `{
testCases := []struct {
name string
imageName string
manifestResp string
layerData []byte
blobData string
expectedFileMap extractor.FileMap
expectedError string
}{
{
name: "happy path",
manifestResp: `{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"layers": [
@@ -238,9 +244,8 @@ func TestDockerExtractor_Extract(t *testing.T) {
"digest": "sha256:62d8908bee94c202b2d35224a221aaa2058318bfa9879fa541efaecba272331b"
}
]
}`)
case strings.Contains(httpPath, "/v2/library/fooimage/blobs/sha256:62d8908bee94c202b2d35224a221aaa2058318bfa9879fa541efaecba272331b"):
_, _ = w.Write([]byte{ // this is hello.txt containing "hello world\n" POSIX tar'd and then gzipped
}`,
layerData: []byte{ // this is hello.txt containing "hello world\n" POSIX tar'd and then gzipped
0x1f, 0x8b, 0x8, 0x8, 0xfa, 0x33, 0xd4, 0x5d, 0x0, 0x3, 0x68, 0x65,
0x6c, 0x6c, 0x6f, 0x0, 0xd3, 0xd3, 0xcf, 0x48, 0xcd, 0xc9, 0xc9, 0xd7,
0x2b, 0xa9, 0x28, 0x61, 0xa0, 0x15, 0x30, 0x30, 0x30, 0x30, 0x33, 0x31,
@@ -254,9 +259,53 @@ func TestDockerExtractor_Extract(t *testing.T) {
0x5, 0x70, 0x15, 0xd, 0xe6, 0xcc, 0xb3, 0xee, 0xc9, 0xaa, 0x33, 0x68, 0xc, 0x98,
0x1b, 0x47, 0xc1, 0x28, 0x18, 0x5, 0xa3, 0x60, 0x14, 0x50, 0x1f, 0x0, 0x0,
0x7b, 0x78, 0xf9, 0x4b, 0x0, 0x8, 0x0, 0x0,
})
},
blobData: "foo",
expectedFileMap: extractor.FileMap{
"/config": []uint8{0x66, 0x6f, 0x6f},
},
},
{
name: "sad path: invalid manifest response",
manifestResp: "badManifestResponse",
expectedError: "failed to get the v2 manifest: invalid character 'b' looking for beginning of value",
},
{
name: "sad path: bad image name",
imageName: "https://docker/very/bad/imagename",
expectedError: `failed to parse the image: parsing image "https://docker/very/bad/imagename" failed: invalid reference format`,
},
{
name: "sad path: corrupt layer data invalid gzip",
manifestResp: `{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"layers": [
{
"mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
"size": 153263,
"digest": "sha256:62d8908bee94c202b2d35224a221aaa2058318bfa9879fa541efaecba272331b"
}
]
}`,
layerData: []byte{0xde, 0xad, 0xbe, 0xef},
blobData: "foo",
expectedFileMap: extractor.FileMap(nil),
expectedError: "invalid gzip: unexpected EOF",
},
}
for _, tc := range testCases {
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
httpPath := r.URL.String()
switch {
case strings.Contains(httpPath, "/v2/library/fooimage/manifests/latest"):
w.Header().Set("Content-Type", "application/vnd.docker.distribution.manifest.v2+json")
_, _ = fmt.Fprint(w, tc.manifestResp)
case strings.Contains(httpPath, "/v2/library/fooimage/blobs/sha256:62d8908bee94c202b2d35224a221aaa2058318bfa9879fa541efaecba272331b"):
_, _ = w.Write(tc.layerData)
case strings.Contains(httpPath, "/v2/library/fooimage/blobs/"):
_, _ = w.Write([]byte("someblobdata"))
_, _ = w.Write([]byte(tc.blobData))
default:
assert.FailNow(t, "unexpected path accessed: ", r.URL.String())
}
@@ -285,7 +334,22 @@ func TestDockerExtractor_Extract(t *testing.T) {
filesToExtract := []string{"file1", "file2", "file3"}
tsURL := strings.TrimPrefix(ts.URL, "http://")
fm, err := de.Extract(context.TODO(), tsURL+"/library/fooimage", filesToExtract)
assert.NoError(t, err)
assert.NotNil(t, fm)
var imageName string
switch {
case tc.imageName != "":
imageName = tc.imageName
default:
imageName = tsURL + "/library/fooimage"
}
fm, err := de.Extract(context.TODO(), imageName, filesToExtract)
switch {
case tc.expectedError != "":
assert.Equal(t, tc.expectedError, err.Error(), tc.name)
default:
assert.NoError(t, err, tc.name)
}
assert.Equal(t, tc.expectedFileMap, fm, tc.name)
}
}