From 3a4e18ac82fcb31b8b54739db02328f6568a2e26 Mon Sep 17 00:00:00 2001 From: AndreyLevchenko Date: Mon, 24 Jan 2022 19:11:03 +0600 Subject: [PATCH] docs(contribution): change role who should resolve comments (#1618) --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4a62eb4982..fcf4a73ece 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -12,7 +12,7 @@ Thank you for taking interest in contributing to Trivy! 4. Please add the associated Issue link in the PR description. 2. Your PR is more likely to be accepted if it focuses on just one change. 5. There's no need to add or tag reviewers. -6. If a reviewer commented on your code or asked for changes, please remember to mark the discussion as resolved after you address it. PRs with unresolved issues should not be merged (even if the comment is unclear or requires no action from your side). +6. If a reviewer commented on your code or asked for changes, please remember to respond with comment. Do not mark discussion as resolved. It's up to reviewer to mark it resolved (in case if suggested fix addresses problem properly). PRs with unresolved issues should not be merged (even if the comment is unclear or requires no action from your side). 7. Please include a comment with the results before and after your change. 8. Your PR is more likely to be accepted if it includes tests (We have not historically been very strict about tests, but we would like to improve this!). 9. If your PR affects the user experience in some way, please update the README.md and the CLI help accordingly.