From bc0b463f3ed099fa463a0fc5d7c0142b299fe134 Mon Sep 17 00:00:00 2001
From: Vetlix <31412314+Vetlix@users.noreply.github.com>
Date: Tue, 4 Jun 2024 05:50:53 +0200
Subject: [PATCH] fix: incorrect password autocompletes (#557)

* fix: correct password autocompletes

* fix: file view inconsistency

---------

Co-authored-by: dicedtomato <35403473+diced@users.noreply.github.com>
---
 .../file/DashboardFile/EditFileDetailsModal.tsx           | 1 +
 src/components/file/DashboardFileType.tsx                 | 8 +-------
 src/components/pages/settings/parts/SettingsUser.tsx      | 1 +
 src/components/pages/upload/UploadOptionsButton.tsx       | 3 ++-
 src/components/pages/urls/index.tsx                       | 1 +
 src/components/pages/users/EditUserModal.tsx              | 1 +
 src/components/pages/users/index.tsx                      | 1 +
 src/pages/auth/register.tsx                               | 2 +-
 8 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/components/file/DashboardFile/EditFileDetailsModal.tsx b/src/components/file/DashboardFile/EditFileDetailsModal.tsx
index 87eceafa..1c238de0 100755
--- a/src/components/file/DashboardFile/EditFileDetailsModal.tsx
+++ b/src/components/file/DashboardFile/EditFileDetailsModal.tsx
@@ -142,6 +142,7 @@ export default function EditFileDetailsModal({
             label='Password'
             description='Set a password for these files. Leave blank to disable password protection.'
             value={password ?? ''}
+            autoComplete='off'
             onChange={(event) =>
               setPassword(event.currentTarget.value.trim() === '' ? null : event.currentTarget.value.trim())
             }
diff --git a/src/components/file/DashboardFileType.tsx b/src/components/file/DashboardFileType.tsx
index 0a82de3f..1c4bf7f9 100755
--- a/src/components/file/DashboardFileType.tsx
+++ b/src/components/file/DashboardFileType.tsx
@@ -83,13 +83,7 @@ export default function DashboardFileType({
     return <Placeholder text={`Click to view file ${file.name}`} Icon={icon[type] ?? IconFileUnknown} />;
 
   if (dbFile && file.password === true && !show)
-    return (
-      <Placeholder
-        text={`Click to view protected ${file.name}`}
-        Icon={IconShieldLockFilled}
-        onClick={() => window.open(`/view/${file.name}${password ? `?pw=${password}` : ''}`)}
-      />
-    );
+    return <Placeholder text={`Click to view protected ${file.name}`} Icon={IconShieldLockFilled} />;
 
   if (dbFile && file.password === true && show)
     return (
diff --git a/src/components/pages/settings/parts/SettingsUser.tsx b/src/components/pages/settings/parts/SettingsUser.tsx
index 13961333..55e23908 100755
--- a/src/components/pages/settings/parts/SettingsUser.tsx
+++ b/src/components/pages/settings/parts/SettingsUser.tsx
@@ -122,6 +122,7 @@ export default function SettingsUser() {
         <PasswordInput
           label='Password'
           description='Leave blank to keep the same password'
+          autoComplete='new-password'
           {...form.getInputProps('password')}
           leftSection={<IconAsteriskSimple size='1rem' />}
         />
diff --git a/src/components/pages/upload/UploadOptionsButton.tsx b/src/components/pages/upload/UploadOptionsButton.tsx
index 4d6b934b..5fcca872 100755
--- a/src/components/pages/upload/UploadOptionsButton.tsx
+++ b/src/components/pages/upload/UploadOptionsButton.tsx
@@ -225,6 +225,7 @@ export default function UploadOptionsButton({ numFiles }: { numFiles: number })
             description='Set a password for these files. Leave blank to disable password protection. This value is not saved to your browser, and is cleared after uploading.'
             leftSection={<IconKey size='1rem' />}
             value={ephemeral.password ?? ''}
+            autoComplete='off'
             onChange={(event) =>
               setEphemeral(
                 'password',
@@ -233,7 +234,7 @@ export default function UploadOptionsButton({ numFiles }: { numFiles: number })
             }
           />
 
-          <Text color='dimmed' size='sm'>
+          <Text c='dimmed' size='sm'>
             <b>Other Options</b>
           </Text>
 
diff --git a/src/components/pages/urls/index.tsx b/src/components/pages/urls/index.tsx
index 9fdc9a31..41f098a7 100755
--- a/src/components/pages/urls/index.tsx
+++ b/src/components/pages/urls/index.tsx
@@ -144,6 +144,7 @@ export default function DashboardURLs() {
             <PasswordInput
               label='Password'
               description='Protect your link with a password'
+              autoComplete='off'
               {...form.getInputProps('password')}
             />
 
diff --git a/src/components/pages/users/EditUserModal.tsx b/src/components/pages/users/EditUserModal.tsx
index 5e3ca665..42ead003 100755
--- a/src/components/pages/users/EditUserModal.tsx
+++ b/src/components/pages/users/EditUserModal.tsx
@@ -170,6 +170,7 @@ export default function EditUserModal({
             <PasswordInput
               label='Password'
               placeholder='Enter a password...'
+              autoComplete='new-password'
               {...form.getInputProps('password')}
             />
             <FileInput
diff --git a/src/components/pages/users/index.tsx b/src/components/pages/users/index.tsx
index 23a547fd..0d8244f1 100755
--- a/src/components/pages/users/index.tsx
+++ b/src/components/pages/users/index.tsx
@@ -106,6 +106,7 @@ export default function DashboardUsers() {
             <PasswordInput
               label='Password'
               placeholder='Enter a password...'
+              autoComplete='new-password'
               {...form.getInputProps('password')}
             />
             <FileInput
diff --git a/src/pages/auth/register.tsx b/src/pages/auth/register.tsx
index 946018db..c0eb0542 100755
--- a/src/pages/auth/register.tsx
+++ b/src/pages/auth/register.tsx
@@ -100,7 +100,7 @@ export default function Register({ config, invite }: InferGetServerSidePropsType
             </div>
           )}
 
-          <Text size='sm' color='dimmed'>
+          <Text size='sm' c='dimmed'>
             Create an account to get started.
           </Text>