gitea-mirror/capa
1
0
Fork 0
mirror of https://github.com/mandiant/capa.git synced 2026-06-12 19:11:32 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: use singular get_segment_at API in binja file string extractor

Browse Source
This commit is contained in:
Willi Ballenthin
2026-05-08 09:52:19 +02:00
committed by Willi Ballenthin
parent a28fcce72b
commit 99b3cfe096
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
capa/features/extractors/binja/file.py
+3 -4
View File
@@ -121,10 +121,9 @@ def extract_file_section_names(bv: BinaryView) -> Iterator[tuple[Feature, Addres
def extract_file_strings(bv: BinaryView) -> Iterator[tuple[Feature, Address]]:
"""extract ASCII and UTF-16 LE strings"""
for s in bv.strings:
for seg in bv.get_segments_at(s.start):
if s.start - seg.start < seg.data_length:
yield String(s.value), FileOffsetAddress(seg.data_offset + (s.start - seg.start))
break
seg = bv.get_segment_at(s.start)
if seg is not None and s.start - seg.start < seg.data_length:
yield String(s.value), FileOffsetAddress(seg.data_offset + (s.start - seg.start))
def extract_file_function_names(bv: BinaryView) -> Iterator[tuple[Feature, Address]]: