lints

.pre-commit-config.yaml

@@ -138,6 +138,7 @@ repos:
         -   "--ignore=tests/test_ghidra_features.py"
         -   "--ignore=tests/test_ida_features.py"
         -   "--ignore=tests/test_viv_features.py"
+        -   "--ignore=tests/test_idalib_features.py"
         -   "--ignore=tests/test_main.py"
         -   "--ignore=tests/test_scripts.py"
         always_run: true

tests/fixtures.py

@@ -12,7 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import io
 import logging
 import contextlib
 import collections
@@ -202,6 +201,7 @@ def get_binja_extractor(path: Path):
 
     return extractor
 
+
 # we can't easily cache this because the extractor relies on global state (the opened database)
 # which also has to be closed elsewhere. so, the idalib tests will just take a little bit to run.
 def get_idalib_extractor(path: Path):

tests/test_idalib_features.py

@@ -1,4 +1,3 @@
-
 # Copyright 2020 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,11 +15,10 @@
 import logging
 
 import pytest
+import fixtures
 
 import capa.features.extractors.ida.idalib
 
-import fixtures
-
 logger = logging.getLogger(__name__)
 
 idalib_present = capa.features.extractors.ida.idalib.has_idalib()
@@ -38,6 +36,7 @@ def test_idalib_features(sample, scope, feature, expected):
     finally:
         logger.debug("closing database...")
         import idapro
+
         idapro.close_database(save=False)
         logger.debug("opened database.")
 
@@ -54,5 +53,6 @@ def test_idalib_feature_counts(sample, scope, feature, expected):
     finally:
         logger.debug("closing database...")
         import idapro
+
         idapro.close_database(save=False)
         logger.debug("closed database.")