gitea-mirror/capa
1
0
Fork 0
mirror of https://github.com/mandiant/capa.git synced 2026-02-04 11:07:53 -08:00
Code Issues Packages Projects Releases Wiki Activity

linter: optional maps to some, not range

Browse Source
This commit is contained in:
William Ballenthin
2021-11-10 14:13:37 -07:00
parent 1aaaa8919c
commit e550d48bcd
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/lint.py
View File

@@ -363,8 +363,8 @@ class NotNotUnderAnd(Lint):
class OptionalNotUnderAnd(Lint):
name = "rule contains an `optional` or `range(0, ...)` statement that's not found under an `and` statement"
recommendation = "clarify the rule logic and ensure `optional` and `range(0, ...)` is always found under `and`"
name = "rule contains an `optional` or `0 or more` statement that's not found under an `and` statement"
recommendation = "clarify the rule logic and ensure `optional` and `0 or more` is always found under `and`"
violation = False
def check_rule(self, ctx: Context, rule: Rule):
@@ -374,7 +374,7 @@ class OptionalNotUnderAnd(Lint):
if isinstance(statement, capa.engine.Statement):
if not isinstance(statement, capa.engine.And):
for child in statement.get_children():
if isinstance(child, capa.engine.Range) and child.min == 0:
if isinstance(child, capa.engine.Some) and child.count == 0:
self.violation = True
for child in statement.get_children():