fix: remove unreachable StaticAnalysis assert in assert_meta and cover dynamic proto path

Removes the bare `assert isinstance(meta.analysis, rd.StaticAnalysis)` that
blocked dynamic ResultDocument from being validated, removes the incorrect
direct list comparison in assert_dynamic_analyis, and adds dynamic_a0000a6_rd
to test_doc_to_pb2 so the dynamic proto serialization path is exercised.

CHANGELOG.md

@@ -48,8 +48,7 @@
 - fix: remove unreachable backports.functools_lru_cache fallback and dead dependency @williballenthin
 - fix: Scopes.from_dict uses cls instead of self so subclasses return the correct type @williballenthin
 - fix: correct wrong dict key in VMRay _compute_monitor_threads assertion (used thread_id instead of process_id) @williballenthin
-fix: replace assert with isinstance guard in get_callee for invalid MethodSpec tokens @williballenthin
-- fix: replace assert with isinstance guard in get_callee for invalid MethodSpec tokens @williballenthin
+- fix: remove unreachable StaticAnalysis assert in assert_meta and add dynamic fixture to test_doc_to_pb2 @williballenthin (SURF-75)
 - fix: correct self-comparison sa.max == sa.max to sa.max == sb.max in test_proto assert_statement @williballenthin (SURF-74)
 - fix: guard parse_node against missing "type" key to avoid TypeError crash @williballenthin (SURF-73)
 - fix: allocate feat_dict per feature in parse_json to avoid shared-reference aliasing @williballenthin (SURF-72)

tests/test_proto.py

@@ -38,6 +38,7 @@ from capa.helpers import assert_never
         pytest.param("a076114_rd"),
         pytest.param("pma0101_rd"),
         pytest.param("dotnet_1c444e_rd"),
+        pytest.param("dynamic_a0000a6_rd"),
     ],
 )
 def test_doc_to_pb2(request, rd_file):
@@ -197,7 +198,7 @@ def assert_dynamic_analyis(analysis: rd.DynamicAnalysis, dst: capa_pb2.DynamicAn
         for rd_t, proto_t in zip(rd_p.matched_threads, proto_p.matched_threads):
             assert capa.render.proto.addr_to_pb2(rd_t.address) == proto_t.address
 
-    assert analysis.feature_counts.processes == dst.feature_counts.processes
+    assert analysis.feature_counts.file == dst.feature_counts.file
     assert len(analysis.feature_counts.processes) == len(dst.feature_counts.processes)
     for rd_cp, proto_cp in zip(analysis.feature_counts.processes, dst.feature_counts.processes):
         assert capa.render.proto.addr_to_pb2(rd_cp.address) == proto_cp.address
@@ -205,7 +206,6 @@ def assert_dynamic_analyis(analysis: rd.DynamicAnalysis, dst: capa_pb2.DynamicAn
 
 
 def assert_meta(meta: rd.Metadata, dst: capa_pb2.Metadata):
-    assert isinstance(meta.analysis, rd.StaticAnalysis)
     assert str(meta.timestamp) == dst.timestamp
     assert meta.version == dst.version
     if meta.argv is None: