Commit Graph

316 Commits

Author SHA1 Message Date
Justin Bollinger 6013d7ba8b updated Makefile submodule 2026-02-01 23:39:02 -05:00
Justin Bollinger 5e86581956 updated Makefile submodule 2026-02-01 23:37:03 -05:00
Justin Bollinger 8e6a95d676 updated Makefile submodule 2026-02-01 23:35:20 -05:00
Justin Bollinger c7877baa23 fixed pathing issue 2026-02-01 23:18:54 -05:00
Justin Bollinger 5f43b6cd80 fixed pathing issue 2026-02-01 23:16:19 -05:00
Justin Bollinger 495346f378 fixed pathing issue 2026-02-01 23:11:40 -05:00
Justin Bollinger 847aec9a67 fixed pathing issue 2026-02-01 22:43:44 -05:00
Justin Bollinger 23134be3a0 Revert ancestor asset lookup 2026-02-01 22:41:42 -05:00
Justin Bollinger 4402d3175b Fix uv tool asset lookup 2026-02-01 22:32:24 -05:00
Justin Bollinger 42469f3563 fixed pathing issues and automatic building of files due to relative paths 2026-02-01 22:19:28 -05:00
Justin Bollinger 6d6565701e Remove automatic make execution in ensure_binary
Instead of automatically running 'make' when binaries are missing,
now provides clear instructions for users to manually build utilities.

This gives users more control and makes the build process explicit.
Users will see: 'Please build the utilities by running: cd <dir> && make'
2026-02-01 22:10:58 -05:00
Justin Bollinger e2775b1e53 Add regression tests for asset path separation
Tests now verify that hashcat-utils are loaded from hate_crack repo
even when hcatPath points to a different directory (like /opt/hashcat).

Why previous tests didn't catch this bug:
- config.json.example has hcatPath = "" (empty)
- Code has fallback: hcatPath = config.get('hcatPath', '') or hate_path
- So hcatPath accidentally defaulted to hate_path during testing
- This masked the bug where utilities incorrectly used hcatPath

Added tests that would have caught this:
- test_hashcat_utils_uses_hate_path_not_hcat_path
- test_config_with_explicit_hashcat_path
- test_readme_documents_correct_usage

Also added code comment documenting the fallback behavior.
2026-02-01 22:06:52 -05:00
Justin Bollinger 52f8d5ee8b Fix asset path resolution: separate hashcat and hate_crack locations
BREAKING CHANGE: Corrected understanding of hcatPath configuration

- hcatPath should point to hashcat binary location (or omit if in PATH)
- hashcat-utils and princeprocessor are located in hate_crack repo
- Changed code to use hate_path for utilities instead of hcatPath
- Updated error messages to guide users correctly
- Updated README with correct configuration examples
- Asset discovery now properly uses HATE_CRACK_HOME environment variable

This fixes the issue where users had hcatPath pointing to hashcat
installation but the code was looking there for hashcat-utils.
2026-02-01 22:05:27 -05:00
Justin Bollinger 33a20d2540 Improve error handling for misconfigured hcatPath
- Add directory existence check in ensure_binary() before attempting make
- Provide clear error message when build directory doesn't exist
- Add troubleshooting section to README.md explaining common hcatPath mistakes
- Add tests for invalid hcatPath scenario and installed tool execution
- Helps users distinguish between hashcat path and hate_crack path

Fixes issue where users set hcatPath to hashcat installation directory
instead of hate_crack repository directory, causing confusing errors.
2026-02-01 22:02:35 -05:00
Justin Bollinger 83cf6146a2 issue executing hate_crack from make install outside of the install directory 2026-02-01 21:54:33 -05:00
Justin Bollinger 8e6909d602 updated makefile 2026-02-01 20:46:01 -05:00
Justin Bollinger 0ca3c9ca97 Merge pull request #61 from trustedsec/ci-github-actions
Add CI workflow and E2E install tests
2026-01-31 23:47:32 -05:00
Justin Bollinger 1dcc44691d Print hashview menu header even when API key missing 2026-01-31 23:46:28 -05:00
Justin Bollinger d2da6663e0 CI: set HATE_CRACK_SKIP_INIT for tests 2026-01-31 23:44:49 -05:00
Justin Bollinger 9768ee14ec CI: use venv python for pytest 2026-01-31 23:43:35 -05:00
Justin Bollinger 01c3a9b1c4 Merge draft PR #65 2026-01-31 23:41:33 -05:00
Justin Bollinger d177b2e8e7 Merge draft PR #64 2026-01-31 23:40:41 -05:00
Justin Bollinger d429cede89 Merge draft PR #63 2026-01-31 23:40:09 -05:00
Justin Bollinger 80556b5983 Merge draft PR #62 2026-01-31 23:39:11 -05:00
Justin Bollinger 96896dea82 CI: create uv venv before installing deps 2026-01-31 23:31:30 -05:00
copilot-swe-agent[bot] 0ae172acf4 Pin uv to version 0.9.28 to mitigate supply-chain risk
Co-authored-by: bandrel <3598052+bandrel@users.noreply.github.com>
2026-02-01 04:30:05 +00:00
copilot-swe-agent[bot] ac7f809e33 Check return code and log stderr on cleanup failure
Co-authored-by: bandrel <3598052+bandrel@users.noreply.github.com>
2026-02-01 04:29:41 +00:00
copilot-swe-agent[bot] 0e7db78296 Improve error logging in Docker image cleanup
Co-authored-by: bandrel <3598052+bandrel@users.noreply.github.com>
2026-02-01 04:29:09 +00:00
copilot-swe-agent[bot] 371e9dc3c3 Replace external wordlist download with inline generation
Co-authored-by: bandrel <3598052+bandrel@users.noreply.github.com>
2026-02-01 04:28:53 +00:00
copilot-swe-agent[bot] afb6a4d492 Fix Docker build to use absolute Dockerfile path
Co-authored-by: bandrel <3598052+bandrel@users.noreply.github.com>
2026-02-01 04:28:37 +00:00
copilot-swe-agent[bot] 8972fcaf52 Initial plan 2026-02-01 04:28:37 +00:00
copilot-swe-agent[bot] 2bddce51a4 Add Docker image cleanup to test fixture
Co-authored-by: bandrel <3598052+bandrel@users.noreply.github.com>
2026-02-01 04:28:31 +00:00
copilot-swe-agent[bot] caaec92df4 Initial plan 2026-02-01 04:27:29 +00:00
copilot-swe-agent[bot] 36d29eba4f Initial plan 2026-02-01 04:27:05 +00:00
copilot-swe-agent[bot] d68915bfc0 Initial plan 2026-02-01 04:26:54 +00:00
Justin Bollinger 92200a7964 CI: install project deps before pytest 2026-01-31 23:24:19 -05:00
Justin Bollinger a0fec73fda CI: install pytest 2026-01-31 23:22:04 -05:00
Justin Bollinger 412d22bff0 Add make test and update testing docs 2026-01-31 23:17:16 -05:00
Justin Bollinger afb453b01c Use Makefile in Docker test image 2026-01-31 23:08:50 -05:00
Justin Bollinger 1f5470b2f3 Expand Docker E2E tests with hashcat crack 2026-01-31 23:01:14 -05:00
Justin Bollinger 631b528795 Add GitHub Actions test workflow 2026-01-31 22:54:08 -05:00
Justin Bollinger 14d02eb689 Restore hate_crack package and add E2E install tests 2026-01-31 22:50:51 -05:00
Justin Bollinger 4cd3018b69 added uv pytest 2026-01-30 16:47:05 -05:00
Justin Bollinger 175ddfca4c fixed uv tool install 2026-01-30 16:39:03 -05:00
Justin Bollinger 4899da197e updated tests 2026-01-28 10:56:00 -05:00
Justin Bollinger c45b30e9bb updated tests 2026-01-27 20:04:45 -05:00
Justin Bollinger 74d81da503 updated hashview apis and tests. 2026-01-27 16:00:09 -05:00
Justin Bollinger 19c6651868 updated pytests for hashview 2026-01-27 13:24:38 -05:00
Justin Bollinger 092d72f0cd updated pytests for hashview 2026-01-27 13:22:55 -05:00
Justin Bollinger 470fe37488 Update README with submodule initialization instructions
Added instructions for initializing submodules if not cloned recursively.
2026-01-27 13:07:03 -05:00