Commit Graph
319 Commits
Author SHA1 Message Date
Justin Bollinger fe8bde2302 config file location issues 2026-02-02 11:53:12 -05:00
Justin Bollinger be5886a735 makefile asset issues 2026-02-01 23:49:19 -05:00
Justin Bollinger 35737b645b uv toll uninstall fix 2026-02-01 23:46:46 -05:00
Justin Bollinger 8fd7dcf30c updated Makefile submodule 2026-02-01 23:39:02 -05:00
Justin Bollinger ac639e3f8f updated Makefile submodule 2026-02-01 23:37:03 -05:00
Justin Bollinger a7c2636175 updated Makefile submodule 2026-02-01 23:35:20 -05:00
Justin Bollinger 158eee4747 fixed pathing issue 2026-02-01 23:18:54 -05:00
Justin Bollinger fef4d5794a fixed pathing issue 2026-02-01 23:16:19 -05:00
Justin Bollinger bda34fde81 fixed pathing issue 2026-02-01 23:11:40 -05:00
Justin Bollinger 2f0419e809 fixed pathing issue 2026-02-01 22:43:44 -05:00
Justin Bollinger 892eb6b839 Revert ancestor asset lookup 2026-02-01 22:41:42 -05:00
Justin Bollinger 9695e1b676 Fix uv tool asset lookup 2026-02-01 22:32:24 -05:00
Justin Bollinger 18efb9592e fixed pathing issues and automatic building of files due to relative paths 2026-02-01 22:19:28 -05:00
Justin Bollinger 2c8c2e61a9 Remove automatic make execution in ensure_binary
Instead of automatically running 'make' when binaries are missing,
now provides clear instructions for users to manually build utilities.

This gives users more control and makes the build process explicit.
Users will see: 'Please build the utilities by running: cd <dir> && make'
2026-02-01 22:10:58 -05:00
Justin Bollinger 3a858c7e7d Add regression tests for asset path separation
Tests now verify that hashcat-utils are loaded from hate_crack repo
even when hcatPath points to a different directory (like /opt/hashcat).

Why previous tests didn't catch this bug:
- config.json.example has hcatPath = "" (empty)
- Code has fallback: hcatPath = config.get('hcatPath', '') or hate_path
- So hcatPath accidentally defaulted to hate_path during testing
- This masked the bug where utilities incorrectly used hcatPath

Added tests that would have caught this:
- test_hashcat_utils_uses_hate_path_not_hcat_path
- test_config_with_explicit_hashcat_path
- test_readme_documents_correct_usage

Also added code comment documenting the fallback behavior.
2026-02-01 22:06:52 -05:00
Justin Bollinger 80fca8f41b Fix asset path resolution: separate hashcat and hate_crack locations
BREAKING CHANGE: Corrected understanding of hcatPath configuration

- hcatPath should point to hashcat binary location (or omit if in PATH)
- hashcat-utils and princeprocessor are located in hate_crack repo
- Changed code to use hate_path for utilities instead of hcatPath
- Updated error messages to guide users correctly
- Updated README with correct configuration examples
- Asset discovery now properly uses HATE_CRACK_HOME environment variable

This fixes the issue where users had hcatPath pointing to hashcat
installation but the code was looking there for hashcat-utils.
2026-02-01 22:05:27 -05:00
Justin Bollinger 604da2a3e2 Improve error handling for misconfigured hcatPath
- Add directory existence check in ensure_binary() before attempting make
- Provide clear error message when build directory doesn't exist
- Add troubleshooting section to README.md explaining common hcatPath mistakes
- Add tests for invalid hcatPath scenario and installed tool execution
- Helps users distinguish between hashcat path and hate_crack path

Fixes issue where users set hcatPath to hashcat installation directory
instead of hate_crack repository directory, causing confusing errors.
2026-02-01 22:02:35 -05:00
Justin Bollinger d23a0a8be8 issue executing hate_crack from make install outside of the install directory 2026-02-01 21:54:33 -05:00
Justin Bollinger 82d2a1a13a updated makefile 2026-02-01 20:46:01 -05:00
Justin BollingerandGitHub 255c9b212a Merge pull request #61 from trustedsec/ci-github-actions
Add CI workflow and E2E install tests
2026-01-31 23:47:32 -05:00
Justin Bollinger b9161441c4 Print hashview menu header even when API key missing 2026-01-31 23:46:28 -05:00
Justin Bollinger a4ad60e51b CI: set HATE_CRACK_SKIP_INIT for tests 2026-01-31 23:44:49 -05:00
Justin Bollinger 277ab2deef CI: use venv python for pytest 2026-01-31 23:43:35 -05:00
Justin Bollinger 0351431806 Merge draft PR #65 2026-01-31 23:41:33 -05:00
Justin Bollinger fb3911cba5 Merge draft PR #64 2026-01-31 23:40:41 -05:00
Justin Bollinger 793bae9114 Merge draft PR #63 2026-01-31 23:40:09 -05:00
Justin Bollinger 46e9b9546c Merge draft PR #62 2026-01-31 23:39:11 -05:00
Justin Bollinger 2063292937 CI: create uv venv before installing deps 2026-01-31 23:31:30 -05:00
copilot-swe-agent[bot]andbandrel 54bd5b3c37 Pin uv to version 0.9.28 to mitigate supply-chain risk
Co-authored-by: bandrel <3598052+bandrel@users.noreply.github.com>
2026-02-01 04:30:05 +00:00
copilot-swe-agent[bot]andbandrel 229caa09c9 Check return code and log stderr on cleanup failure
Co-authored-by: bandrel <3598052+bandrel@users.noreply.github.com>
2026-02-01 04:29:41 +00:00
copilot-swe-agent[bot]andbandrel c00d257430 Improve error logging in Docker image cleanup
Co-authored-by: bandrel <3598052+bandrel@users.noreply.github.com>
2026-02-01 04:29:09 +00:00
copilot-swe-agent[bot]andbandrel a6e1aa5715 Replace external wordlist download with inline generation
Co-authored-by: bandrel <3598052+bandrel@users.noreply.github.com>
2026-02-01 04:28:53 +00:00
copilot-swe-agent[bot]andbandrel 13100bcbf1 Fix Docker build to use absolute Dockerfile path
Co-authored-by: bandrel <3598052+bandrel@users.noreply.github.com>
2026-02-01 04:28:37 +00:00
copilot-swe-agent[bot] 9a7500796f Initial plan 2026-02-01 04:28:37 +00:00
copilot-swe-agent[bot]andbandrel 3a47b7d60b Add Docker image cleanup to test fixture
Co-authored-by: bandrel <3598052+bandrel@users.noreply.github.com>
2026-02-01 04:28:31 +00:00
copilot-swe-agent[bot] 547b858f9c Initial plan 2026-02-01 04:27:29 +00:00
copilot-swe-agent[bot] 2e3ae1c6f5 Initial plan 2026-02-01 04:27:05 +00:00
copilot-swe-agent[bot] d9e01e0a7f Initial plan 2026-02-01 04:26:54 +00:00
Justin Bollinger 0fdb3005df CI: install project deps before pytest 2026-01-31 23:24:19 -05:00
Justin Bollinger e163e58f93 CI: install pytest 2026-01-31 23:22:04 -05:00
Justin Bollinger fbd8d7041f Add make test and update testing docs 2026-01-31 23:17:16 -05:00
Justin Bollinger 60db30eb83 Use Makefile in Docker test image 2026-01-31 23:08:50 -05:00
Justin Bollinger 1b01993a19 Expand Docker E2E tests with hashcat crack 2026-01-31 23:01:14 -05:00
Justin Bollinger 9863dcd201 Add GitHub Actions test workflow 2026-01-31 22:54:08 -05:00
Justin Bollinger 203afb3d82 Restore hate_crack package and add E2E install tests 2026-01-31 22:50:51 -05:00
Justin Bollinger c298008f8e added uv pytest 2026-01-30 16:47:05 -05:00
Justin Bollinger ea251904c9 fixed uv tool install 2026-01-30 16:39:03 -05:00
Justin Bollinger b3d7576e35 updated tests 2026-01-28 10:56:00 -05:00
Justin Bollinger fd293a75c6 updated tests 2026-01-27 20:04:45 -05:00
Justin Bollinger d788f31f84 updated hashview apis and tests. 2026-01-27 16:00:09 -05:00